Bug 1738401 - Remove -Wno-shadow warning suppressions. r=firefox-build-system-reviewers,glandium

-Wshadow warnings are not enabled globally, so these -Wno-shadow suppressions have no effect. I had intended to enable -Wshadow globally along with these suppressions in some directories (in bug 1272513), but that was blocked by other issues.

There are too many -Wshadow warnings (now over 2000) to realistically fix them all. We should remove all these unnecessary -Wno-shadow flags cluttering many moz.build files.

Differential Revision: https://phabricator.services.mozilla.com/D132289

accessible/android/moz.build

@@ -37,6 +37,3 @@ LOCAL_INCLUDES += [
 FINAL_LIBRARY = "xul"
 
 include("/ipc/chromium/chromium-config.mozbuild")
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

accessible/atk/moz.build

@@ -63,6 +63,5 @@ if CONFIG["CC_TYPE"] in ("clang", "gcc"):
     # gobject headers. See bug 1243331 comment 3.
     CXXFLAGS += [
         "-Wno-error=unused-function",
-        "-Wno-error=shadow",
         "-Wno-unused-local-typedefs",
     ]

accessible/base/moz.build

@@ -115,6 +115,3 @@ else:
 FINAL_LIBRARY = "xul"
 
 include("/ipc/chromium/chromium-config.mozbuild")
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

accessible/basetypes/moz.build

@@ -21,6 +21,3 @@ LOCAL_INCLUDES += [
 FINAL_LIBRARY = "xul"
 
 include("/ipc/chromium/chromium-config.mozbuild")
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

accessible/generic/moz.build

@@ -72,6 +72,3 @@ else:
 FINAL_LIBRARY = "xul"
 
 include("/ipc/chromium/chromium-config.mozbuild")
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

accessible/html/moz.build

@@ -50,6 +50,3 @@ else:
 include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

accessible/ipc/moz.build

@@ -42,9 +42,6 @@ EXPORTS.mozilla.a11y += [
     "IPCTypes.h",
 ]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 if CONFIG["ACCESSIBILITY"]:
     EXPORTS.mozilla.a11y += [
         "DocAccessibleChildBase.h",

accessible/ipc/other/moz.build

@@ -48,7 +48,4 @@ include("/ipc/chromium/chromium-config.mozbuild")
 # Add libFuzzer configuration directives
 include("/tools/fuzzing/libfuzzer-config.mozbuild")
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 FINAL_LIBRARY = "xul"

accessible/other/moz.build

@@ -22,6 +22,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

accessible/xpcom/moz.build

@@ -77,6 +77,3 @@ GeneratedFile(
 FINAL_LIBRARY = "xul"
 
 include("/ipc/chromium/chromium-config.mozbuild")
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

accessible/xul/moz.build

@@ -54,6 +54,3 @@ else:
 include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

devtools/shared/heapsnapshot/moz.build

@@ -57,6 +57,3 @@ DevToolsModules(
     "HeapSnapshotFileUtils.js",
     "shortest-paths.js",
 )
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

devtools/shared/heapsnapshot/tests/gtest/moz.build

@@ -23,9 +23,6 @@ UNIFIED_SOURCES = [
     "SerializesTypeNames.cpp",
 ]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 # THE MOCK_METHOD2 macro from gtest triggers this clang warning and it's hard
 # to work around, so we just ignore it.
 if CONFIG["CC_TYPE"] == "clang":

docshell/base/moz.build

@@ -124,7 +124,4 @@ LOCAL_INCLUDES += [
     "/tools/profiler",
 ]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 EXTRA_JS_MODULES += ["URIFixup.jsm"]

docshell/shistory/moz.build

@@ -39,7 +39,4 @@ LOCAL_INCLUDES += [
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 include("/ipc/chromium/chromium-config.mozbuild")

dom/base/moz.build

@@ -580,6 +580,3 @@ GeneratedFile(
     entry_point="use_counter_list",
     inputs=["UseCountersWorker.conf"],
 )
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/bindings/moz.build

@@ -172,9 +172,7 @@ PYTHON_UNITTEST_MANIFESTS += [
     "mozwebidlcodegen/test/python.ini",
 ]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-    # Suppress warnings in third-party code.
+if CONFIG["CC_TYPE"] == "gcc":
     CXXFLAGS += [
         "-Wno-maybe-uninitialized",
     ]

dom/bindings/test/moz.build

@@ -54,9 +54,6 @@ LOCAL_INCLUDES += [
 
 include("/ipc/chromium/chromium-config.mozbuild")
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 if CONFIG["MOZ_DEBUG"]:
     XPIDL_SOURCES += [
         "mozITestInterfaceJS.idl",

dom/cache/moz.build

@@ -97,6 +97,3 @@ BROWSER_CHROME_MANIFESTS += [
 XPCSHELL_TESTS_MANIFESTS += [
     "test/xpcshell/xpcshell.ini",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/canvas/moz.build

@@ -199,9 +199,6 @@ CXXFLAGS += CONFIG["TK_CFLAGS"]
 
 LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 if CONFIG["CC_TYPE"] in ("clang", "clang-cl"):
     CXXFLAGS += ["-Werror=implicit-int-conversion"]
     CXXFLAGS += ["-Werror=switch"]

dom/events/moz.build

@@ -183,6 +183,3 @@ LOCAL_INCLUDES += [
     "/layout/xul",
     "/layout/xul/tree/",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/file/ipc/moz.build

@@ -67,8 +67,5 @@ FINAL_LIBRARY = "xul"
 
 CXXFLAGS += CONFIG["TK_CFLAGS"]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 BROWSER_CHROME_MANIFESTS += ["tests/browser.ini"]
 MOCHITEST_MANIFESTS += ["tests/mochitest.ini"]

dom/html/input/moz.build

@@ -34,6 +34,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/html/moz.build

@@ -257,6 +257,3 @@ FINAL_LIBRARY = "xul"
 
 if CONFIG["MOZ_ANDROID_HLS_SUPPORT"]:
     DEFINES["MOZ_ANDROID_HLS_SUPPORT"] = True
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/indexedDB/moz.build

@@ -111,7 +111,6 @@ if CONFIG["CC_TYPE"] in ("clang", "gcc"):
     # Suppress gcc warning about a comparison being always false due to the
     # range of the data type
     SOURCES["Key.cpp"].flags += ["-Wno-error=type-limits"]
-    CXXFLAGS += ["-Wno-error=shadow"]
 
 LOCAL_INCLUDES += [
     "/dom/base",

dom/ipc/moz.build

@@ -246,9 +246,6 @@ XPCSHELL_TESTS_MANIFESTS += ["tests/xpcshell.ini"]
 
 CXXFLAGS += CONFIG["TK_CFLAGS"]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 if CONFIG["FUZZING"] and CONFIG["FUZZING_INTERFACES"]:
     TEST_DIRS += ["fuzztest"]
 

dom/localstorage/moz.build

@@ -70,9 +70,6 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["GNU_CXX"]:
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 LOCAL_INCLUDES += [
     "/dom/file/ipc",
 ]

dom/media/bridge/moz.build

@@ -33,6 +33,3 @@ if CONFIG["MOZ_WEBRTC"]:
     ]
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/doctor/test/gtest/moz.build

@@ -17,6 +17,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul-gtest"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/flac/moz.build

@@ -20,8 +20,5 @@ CXXFLAGS += CONFIG["MOZ_LIBVPX_CFLAGS"]
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 # Add libFuzzer configuration directives
 include("/tools/fuzzing/libfuzzer-config.mozbuild")

dom/media/gmp/moz.build

@@ -149,6 +149,3 @@ LOCAL_INCLUDES += [
     "/xpcom/build",
     "/xpcom/threads",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/gmp/widevine-adapter/moz.build

@@ -18,7 +18,4 @@ LOCAL_INCLUDES += [
     "/dom/media/gmp",
 ]
 
-if CONFIG["CC_TYPE"] == "clang":
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 include("/ipc/chromium/chromium-config.mozbuild")

dom/media/gtest/moz.build

@@ -133,9 +133,6 @@ LOCAL_INCLUDES += [
 
 FINAL_LIBRARY = "xul-gtest"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 if CONFIG["CC_TYPE"] in ("clang", "clang-cl"):
     CXXFLAGS += [
         "-Wno-inconsistent-missing-override",

dom/media/hls/moz.build

@@ -20,8 +20,5 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 # Add libFuzzer configuration directives
 include("/tools/fuzzing/libfuzzer-config.mozbuild")

dom/media/mediacontrol/tests/gtest/moz.build

@@ -22,6 +22,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul-gtest"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/mediasink/moz.build

@@ -25,6 +25,3 @@ DEFINES["TRACING"] = True
 include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/mediasource/moz.build

@@ -40,6 +40,3 @@ TEST_DIRS += [
 include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/moz.build

@@ -376,7 +376,6 @@ include("/ipc/chromium/chromium-config.mozbuild")
 if CONFIG["CC_TYPE"] in ("clang", "gcc"):
     CXXFLAGS += [
         "-Wno-error=attributes",
-        "-Wno-error=shadow",
     ]
 
 CXXFLAGS += ["-Werror=switch"]

dom/media/platforms/moz.build

@@ -135,8 +135,5 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "android":
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 # Add libFuzzer configuration directives
 include("/tools/fuzzing/libfuzzer-config.mozbuild")

dom/media/platforms/omx/moz.build

@@ -28,9 +28,6 @@ if CONFIG["MOZ_OMX"]:
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 # Avoid warnings from third-party code that we can not modify.
 if CONFIG["CC_TYPE"] == "clang-cl":
     CXXFLAGS += ["-Wno-invalid-source-encoding"]

dom/media/systemservices/moz.build

@@ -114,8 +114,5 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 with Files("android_video_capture/**"):
     SCHEDULES.exclusive = ["android"]

dom/media/utils/gtest/moz.build

@@ -13,6 +13,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul-gtest"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/wave/moz.build

@@ -16,8 +16,5 @@ UNIFIED_SOURCES += [
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 # Add libFuzzer configuration directives
 include("/tools/fuzzing/libfuzzer-config.mozbuild")

dom/media/webaudio/blink/moz.build

@@ -34,6 +34,3 @@ FINAL_LIBRARY = "xul"
 LOCAL_INCLUDES += [
     "/dom/media/webaudio",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-shadow"]

dom/media/webaudio/moz.build

@@ -142,6 +142,3 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 LOCAL_INCLUDES += [".."]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/webm/moz.build

@@ -28,8 +28,5 @@ CXXFLAGS += CONFIG["MOZ_LIBVPX_CFLAGS"]
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 # Add libFuzzer configuration directives
 include("/tools/fuzzing/libfuzzer-config.mozbuild")

dom/media/webrtc/moz.build

@@ -109,7 +109,6 @@ include("/ipc/chromium/chromium-config.mozbuild")
 #    android API types
 CXXFLAGS += [
     "-Wno-error=attributes",
-    "-Wno-error=shadow",
 ]
 
 DEFINES["TRACING"] = True

dom/media/webrtc/third_party_build/webrtc.mozbuild

@@ -37,6 +37,3 @@ if CONFIG['MOZ_WEBRTC']:
 
     if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
         DEFINES['WEBRTC_USE_PIPEWIRE'] = True
-
-    if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
-        CXXFLAGS += ['-Wno-error=shadow']

dom/media/webrtc/transport/common.build

@@ -92,6 +92,3 @@ DEFINES["R_DEFINED_INT4"] = "int32_t"
 DEFINES["R_DEFINED_UINT4"] = "uint32_t"
 DEFINES["R_DEFINED_INT8"] = "int64_t"
 DEFINES["R_DEFINED_UINT8"] = "uint64_t"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/webrtc/transport/test/moz.build

@@ -102,6 +102,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul-gtest"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/webspeech/recognition/moz.build

@@ -62,6 +62,3 @@ LOCAL_INCLUDES += [
 include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/media/webspeech/synth/moz.build

@@ -63,6 +63,3 @@ FINAL_LIBRARY = "xul"
 LOCAL_INCLUDES += [
     "ipc",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/network/moz.build

@@ -53,6 +53,3 @@ IPDL_SOURCES += [
 include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/notification/moz.build

@@ -38,10 +38,6 @@ XPCSHELL_TESTS_MANIFESTS += ["test/unit/xpcshell.ini"]
 MOCHITEST_MANIFESTS += ["test/mochitest/mochitest.ini"]
 MOCHITEST_CHROME_MANIFESTS += ["test/chrome/chrome.ini"]
 
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 if CONFIG["MOZ_NEW_NOTIFICATION_STORE"]:
     EXTRA_JS_MODULES += [
         "new/NotificationDB.jsm",

dom/plugins/base/moz.build

@@ -42,6 +42,3 @@ include("/ipc/chromium/chromium-config.mozbuild")
 FINAL_LIBRARY = "xul"
 
 CXXFLAGS += CONFIG["TK_CFLAGS"]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/promise/moz.build

@@ -37,7 +37,4 @@ MOCHITEST_CHROME_MANIFESTS += ["tests/chrome.ini"]
 
 XPCSHELL_TESTS_MANIFESTS += ["tests/unit/xpcshell.ini"]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 REQUIRES_UNIFIED_BUILD = True

dom/quota/moz.build

@@ -103,6 +103,3 @@ FINAL_LIBRARY = "xul"
 LOCAL_INCLUDES += [
     "/caps",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/simpledb/moz.build

@@ -38,6 +38,3 @@ IPDL_SOURCES += [
 include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["GNU_CXX"]:
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/svg/moz.build

@@ -261,6 +261,3 @@ LOCAL_INCLUDES += [
     "/layout/svg",
     "/layout/xul",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/webbrowserpersist/moz.build

@@ -47,6 +47,3 @@ LOCAL_INCLUDES += [
     "/dom/base",
     "/dom/html",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/workers/moz.build

@@ -103,6 +103,3 @@ MOCHITEST_CHROME_MANIFESTS += [
 XPCSHELL_TESTS_MANIFESTS += ["test/xpcshell/xpcshell.ini"]
 
 BROWSER_CHROME_MANIFESTS += ["test/browser.ini"]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/xslt/base/moz.build

@@ -21,6 +21,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/xslt/xpath/moz.build

@@ -56,6 +56,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/xslt/xslt/moz.build

@@ -58,6 +58,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

dom/xul/moz.build

@@ -84,6 +84,3 @@ LOCAL_INCLUDES += [
 include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

editor/composer/moz.build

@@ -58,6 +58,3 @@ RESOURCE_FILES += [
     "res/table-remove-row-hover.gif",
     "res/table-remove-row.gif",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

editor/libeditor/moz.build

@@ -95,8 +95,5 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 with Files("tests/*1151186*"):
     BUG_COMPONENT = ("Core", "DOM: UI Events & Focus Handling")

extensions/permissions/moz.build

@@ -35,8 +35,5 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 with Files("**"):
     BUG_COMPONENT = ("Core", "Permission Manager")

extensions/spellcheck/src/moz.build

@@ -28,6 +28,3 @@ EXPORTS.mozilla += [
     "mozInlineSpellChecker.h",
     "mozSpellChecker.h",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

gfx/2d/moz.build

@@ -197,9 +197,6 @@ SOURCES += [
 if CONFIG["CC_TYPE"] == "clang":
     SOURCES["Factory.cpp"].flags += ["-Wno-implicit-fallthrough"]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "cocoa":
     EXPORTS.mozilla.gfx += [
         "QuartzSupport.h",

gfx/gl/moz.build

@@ -163,6 +163,3 @@ LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]
 LOCAL_INCLUDES += [
     "/gfx/cairo/cairo/src",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

gfx/layers/apz/test/gtest/moz.build

@@ -35,6 +35,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul-gtest"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

gfx/layers/moz.build

@@ -504,9 +504,8 @@ CXXFLAGS += ["-Werror=switch"]
 
 LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-    # Suppress warnings in third-party code.
+# Suppress warnings in third-party code.
+if CONFIG["CC_TYPE"] == "gcc":
     CXXFLAGS += ["-Wno-maybe-uninitialized"]
 
 UNIFIED_SOURCES += []

gfx/skia/generate_mozbuild.py

@@ -79,7 +79,6 @@ DEFINES['SK_OUTLINE_EMBOLDEN_DIVISOR'] = 48
 CXXFLAGS += [
     '-Wno-deprecated-declarations',
     '-Wno-overloaded-virtual',
-    '-Wno-shadow',
     '-Wno-sign-compare',
     '-Wno-unreachable-code',
     '-Wno-unused-function',

gfx/skia/moz.build

@@ -471,7 +471,6 @@ if CONFIG['MOZ_TREE_FREETYPE']:
 CXXFLAGS += [
     '-Wno-deprecated-declarations',
     '-Wno-overloaded-virtual',
-    '-Wno-shadow',
     '-Wno-sign-compare',
     '-Wno-unreachable-code',
     '-Wno-unused-function',

gfx/tests/gtest/moz.build

@@ -83,6 +83,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = "xul-gtest"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

image/decoders/moz.build

@@ -56,9 +56,6 @@ LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 CXXFLAGS += ["-Werror=switch"]
 
 # Add libFuzzer configuration directives

image/moz.build

@@ -135,8 +135,5 @@ LOCAL_INCLUDES += [
 
 LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 # Add libFuzzer configuration directives
 include("/tools/fuzzing/libfuzzer-config.mozbuild")

image/test/gtest/moz.build

@@ -152,6 +152,3 @@ LOCAL_INCLUDES += [
 LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]
 
 FINAL_LIBRARY = "xul-gtest"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

intl/hyphenation/glue/moz.build

@@ -18,9 +18,6 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 if CONFIG["COMPILE_ENVIRONMENT"]:
     CbindgenHeader("mapped_hyph.h", inputs=["/third_party/rust/mapped_hyph"])
 

intl/strres/moz.build

@@ -23,6 +23,3 @@ LOCAL_INCLUDES += [
 include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

intl/uconv/moz.build

@@ -30,7 +30,4 @@ XPCOM_MANIFESTS += [
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 REQUIRES_UNIFIED_BUILD = True

ipc/chromium/moz.build

@@ -133,7 +133,4 @@ include("/ipc/chromium/chromium-config.mozbuild")
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 REQUIRES_UNIFIED_BUILD = True

ipc/glue/moz.build

@@ -275,8 +275,5 @@ if CONFIG["MOZ_SANDBOX"] and CONFIG["OS_ARCH"] == "WINNT":
         "/security/sandbox/win/src/sandboxbroker",
     ]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-shadow"]
-
 # Add libFuzzer configuration directives
 include("/tools/fuzzing/libfuzzer-config.mozbuild")

ipc/testshell/moz.build

@@ -33,8 +33,5 @@ LOCAL_INCLUDES += [
     "/js/xpconnect/src",
 ]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 with Files("**"):
     BUG_COMPONENT = ("Core", "XPConnect")

js/src/js-cxxflags.mozbuild

@@ -13,8 +13,6 @@ if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
     CXXFLAGS += ['-fno-strict-aliasing']
     # Error on bad printf-like format strings
     CXXFLAGS += ['-Werror=format']
-    # Ignore shadowed variable warnings as there are too many.
-    CXXFLAGS += ['-Wno-shadow']
 
 # gcc is buggy and warns on our attempts to JS_PUBLIC_API our
 # forward-declarations or explicit template instantiations. See

js/xpconnect/loader/moz.build

@@ -59,7 +59,4 @@ LOCAL_INCLUDES += [
 
 include("/ipc/chromium/chromium-config.mozbuild")
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-shadow"]
-
 REQUIRES_UNIFIED_BUILD = True

js/xpconnect/src/moz.build

@@ -75,6 +75,6 @@ LOCAL_INCLUDES += [
 ]
 
 if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-shadow", "-Werror=format"]
+    CXXFLAGS += ["-Werror=format"]
 
 REQUIRES_UNIFIED_BUILD = True

js/xpconnect/wrappers/moz.build

@@ -31,7 +31,4 @@ LOCAL_INCLUDES += [
     "/caps",
 ]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-shadow"]
-
 REQUIRES_UNIFIED_BUILD = True

layout/base/moz.build

@@ -181,6 +181,3 @@ BROWSER_CHROME_MANIFESTS += ["tests/browser.ini"]
 MARIONETTE_LAYOUT_MANIFESTS += ["tests/marionette/manifest.ini"]
 MOCHITEST_MANIFESTS += ["tests/mochitest.ini"]
 MOCHITEST_CHROME_MANIFESTS += ["tests/chrome/chrome.ini"]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

layout/build/moz.build

@@ -76,6 +76,3 @@ XPCOM_MANIFESTS += [
 ]
 
 FINAL_LIBRARY = "xul"
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

layout/forms/moz.build

@@ -51,7 +51,4 @@ LOCAL_INCLUDES += [
     "/dom/html",
 ]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 REQUIRES_UNIFIED_BUILD = True

layout/generic/moz.build

@@ -267,6 +267,3 @@ MOCHITEST_CHROME_MANIFESTS += ["test/chrome.ini"]
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
     CXXFLAGS += CONFIG["TK_CFLAGS"]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

layout/mathml/moz.build

@@ -61,7 +61,4 @@ RESOURCE_FILES.fonts += [
     "mathfontUnicode.properties",
 ]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 REQUIRES_UNIFIED_BUILD = True

layout/painting/moz.build

@@ -72,7 +72,4 @@ LOCAL_INCLUDES += CONFIG["SKIA_INCLUDES"]
 
 FINAL_LIBRARY = "xul"
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 REQUIRES_UNIFIED_BUILD = True

layout/tables/moz.build

@@ -52,7 +52,4 @@ LOCAL_INCLUDES += [
 
 DEFINES["DEBUG_TABLE_STRATEGY_off"] = True
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 REQUIRES_UNIFIED_BUILD = True

layout/xul/moz.build

@@ -73,7 +73,4 @@ LOCAL_INCLUDES += [
     "/dom/xul",
 ]
 
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]
-
 REQUIRES_UNIFIED_BUILD = True

layout/xul/tree/moz.build

@@ -44,6 +44,3 @@ LOCAL_INCLUDES += [
     "/dom/base",
     "/dom/xul",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]

media/libcubeb/gtest/moz.build

@@ -69,9 +69,6 @@ elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'uikit':
       '-framework AudioToolbox',
     ]
 
-if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
-    CXXFLAGS += ['-Wno-error=shadow']
-
 FINAL_LIBRARY = 'xul-gtest'
 
 REQUIRES_UNIFIED_BUILD = True

memory/replace/dmd/test/moz.build

@@ -24,6 +24,3 @@ DisableStlWrapping()
 XPCSHELL_TESTS_MANIFESTS += [
     "xpcshell.ini",
 ]
-
-if CONFIG["CC_TYPE"] in ("clang", "gcc"):
-    CXXFLAGS += ["-Wno-error=shadow"]