Bug 775624 Part 5 - Remove NS_FRAME_IS_COMPLETE. r=dholbert

This patch is written by the help of the following script.

function rename() {
find layout\
     -type f\
     \( -name "*.cpp" -or\
        -name "*.h" \)\
        -exec sed -i -r "s/$1/$2/g" "{}" \;
}

rename "NS_FRAME_IS_COMPLETE\(([a-zA-Z0-9.*]*)\)" "\1.IsComplete()"

MozReview-Commit-ID: GOd4y2N6dcz

--HG--
extra : rebase_source : aa8b11d3a756c9e7c521e6ffd70713af0174bd98
This commit is contained in:
Ting-Yu Lin 2017-02-11 22:45:07 +08:00
Родитель 99ebdf6cf3
Коммит f7a393e947
24 изменённых файлов: 43 добавлений и 46 удалений

Просмотреть файл

@ -257,7 +257,7 @@ nsHTMLButtonControlFrame::ReflowButtonContents(nsPresContext* aPresContext,
ReflowChild(aFirstKid, aPresContext,
contentsDesiredSize, contentsReflowInput,
wm, childPos, dummyContainerSize, 0, contentsReflowStatus);
MOZ_ASSERT(NS_FRAME_IS_COMPLETE(contentsReflowStatus),
MOZ_ASSERT(contentsReflowStatus.IsComplete(),
"We gave button-contents frame unconstrained available height, "
"so it should be complete");

Просмотреть файл

@ -775,7 +775,7 @@ BlockReflowInput::FlowAndPlaceFloat(nsIFrame* aFloat)
mBlock->ReflowFloat(*this, adjustedAvailableSpace, aFloat, floatMargin,
floatOffsets, false, reflowStatus);
floatMarginISize = aFloat->ISize(wm) + floatMargin.IStartEnd(wm);
NS_ASSERTION(NS_FRAME_IS_COMPLETE(reflowStatus),
NS_ASSERTION(reflowStatus.IsComplete(),
"letter frames and orthogonal floats with auto block-size "
"shouldn't break, and if they do now, then they're breaking "
"at the wrong point");

Просмотреть файл

@ -1267,7 +1267,7 @@ nsBlockFrame::Reflow(nsPresContext* aPresContext,
// If we end in a BR with clear and affected floats continue,
// we need to continue, too.
if (NS_UNCONSTRAINEDSIZE != reflowInput->AvailableBSize() &&
NS_FRAME_IS_COMPLETE(state.mReflowStatus) &&
state.mReflowStatus.IsComplete() &&
state.FloatManager()->ClearContinues(FindTrailingClear())) {
NS_FRAME_SET_INCOMPLETE(state.mReflowStatus);
}
@ -1472,7 +1472,7 @@ nsBlockFrame::Reflow(nsPresContext* aPresContext,
IndentBy(stdout, gNoiseIndent);
ListTag(stdout);
printf(": status=%x (%scomplete) metrics=%d,%d carriedMargin=%d",
aStatus, NS_FRAME_IS_COMPLETE(aStatus) ? "" : "not ",
aStatus, aStatus.IsComplete() ? "" : "not ",
aMetrics.ISize(parentWM), aMetrics.BSize(parentWM),
aMetrics.mCarriedOutBEndMargin.get());
if (HasOverflowAreas()) {
@ -1613,7 +1613,7 @@ nsBlockFrame::ComputeFinalSize(const ReflowInput& aReflowInput,
ComputeFinalBSize(aReflowInput, &aState.mReflowStatus,
aState.mBCoord + nonCarriedOutBDirMargin,
borderPadding, finalSize, aState.mConsumedBSize);
if (!NS_FRAME_IS_COMPLETE(aState.mReflowStatus)) {
if (!aState.mReflowStatus.IsComplete()) {
// Use the current height; continuations will take up the rest.
// Do extend the height to at least consume the available
// height, otherwise our left/right borders (for example) won't
@ -1635,7 +1635,7 @@ nsBlockFrame::ComputeFinalSize(const ReflowInput& aReflowInput,
// Don't carry out a block-end margin when our BSize is fixed.
aMetrics.mCarriedOutBEndMargin.Zero();
}
else if (NS_FRAME_IS_COMPLETE(aState.mReflowStatus)) {
else if (aState.mReflowStatus.IsComplete()) {
nscoord contentBSize = blockEndEdgeOfChildren - borderPadding.BStart(wm);
nscoord autoBSize = aReflowInput.ApplyMinMaxBSize(contentBSize);
if (autoBSize != contentBSize) {
@ -1667,7 +1667,7 @@ nsBlockFrame::ComputeFinalSize(const ReflowInput& aReflowInput,
}
} else if (aReflowInput.AvailableBSize() != NS_UNCONSTRAINEDSIZE &&
!NS_INLINE_IS_BREAK_BEFORE(aState.mReflowStatus) &&
NS_FRAME_IS_COMPLETE(aState.mReflowStatus)) {
aState.mReflowStatus.IsComplete()) {
// Currently only used for grid items, but could be used in other contexts.
// The FragStretchBSizeProperty is our expected non-fragmented block-size
// we should stretch to (for align-self:stretch etc). In some fragmentation
@ -1684,7 +1684,7 @@ nsBlockFrame::ComputeFinalSize(const ReflowInput& aReflowInput,
// Clamp the content size to fit within the margin-box clamp size, if any.
if (MOZ_UNLIKELY(aReflowInput.mFlags.mBClampMarginBoxMinSize) &&
NS_FRAME_IS_COMPLETE(aState.mReflowStatus)) {
aState.mReflowStatus.IsComplete()) {
bool found;
nscoord cbSize = Properties().Get(BClampMarginBoxMinSizeProperty(), &found);
if (found) {
@ -4228,7 +4228,7 @@ nsBlockFrame::ReflowInlineFrame(BlockReflowInput& aState,
}
}
aLine->SetBreakTypeAfter(breakType);
if (NS_FRAME_IS_COMPLETE(frameReflowStatus)) {
if (frameReflowStatus.IsComplete()) {
// Split line, but after the frame just reflowed
SplitLine(aState, aLineLayout, aLine, aFrame->GetNextSibling(), aLineReflowStatus);
@ -7416,7 +7416,7 @@ nsBlockFrame::ComputeFinalBSize(const ReflowInput& aReflowInput,
NS_FRAME_SET_OVERFLOW_INCOMPLETE(*aStatus);
}
if (NS_FRAME_IS_COMPLETE(*aStatus)) {
if (aStatus->IsComplete()) {
if (computedBSizeLeftOver > 0 &&
NS_UNCONSTRAINEDSIZE != aReflowInput.AvailableBSize() &&
aFinalSize.BSize(wm) > aReflowInput.AvailableBSize()) {

Просмотреть файл

@ -367,7 +367,7 @@ nsBlockReflowContext::PlaceBlock(const ReflowInput& aReflowInput,
// Compute collapsed block-end margin value.
WritingMode wm = aReflowInput.GetWritingMode();
WritingMode parentWM = mMetrics.GetWritingMode();
if (NS_FRAME_IS_COMPLETE(aReflowStatus)) {
if (aReflowStatus.IsComplete()) {
aBEndMarginResult = mMetrics.mCarriedOutBEndMargin;
aBEndMarginResult.Include(aReflowInput.ComputedLogicalMargin().
ConvertTo(parentWM, wm).BEnd(parentWM));

Просмотреть файл

@ -1287,7 +1287,7 @@ nsContainerFrame::ReflowOverflowContainerChildren(nsPresContext* aPres
NS_FRAME_SET_OVERFLOW_INCOMPLETE(frameStatus);
}
else {
NS_ASSERTION(NS_FRAME_IS_COMPLETE(frameStatus),
NS_ASSERTION(frameStatus.IsComplete(),
"overflow container frames can't be incomplete, only overflow-incomplete");
}

Просмотреть файл

@ -268,7 +268,7 @@ nsFirstLetterFrame::Reflow(nsPresContext* aPresContext,
if (!NS_INLINE_IS_BREAK_BEFORE(aReflowStatus)) {
// Create a continuation or remove existing continuations based on
// the reflow completion status.
if (NS_FRAME_IS_COMPLETE(aReflowStatus)) {
if (aReflowStatus.IsComplete()) {
if (aReflowInput.mLineLayout) {
aReflowInput.mLineLayout->SetFirstLetterStyleOK(false);
}

Просмотреть файл

@ -1846,7 +1846,7 @@ nsFlexContainerFrame::MeasureAscentAndHeightForFlexItem(
// XXXdholbert Once we do pagination / splitting, we'll need to actually
// handle incomplete childReflowStatuses. But for now, we give our kids
// unconstrained available height, which means they should always complete.
MOZ_ASSERT(NS_FRAME_IS_COMPLETE(childReflowStatus),
MOZ_ASSERT(childReflowStatus.IsComplete(),
"We gave flex item unconstrained available height, so it "
"should be complete");
@ -4626,7 +4626,7 @@ nsFlexContainerFrame::DoFlexLayout(nsPresContext* aPresContext,
// NOTE: If we're auto-height, we allow our bottom border/padding to push us
// over the available height without requesting a continuation, for
// consistency with the behavior of "display:block" elements.
if (NS_FRAME_IS_COMPLETE(aStatus)) {
if (aStatus.IsComplete()) {
nscoord desiredBSizeWithBEndBP =
desiredSizeInFlexWM.BSize(flexWM) + blockEndContainerBP;
@ -4780,7 +4780,7 @@ nsFlexContainerFrame::ReflowFlexItem(nsPresContext* aPresContext,
// handle incomplete childReflowStatuses. But for now, we give our kids
// unconstrained available height, which means they should always
// complete.
MOZ_ASSERT(NS_FRAME_IS_COMPLETE(childReflowStatus),
MOZ_ASSERT(childReflowStatus.IsComplete(),
"We gave flex item unconstrained available height, so it "
"should be complete");

Просмотреть файл

@ -9946,7 +9946,7 @@ nsFrame::BoxReflow(nsBoxLayoutState& aState,
Reflow(aPresContext, aDesiredSize, reflowInput, status);
NS_ASSERTION(NS_FRAME_IS_COMPLETE(status), "bad status");
NS_ASSERTION(status.IsComplete(), "bad status");
uint32_t layoutFlags = aState.LayoutFlags();
nsContainerFrame::FinishReflowChild(this, aPresContext, aDesiredSize,

Просмотреть файл

@ -705,7 +705,7 @@ nsHTMLFramesetFrame::ReflowPlaceChild(nsIFrame* aChild,
ReflowChild(aChild, aPresContext, reflowOutput, reflowInput, aOffset.x,
aOffset.y, 0, status);
NS_ASSERTION(NS_FRAME_IS_COMPLETE(status), "bad status");
NS_ASSERTION(status.IsComplete(), "bad status");
// Place and size the child
reflowOutput.Width() = aSize.width;

Просмотреть файл

@ -5287,7 +5287,7 @@ nsGridContainerFrame::ReflowInFlowChild(nsIFrame* aChild,
// Apply align/justify-self and reflow again if that affects the size.
if (MOZ_LIKELY(isGridItem)) {
LogicalSize size = childSize.Size(childWM); // from the ReflowChild()
if (NS_FRAME_IS_COMPLETE(aStatus)) {
if (aStatus.IsComplete()) {
auto align = childRI.mStylePosition->UsedAlignSelf(containerSC);
auto state = aGridItemInfo->mState[eLogicalAxisBlock];
if (state & ItemState::eContentBaseline) {
@ -5348,7 +5348,7 @@ nsGridContainerFrame::ReflowInFragmentainer(GridReflowInput& aState,
nsReflowStatus childStatus;
ReflowInFlowChild(child, nullptr, aContainerSize, Nothing(), &aFragmentainer,
aState, aContentArea, aDesiredSize, childStatus);
MOZ_ASSERT(NS_FRAME_IS_COMPLETE(childStatus),
MOZ_ASSERT(childStatus.IsComplete(),
"nsPlaceholderFrame should never need to be fragmented");
}
@ -5516,7 +5516,7 @@ nsGridContainerFrame::ReflowInFragmentainer(GridReflowInput& aState,
// If we can't fit all rows then we're at least overflow-incomplete.
if (endRow < numRows) {
childAvailableSize = bEndRow;
if (NS_FRAME_IS_COMPLETE(aStatus)) {
if (aStatus.IsComplete()) {
NS_FRAME_SET_OVERFLOW_INCOMPLETE(aStatus);
aStatus |= NS_FRAME_REFLOW_NEXTINFLOW;
}
@ -5702,7 +5702,7 @@ nsGridContainerFrame::ReflowRowsInFragmentainer(
if (!pushedItems.IsEmpty() ||
!incompleteItems.IsEmpty() ||
!overflowIncompleteItems.IsEmpty()) {
if (NS_FRAME_IS_COMPLETE(aStatus)) {
if (aStatus.IsComplete()) {
NS_FRAME_SET_OVERFLOW_INCOMPLETE(aStatus);
aStatus |= NS_FRAME_REFLOW_NEXTINFLOW;
}
@ -5853,7 +5853,7 @@ nsGridContainerFrame::ReflowChildren(GridReflowInput& aState,
}
ReflowInFlowChild(*aState.mIter, info, containerSize, Nothing(), nullptr,
aState, aContentArea, aDesiredSize, aStatus);
MOZ_ASSERT(NS_FRAME_IS_COMPLETE(aStatus), "child should be complete "
MOZ_ASSERT(aStatus.IsComplete(), "child should be complete "
"in unconstrained reflow");
}
}
@ -6157,7 +6157,7 @@ nsGridContainerFrame::Reflow(nsPresContext* aPresContext,
bSize = std::max(bSize - consumedBSize, 0);
// Skip our block-end border if we're INCOMPLETE.
if (!NS_FRAME_IS_COMPLETE(aStatus) &&
if (!aStatus.IsComplete() &&
!gridReflowInput.mSkipSides.BEnd() &&
StyleBorder()->mBoxDecorationBreak !=
StyleBoxDecorationBreak::Clone) {
@ -6172,7 +6172,7 @@ nsGridContainerFrame::Reflow(nsPresContext* aPresContext,
// Convert INCOMPLETE -> OVERFLOW_INCOMPLETE and zero bsize if we're an OC.
if (HasAnyStateBits(NS_FRAME_IS_OVERFLOW_CONTAINER)) {
if (!NS_FRAME_IS_COMPLETE(aStatus)) {
if (!aStatus.IsComplete()) {
NS_FRAME_SET_OVERFLOW_INCOMPLETE(aStatus);
aStatus |= NS_FRAME_REFLOW_NEXTINFLOW;
}

Просмотреть файл

@ -303,9 +303,6 @@ private:
#define NS_FRAME_REFLOW_NEXTINFLOW 0x2
#define NS_FRAME_OVERFLOW_INCOMPLETE 0x4
#define NS_FRAME_IS_COMPLETE(status) \
(0 == ((status) & NS_FRAME_NOT_COMPLETE))
#define NS_FRAME_OVERFLOW_IS_INCOMPLETE(status) \
(0 != ((status) & NS_FRAME_OVERFLOW_INCOMPLETE))

Просмотреть файл

@ -734,7 +734,7 @@ nsInlineFrame::ReflowFrames(nsPresContext* aPresContext,
}
}
NS_ASSERTION(!NS_FRAME_IS_COMPLETE(aStatus) || !GetOverflowFrames(),
NS_ASSERTION(!aStatus.IsComplete() || !GetOverflowFrames(),
"We can't be complete AND have overflow frames!");
// If after reflowing our children they take up no area then make
@ -771,7 +771,7 @@ nsInlineFrame::ReflowFrames(nsPresContext* aPresContext,
* chain. For box-decoration-break:clone we always apply the end border and
* padding since all continuations have them.
*/
if ((NS_FRAME_IS_COMPLETE(aStatus) &&
if ((aStatus.IsComplete() &&
!LastInFlow()->GetNextContinuation() &&
!FrameIsNonLastInIBSplit()) ||
boxDecorationBreakClone) {

Просмотреть файл

@ -1072,7 +1072,7 @@ nsLineLayout::ReflowFrame(nsIFrame* aFrame,
// them now. Do not do this when a break-before is signaled because
// the frame is going to get reflowed again (and may end up wanting
// a next-in-flow where it ends up).
if (NS_FRAME_IS_COMPLETE(aReflowStatus)) {
if (aReflowStatus.IsComplete()) {
nsIFrame* kidNextInFlow = aFrame->GetNextInFlow();
if (nullptr != kidNextInFlow) {
// Remove all of the childs next-in-flows. Make sure that we ask

Просмотреть файл

@ -95,7 +95,7 @@ nsPageContentFrame::Reflow(nsPresContext* aPresContext,
// Reflow our fixed frames
nsReflowStatus fixedStatus = NS_FRAME_COMPLETE;
ReflowAbsoluteFrames(aPresContext, aDesiredSize, aReflowInput, fixedStatus);
NS_ASSERTION(NS_FRAME_IS_COMPLETE(fixedStatus), "fixed frames can be truncated, but not incomplete");
NS_ASSERTION(fixedStatus.IsComplete(), "fixed frames can be truncated, but not incomplete");
// Return our desired size
WritingMode wm = aReflowInput.GetWritingMode();

Просмотреть файл

@ -405,9 +405,9 @@ nsRubyBaseContainerFrame::Reflow(nsPresContext* aPresContext,
// If there exists any span, the columns must either be completely
// reflowed, or be not reflowed at all.
MOZ_ASSERT(NS_INLINE_IS_BREAK_BEFORE(aStatus) ||
NS_FRAME_IS_COMPLETE(aStatus) || !hasSpan);
aStatus.IsComplete() || !hasSpan);
if (!NS_INLINE_IS_BREAK_BEFORE(aStatus) &&
NS_FRAME_IS_COMPLETE(aStatus) && hasSpan) {
aStatus.IsComplete() && hasSpan) {
// Reflow spans
RubyReflowInput reflowInput = {
false, false, textContainers, aReflowInput, reflowInputs
@ -528,7 +528,7 @@ nsRubyBaseContainerFrame::ReflowColumns(const RubyReflowInput& aReflowInput,
return 0;
}
aStatus = NS_INLINE_LINE_BREAK_AFTER(aStatus);
MOZ_ASSERT(NS_FRAME_IS_COMPLETE(aStatus) || aReflowInput.mAllowLineBreak);
MOZ_ASSERT(aStatus.IsComplete() || aReflowInput.mAllowLineBreak);
// If we are on an intra-level whitespace column, null values in
// column.mBaseFrame and column.mTextFrames don't represent the

Просмотреть файл

@ -171,7 +171,7 @@ nsRubyFrame::Reflow(nsPresContext* aPresContext,
if (boxDecorationBreakClone || !GetPrevContinuation()) {
aDesiredSize.ISize(lineWM) += borderPadding.IStart(frameWM);
}
if (boxDecorationBreakClone || NS_FRAME_IS_COMPLETE(aStatus)) {
if (boxDecorationBreakClone || aStatus.IsComplete()) {
aDesiredSize.ISize(lineWM) += borderPadding.IEnd(frameWM);
}

Просмотреть файл

@ -894,7 +894,7 @@ nsMathMLContainerFrame::Reflow(nsPresContext* aPresContext,
childFrame, availSize);
ReflowChild(childFrame, aPresContext, childDesiredSize,
childReflowInput, childStatus);
//NS_ASSERTION(NS_FRAME_IS_COMPLETE(childStatus), "bad status");
//NS_ASSERTION(childStatus.IsComplete(), "bad status");
SaveReflowAndBoundingMetricsFor(childFrame, childDesiredSize,
childDesiredSize.mBoundingMetrics);
childFrame = childFrame->GetNextSibling();

Просмотреть файл

@ -144,7 +144,7 @@ nsMathMLTokenFrame::Reflow(nsPresContext* aPresContext,
childFrame, availSize);
ReflowChild(childFrame, aPresContext, childDesiredSize,
childReflowInput, aStatus);
//NS_ASSERTION(NS_FRAME_IS_COMPLETE(aStatus), "bad status");
//NS_ASSERTION(aStatus.IsComplete(), "bad status");
SaveReflowAndBoundingMetricsFor(childFrame, childDesiredSize,
childDesiredSize.mBoundingMetrics);
}

Просмотреть файл

@ -265,7 +265,7 @@ nsMathMLmfencedFrame::Reflow(nsPresContext* aPresContext,
childFrame, availSize);
ReflowChild(childFrame, aPresContext, childDesiredSize,
childReflowInput, childStatus);
//NS_ASSERTION(NS_FRAME_IS_COMPLETE(childStatus), "bad status");
//NS_ASSERTION(childStatus.IsComplete(), "bad status");
SaveReflowAndBoundingMetricsFor(childFrame, childDesiredSize,
childDesiredSize.mBoundingMetrics);

Просмотреть файл

@ -315,7 +315,7 @@ nsMathMLmpaddedFrame::Reflow(nsPresContext* aPresContext,
// Let the base class format our content like an inferred mrow
nsMathMLContainerFrame::Reflow(aPresContext, aDesiredSize,
aReflowInput, aStatus);
//NS_ASSERTION(NS_FRAME_IS_COMPLETE(aStatus), "bad status");
//NS_ASSERTION(aStatus.IsComplete(), "bad status");
}
/* virtual */ nsresult

Просмотреть файл

@ -196,7 +196,7 @@ nsMathMLmrootFrame::Reflow(nsPresContext* aPresContext,
childFrame, availSize);
ReflowChild(childFrame, aPresContext,
childDesiredSize, childReflowInput, childStatus);
//NS_ASSERTION(NS_FRAME_IS_COMPLETE(childStatus), "bad status");
//NS_ASSERTION(childStatus.IsComplete(), "bad status");
if (0 == count) {
// base
baseFrame = childFrame;

Просмотреть файл

@ -1929,7 +1929,7 @@ nsTableFrame::Reflow(nsPresContext* aPresContext,
}
// XXXldb Are all these conditions correct?
if (needToInitiateSpecialReflow && NS_FRAME_IS_COMPLETE(aStatus)) {
if (needToInitiateSpecialReflow && aStatus.IsComplete()) {
// XXXldb Do we need to set the IsBResize flag on any reflow states?
ReflowInput &mutable_rs =
@ -3172,7 +3172,7 @@ nsTableFrame::ReflowChildren(TableReflowInput& aReflowInput,
// the next page
if (isPaginated &&
(NS_INLINE_IS_BREAK_BEFORE(aStatus) ||
(NS_FRAME_IS_COMPLETE(aStatus) &&
(aStatus.IsComplete() &&
(NS_UNCONSTRAINEDSIZE != kidReflowInput.AvailableHeight()) &&
kidReflowInput.AvailableHeight() < desiredSize.Height()))) {
if (ShouldAvoidBreakInside(aReflowInput.reflowInput)) {
@ -3233,7 +3233,7 @@ nsTableFrame::ReflowChildren(TableReflowInput& aReflowInput,
pageBreak = false;
// see if there is a page break after this row group or before the next one
if (NS_FRAME_IS_COMPLETE(aStatus) && isPaginated &&
if (aStatus.IsComplete() && isPaginated &&
(NS_UNCONSTRAINEDSIZE != kidReflowInput.AvailableHeight())) {
nsIFrame* nextKid =
(childX + 1 < rowGroups.Length()) ? rowGroups[childX + 1] : nullptr;

Просмотреть файл

@ -1177,7 +1177,7 @@ nsTableRowFrame::ReflowCellFrame(nsPresContext* aPresContext,
ReflowChild(aCellFrame, aPresContext, desiredSize, cellReflowInput,
0, 0, NS_FRAME_NO_MOVE_FRAME, aStatus);
bool fullyComplete = NS_FRAME_IS_COMPLETE(aStatus) && !NS_FRAME_IS_TRUNCATED(aStatus);
bool fullyComplete = aStatus.IsComplete() && !NS_FRAME_IS_TRUNCATED(aStatus);
if (fullyComplete) {
desiredSize.BSize(wm) = aAvailableBSize;
}

Просмотреть файл

@ -1028,7 +1028,7 @@ nsTableRowGroupFrame::SplitSpanningCells(nsPresContext& aPresContext,
isTopOfPage, cell,
cellAvailBSize, status);
aDesiredBSize = std::max(aDesiredBSize, rowPos.y + cellBSize);
if (NS_FRAME_IS_COMPLETE(status)) {
if (status.IsComplete()) {
if (cellBSize > cellAvailBSize) {
aFirstTruncatedRow = row;
if ((row != &aFirstRow) || !aFirstRowIsTopOfPage) {