Bug 1789245 - [devtools] Mark openDevTools as nullable for installTemporaryAddon r=devtools-backward-compat-reviewers,ochameau

Differential Revision: https://phabricator.services.mozilla.com/D156458

devtools/client/shared/test/browser_dbg_listaddons.js

@@ -77,6 +77,18 @@ add_task(async function() {
   );
   ok(!front2AfterRemove, "Should no longer get a front for addon1");
 
+  // Check behavior when openDevTools is not passed:
+  const addon2again = await addTemporaryAddon({
+    addons,
+    path: ADDON2_PATH,
+    // openDevTools: null,
+  });
+  const addonFront2again = await client.mainRoot.getAddon({ id: ADDON2_ID });
+  ok(addonFront2again, "Should find an addon actor for addon2.");
+  is(addonListChangedEvents, 4, "Should have seen addonListChanged.");
+  await removeAddon(addon2again);
+  is(addonListChangedEvents, 5, "Should have seen addonListChanged.");
+
   await client.close();
 });
 

devtools/server/tests/xpcshell/test_webext_apis.js

@@ -62,7 +62,9 @@ add_task(async function test_webext_run_apis() {
     to: getRootResponse.addonsActor,
     type: "installTemporaryAddon",
     addonPath,
-    openDevTools: false,
+    // The openDevTools parameter is not always passed by web-ext. This test
+    // omits it, to make sure that the request without the flag is accepted.
+    // openDevTools: false,
   });
   await promiseStarted;
 

devtools/shared/specs/addon/addons.js

@@ -10,7 +10,10 @@ const addonsSpec = generateActorSpec({
 
   methods: {
     installTemporaryAddon: {
-      request: { addonPath: Arg(0, "string"), openDevTools: Arg(1, "boolean") },
+      request: {
+        addonPath: Arg(0, "string"),
+        openDevTools: Arg(1, "nullable:boolean"),
+      },
       response: { addon: RetVal("json") },
     },
   },