Bug 1434326: Cleanup DiagnosticsMatcher constructor. r=mystor

Removing a bit of the ugly :)

MozReview-Commit-ID: ATf2b2oh1F1

--HG--
extra : rebase_source : da6e36533c2b2ec8820c728953b0c0544c5a085e

build/clang-plugin/DiagnosticsMatcher.cpp

@@ -4,12 +4,7 @@
 
 #include "DiagnosticsMatcher.h"
 
-DiagnosticsMatcher::DiagnosticsMatcher(CompilerInstance &CI)
-    :
-#define CHECK(cls, name) cls##_(name),
-#include "Checks.inc"
-#undef CHECK
-      AstMatcher() {
+DiagnosticsMatcher::DiagnosticsMatcher(CompilerInstance &CI) {
 #define CHECK(cls, name)                                                       \
   cls##_.registerMatchers(&AstMatcher);                                        \
   cls##_.registerPPCallbacks(CI);

build/clang-plugin/DiagnosticsMatcher.h

@@ -14,7 +14,7 @@ public:
   ASTConsumerPtr makeASTConsumer() { return AstMatcher.newASTConsumer(); }
 
 private:
-#define CHECK(cls, name) cls cls##_;
+#define CHECK(cls, name) cls cls##_ { name };
 #include "Checks.inc"
 #undef CHECK
   MatchFinder AstMatcher;