Bug 1692939 - Turn namespace() into a builtin in python configure. r=firefox-build-system-reviewers,mhentges

This removes the need for some --help dependencies.

Differential Revision: https://phabricator.services.mozilla.com/D105263

build/moz.configure/android-sdk.configure

@@ -46,8 +46,8 @@ def android_sdk_root(value):
     )
 
 
-@depends("--help")
-def android_sdk_version(_):
+@dependable
+def android_sdk_version():
     return namespace(build_tools_version="29.0.3", target_sdk_version="29")
 
 

build/moz.configure/arm.configure

@@ -5,8 +5,8 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 
-@depends(target.os, "--help")
-def arm_option_defaults(os, _):
+@depends(target.os)
+def arm_option_defaults(os):
     if os == "Android":
         arch = "armv7-a"
         thumb = "yes"

build/moz.configure/toolchain.configure

@@ -10,8 +10,8 @@
 option("--disable-optimize", nargs="?", help="Disable optimizations via compiler flags")
 
 
-@depends("--enable-optimize", "--help")
-def moz_optimize(option, _):
+@depends("--enable-optimize")
+def moz_optimize(option):
     flags = None
 
     if len(option):

build/moz.configure/util.configure

@@ -403,12 +403,6 @@ def deprecated_option(*args, **kwargs):
     return decorator
 
 
-# from mozbuild.util import ReadOnlyNamespace as namespace
-@imports(_from="mozbuild.util", _import="ReadOnlyNamespace")
-def namespace(**kwargs):
-    return ReadOnlyNamespace(**kwargs)
-
-
 # Turn an object into an object that can be used as an argument to @depends.
 # The given object can be a literal value, a function that takes no argument,
 # or, for convenience, a @depends function.

js/moz.configure

@@ -168,8 +168,8 @@ option(
 )
 
 
-@depends("--enable-jit", "--enable-simulator", target, "--help")
-def simulator(jit_enabled, simulator_enabled, target, _):
+@depends("--enable-jit", "--enable-simulator", target)
+def simulator(jit_enabled, simulator_enabled, target):
     if not jit_enabled or not simulator_enabled:
         return
 
@@ -183,7 +183,7 @@ def simulator(jit_enabled, simulator_enabled, target, _):
         if target.cpu != "x86_64":
             die("The %s simulator only works on x86-64." % sim_cpu)
 
-    return namespace(**{sim_cpu: True})
+    return namespace(sim_cpu=True)
 
 
 set_config("JS_SIMULATOR", depends_if(simulator)(lambda x: True))

python/mozbuild/mozbuild/configure/__init__.py

@@ -1258,6 +1258,7 @@ class ConfigureSandbox(dict):
             __name__=self._paths[-1] if self._paths else "",
             os=self.OS,
             log=self.log_impl,
+            namespace=ReadOnlyNamespace,
         )
         if update_globals:
             update_globals(glob)

python/mozbuild/mozbuild/configure/lint.py

@@ -177,6 +177,8 @@ class LintSandbox(ConfigureSandbox):
                         continue
                     if instr.argval in self.BUILTINS:
                         continue
+                    if instr.argval in "namespace":
+                        continue
                     return True
         return False