Bug 1773399 - Update clang-sys to 1.3.3. r=emilio

Differential Revision: https://phabricator.services.mozilla.com/D148707

Cargo.lock

@@ -763,9 +763,9 @@ checksum = "bb7bdea464ae038f09197b82430b921c53619fc8d2bcaf7b151013b3ca008017"
 
 [[package]]
 name = "clang-sys"
-version = "1.3.2"
+version = "1.3.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "bf6b561dcf059c85bbe388e0a7b0a1469acb3934cc0cfa148613a830629e3049"
+checksum = "5a050e2153c5be08febd6734e29298e844fdb0fa21aeddd63b4eb7baa106c69b"
 dependencies = [
  "glob",
  "libc",

supply-chain/config.toml

@@ -246,7 +246,7 @@ version = "0.1.0"
 criteria = "safe-to-deploy"
 
 [[unaudited.clang-sys]]
-version = "1.3.2"
+version = "1.3.3"
 criteria = "safe-to-deploy"
 
 [[unaudited.clap]]

third_party/rust/clang-sys/.cargo-checksum.json

@@ -1 +1 @@
-{"files":{"CHANGELOG.md":"499c57eade3c5b157a5f36412f723aa86da1cf805d330e9c1e5a2bbb85a9f2c7","Cargo.toml":"54313f3bb32a6cc6f65c6fc6e43ca79e0f2599f4d6f28a8410c348721dd1d6c2","LICENSE.txt":"3ddf9be5c28fe27dad143a5dc76eea25222ad1dd68934a047064e56ed2fa40c5","README.md":"e1800b83d40b2fe14cee9cf97bdd1e28c1578f30ce946f342321dbcd31e17874","build.rs":"fbcd7eb0494a38be9e3fda648f91e4be05cad53a4c9faaf4fb8c7be270b1305d","build/common.rs":"7a38220e50c7c208057cb0b5ac13d54152aa4f6bebaea2160b0391adaf518e68","build/dynamic.rs":"84bc5a004dd7fa72a176cf9564db58a517c09870bac9ae6f5169411e1ed7f548","build/static.rs":"15e680b3896d1a83720210de7b72cc2fd2791626721e480c89902595d876eba7","clippy.toml":"fcf54943ba571514b244cc098ce08671b4117167733e8107e799d533a12a2195","src/lib.rs":"e2a78105864d5d49cb1dcafc331a5433cae39e4d39c726030f727d61cb214d7c","src/link.rs":"2fd772f679752a215566460671b159c01324504e7a36b642751fa3e1eca8d42f","src/support.rs":"8e560210d97b8464de7108bbc67c4b09296fb7c25cbc5698bebb6485ba4d637d","tests/header.h":"1b15a686d1c06561960045a26c25a34d840f26c8246f2f5e630f993b69c7492c","tests/lib.rs":"81a459e9f48e6d384b3fd61e7942e685f7ea39af6574bc2b382a0fbe7820ff65"},"package":"bf6b561dcf059c85bbe388e0a7b0a1469acb3934cc0cfa148613a830629e3049"}
+{"files":{"CHANGELOG.md":"5c841ce7a1c6037216be4012152bbe1945d2d57f6d9d7a86fdb217a830714651","Cargo.toml":"bbcb69b5a8c1172d85c80d0bb1cb53c95cc83422d2d98a4208268d6874960a96","LICENSE.txt":"3ddf9be5c28fe27dad143a5dc76eea25222ad1dd68934a047064e56ed2fa40c5","README.md":"e1800b83d40b2fe14cee9cf97bdd1e28c1578f30ce946f342321dbcd31e17874","build.rs":"fbcd7eb0494a38be9e3fda648f91e4be05cad53a4c9faaf4fb8c7be270b1305d","build/common.rs":"7a38220e50c7c208057cb0b5ac13d54152aa4f6bebaea2160b0391adaf518e68","build/dynamic.rs":"84bc5a004dd7fa72a176cf9564db58a517c09870bac9ae6f5169411e1ed7f548","build/static.rs":"15e680b3896d1a83720210de7b72cc2fd2791626721e480c89902595d876eba7","clippy.toml":"fcf54943ba571514b244cc098ce08671b4117167733e8107e799d533a12a2195","src/lib.rs":"e2a78105864d5d49cb1dcafc331a5433cae39e4d39c726030f727d61cb214d7c","src/link.rs":"2fd772f679752a215566460671b159c01324504e7a36b642751fa3e1eca8d42f","src/support.rs":"da7e4e08a5fce844f563943588fca5de3b72972fc61db96c5158b1246737e006","tests/header.h":"1b15a686d1c06561960045a26c25a34d840f26c8246f2f5e630f993b69c7492c","tests/lib.rs":"81a459e9f48e6d384b3fd61e7942e685f7ea39af6574bc2b382a0fbe7820ff65"},"package":"5a050e2153c5be08febd6734e29298e844fdb0fa21aeddd63b4eb7baa106c69b"}

third_party/rust/clang-sys/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [1.3.3] - 2022-05-28
+
+### Fixed
+- Fixed `Clang::find` to check that `CLANG_PATH` is an executable file before
+selecting it
+
 ## [1.3.2] - 2022-05-18
 
 ### Added

third_party/rust/clang-sys/Cargo.toml

@@ -11,7 +11,7 @@
 
 [package]
 name = "clang-sys"
-version = "1.3.2"
+version = "1.3.3"
 authors = ["Kyle Mayes <kyle@mayeses.com>"]
 build = "build.rs"
 links = "clang"

third_party/rust/clang-sys/src/support.rs

@@ -58,7 +58,10 @@ impl Clang {
     /// `x86_64-unknown-linux-gnu-clang` for the above example).
     pub fn find(path: Option<&Path>, args: &[String]) -> Option<Clang> {
         if let Ok(path) = env::var("CLANG_PATH") {
-            return Some(Clang::new(path, args));
+            let p = Path::new(&path);
+            if p.is_file() && is_executable(&p).unwrap_or(false) {
+                return Some(Clang::new(p, args));
+            }
         }
 
         // Determine the cross-compilation target, if any.