Bug 1796085 - Part 1: Define MOZ_BACKGROUNDTASKS macro globally r=smaug,necko-reviewers,application-update-reviewers,nalexander,valentin

There are 10+ separate macro definition for this, we can do it globally instead.

Differential Revision: https://phabricator.services.mozilla.com/D156911

browser/installer/Makefile.in

@@ -102,10 +102,6 @@ ifdef MOZ_NOTIFICATION_SERVER
 DEFINES += -DMOZ_NOTIFICATION_SERVER=1
 endif
 
-ifdef MOZ_BACKGROUNDTASKS
-DEFINES += -DMOZ_BACKGROUNDTASKS=1
-endif
-
 ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT))
 MOZ_PKG_MAC_DSSTORE=$(topsrcdir)/$(MOZ_BRANDING_DIRECTORY)/dsstore
 MOZ_PKG_MAC_BACKGROUND=$(topsrcdir)/$(MOZ_BRANDING_DIRECTORY)/background.png

browser/moz.build

@@ -48,9 +48,6 @@ for cdm in CONFIG["MOZ_EME_MODULES"]:
 if CONFIG["MOZ_GPSD"]:
     DEFINES["MOZ_GPSD"] = True
 
-if CONFIG["MOZ_BACKGROUNDTASKS"]:
-    DEFINES["MOZ_BACKGROUNDTASKS"] = True
-
 if CONFIG["MOZ_UPDATE_AGENT"]:
     DEFINES["MOZ_UPDATE_AGENT"] = True
 

modules/libpref/moz.build

@@ -175,7 +175,4 @@ else:
         "greprefs.js",
     ]
 
-if CONFIG["MOZ_BACKGROUNDTASKS"]:
-    DEFINES["MOZ_BACKGROUNDTASKS"] = True
-
 REQUIRES_UNIFIED_BUILD = True

netwerk/cache2/moz.build

@@ -68,4 +68,3 @@ if CONFIG["MOZ_BACKGROUNDTASKS"]:
     EXTRA_JS_MODULES.backgroundtasks += [
         "BackgroundTask_purgeHTTPCache.sys.mjs",
     ]
-    DEFINES["MOZ_BACKGROUNDTASKS"] = True

startupcache/moz.build

@@ -31,9 +31,6 @@ XPIDL_SOURCES += [
     "nsIStartupCacheInfo.idl",
 ]
 
-if CONFIG["MOZ_BACKGROUNDTASKS"]:
-    DEFINES["MOZ_BACKGROUNDTASKS"] = True
-
 FINAL_LIBRARY = "xul"
 
 REQUIRES_UNIFIED_BUILD = True

toolkit/components/telemetry/moz.build

@@ -19,10 +19,6 @@ if CONFIG["COMPILE_ENVIRONMENT"]:
 
 DEFINES["MOZ_APP_VERSION"] = '"%s"' % CONFIG["MOZ_APP_VERSION"]
 
-for var in ("MOZ_BACKGROUNDTASKS",):
-    if CONFIG[var]:
-        DEFINES[var] = True
-
 LOCAL_INCLUDES += [
     "/xpcom/build",
     "/xpcom/threads",

toolkit/modules/moz.build

@@ -286,7 +286,6 @@ for var in (
 
 for var in (
     "MOZ_ALLOW_ADDON_SIDELOAD",
-    "MOZ_BACKGROUNDTASKS",
     "MOZ_SYSTEM_NSS",
     "MOZ_SYSTEM_POLICIES",
     "MOZ_UNSIGNED_APP_SCOPE",

toolkit/moz.configure

@@ -2656,9 +2656,13 @@ option(
 )
 
 
-set_config(
+@depends("--enable-backgroundtasks")
-    "MOZ_BACKGROUNDTASKS", depends_if("--enable-backgroundtasks")(lambda _: True)
+def background_tasks(value):
-)
+    return bool(value)
+
+
+set_config("MOZ_BACKGROUNDTASKS", background_tasks)
+set_define("MOZ_BACKGROUNDTASKS", background_tasks)
 
 
 # Update-related programs: updater, maintenance service, update agent,

toolkit/mozapps/update/updater/updater-common.build

@@ -92,7 +92,7 @@ if CONFIG["MOZ_TSAN"]:
 DEFINES["SPRINTF_H_USES_VSNPRINTF"] = True
 DEFINES["NS_NO_XPCOM"] = True
 DisableStlWrapping()
-for var in ("MAR_CHANNEL_ID", "MOZ_APP_VERSION", "MOZ_BACKGROUNDTASKS"):
+for var in ("MAR_CHANNEL_ID", "MOZ_APP_VERSION"):
     DEFINES[var] = '"%s"' % CONFIG[var]
 
 LOCAL_INCLUDES += [

toolkit/profile/moz.build

@@ -28,9 +28,6 @@ if CONFIG["OS_ARCH"] == "WINNT":
 if CONFIG["OS_TARGET"] == "Android":
     UNIFIED_SOURCES += ["ProfileUnlockerAndroid.cpp"]
 
-if CONFIG["MOZ_BACKGROUNDTASKS"]:
-    DEFINES["MOZ_BACKGROUNDTASKS"] = True
-
 UNIFIED_SOURCES += ["nsToolkitProfileService.cpp"]
 
 LOCAL_INCLUDES += [

toolkit/xre/moz.build

@@ -288,7 +288,4 @@ FINAL_TARGET_PP_FILES += ["platform.ini"]
 if CONFIG["ENABLE_TESTS"]:
     DIRS += ["test/gtest"]
 
-if CONFIG["MOZ_BACKGROUNDTASKS"]:
-    DEFINES["MOZ_BACKGROUNDTASKS"] = True
-
 REQUIRES_UNIFIED_BUILD = True

widget/windows/moz.build

@@ -182,7 +182,7 @@ DEFINES["MOZ_APP_NAME"] = '"%s"' % CONFIG["MOZ_APP_NAME"]
 # Turn `firefox` into `Firefox`.
 DEFINES["MOZ_TOAST_APP_NAME"] = '"%s"' % CONFIG["MOZ_APP_NAME"].title()
 
-for var in ("MOZ_ENABLE_D3D10_LAYER", "MOZ_BACKGROUNDTASKS"):
+for var in ("MOZ_ENABLE_D3D10_LAYER",):
     if CONFIG[var]:
         DEFINES[var] = True
 

xpcom/base/moz.build

@@ -257,6 +257,3 @@ LOCAL_INCLUDES += [
 
 if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
     CXXFLAGS += CONFIG["MOZ_GTK3_CFLAGS"]
-
-if CONFIG["MOZ_BACKGROUNDTASKS"]:
-    DEFINES["MOZ_BACKGROUNDTASKS"] = True

xpcom/components/moz.build

@@ -78,9 +78,6 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "gtk":
     if CONFIG["MOZ_ENABLE_DBUS"]:
         CXXFLAGS += CONFIG["MOZ_DBUS_GLIB_CFLAGS"]
 
-if CONFIG["MOZ_BACKGROUNDTASKS"]:
-    DEFINES["MOZ_BACKGROUNDTASKS"] = True
-
 include("/ipc/chromium/chromium-config.mozbuild")
 
 PYTHON_UNITTEST_MANIFESTS += [