From fb54936d49821a9109bac31fc908efd8ae7c5bab Mon Sep 17 00:00:00 2001 From: Boris Zbarsky Date: Wed, 23 Mar 2016 11:44:54 -0400 Subject: [PATCH] Bug 1255817 part 4. Make XPCJSRuntime use MozCrashErrorReporter by default, now that there should be no stray JS_ReportPendingException calls. r=bholley --- js/xpconnect/src/XPCJSRuntime.cpp | 1 - xpcom/base/CycleCollectedJSRuntime.cpp | 2 -- 2 files changed, 3 deletions(-) diff --git a/js/xpconnect/src/XPCJSRuntime.cpp b/js/xpconnect/src/XPCJSRuntime.cpp index 158f0962d2eb..50fce3980451 100644 --- a/js/xpconnect/src/XPCJSRuntime.cpp +++ b/js/xpconnect/src/XPCJSRuntime.cpp @@ -3509,7 +3509,6 @@ XPCJSRuntime::Initialize() kStackQuota - kSystemCodeBuffer, kStackQuota - kSystemCodeBuffer - kTrustedScriptBuffer); - JS_SetErrorReporter(runtime, xpc::SystemErrorReporter); JS_SetDestroyCompartmentCallback(runtime, CompartmentDestroyedCallback); JS_SetSizeOfIncludingThisCompartmentCallback(runtime, CompartmentSizeOfIncludingThisCallback); JS_SetCompartmentNameCallback(runtime, CompartmentNameCallback); diff --git a/xpcom/base/CycleCollectedJSRuntime.cpp b/xpcom/base/CycleCollectedJSRuntime.cpp index 2719f6be6628..e0b4d223ab07 100644 --- a/xpcom/base/CycleCollectedJSRuntime.cpp +++ b/xpcom/base/CycleCollectedJSRuntime.cpp @@ -528,8 +528,6 @@ CycleCollectedJSRuntime::Initialize(JSRuntime* aParentRuntime, JS_SetDestroyZoneCallback(mJSRuntime, XPCStringConvert::FreeZoneCache); JS_SetSweepZoneCallback(mJSRuntime, XPCStringConvert::ClearZoneCache); JS::SetBuildIdOp(mJSRuntime, GetBuildId); - // XPCJSRuntime currently overrides this because we don't - // TakeOwnershipOfErrorReporting everwhere on the main thread yet. JS_SetErrorReporter(mJSRuntime, MozCrashErrorReporter); static js::DOMCallbacks DOMcallbacks = {