Adding caret width and blink time to nsILookAndFeel

widget/public/nsILookAndFeel.h

@@ -66,7 +66,10 @@ public:
     eMetric_ListHorizontalInsideMinimumPadding,         
 
     eMetric_ListShouldUseVerticalInsidePadding,           // needed only because of GTK
-    eMetric_ListVerticalInsidePadding                     // needed only because of GTK
+    eMetric_ListVerticalInsidePadding,                    // needed only because of GTK
+
+    eMetric_CaretBlinkTime,                               // default, may be overriden by OS
+    eMetric_CaretWidthTwips
   } nsMetricID;
 
   typedef enum {

widget/src/beos/nsLookAndFeel.cpp

@@ -139,6 +139,12 @@ NS_IMETHODIMP nsLookAndFeel::GetMetric(const nsMetricID aID, PRInt32 & aMetric)
     case eMetric_ListVerticalInsidePadding:
         aMetric = 0;
         break;
+    case eMetric_CaretBlinkTime:
+        aMetric = 500;
+        break;
+    case eMetric_CaretWidthTwips:
+        aMetric = 20;
+        break;
     default:
         aMetric = -1;
         res = NS_ERROR_FAILURE;

widget/src/gtk/nsLookAndFeel.cpp

@@ -153,6 +153,12 @@ NS_IMETHODIMP nsLookAndFeel::GetMetric(const nsMetricID aID, PRInt32 & aMetric)
     case eMetric_ListVerticalInsidePadding:
         aMetric = 1;
         break;
+    case eMetric_CaretBlinkTime:
+        aMetric = 500;
+        break;
+    case eMetric_CaretWidthTwips:
+        aMetric = 20;
+        break;
     default:
         aMetric = -1;
         res     = NS_ERROR_FAILURE;

widget/src/mac/nsLookAndFeel.cpp

@@ -159,6 +159,12 @@ NS_IMETHODIMP nsLookAndFeel::GetMetric(const nsMetricID aID, PRInt32 & aMetric)
     case eMetric_ListVerticalInsidePadding:
         aMetric = 3;
         break;
+    case eMetric_CaretBlinkTime:
+        aMetric = ::GetCaretTime() * 1000 / 60;
+        break;
+    case eMetric_CaretWidthTwips:
+        aMetric = 20;
+        break;
     default:
         aMetric = 0;
         res = NS_ERROR_FAILURE;

widget/src/motif/nsLookAndFeel.cpp

@@ -110,6 +110,12 @@ NS_IMETHODIMP nsLookAndFeel::GetMetric(const nsMetricID aID, PRInt32 & aMetric)
     case eMetric_RadioboxSize:
         aMetric = 12;
         break;
+    case eMetric_CaretBlinkTime:
+        aMetric = 500;
+        break;
+    case eMetric_CaretWidthTwips:
+        aMetric = 20;
+        break;
     default:
         aMetric = 0;
         res     = NS_ERROR_FAILURE;

widget/src/os2/nsLookAndFeel.cpp

@@ -123,6 +123,28 @@ NS_IMETHODIMP nsLookAndFeel::GetMetric(const nsMetricID aID, PRInt32 & aMetric)
          aMetric = 0;
          break;
 
+    case eMetric_CaretBlinkTime:
+        aMetric = WinQuerySysValue( HWND_DESKTOP, SV_CURSORRATE);
+        break;
+    case eMetric_CaretWidthTwips:
+        // Sigh - this is in 'twips', should be in 'app units', but there's no
+        // DC anyway so we can't work it out!
+
+        // The reason for this is that there is some rounding weirdness,
+        // such that the 2-pixel caret requested by the windows guys
+        // got rounded down to a 1-pixel caret for drawing, because
+        // of errors in conversion to twips and back.
+        
+        ULONG ulPels = WinQuerySysValue( HWND_DESKTOP, SV_CYBORDER);
+
+        // With luck, either:
+        //   * these metrics will go into nsILookAndFeel, or
+        //   * we'll get an nsIDeviceContext here
+        //
+        // For now, lets assume p2t = 20.
+        aMetric = 20 * ulPels;
+        break;
+
       default:
          NS_ASSERTION( 0, "Bad metric");
          break;

widget/src/photon/nsLookAndFeel.cpp

@@ -158,6 +158,12 @@ NS_IMETHODIMP nsLookAndFeel::GetMetric(const nsMetricID aID, PRInt32 & aMetric)
     break;
   case eMetric_ListVerticalInsidePadding:
     aMetric = 0; // REVISIT - HACK!
+    break;
+	case eMetric_CaretBlinkTime:
+    aMetric = 500;
+    break;
+	case eMetric_CaretWidthTwips:
+    aMetric = 20;
     break;
   default:
     aMetric = -1;

widget/src/windows/nsLookAndFeel.cpp

@@ -139,6 +139,12 @@ NS_IMETHODIMP nsLookAndFeel::GetMetric(const nsMetricID aID, PRInt32 & aMetric)
     case eMetric_ListVerticalInsidePadding:
         aMetric = 0;
         break;
+    case eMetric_CaretBlinkTime:
+        aMetric = 500;
+        break;
+    case eMetric_CaretWidthTwips:
+        aMetric = 30;
+        break;
     default:
         aMetric = -1;
         res = NS_ERROR_FAILURE;

widget/src/xlib/nsLookAndFeel.cpp

@@ -98,6 +98,12 @@ NS_IMETHODIMP nsLookAndFeel::GetMetric(const nsMetricID aID, PRInt32 & aMetric)
     case eMetric_ListVerticalInsidePadding:
         aMetric = 0;
         break;
+    case eMetric_CaretBlinkTime:
+        aMetric = 500;
+        break;
+    case eMetric_CaretWidthTwips:
+        aMetric = 20;
+        break;
     default:
         aMetric = -1;
         res = NS_ERROR_FAILURE;