Bug 811864 - Remove PannerNode.coneGain/distanceGain; r=bzbarsky

content/media/webaudio/PannerNode.cpp

@@ -12,12 +12,8 @@ namespace dom {
 
 NS_IMPL_CYCLE_COLLECTION_CLASS(PannerNode)
 NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(PannerNode, AudioNode)
-  NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mConeGain)
-  NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mDistanceGain)
 NS_IMPL_CYCLE_COLLECTION_UNLINK_END
 NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED(PannerNode, AudioNode)
-  NS_IMPL_CYCLE_COLLECTION_TRAVERSE_NATIVE_PTR(tmp->mConeGain, AudioParam, "cone gain value")
-  NS_IMPL_CYCLE_COLLECTION_TRAVERSE_NATIVE_PTR(tmp->mDistanceGain, AudioParam, "distance gain value")
 NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
 
 NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED(PannerNode)
@@ -39,8 +35,6 @@ PannerNode::PannerNode(AudioContext* aContext)
   , mConeInnerAngle(360.f)
   , mConeOuterAngle(360.f)
   , mConeOuterGain(0.f)
-  , mConeGain(new AudioParam(aContext, 1.f, 0.f, 1.f))
-  , mDistanceGain(new AudioParam(aContext, 1.f, 0.f, 1.f))
 {
 }
 

content/media/webaudio/PannerNode.h

@@ -156,16 +156,6 @@ public:
     mConeOuterGain = aConeOuterGain;
   }
 
-  AudioParam* ConeGain() const
-  {
-    return mConeGain;
-  }
-
-  AudioParam* DistanceGain() const
-  {
-    return mDistanceGain;
-  }
-
 private:
   PanningModelEnum mPanningModel;
   DistanceModelEnum mDistanceModel;
@@ -178,8 +168,6 @@ private:
   float mConeInnerAngle;
   float mConeOuterAngle;
   float mConeOuterGain;
-  nsRefPtr<AudioParam> mConeGain;
-  nsRefPtr<AudioParam> mDistanceGain;
 };
 
 }

content/media/webaudio/test/test_pannerNode.html

@@ -44,9 +44,6 @@ addLoadEvent(function() {
   near(panner.coneOuterAngle, 360, "Correct default value for cone outer angle");
   near(panner.coneOuterGain, 0, "Correct default value for cone outer gain");
 
-  ok("coneGain" in panner, "panner.coneGain exists");
-  ok("distanceGain in panner", "panner.distanceGain exists");
-
   panner.setPosition(1, 1, 1);
   panner.setOrientation(1, 1, 1);
   panner.setVelocity(1, 1, 1);

dom/webidl/PannerNode.webidl

@@ -44,9 +44,5 @@ interface PannerNode : AudioNode {
     attribute float coneOuterAngle;
     attribute float coneOuterGain;
 
-    // Dynamically calculated gain values 
-    readonly attribute AudioParam coneGain;
-    readonly attribute AudioParam distanceGain;
-
 };