Fixed pre-processing and includes for all scripts.

webtools/addons/public/htdocs/addon.php

@@ -7,15 +7,19 @@
  */
 
 startProcessing('addon.tpl');
+require_once('includes.php');
 
 // Arrays to store clean inputs.
 $clean = array();  // General array for verified inputs.
 $sql = array();  // Trusted for SQL.
 
-// Get our addon ID.
+// Get the int value of our addon ID.
 $clean['ID'] = intval($_GET['id']);
+
+// Since it is guaranteed to be just an int, we can reference it.
 $sql['ID'] =& $clean['ID'];
 
+// Create our AddOn object using the ID.
 $addon = new AddOn($sql['ID']);
 
 // Assign template variables.

webtools/addons/public/htdocs/author.php

@@ -5,6 +5,9 @@
  * @subpackage docs
  */
 
+startProcessing('author.tpl');
+require_once('includes.php');
+
 // Arrays to store clean inputs.
 $clean = array();  // General array for verified inputs.
 $sql = array();  // Trusted for SQL.

webtools/addons/public/htdocs/comments.php

@@ -6,6 +6,9 @@
  * @subpackage docs
  */
 
+startProcessing('comments.tpl');
+require_once('includes.php');
+
 // Arrays to store clean inputs.
 $clean = array();  // General array for verified inputs.
 $sql = array();  // Trusted for SQL.

webtools/addons/public/htdocs/faq.php

@@ -7,6 +7,10 @@
  *
  * @todo FAQ search?
  */
+
+startProcessing('faq.tpl');
+require_once('includes.php');
+
 $db->query("
     SELECT
         `title`,

webtools/addons/public/htdocs/history.php

@@ -9,6 +9,9 @@
  * @todo break this into a simpler design, probably a smaller table with an abbreviated desc.
  * @todo do we still want to allow users access to old versions?
  */
+
+startProcessing('history.tpl');
+require_once('includes.php');
  
 // Arrays to store clean inputs.
 $clean = array();  // General array for verified inputs.

webtools/addons/public/htdocs/index.php

@@ -10,8 +10,6 @@
  */
 
 startProcessing('index.tpl', 'nonav');
-
-// Init only the stuff we need to generate content.
 require_once('includes.php');
 
 // Arrays to store clean inputs.

webtools/addons/public/htdocs/policy.php

@@ -8,6 +8,9 @@
  * @todo talk to cbeard and rebron about establishing the policy document.
  */
 
+startProcessing('policy.tpl');
+require_once('includes.php');
+
 $links = array(
     array(  'href'  => './faq.php',
             'title' => 'Frequently Asked Questions', 

webtools/addons/public/htdocs/previews.php

@@ -5,6 +5,9 @@
  * @package amo
  * @subpackage docs
  */
+
+startProcessing('previews.tpl');
+require_once('includes.php');
  
 // Arrays to store clean inputs.
 $clean = array();  // General array for verified inputs.

webtools/addons/public/htdocs/ratecomment.php

@@ -6,6 +6,8 @@
  * @subpackage docs
  */
 
+require_once('includes.php');
+
 // Arrays to store clean inputs.
 $clean = array();  // General array for verified inputs.
 $sql = array();  // Trusted for SQL.

webtools/addons/public/htdocs/rss.php

@@ -0,0 +1,8 @@
+<?php
+/**
+ * Syndication for commonly referenced lists.
+ *
+ * @package amo
+ * @subpackage docs
+ */
+?>

webtools/addons/public/htdocs/search-engines.php

@@ -9,6 +9,9 @@
  * @todo Get main template spruced up.
  */
 
+startProcessing('search-engines.tpl','nonav');
+require_once('includes.php');
+
 // Assign template variables.
 $tpl->assign(
     array(  'title'             => 'Search Engines',

webtools/addons/public/htdocs/search.php

@@ -12,6 +12,9 @@
  * @todo fix CSS so the pull-downs look symmetrical before design freaks start crying.
  */
 
+startProcessing('search.tpl','nonav');
+require_once('includes.php');
+
 // Array to store clean inputs.
 $clean = array();
 $sql = array();

webtools/addons/public/inc/includes.php

@@ -1,5 +1,4 @@
 <?php
-
 // Include required libraries and classes.
 require_once('DB.php');  // PEAR::DB
 require_once('Auth.php');  // PEAR::Auth
@@ -49,7 +48,4 @@ if (USE_DB_SESSIONS)
     array(&$amo_session_handler, '_destroy'),
     array(&$amo_session_handler, '_gc'));
 }
-
-
-
-?>
+?>

webtools/addons/public/inc/init.php

@@ -36,7 +36,7 @@ class AMO_Smarty extends Smarty
     }
 }
 
-function startProcessing($aTplName, $aPageType)
+function startProcessing($aTplName, $aPageType='default')
 {
     // Global template object.
     global $tpl, $pageType, $content;