Bug 1611853: return early in `Selection::AddRangeAndSelectFramesAndNotifyListeners` when it didn't add a range. r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D61448

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Mirko Brodesser 2020-02-04 08:43:06 +00:00
Родитель d6f4b8ad5e
Коммит fcd2fa44a5
2 изменённых файлов: 6 добавлений и 2 удалений

Просмотреть файл

@ -1893,7 +1893,10 @@ void Selection::AddRangeAndSelectFramesAndNotifyListeners(nsRange& aRange,
}
}
MOZ_ASSERT(rangeIndex >= 0);
if (rangeIndex < 0) {
return;
}
MOZ_ASSERT(rangeIndex < static_cast<int32_t>(mRanges.Length()));
SetAnchorFocusRange(rangeIndex);

Просмотреть файл

@ -171,7 +171,8 @@ class Selection final : public nsSupportsWeakReference,
*
* @param aOutIndex points to the range last added, if at least one was added.
* If aRange is already contained, it points to the range
* containing it.
* containing it. -1 if mRanges was empty and no range was
* added.
*/
nsresult AddRangesForSelectableNodes(nsRange* aRange, int32_t* aOutIndex,
bool aNoStartSelect = false);