Bug 1542149 - Add some MacOS file extensions to to the list of executable extensions in download protection. r=Gijs

Here are the file extensions are added to the list:
1. action
2. caction
3. configprofile
4. definition
5. dylib
6. internetconnect
7. networkconnect
8. service
9. wflow
10.workflow

Differential Revision: https://phabricator.services.mozilla.com/D26284

--HG--
extra : moz-landing-system : lando

toolkit/components/reputationservice/ApplicationReputation.cpp

@@ -162,7 +162,7 @@ const char* const ApplicationReputationService::kBinaryFileExtensions[] = {
     //".001",
     //".7z",
     //".ace",
-    //".action", // Mac script
+    ".action",  // Mac script
     //".ad", exec // Windows
     //".ade", exec  // MS Access
     //".adp", exec // MS Access
@@ -193,6 +193,7 @@ const char* const ApplicationReputationService::kBinaryFileExtensions[] = {
     ".bz2",        // Linux archive (bzip2)
     ".bzip2",      // Linux archive (bzip2)
     ".cab",        // Windows archive
+    ".caction",    // Automator action
     ".cdr",        // Mac disk image
     ".cfg",        // Windows
     ".chi",        // Windows Help
@@ -201,6 +202,7 @@ const char* const ApplicationReputationService::kBinaryFileExtensions[] = {
     //".cmd", exec // Windows executable
     //".com", exec // Windows executable
     ".command",        // Mac script
+    ".configprofile",  // Configuration file for Apple systems
     ".cpgz",           // Mac archive
     ".cpi",            // Control Panel Item. Executable used for adding icons
                        // to Control Panel
@@ -213,6 +215,7 @@ const char* const ApplicationReputationService::kBinaryFileExtensions[] = {
     ".dart",        // Mac disk image
     ".dc42",        // Apple DiskCopy Image
     ".deb",         // Linux package
+    ".definition",  // Automator action
     ".desktop",     // A shortcut that runs other files
     ".dex",         // Android
     ".dht",         // HTML
@@ -232,6 +235,7 @@ const char* const ApplicationReputationService::kBinaryFileExtensions[] = {
     ".dotx",        // MS Word
     ".drv",         // Windows driver
     ".dvdr",        // Mac Disk image
+    ".dylib",       // Mach object dynamic library file
     ".efi",         // Firmware
     ".eml",         // MS Outlook
     //".exe", exec // Windows executable
@@ -255,6 +259,7 @@ const char* const ApplicationReputationService::kBinaryFileExtensions[] = {
     //".inf", exec // Windows installer
     ".ini",  // Generic config file
     //".ins", exec // IIS config
+    ".internetconnect",  // Configuration file for Apple system
     //".inx", // InstallShield
     ".iso",  // CD image
     //".isp", exec // IIS config
@@ -316,6 +321,7 @@ const char* const ApplicationReputationService::kBinaryFileExtensions[] = {
     //".msp", exec  // Windows installer
     //".mst", exec  // Windows installer
     ".ndif",            // Mac disk image
+    ".networkconnect",  // Configuration file for Apple systems
     //".ntfs", // 7z
     ".ocx",  // ActiveX
     //".ops", exec  // MS Office
@@ -411,6 +417,7 @@ const char* const ApplicationReputationService::kBinaryFileExtensions[] = {
     //".sct", exec         // Windows shell
     ".search-ms",  // Windows
     ".seplugin",   // AppleScript
+    ".service",    // Systemd service unit file
     //".settingcontent-ms", exec // Windows settings
     ".sh",    // Linux shell
     ".shar",  // Linux shell
@@ -475,8 +482,9 @@ const char* const ApplicationReputationService::kBinaryFileExtensions[] = {
     //".wav",
     //".webp",
     ".website",   // Windows
+    ".wflow",     // Automator action
     ".wim",       // Windows Imaging
-    //".workflow", // Mac Automator
+    ".workflow",  // Mac Automator
     //".wrc", // FreeArc archive
     //".ws",  exec  // Windows script
     //".wsc", exec  // Windows script

toolkit/components/reputationservice/ApplicationReputation.h

@@ -29,9 +29,9 @@ class ApplicationReputationService final
  public:
   static const char* const kNonBinaryExecutables[2];
 #ifdef XP_WIN
-  static const char* const kBinaryFileExtensions[176];
+  static const char* const kBinaryFileExtensions[186];
 #else
-  static const char* const kBinaryFileExtensions[175];
+  static const char* const kBinaryFileExtensions[185];
 #endif
   static already_AddRefed<ApplicationReputationService> GetSingleton();
 

toolkit/components/reputationservice/test/gtest/TestExecutableLists.cpp

@@ -9,6 +9,7 @@
 // PLEASE read the comment in ApplicationReputation.cpp before modifying this
 // list.
 static const char* const kTestFileExtensions[] = {
+    ".action",  // Nac script
     ".ad",      // Windows (ignored for app rep)
     ".ade",     // MS Access
     ".adp",     // MS Access
@@ -34,6 +35,7 @@ static const char* const kTestFileExtensions[] = {
     ".bz2",            // Linux archive (bzip2)
     ".bzip2",          // Linux archive (bzip2)
     ".cab",            // Windows archive
+    ".caction",        // Automator action
     ".cdr",            // Mac disk image
     ".cfg",            // Windows
     ".chi",            // Windows Help
@@ -42,6 +44,7 @@ static const char* const kTestFileExtensions[] = {
     ".cmd",            // Windows executable
     ".com",            // Windows executable
     ".command",        // Mac script
+    ".configprofile",  // Configuration file for Apple systems
     ".cpgz",           // Mac archive
     ".cpi",            // Control Panel Item. Executable used for adding icons
                        // to Control Panel
@@ -52,6 +55,7 @@ static const char* const kTestFileExtensions[] = {
     ".dart",           // Mac disk image
     ".dc42",           // Apple DiskCopy Image
     ".deb",            // Linux package
+    ".definition",     // Automator action
     ".desktop",        // A shortcut that runs other files
     ".dex",            // Android
     ".dht",            // HTML
@@ -71,6 +75,7 @@ static const char* const kTestFileExtensions[] = {
     ".dotx",           // MS Word
     ".drv",            // Windows driver
     ".dvdr",           // Mac Disk image
+    ".dylib",          // Mach object dynamic library file
     ".efi",            // Firmware
     ".eml",            // MS Outlook
     ".exe",            // Windows executable
@@ -91,6 +96,7 @@ static const char* const kTestFileExtensions[] = {
     ".inf",                // Windows installer
     ".ini",                // Generic config file
     ".ins",                // IIS config
+    ".internetconnect",    // Configuration file for Apple system
     ".iso",                // CD image
     ".isp",                // IIS config
     ".jar",                // Java
@@ -137,6 +143,7 @@ static const char* const kTestFileExtensions[] = {
     ".msp",                // Windows installer
     ".mst",                // Windows installer
     ".ndif",               // Mac disk image
+    ".networkconnect",     // Configuration file for Apple system
     ".ocx",                // ActiveX
     ".ops",                // MS Office
     ".osas",               // AppleScript
@@ -188,6 +195,7 @@ static const char* const kTestFileExtensions[] = {
     ".sct",                // Windows shell
     ".search-ms",          // Windows
     ".seplugin",           // AppleScript
+    ".service",            // Systemd service unit file
     ".settingcontent-ms",  // Windows settings
     ".sh",                 // Linux shell
     ".shar",               // Linux shell
@@ -242,7 +250,9 @@ static const char* const kTestFileExtensions[] = {
     ".vsx",       // MS Visio
     ".vtx",       // MS Visio
     ".website",   // Windows
+    ".wflow",     // Automator action
     ".wim",       // Windows Imaging
+    ".workflow",  // Mac Automator
     ".ws",        // Windows script
     ".wsc",       // Windows script
     ".wsf",       // Windows script