Bug 1815899 - Remove support for --lwt-toolbar-field-icon-fill-attention. r=Itiel

Most users of colorways have been migrated to AMO from built-in themes, and the versions on AMO don't set `--lwt-toolbar-field-icon-fill-attention`. Built-in themes still set `--lwt-toolbar-field-icon-fill-attention` but we can just ignore that with bug 1811267 having been fixed.

Differential Revision: https://phabricator.services.mozilla.com/D175891

browser/themes/shared/notification-icons.css

@@ -131,7 +131,7 @@
 }
 
 #password-notification-icon[extraAttr="attention"] {
-  fill: var(--toolbar-field-icon-fill-attention);
+  fill: var(--toolbarbutton-icon-fill-attention);
   fill-opacity: 1;
 }
 

browser/themes/shared/toolbarbutton-icons.css

@@ -21,13 +21,6 @@ toolbar[brighttext]:-moz-lwtheme {
   --warning-icon-bgcolor: #FFBD4F;
 }
 
-:root,
-/* Pick up potentially diverging --toolbarbutton-icon-fill-attention
-   values from above. */
-:is(panel, toolbar, #urlbar, #searchbar) {
-  --toolbar-field-icon-fill-attention: var(--lwt-toolbar-field-icon-fill-attention, var(--toolbarbutton-icon-fill-attention));
-}
-
 .toolbarbutton-animatable-box,
 .toolbarbutton-1 {
   color: inherit;

browser/themes/shared/urlbar-searchbar.css

@@ -356,7 +356,7 @@
 }
 #star-button[starred] {
   fill-opacity: 1;
-  fill: var(--toolbar-field-icon-fill-attention);
+  fill: var(--toolbarbutton-icon-fill-attention);
 }
 
 /* URL bar and page action buttons */
@@ -575,7 +575,7 @@
 }
 
 #reader-mode-button[readeractive] > .urlbar-icon {
-  fill: var(--toolbar-field-icon-fill-attention);
+  fill: var(--toolbarbutton-icon-fill-attention);
   fill-opacity: 1;
 }
 
@@ -599,7 +599,7 @@
 }
 
 #translations-button[translationsactive] > .urlbar-icon {
-  fill: var(--toolbar-field-icon-fill-attention);
+  fill: var(--toolbarbutton-icon-fill-attention);
   fill-opacity: 1;
 }
 

browser/themes/shared/urlbarView.css

@@ -287,7 +287,7 @@
 
 .urlbarView-row[type=bookmark] > .urlbarView-row-inner > .urlbarView-no-wrap > .urlbarView-type-icon {
   background-image: url(chrome://browser/skin/bookmark-12.svg);
-  fill: var(--toolbar-field-icon-fill-attention);
+  fill: var(--toolbarbutton-icon-fill-attention);
 }
 
 .urlbarView-row[pinned] > .urlbarView-row-inner > .urlbarView-no-wrap > .urlbarView-type-icon {
@@ -785,7 +785,7 @@
 .urlbarView-row[source="bookmarks"] > .urlbarView-row-inner > .urlbarView-no-wrap > .urlbarView-favicon,
 #urlbar-engine-one-off-item-bookmarks {
   list-style-image: url("chrome://browser/skin/bookmark.svg");
-  fill: var(--toolbar-field-icon-fill-attention);
+  fill: var(--toolbarbutton-icon-fill-attention);
   fill-opacity: 1;
   -moz-context-properties: fill, fill-opacity;
 }