Bug 1602069 - Enable ESLint no-undef rule for accessible/test/mochitest js files. r=Jamie

Differential Revision: https://phabricator.services.mozilla.com/D56230

--HG--
extra : moz-landing-system : lando

accessible/tests/mochitest/.eslintrc.js

@@ -6,6 +6,15 @@ module.exports = {
     // disabled here due to failures when initially implemented. They should be
     // removed (and hence enabled) at some stage.
     "no-nested-ternary": "off",
-    "no-undef": "off",
-  }
+  },
+
+  "overrides": [{
+    "files": [
+      "*.xhtml",
+      "*.html",
+    ],
+    "rules": {
+      "no-undef": "off",
+    }
+  }]
 };

accessible/tests/mochitest/actions.js

@@ -1,3 +1,6 @@
+/* import-globals-from common.js */
+/* import-globals-from events.js */
+
 // //////////////////////////////////////////////////////////////////////////////
 // Event constants
 

accessible/tests/mochitest/attributes.js

@@ -1,3 +1,5 @@
+/* import-globals-from common.js */
+
 // //////////////////////////////////////////////////////////////////////////////
 // Object attributes.
 
@@ -268,6 +270,8 @@ function testTextAttrsWrongOffset(aID, aOffset) {
   try {
     var s = {},
       e = {};
+    // Bug 1602031
+    // eslint-disable-next-line no-undef
     var acc = getAccessible(ID, [nsIAccessibleText]);
     acc.getTextAttributes(false, 157, s, e);
   } catch (ex) {

accessible/tests/mochitest/browser.js

@@ -1,3 +1,5 @@
+/* import-globals-from common.js */
+
 var { AppConstants } = ChromeUtils.import(
   "resource://gre/modules/AppConstants.jsm"
 );

accessible/tests/mochitest/common.js

@@ -1,3 +1,17 @@
+// This file has circular dependencies that may require other files. Rather
+// than use import-globals-from, we list the globals individually here to save
+// confusing ESLint.
+// actions.js
+/* globals testActionNames */
+// attributes.js
+/* globals testAttrs, testAbsentAttrs, testTextAttrs */
+// relations.js
+/* globals testRelation */
+// role.js
+/* globals isRole */
+// state.js
+/* globals testStates */
+
 // //////////////////////////////////////////////////////////////////////////////
 // Interfaces
 

accessible/tests/mochitest/editabletext/editabletext.js

@@ -1,3 +1,6 @@
+/* import-globals-from ../common.js */
+/* import-globals-from ../events.js */
+
 /**
  * Perform all editable text tests.
  */

accessible/tests/mochitest/events.js

@@ -1,3 +1,7 @@
+/* import-globals-from common.js */
+/* import-globals-from states.js */
+/* import-globals-from text.js */
+
 // XXX Bug 1425371 - enable no-redeclare and fix the issues with the tests.
 /* eslint-disable no-redeclare */
 

accessible/tests/mochitest/grid.js

@@ -1,3 +1,5 @@
+/* import-globals-from common.js */
+
 /**
  * Create grid object based on HTML table.
  */

accessible/tests/mochitest/hyperlink/hyperlink.js

@@ -1,3 +1,7 @@
+/* import-globals-from ../common.js */
+/* import-globals-from ../events.js */
+/* import-globals-from ../states.js */
+
 /**
  * Focus hyperlink invoker.
  *

accessible/tests/mochitest/layout.js

@@ -1,3 +1,5 @@
+/* import-globals-from common.js */
+
 /**
  * Tests if the given child and grand child accessibles at the given point are
  * expected.

accessible/tests/mochitest/name.js

@@ -1,3 +1,5 @@
+/* import-globals-from common.js */
+
 /**
  * Test accessible name for the given accessible identifier.
  */

accessible/tests/mochitest/name/markup.js

@@ -1,3 +1,8 @@
+/* import-globals-from ../attributes.js */
+/* import-globals-from ../common.js */
+/* import-globals-from ../events.js */
+/* import-globals-from ../name.js */
+
 // //////////////////////////////////////////////////////////////////////////////
 // Name tests described by "markuprules.xml" file.
 

accessible/tests/mochitest/pivot.js

@@ -1,3 +1,9 @@
+/* import-globals-from common.js */
+/* import-globals-from events.js */
+/* import-globals-from role.js */
+/* import-globals-from states.js */
+/* import-globals-from text.js */
+
 ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
 
 // //////////////////////////////////////////////////////////////////////////////

accessible/tests/mochitest/relations.js

@@ -1,3 +1,5 @@
+/* import-globals-from common.js */
+
 // //////////////////////////////////////////////////////////////////////////////
 // Constants
 

accessible/tests/mochitest/role.js

@@ -1,3 +1,5 @@
+/* import-globals-from common.js */
+
 // //////////////////////////////////////////////////////////////////////////////
 // Role constants
 

accessible/tests/mochitest/selectable.js

@@ -1,3 +1,6 @@
+/* import-globals-from common.js */
+/* import-globals-from states.js */
+
 /**
  * Test selection getter methods of nsIAccessibleSelectable.
  *

accessible/tests/mochitest/states.js

@@ -6,6 +6,8 @@
 //   role.js
 //
 // //////////////////////////////////////////////////////////////////////////////
+/* import-globals-from common.js */
+/* import-globals-from role.js */
 
 // //////////////////////////////////////////////////////////////////////////////
 // State constants

accessible/tests/mochitest/table.js

@@ -7,6 +7,9 @@
  *   role.js
  *   states.js
  */
+/* import-globals-from common.js */
+/* import-globals-from role.js */
+/* import-globals-from states.js */
 
 /**
  * Constants used to describe cells array.

accessible/tests/mochitest/text.js

@@ -1,3 +1,5 @@
+/* import-globals-from common.js */
+
 // //////////////////////////////////////////////////////////////////////////////
 // Public
 
@@ -320,7 +322,7 @@ function testWordAt(aElement, aWordIndex, aText, aToDoFlag) {
   var wordIdx = aWordIndex;
   var startOffsetObj = { value: 0 },
     endOffsetObj = { value: 0 };
-  for (offset = 0; offset < textLength; offset = endOffsetObj.value) {
+  for (let offset = 0; offset < textLength; offset = endOffsetObj.value) {
     acc.getTextAtOffset(
       offset,
       BOUNDARY_WORD_START,
@@ -375,7 +377,7 @@ function testWordAt(aElement, aWordIndex, aText, aToDoFlag) {
     return;
   }
 
-  text = acc.getText(startWordOffset, endWordOffset);
+  let text = acc.getText(startWordOffset, endWordOffset);
   isFunc(
     text,
     aText,

accessible/tests/mochitest/treeview.js

@@ -1,3 +1,6 @@
+/* import-globals-from common.js */
+/* import-globals-from events.js */
+
 /**
  * Helper method to start a single XUL tree test.
  */

accessible/tests/mochitest/value.js

@@ -1,3 +1,5 @@
+/* import-globals-from common.js */
+
 // //////////////////////////////////////////////////////////////////////////////
 // Public methods