Automatic update from web-platform-tests
Calculate legend block-size contribution consistently.
For fragmentation, if we were resuming layout after a break, we used to
calculate it based on the consumed block-size stored in the break token
of the fieldset itself and the break token of the anonymous content
wrapper child. Turns out it's too hard to get this right. For instance,
if the contents wrapper breaks before the fragmentation line, due to
tall trailing padding, we'd get this wrong (and count the "pagination
strut" as part of the legend block-size contribution).
So here's a solution to that: store the block-size contribution in the
break token.
Bug: 1318137
Change-Id: I01b66477bf79f1076da897da8e76d4080410450a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3629328
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1000694}
--
wpt-commits: 6c9f7ead6913fb4de763dbd620b290bd86e2cc4c
wpt-pr: 33967
Automatic update from web-platform-tests
selectors-4: Convert fast/css/only-child-pseudo-class.html to WPT
The major part of the test is overflowed from the viewport, and it can
be tested with testharness.js.
Change-Id: Ibcaf103bf64b8e2be210ae65939371ba877322b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3631780
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000685}
--
wpt-commits: ccd7e7d4e509263a44e335e7b36ee6b3665a8cbf
wpt-pr: 33960
Automatic update from web-platform-tests
Use mojo_base.mojom.ReadOnlySharedMemoryRegion in device sensors.
Unfortunately, the CL largely relies on using static_cast<const T*>
instead of the safer GetMemoryAs<T> helper, since GetMemoryAs<T> requires
that device::SensorReadingSharedBuffer is trivially copyable.
Bug: 1306363
Change-Id: I91d048450bf7ba341065e6175c9928be34e45946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3621355
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000672}
--
wpt-commits: 3d86860cf3ae5b1ba907a19089c4f5ff73d5177d
wpt-pr: 33955
Automatic update from web-platform-tests
Remove expected exception messages from WebUSB tests
While the exception name is specified, the exact message may depend on
implementation-specific behavior. This change removes cases where the
WebUSB tests asserted that exceptions contained specific messages. In
the process the assertRejectsWithError() and similar helpers have been
replaced by the standard promise_rejects_dom() and promise_rejects_js()
methods from the testharness.js framework.
This change is the first in a series which switches WebUSB to construct
DOMExceptions using a blink::ExceptionState object, which will add
additional diagnostic information to the exception message which is not
compatible with these tests as written.
Change-Id: I5780106d2c7335c0e03502e742ca6c97604752d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3630436
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000668}
--
wpt-commits: 3d522de930aca526c850660d1a19af5ac0f21509
wpt-pr: 33977
Automatic update from web-platform-tests
Improve 'idbfactory-open-opaque-origin' WPT
For the test to ensure that IDBFactory.open raises an exception
in opaque origin contexts, the test should ignore any exceptions
raised by the preceding IDBFactory.deleteDatabase call (which
also raises an exception in opaque origin contexts).
Bug: None
Change-Id: Ibf086a21b2d242377a9833d04854de34ccaa3d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3629652
Quick-Run: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000627}
--
wpt-commits: 588bbb136711a7b08ba36680fda3038c7a972d3d
wpt-pr: 33973
Automatic update from web-platform-tests
[Maintenance] Add comments to help locate functions
The partitioned ServiceWorker WPTs rely on many
functions defined in resources files. To improve the
readability of these files, I added comments to aid in
locating and understanding the behavior of these test
resource functions.
Change-Id: I723166490de2bca1ab4ebc486044662dd0ee3408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3615132
Reviewed-by: Steven Bingler <bingler@chromium.org>
Commit-Queue: Kyra Seevers <kyraseevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000595}
--
wpt-commits: 441919dd2428104c286f728877e696450db906df
wpt-pr: 33910
Automatic update from web-platform-tests
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=240083 (#33971)
Use correct document as root for lazy image observer
--
wpt-commits: 8c4c2635c4816e02071ed7e594c71cb52a09f19d
wpt-pr: 33971
Automatic update from web-platform-tests
Add WPT tests for using cookies in cross origin SR prefetch
- speculation-rules base prefetch logic should not send/set
cookies when prefetching cross origin urls.
Bug: 1302365
Change-Id: I7c54dccedf1dbe54671e7aa89c0ae9b63af5b80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599108
Commit-Queue: Iman Saboori <isaboori@google.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000545}
--
wpt-commits: 41096e0790d6427a354f1b447b36eb1f45128d69
wpt-pr: 33733
Automatic update from web-platform-tests
Adds partitioned storage manager estimate() usage tests.
This CL contains WPTs test coverage for estimate() usage details of
caches, indexedDB, service workers storages.
ToDo: The expectation files for the virtual test suite will need to
be updated once the partitioning of these APIs is completed and the
tests are finally passing, as it's to be expected when third party
storage partitioning is enabled.
Change-Id: I02049498372bbb924578e989ef388b249f764b0e
Bug: 1322922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3614147
Reviewed-by: Mike Taylor <miketaylr@chromium.org>
Commit-Queue: Jonathan Njeunje <njeunje@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000541}
--
wpt-commits: 30a8cb8ae22e9d8c0a2b036e6fb10a348fd4c8a8
wpt-pr: 33843
Automatic update from web-platform-tests
[Anonymous Iframe] Change window.anonymous to window.isAnonymouslyFramed
Since there's a bunch of usage of window.anonymous in various of origins
currently in the world, we decide to change the naming to a more precise
and un-confusing `isAnonymouslyFramed`. See more:
https://github.com/WICG/anonymous-iframe/issues/1
Bug: 1323180
Change-Id: I81637cdb004e87408235edb9b367062f62358577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3613772
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000496}
--
wpt-commits: 7cd897fb1c5c0b29a2d7460c8b3f8638f4142aee
wpt-pr: 33962
Automatic update from web-platform-tests
Move COOP parsing tests to the dispatcher. (#33909)
Similar to what was done for other COOP tests in
https://chromium-review.googlesource.com/c/chromium/src/+/3593078
Tests use a complex postMessage flow today, that can be replaced by
simple and more readable code using dispatcher.js
Bug: 1318373
Change-Id: I0e5f261ded77fbf07a25f2f45380d4e9522e7934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3620319
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999403}
Co-authored-by: Arthur Hemery <ahemery@chromium.org>
--
wpt-commits: 0395d0cc0e8da6a969db68c0fc82b5f71c04c7f9
wpt-pr: 33909
Automatic update from web-platform-tests
Remove obsolete function in COOP WPTs. (#33932)
percent_encode was used for a single test case in COOP parsing. That
test case does not use url_test anymore and can be removed.
See https://chromium-review.googlesource.com/c/chromium/src/+/3620319
Bug: 1318373
Change-Id: I2c0d5bab35841711357b0dcc43410fad9be863eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627538
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999430}
Co-authored-by: Arthur Hemery <ahemery@chromium.org>
--
wpt-commits: f90d75b7664d99ba3076497c67c0307d40959b14
wpt-pr: 33932
Automatic update from web-platform-tests
[GridFragmentation] Ensure we layout all items when size is saturated.
Previously it was possible to saturate the size of the grid, with some
content, plus a LayoutUnit::Max() end border.
In this particular sub-case - we'd believe that we were at the end of
content, then make the first fragment LayoutUnit::Max() (with the
border).
The PlaceGridItemsForFragmentation function looks at the previously
consumed block-size to place items.
For this case, we'd layout some content in the first fragment.
Then in the second fragment believe we were past all the content due
to the value of ConsumedBlockSize().
The fix for this is to separately track the "consumed_grid_size" to
ensure the end border doesn't mess up (saturate) this value used for
positioning.
Bug: 1319964
Change-Id: I8cc98ab61d7148cf64c691c4322dca7a68c5fe95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627154
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1000459}
--
wpt-commits: 4bdc117210fd2972f9423d73eb59acdfdfd898dd
wpt-pr: 33939
Automatic update from web-platform-tests
Implement "Animatable: no" for CSS toggle properties and improve testing for "Animatable: No".
This makes a small code change to implement "Animatable: No" correctly
for the toggle-* properties, and also improves the WPT testing setup for
testing "Animatable: No" (which is different from discrete animation,
which is tested by test_no_interpolation). As far as I can tell, the
only such property that already had an interpolation test was 'display'.
The added WPT tests for the toggle properties fail the CSS Animations
and Web Animations parts without this change.
Note that the toggle spec's syntax has been updated in the past few
weeks, and this new test still uses the old syntax to match our
implementation and the other tests. I hope to update the syntax
throughout in a later change.
Fixed: 1318021
Bug: 1250716
Change-Id: Ie1c188238a197ad55840905f35dd9483d5b41596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3630578
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000441}
--
wpt-commits: f5ff29cdbe832d015fd729a1c6f81827d1fadb56
wpt-pr: 33947
Automatic update from web-platform-tests
Adjust when simplified layout can be performed
We could end up in a state where we retrieved a cached *measure*
result, and a cache status of kNeedsSimplifiedLayout. However, if the
box had previously fragmented, it wouldn't have a cached layout result
(and its children might not either). We should avoid simplified
layout in this case since simplified layout relies on children having
a cached layout result.
Bug: 1321393
Change-Id: I9748c75cebbdefc7946e27c40bc8f6024cf305af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3621501
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000431}
--
wpt-commits: df3b1987b667e2ed66c8ad529620b8012c1e854a
wpt-pr: 33900
Automatic update from web-platform-tests
Disable incremental styling for animated ComputedStyles
For ComputedStyles that are affected by animation effects, we also
store the corresponding *base style* on that animated ComputedStyle.
This currently interacts poorly with incremental styling, since we copy
the (potentially animated) ComputedStyle from the Element, which may
already have the base style stored. StyleResolver::ApplyAnimatedStyle
may then store *that* style as a base style again, potentially creating
an infinite chain of base styles.
This problem can't be reproduced with DCHECKs enabled, since we
call ApplyBaseStyleNoCache to verify that the incremental
ComputedStyle is equal to the ComputedStyle we would produce with a
full resolution. However, the diff is blind to to fields which aren't
generated, which includes the BaseData.
Bug: 1313554
Change-Id: I24ce40b7ec9a54f818098b21e1125f0071c11b24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3629398
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000332}
--
wpt-commits: f33ef39a7f8e26ff9361b68c55b33284a549c907
wpt-pr: 33963
Automatic update from web-platform-tests
Always create an anonymous contents wrapper inside a fieldset.
This way we'll have less to worry about in the layout algorithm.
Padding handling was incorrect, and it caused an infinite loop, because
the algorithm expected the anonymous child to take care of trailing
padding, and therefore didn't pass it to FinishFragmentation(). We
therefore failed to treat the trailing padding as monolithic.
We need to treat padding as monolithic, or we might never get past it if
it's taller than the fragmentainer (and push it ahead of us into the
next fragmentainer infinitely). The fragmentation code would believe
that we managed to fit some of it in one fragmentainer, but we'd in fact
try again from the start of the padding-block-end in the next
fragmentainer (because it should be monolithic, that's why!) - forever.
Just making sure that there's always an anonymous contents wrapper
simplifies things and fixes bugs, including a minor correctness bug;
see the new test empty-scrollable.html
Some unit tests had to be updated. These expectations were mostly last
touched by CL:2960239 , which eliminated the need for anonymous content
wrappers if the fieldset only had a legend child. Now we'll always
create them.
Bug: 1322426
Change-Id: I215ecd6387e388d0a6801476b6269cb8fb84cba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3629580
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000277}
--
wpt-commits: 2b9cfbf0c87d9d0130a0dfc5f2da3b81eb1b86be
wpt-pr: 33946
Automatic update from web-platform-tests
selectors-4: Convert four web tests to WPT
These four tests were pixel tests. However the major parts of their
contents were overflowed from the viewport, and they can be tested with
testharness.js.
Change-Id: I758c9c2fe64ca90b9905f7dce05042acad580a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3631778
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000246}
--
wpt-commits: 370b4a5371fd9806b6d89692b3e9c6efb356440a
wpt-pr: 33957
Automatic update from web-platform-tests
Avoid unnecessary calls to paint invalidation.
Previously, any background color change during style resolution
triggered paint invalidation regardless of whether the change is
triggered by a composited animation. We now check if the color change
has a native paint worklet before deciding if paint invalidation should
be performed. In the event of a main thread background-color animation,
we prevent spinning needlessly on building a native worklet paint image
by caching whether the animation can be composited.
Bug: 1301961
Change-Id: I02a9b33267592590321af6d6c0e4da7cfbee2cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542797
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000090}
--
wpt-commits: 55c2edd1190997c04fb0c3da737c6bb507332cb4
wpt-pr: 33614
Automatic update from web-platform-tests
Fix all .gitignore related WPTLint errors
After rolling WPTLint with this fix:
https://github.com/web-platform-tests/wpt/pull/33697
the WPTLint checks started reporting on long-standing .gitignore issues.
These were:
.gitignore found outside the root (GITIGNORE)
cors/resources/.gitignore
css/.gitignore
css/css-writing-modes/tools/generators/.gitignore
resources/.gitignore
webaudio/.gitignore
matches an ignore filter in .gitignore (IGNORED PATH)
content-security-policy/support/manifest.json
payment-handler/manifest.json
resource-timing/resources/manifest.json
testharness_runner.html
The .gitignore files in child directories were handled with entries in
lint.ignore. The manifest.json IGNORED_PATH errors were because of a
MANIFEST.json entry in the root-level .gitignore file - on Windows that
also matches manifest.json. Adding a leading slash fixed that.
Finally, testharness_runner.html has been checked in since at least 2016
but has a .gitignore entry specifically for it. The .gitignore entry
and the file both seem to be unnecessary so I deleted both of them.
That .gitignore entry was last modified in 2019 (crrev.com/c/1527876)
which presumably only happened because the .gitignore linting was
broken at that time.
With this change the following command now runs clean:
git cl presubmit --files=third_party/blink/web_tests/external/wpt/*
Bug: 1318089
Change-Id: Idf8b45b92b27513a668d1a672ca72600d53b5b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3625631
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Cr-Commit-Position: refs/heads/main@{#1000013}
--
wpt-commits: 74372e46d092e81c5b9810ca1c0fd04f20cdb2bd
wpt-pr: 33936
Automatic update from web-platform-tests
Simplify fragment / break token copying when adding OOFs.
There were two known problems, that the code didn't handle.
1. We may have generated a fragment for a node which is preceded by a
node that generated a break token. See
break-after-oof-before-preceding-pushed-float-crash.html
2. Clearance may push a node past multiple fragmentainers (with a
break-before break token in each fragmentainer). The code would get
confused when it found these break tokens while expecting an incoming
OOF break token.
I started by fixing these separately, but realized that we might as well just remove the special child fragment / break token iteration code. All
we need is making sure that we keep the order of child fragments and
break tokens from the original fragment intact. Furthermore, we don't
need to propagate any break tokens for OOFs that break, since
NGOutOfFlowLayoutPart will resume them correctly anyway. Note that we
still need the break tokens associated with the OOF fragments (for pre-
paint); it's just that we don't need to propagate them up to the
fragmentainer, since layout doesn't need it.
Add a flag to the container builder, to prevent outgoing break tokens
from being added automatically when adding child fragments. Perform
these two steps separately in NGSimplifiedOOFLayoutAlgorithm().
Bug: 1318455
Change-Id: I8930a78754f0695fd5f99a74e0a5f7ef363fb0f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3622335
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999878}
--
wpt-commits: bfe011aa848f680dc28a4c353bd51e08caffb757
wpt-pr: 33908
Automatic update from web-platform-tests
[@container] Remove resolved github issue reference from test
No need to keep the github issue now that it is resolved and we have a
proper spec reference in the test.
Bug: 1145970
Change-Id: I17b9cb0d8ae857783ac79cd0037a371c82cdb51b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627359
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999828}
--
wpt-commits: ceade5901b6e6a5062d873cdf40cb5a1cccb2a2d
wpt-pr: 33944
Automatic update from web-platform-tests
[@container] Clear pseudo style cache when query changes
When pseudo element styles are cached on the originating element's
ComputedStyle, we need to clear that cache if the container query
evaluations change in case the pseudo element style depends on container
queries.
Bug: 1322592
Change-Id: I57dfa575c4362bffc50cf523be263eace9c5729a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627356
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999822}
--
wpt-commits: 52ef7dd9a622652cf24e044595bc8af1f6ec99c4
wpt-pr: 33943
Automatic update from web-platform-tests
tests for error handling of layer as a media type
Based on https://github.com/w3c/csswg-drafts/issues/7225
--
wpt-commits: bed0261ca3f7826bf56b149be069a38288102082
wpt-pr: 33940
Automatic update from web-platform-tests
FS: Split FSA WPTs
Align our WPTs with the spec split by moving OPFS tests into a new
fs/ directory.
All Access Handle tests and most tests using a sandboxed file system
backend have been moved to fs/. file-system-access/ contains all
file picker tests and tests using a local file system backend, as
well as tests which have not yet shipped
(BaseHandle::remove() and DirHandle::move()).
Bug: N/A
Change-Id: I95ab81c7f19774d69bf72e8140d609e7f4abb32a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550030
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999773}
--
wpt-commits: 5798ab0381b11bea4f6e00cc3b5896c71e5f833f
wpt-pr: 33397
Automatic update from web-platform-tests
Fix UpdateStyleAndLayout for DisplayLocking in ListBoxSelectType
I wasn't able to reproduce the crash in a web_test, but I was able to
reproduce it with the clusterfuzz repro tool and verified that this
fixes the crash.
Fixed: 1318401
Change-Id: I178333c9b4aa313be5a384a59f1dec253d1ccd5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3626089
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999651}
--
wpt-commits: b98b119a1550c0da64879a9013a551d0fbbb150e
wpt-pr: 33938