Граф коммитов

4021 Коммитов

Автор SHA1 Сообщение Дата
Andrew Osmond 00188ff292 Bug 1845946 - Part 2. Add plumbing for component services to be used in the GMP process. r=emilio,geckoview-reviewers,owlish
In order to bring the GMP process in closer alignment with how other
special purpose processes work, we need to be able to use the same
component services generally expected. This patch makes the GMP process
allow the same services as seen in the GPU/VR/RDD/Utility processes.

Differential Revision: https://phabricator.services.mozilla.com/D185336
2023-08-18 22:01:08 +00:00
Cristian Tuns da1e39f50e Backed out 3 changesets (bug 1845946) for causing bug 1848484. CLOSED TREE
Backed out changeset bad73ceb87dd (bug 1845946)
Backed out changeset f984e69872e4 (bug 1845946)
Backed out changeset af600f0290b6 (bug 1845946)
2023-08-13 15:38:36 -04:00
Emilio Cobos Álvarez 9ec8ad454f Bug 1847933 - Fix indeterminate radio button rendering on macOS' native theme. r=mac-reviewers,bradwerth
This fixes a regression introduced in:

  https://hg.mozilla.org/mozilla-central/rev/5cc085b16d94f258f011bbacbb52862ba1559465#l1.138

<input type=checkbox> can match :indeterminate but that was getting
rendered as checked incorrectly by the native theme. Reintroduce the
relevant check.

Differential Revision: https://phabricator.services.mozilla.com/D186011
2023-08-11 22:16:08 +00:00
Chris Peterson d34094627d Bug 1847154 - cocoa: remove some unnecessary OnMojaveOrLater() and OnCatalinaOrLater() version checks. r=mac-reviewers,bradwerth
Firefox versions >= 116 only support macOS >= 10.15. Mojave is macOS 10.14. Catalina is macOS 10.15.

Also stop including unused "nsCocoaFeatures.h" in files with no macOS version checks.

Differential Revision: https://phabricator.services.mozilla.com/D185505
2023-08-10 15:27:05 +00:00
Andrew Osmond ce46c63b8d Bug 1845946 - Part 2. Add plumbing for component services to be used in the GMP process. r=emilio
In order to bring the GMP process in closer alignment with how other
special purpose processes work, we need to be able to use the same
component services generally expected. This patch makes the GMP process
allow the same services as seen in the GPU/VR/RDD/Utility processes.

Differential Revision: https://phabricator.services.mozilla.com/D185336
2023-08-10 14:31:47 +00:00
Masayuki Nakano e6f42bf7f7 Bug 1833494 - Make `GlobalKeyListener` not try to match handler with keyboard event with ignoring `Shift` state after one handler matches with the key combination r=smaug
`GlobalKeyListener` try to match shortcut keys with exactly checking `Shift`
state, but for the cases which do not match localized language and active
keyboard layout location, it scans another shortcut keys with ignoring
`Shift` state if no handler is available.

`<command>` elements and `<key>` elements may be disabled conditionally.
E.g., Zoom-in/Zoom-out are disabled when current zoom level is max/min value.
In this case, it's odd that another shortcut key which does not exactly match
the modifiers works.

Therefore, this patch makes `GlobalKeyListener` does not try to scan handlers
with ignoring `Shift` state if it has already found a disabled handler which
exactly matches with the modifiers.

Differential Revision: https://phabricator.services.mozilla.com/D184789
2023-08-09 04:47:06 +00:00
kriswright 1900e0f3d2 Bug 1801880 - use nsPasteBoard's ConcealedType on password strings. r=mac-reviewers,bradwerth
From my understanding of the issue, we want to preserve the utf8 string type while also adding the `org.nspasteboard.ConcealedType` as an indicator that a string is private data. I do this by creating a new type to add to the key/value dict we use to set clipboard data. While we handle this on Windows via a flag the windows API provides us, it looks like on MacOS we need to manually specify the data information. I'm unsure if this is quite what the OS intends to see, but with a lack of baseline information from Apple or from testing Safari behaviors, it *looks* like this might be the right way to go about it.

Differential Revision: https://phabricator.services.mozilla.com/D185402
2023-08-08 21:22:19 +00:00
Eitan Isaacson b8cc36b196 Bug 1845587 - Don't close Firefox popups when MacOS toolbar menu opens. r=mstange
Now that we have native context menus we don't have to worry about those competing with the toolbar menus.

Differential Revision: https://phabricator.services.mozilla.com/D184631
2023-08-07 17:18:19 +00:00
Masayuki Nakano 0f39d7eda7 Bug 1266437 - Drop "OS" modifier r=smaug,m_kato,karlt,Gijs
On Windows, Windows logo key was mapped to "OS" modifier, and on Linux,
it's same and the key is called "Super" and "Hyper".  That conformed to the
older UI Events spec.

However, UI Events declares that they should be mapped to "Meta" now and Chrome
handles it as the spec in Windows and Linux.  Therefore, we should align the
behavior to them.

Note that we've treated the legacy "Meta" modifier on Linux as DOM "Meta"
modifier state, and we'll keep this as-is because in Sun/Solaris keyboard
layout, they keys are mapped to the legacy "Meta".

Finally, the following check only `IsMeta()` but not `IsOS()`.  I think that
they should've checked `IsOS()` too.  Therefore, they will behave differently
in Windows and Linux.
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/base/Element.cpp#3287-3288
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLInputElement.cpp#3762-3764
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLInputElement.cpp#3796-3806
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLLabelElement.cpp#127-128
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/widget/gtk/nsGtkKeyUtils.cpp#1461-1462

Note that `KEY_NAME_INDEX_OS` will be removed in the patch for bug 1232918.

Differential Revision: https://phabricator.services.mozilla.com/D183480
2023-08-07 01:03:58 +00:00
Noemi Erli ceb006fbde Backed out changeset 610cf07a163c (bug 1827675) per emilio's request CLOSED TREE 2023-08-04 12:03:28 +03:00
Cristian Tuns f5572b469f Backed out 2 changesets (bug 1266437, bug 1232918) for causing mochitest failures in test_autoplay_policy_key_blacklist.html CLOSED TREE
Backed out changeset 33e3c6593d4b (bug 1232918)
Backed out changeset 1b56e99dd221 (bug 1266437)
2023-08-03 23:29:52 -04:00
Masayuki Nakano 0664d98bce Bug 1266437 - Drop "OS" modifier r=smaug,m_kato,karlt,Gijs
On Windows, Windows logo key was mapped to "OS" modifier, and on Linux,
it's same and the key is called "Super" and "Hyper".  That conformed to the
older UI Events spec.

However, UI Events declares that they should be mapped to "Meta" now and Chrome
handles it as the spec in Windows and Linux.  Therefore, we should align the
behavior to them.

Note that we've treated the legacy "Meta" modifier on Linux as DOM "Meta"
modifier state, and we'll keep this as-is because in Sun/Solaris keyboard
layout, they keys are mapped to the legacy "Meta".

Finally, the following check only `IsMeta()` but not `IsOS()`.  I think that
they should've checked `IsOS()` too.  Therefore, they will behave differently
in Windows and Linux.
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/base/Element.cpp#3287-3288
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLInputElement.cpp#3762-3764
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLInputElement.cpp#3796-3806
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/dom/html/HTMLLabelElement.cpp#127-128
* https://searchfox.org/mozilla-central/rev/9a4666e63199bd1bcfc9095f6efec3488c358458/widget/gtk/nsGtkKeyUtils.cpp#1461-1462

Note that `KEY_NAME_INDEX_OS` will be removed in the patch for bug 1232918.

Differential Revision: https://phabricator.services.mozilla.com/D183480
2023-08-04 00:10:11 +00:00
Emilio Cobos Álvarez f4b095a6e7 Bug 1846859 - Fix osx build bustage.
MANUAL PUSH: Trivial bustage fix CLOSED TREE
2023-08-03 19:50:53 +02:00
Emilio Cobos Álvarez bdce6101d4 Bug 1846859 - Remove appearance: {checkbox,radio}-{label,container}. r=desktop-theme-reviewers,dao
I didn't find a single GTK theme that drew something useful for this:

 * The container appearance isn't needed. It is a hack needed to get the
   right styles for the native checkbox, but that's it, we don't need to
   expose it to CSS.

 * The label appearance was meant to draw the focus outline but since it
   didn't work reliably we've been doing it manually since seven years
   ago (see bug 582951 and bug 1312169).

Other platforms also don't use these so this simplifies the code a bit.

Depends on D185279

Differential Revision: https://phabricator.services.mozilla.com/D185286
2023-08-03 16:36:39 +00:00
Emilio Cobos Álvarez 680785da87 Bug 1846782 - Fix nsNativeTheme*::GetWidget{Border,Padding} for always-non-native widgets. r=aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D185186
2023-08-02 20:30:21 +00:00
Brad Werth 0920ea8e55 Bug 1845144 Part 3: Remove the GeckoAVAuthorizationStatus shadow enum. r=mac-reviewers,haik
This enum is no longer needed since our build target is now macOS 10.15.

Differential Revision: https://phabricator.services.mozilla.com/D184433
2023-08-02 02:26:14 +00:00
Brad Werth 5c1d5c00b9 Bug 1845144 Part 2: Remove macOS available and builtin_available directives for always-supported versions of macOS. r=mac-reviewers,mstange,keeler,padenot
This also does minimal refactoring of cases where the directives were
protecting a simple expression that could be refactored back to the
callers.

Differential Revision: https://phabricator.services.mozilla.com/D184399
2023-08-02 02:26:14 +00:00
Brad Werth 945241d7f5 Bug 1845144 Part 1: Update build configs with minimum macOS 10.15 target, update docs. r=glandium
This changes the minimum macOS target from 10.12 to 10.15 in several build
scripts and in documentation that references the minimum version
requirement.

Differential Revision: https://phabricator.services.mozilla.com/D184432
2023-08-02 02:26:14 +00:00
Luke Warlow 3258678027 Bug 1827675 - Fix inverted-colors media query on macOS r=CanadaHonk,emilio
Now correctly matches classic invert instead of smart invert.

Differential Revision: https://phabricator.services.mozilla.com/D184982
2023-08-01 08:40:49 +00:00
Iulian Moraru f8b5b0e9dc Backed out 3 changesets (bug 1845144) for causing py3 failures on test_toolchain_configure.py. CLOSED TREE
Backed out changeset 5168c7b1cf04 (bug 1845144)
Backed out changeset 6afda17fe413 (bug 1845144)
Backed out changeset d233c63f8121 (bug 1845144)
2023-08-01 06:06:53 +03:00
Brad Werth 7becebe2f8 Bug 1845144 Part 3: Remove the GeckoAVAuthorizationStatus shadow enum. r=mac-reviewers,haik
This enum is no longer needed since our build target is now macOS 10.15.

Differential Revision: https://phabricator.services.mozilla.com/D184433
2023-07-31 22:18:10 +00:00
Brad Werth 4280325241 Bug 1845144 Part 2: Remove macOS available and builtin_available directives for always-supported versions of macOS. r=mac-reviewers,mstange,keeler
This also does minimal refactoring of cases where the directives were
protecting a simple expression that could be refactored back to the
callers.

Differential Revision: https://phabricator.services.mozilla.com/D184399
2023-07-31 22:18:09 +00:00
Emilio Cobos Álvarez 55478c757e Bug 1845636 - Allow browser chrome to enable the non-native theme. r=dshin
I tried to reftest this, but actually the non-native-theme is already
enabled on all reftests, so...

Differential Revision: https://phabricator.services.mozilla.com/D184740
2023-07-27 22:09:10 +00:00
Natalia Csoregi cf7c6627a9 Backed out changeset 5939e79c9c50 (bug 1845636) for causing multiple failures moz-theme related. CLOSED TREE 2023-07-27 22:32:23 +03:00
Emilio Cobos Álvarez adfbcc4b42 Bug 1845636 - Allow browser chrome to enable the non-native theme. r=dshin
I tried to reftest this, but actually the non-native-theme is already
enabled on all reftests, so...

Differential Revision: https://phabricator.services.mozilla.com/D184740
2023-07-27 18:08:01 +00:00
Emilio Cobos Álvarez 2e99fa25ff Bug 1845623 - Remove more dead native appearance values. r=mhowell
Everytime I look at this code I find more stuff to remove... :)

-moz-default-appearance: groupbox is not used anywhere.

menulist-text is, but it does nothing (it only would prevent drawing a
background, but we don't specify another background anyways).

Differential Revision: https://phabricator.services.mozilla.com/D184647
2023-07-27 14:39:09 +00:00
Emilio Cobos Álvarez 1827dc203b Bug 1845540 - Remove some unused win-specific system colors and appearance values. r=mstange,devtools-reviewers,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D184597
2023-07-26 20:57:47 +00:00
Emilio Cobos Álvarez 37525ae110 Bug 1845540 - Remove some unused macOS system colors. r=mstange,desktop-theme-reviewers,dao
-moz-mac-secondaryhighlight has one user, but it's the same as
-moz-cellhighlight so just use that.

Differential Revision: https://phabricator.services.mozilla.com/D184596
2023-07-26 20:48:14 +00:00
Emilio Cobos Álvarez 7719dba185 Bug 1845540 - Remove -moz-windows-default-theme and -moz-mac-graphite-theme. r=dao,pip-reviewers,mhowell
The former is just `not (prefers-contrast)` now. The later is unused.

Differential Revision: https://phabricator.services.mozilla.com/D184602
2023-07-26 18:22:26 +00:00
Emilio Cobos Álvarez 5babee8075 Bug 1844242 - Remove now unused windows appearance code. r=handyman,devtools-reviewers
After bug 1843663 these aren't used on Windows.

Some values aren't used anywhere so I removed them as well.

Differential Revision: https://phabricator.services.mozilla.com/D183945
2023-07-20 19:50:11 +00:00
Emilio Cobos Álvarez 907db2c227 Bug 1838460 - Remove unused -moz-buttondefault color. r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D183776
2023-07-18 17:21:40 +00:00
Razvan Cojocaru 90f7a9440b Bug 1841728 - Change the parameter types of BaseMargin::SizeTo() to Coord. r=dlrobertson
Differential Revision: https://phabricator.services.mozilla.com/D183185
2023-07-13 14:24:05 +00:00
Jonathan Watt 07bafd2423 Bug 1833244 p1. Create infrastructure to pass page dimensions to PrintTarget::BeginPage. r=dholbert,geckoview-reviewers,jonalmeida
OS print drivers/devices know nothing about page dimensions unless we tell
them. Previously, the physical page dimensions (including orientation) have
always been the same, so communicating their dimensions once at the start of
a print has been enough. In preparation for supporting different "physical"
page dimensions (in the immediate future only different page orientations) when
we save to PDF, we need to have the infrastructure to pass dimensions through
on a page-by-page basis. This patch adds that.

None of the PrintTarget subclasses do anything with this extra information yet,
but in a follow-up patch PrintTargetPDF will use this information to create
PDFs with mixed page orientations.

Differential Revision: https://phabricator.services.mozilla.com/D179423
2023-07-10 14:26:12 +00:00
Razvan Cojocaru 74639ffcbe Bug 1842072 - Prevent IntCoordTyped's constructor from accepting non-integral parameters. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D182936
2023-07-08 07:45:44 +00:00
Emilio Cobos Álvarez 1b463368ae Bug 1838460 - Remove unused moz-menubartext color. r=geckoview-reviewers,devtools-reviewers,nchevobbe,amejiamarmol
-moz-menubarhovertext has one usage that can go away once we remove
windows 7 / 8 so not touching that yet.

Depends on D182896

Differential Revision: https://phabricator.services.mozilla.com/D182897
2023-07-07 15:23:10 +00:00
Andrew McCreight 9699a67ae7 Bug 1582311 - Remove warning about nsAppShell::Exit() being called redundantly. r=spohl DONTBUILD
This warning was added in 2007, so I don't think it is anybody's priority to
fix. It is currently the most common warning on OSX test runs, occurring
almost twice as much as the next most common warning, so let's just remove it.

Differential Revision: https://phabricator.services.mozilla.com/D182903
2023-07-06 16:28:14 +00:00
Daisuke Akatsuka 5171fa8e4d Bug 1816447: Stop firing mouseup event after dnd performed r=masayuki
There is case that mouseUp event will be fired right after DnD on OSX. To avoid
it, introduce mPerformedDrag flag, ignore the mouseUp event fired right after
DnD.

Differential Revision: https://phabricator.services.mozilla.com/D182752
2023-07-05 07:37:12 +00:00
Masayuki Nakano a556987dbe Bug 1840307 - Add logging code around secure event input management r=m_kato
We've not put secure event input calls into the log.

Bug 1754683 could be caused by wrong management of it because I couldn't
find any wrong point from the log.  Therefore, I'd like to land this.

Differential Revision: https://phabricator.services.mozilla.com/D181951
2023-06-28 05:27:19 +00:00
Edgar Chen 3e0be37306 Bug 1835059 - [Cocoa] Make clipboard supports all operations on kSelectionCache type; r=mstange
There is no real usage so far, but this could make clipbord code and test more generic.

Depends on D180000

Differential Revision: https://phabricator.services.mozilla.com/D181568
2023-06-27 14:29:03 +00:00
Edgar Chen 5d10dd9171 Bug 1810850 - Part 4: Refactor around nsBase::ClipboardEmptyClipboard; r=cmartin,mstange
mEmptyingForSetData flag can be removed since it's used for clearing
cache data without emptying system clipboard and now we could just call
ClipboardCache::Clear().

Depends on D179999

Differential Revision: https://phabricator.services.mozilla.com/D180000
2023-06-26 21:02:40 +00:00
Edgar Chen 1d8c57b7a7 Bug 1810850 - Part 3: Move clipboard cache code for HasDataMatchingFlavors to nsBaseClipboard; r=cmartin,mstange
Depends on D179993

Differential Revision: https://phabricator.services.mozilla.com/D179999
2023-06-26 21:02:40 +00:00
Edgar Chen 2dd7f27175 Bug 1810850 - Part 2: Move clipboard cache code for GetData to nsBaseClipboard; r=cmartin,mstange
This patch introduce a preference for getting the data from cache
directly which is enabled on Mac only. And now we really support getting
data from cache for each type simultaneously, instead of only using the
one that has the latest cached transferable.

Depends on D178777

Differential Revision: https://phabricator.services.mozilla.com/D179993
2023-06-26 21:02:40 +00:00
Edgar Chen daea3055b6 Bug 1810850 - Part 1: Track clipboard change count in clipboard cache; r=cmartin,mstange
We also need to update clipboard cache after setting native clipboard,
in order to obtain the correct clipboard change count.

Differential Revision: https://phabricator.services.mozilla.com/D178777
2023-06-26 21:02:40 +00:00
Cristina Horotan c92d9850e8 Backed out 4 changesets (bug 1810850) for causing build bustages at nsClipboard.h CLOSED TREE
Backed out changeset 012b23b12de6 (bug 1810850)
Backed out changeset 15caa51b406a (bug 1810850)
Backed out changeset 0c8e0e9a9481 (bug 1810850)
Backed out changeset bf1e71a4935a (bug 1810850)
2023-06-26 13:38:46 +03:00
Edgar Chen 25cfc40dd5 Bug 1810850 - Part 4: Refactor around nsBase::ClipboardEmptyClipboard; r=cmartin,mstange
mEmptyingForSetData flag can be removed since it's used for clearing
cache data without emptying system clipboard and now we could just call
ClipboardCache::Clear().

Depends on D179999

Differential Revision: https://phabricator.services.mozilla.com/D180000
2023-06-26 10:03:23 +00:00
Edgar Chen 68f942a08e Bug 1810850 - Part 3: Move clipboard cache code for HasDataMatchingFlavors to nsBaseClipboard; r=cmartin,mstange
Depends on D179993

Differential Revision: https://phabricator.services.mozilla.com/D179999
2023-06-26 10:03:23 +00:00
Edgar Chen 07bafff927 Bug 1810850 - Part 2: Move clipboard cache code for GetData to nsBaseClipboard; r=cmartin,mstange
This patch introduce a preference for getting the data from cache
directly which is enabled on Mac only. And now we really support getting
data from cache for each type simultaneously, instead of only using the
one that has the latest cached transferable.

Depends on D178777

Differential Revision: https://phabricator.services.mozilla.com/D179993
2023-06-26 10:03:22 +00:00
Edgar Chen 94708c1baf Bug 1810850 - Part 1: Track clipboard change count in clipboard cache; r=cmartin,mstange
We also need to update clipboard cache after setting native clipboard,
in order to obtain the correct clipboard change count.

Differential Revision: https://phabricator.services.mozilla.com/D178777
2023-06-26 10:03:22 +00:00
Emilio Cobos Álvarez 4cc6758558 Bug 1839922 - Remove usage of {Has,Get}Attr(kNameSpaceID_None, ..). r=edgar
We have more readable and faster versions (that just omit the namespace
arg).

Mostly done via sed, with a couple helpers to use the faster lookups
where possible.

Differential Revision: https://phabricator.services.mozilla.com/D181795
2023-06-23 10:01:32 +00:00
Stephen A Pohl 1b8862c753 Bug 1832454: Remove the startup.is_restored_by_macos glean metric. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D181088
2023-06-15 17:46:16 +00:00