Same approach as the other bug, mostly replacing automatically by removing
'using mozilla::Forward;' and then:
s/mozilla::Forward/std::forward/
s/Forward</std::forward</
The only file that required manual fixup was TestTreeTraversal.cpp, which had
a class called TestNodeForward with template parameters :)
MozReview-Commit-ID: A88qFG5AccP
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
Some of the RDM toolbar icons relied on `background-size: cover` from the
overall DevTools button styles, which was removed recently in bug 1442531. We
restore RDM's appearance by copying this style into RDM styles.
MozReview-Commit-ID: KcZwaRgZUsh
--HG--
extra : rebase_source : 4a2f548f6f073870ad06183a33bdaabc2bff6d92
This patch will apply the grid layout to the toolbar.
If devtools's width is narrow, we expected that devtool display chevron and the
controls elements only(i.e. chevron and meatball and close button).
In order to display these button, a wrapper of toolbar will use grid layout.
Basically, this patch define grid columns as follow:
------------------------------------------------
| Picker | tooltabs | commands | controls |
| auto | 26px ~ 1fr | auto | max-content|
------------------------------------------------
We can disable the picker and command buttons, in this case, a toolbar will
stretch the tooltabs width by using grid-column-start/end.
MozReview-Commit-ID: ByY2qt2xhAg
--HG--
extra : rebase_source : c86b30acbfc32172eceea365e84ed03d717d5345
This patch will allow that all buttons which accessing the tool panel is
overflowed. i.e. toolbar will display chevron button only.
MozReview-Commit-ID: GbKbAhtpYt7
--HG--
extra : rebase_source : 971aef121c329e6a5ba3ada24015a1d820aab26a
This patch will two impprove performances:
* Remove unnecesarry reflow by using the DOMWindowUtils.getBoundsWithoutFlushing().
This is a tiny performance improvement. Previous code will reflow on each
tab width caclculation.
* Change requestIdleCallback's timeout to 100ms.
If user resize the devtool's width over time, overflow calculation will occur
every 300ms. This patch will reduce this delay.
MozReview-Commit-ID: FxZuK0wGxHk
--HG--
extra : rebase_source : 06a0a4ba5312125e7d15378c253f7278a39a69f9
The preference was true by default and never exposed to
the users, so removing it is the logical next step. This
patch removes all occurences of the preference, and add
a fix to the RETURN key handling when the autocomplete
popup is open (this is asserted on a test where autoMultiline
was explicitely disabled.)
MozReview-Commit-ID: 5783AK8lGR
--HG--
extra : rebase_source : 349a808b86410f5470d19c4f32d2b7040e060fbb
Ultimately fluent.js should not be vendored here, since fluent-react only
needs 2 methods from fluent.js.
Work is currently ongoing to extract those dependencies to separate packages,
once ready we will remove this vendored version of fluent.js.
MozReview-Commit-ID: E5uwsCHQ7tj
--HG--
extra : rebase_source : 549200589ee8f33a950cf28787ae170ee43229c1
The changes to telemetry.js::recordEvent() were necessary because the optional value and extra params cannot be sent to Services.telemetry.recordEvent() as undefined without throwing... using null instead works just fine.
MozReview-Commit-ID: CgoqSeR6mkl
--HG--
extra : rebase_source : 45bf8e249836e2a5c1a1281f1658170a44e1c470
Now that NetworkEventActor uses protocol.js, it can manage child actors it uses.
So instead of hosting the longstring it creates into WebConsoleActor pool,
it can register them it internal pool managed by protocol.js.
MozReview-Commit-ID: 9ekezmqWnME
--HG--
extra : rebase_source : a8888cffb4f284caa08e615f2614dc59730e080b