Sylvestre Ledru
7f26dcf1b6
Bug 1617369 - Reformat recent rust changes with rustfmt r=emilio
...
Done with:
./mach lint -l rustfmt --fix
with
rustfmt 1.4.12-stable (a828ffe 2020-03-11)
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D72527
2020-04-25 21:21:32 +00:00
Emilio Cobos Álvarez
87e0a1e02f
Bug 1613564 - Minor nsstring cleanup / tweaks. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D63968
--HG--
extra : moz-landing-system : lando
2020-02-27 15:42:58 +00:00
Sylvestre Ledru
3551670431
Bug 1617369 - Reformat xpcom using rustfmt r=froydnj
...
Depends on D63955
Differential Revision: https://phabricator.services.mozilla.com/D63956
--HG--
extra : moz-landing-system : lando
2020-02-25 16:17:12 +00:00
Emilio Cobos Álvarez
ad56e58826
Bug 1595212 - Use MaybeUninit in nsString tests. r=SimonSapin
...
Differential Revision: https://phabricator.services.mozilla.com/D52824
--HG--
extra : moz-landing-system : lando
2019-11-13 12:39:23 +00:00
Emilio Cobos Álvarez
f9f0e4b318
Bug 1589738 - nsACString::as_str_unchecked should actually check in debug builds. r=nika
...
Today I reviewed wrong usage of this API.
It'd be good if it crashed in debug builds when misused.
Differential Revision: https://phabricator.services.mozilla.com/D49778
--HG--
extra : moz-landing-system : lando
2019-10-18 19:09:55 +00:00
Emilio Cobos Álvarez
cdb02c10bf
Bug 1552064 - Rust nsStrings shouldn't uselessly reallocate when constructed from a boxed slice. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D31369
--HG--
extra : moz-landing-system : lando
2019-05-16 14:31:32 +00:00
Nathan Froyd
e41e50583a
Bug 1550556 - remove unnecessary `mut` markings for nsstring variables; r=mccr8
...
Newer versions of Rust have started complaining about this by default.
Differential Revision: https://phabricator.services.mozilla.com/D30541
--HG--
extra : moz-landing-system : lando
2019-05-09 20:08:53 +00:00
Emilio Cobos Álvarez
a77188cb74
Bug 1536045 - Turn a comment into a non-doc comment. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D24947
--HG--
extra : moz-landing-system : lando
2019-03-26 20:17:51 +00:00
Nika Layzell
9183dfa10e
Bug 1530438 - Implement Clone for the rust nsString bindings, r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D21039
--HG--
extra : moz-landing-system : lando
2019-02-25 18:32:00 +00:00
Henri Sivonen
b10e89785b
Bug 1515351 - Update encoding_rs to 0.8.14. r=m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D15934
--HG--
extra : moz-landing-system : lando
2019-01-10 09:42:39 +00:00
bitnotri
542ea80ecd
Bug 1461737 - Move nsstring-rs to a better location, r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D15743
--HG--
rename : servo/support/gecko/nsstring/Cargo.toml => xpcom/rust/nsstring/Cargo.toml
rename : servo/support/gecko/nsstring/src/conversions.rs => xpcom/rust/nsstring/src/conversions.rs
rename : servo/support/gecko/nsstring/src/lib.rs => xpcom/rust/nsstring/src/lib.rs
extra : moz-landing-system : lando
2019-01-04 22:03:56 +00:00
Nika Layzell
1b1ba4879a
Bug 1403213 - Move nsstring into servo/support/gecko/nsstring, r=froydnj
...
MozReview-Commit-ID: 8ucStGkxmj7
--HG--
rename : xpcom/rust/nsstring/gtest/Test.cpp => xpcom/rust/gtest/nsstring/Test.cpp
rename : xpcom/rust/nsstring/gtest/test.rs => xpcom/rust/gtest/nsstring/test.rs
extra : rebase_source : 509a2ab1aa569e8f3ef0955dcdfa36b53ce5e234
2017-10-23 15:37:25 -04:00
Sebastian Hengst
5d671ee296
Backed out changeset 74c58b336d30 (bug 1403213) for referencing non-existing xpcom/rust/gtest/moz.build in xpcom/moz.build. r=backout on a CLOSED TREE
...
--HG--
extra : amend_source : 7c25d872785312b81c4a94ef32de025b38642f54
2017-10-20 21:30:36 +02:00
Nika Layzell
a4927e2417
Bug 1403213 - Move nsstring into servo/support/gecko/nsstring, r=froydnj
...
MozReview-Commit-ID: FmKtJxSCdYc
2017-10-20 12:04:30 -07:00
Nika Layzell
4146e6b110
Bug 1377351 - Part 3: Expose nsA[C]String::Assign(nsA[C]String&&) overload as take_from to rust, r=froydnj
...
MozReview-Commit-ID: 4YNPi3iRo78
2017-10-18 13:00:15 -04:00
Nicholas Nethercote
9e0714dd26
Bug 1403506 - Remove nsTFixedString<T>. r=erahm.
...
(patch is actually r=erahm,mystor)
nsTFixedString<T> is only used as a base class for nsTAutoStringN<T, N>, so
this patch merges the former into the latter, cutting some code and simplifying
the string class hierarchy.
Because the "Fixed" name is now gone, the patch also renames
StringDataFlags::FIXED as INLINE and ClassDataFlags::FIXED as INLINE.
The patch also removes nsFixed[C]String and ns_auto_[c]string! from Rust code
because nsAutoString can't be implemented directly in Rust due to its move
semantics. There were only two uses of ns_auto_string! outside of tests so this
seems like a minor loss.
MozReview-Commit-ID: 8ntximghiut
--HG--
extra : rebase_source : f36edbae0553adcfee356fb8b311097ff7424786
2017-09-27 20:19:33 +10:00
Michael Layzell
8b222e2445
Bug 1403545 - Stop allocating in fmt::Write for nsA[C]String, r=froydnj
...
MozReview-Commit-ID: 6EOJ8QBrwXK
2017-09-27 12:19:29 -07:00
Michael Layzell
8e9f0c50e6
Bug 1383411 - Introduce a distinction between nsCStr<'a> and nsCString, r=froydnj
2017-09-25 18:14:43 -04:00
L. David Baron
eb59a21402
Bug 1381080 patch 1 - Add ClassFlags::NULL_TERMINATED to strings that require null-termination. r=erahm
...
This is needed for patch 4.
MozReview-Commit-ID: 5ikQFIL9O0i
--HG--
extra : transplant_source : %88%80%E3%04%11%7E%7F%A4%7E%15%1B%1A%84%E2%13%3E%F6%E8%2A%1C
2017-07-20 15:46:58 -07:00
L. David Baron
715cb90c8e
Bug 1343715 - Split nsTSubstring::mFlags into separate variables for class and data flags (rust bindings changes). r=mystor
...
Thanks to Manish for help in reflecting this idiomatically in rust.
MozReview-Commit-ID: 8tB7vsc5yxc
--HG--
extra : transplant_source : F%87%16%82.P%BD%F3%B1%A4%19%BA%F0%3DQ%F6%ED%BD%95%60
2017-07-10 12:23:11 -07:00
Ralph Giles
f56cb16c14
Bug 1336153
- Remove MOZ_RUST. r=ted
...
We now have code that unconditionally requires the rust
compiler and are committed to adding more. Remove this
last vestige of conditional support.
MozReview-Commit-ID: EK6FBnAbR
--HG--
extra : rebase_source : 6efda10a74f9ca0482304c2b1ffe6941e42138f8
2017-05-09 11:36:13 -07:00
Henri Sivonen
778981d9cc
Bug 1359353 - Make the backing buffers of XPCOM strings available as mutable slices. r=mystor.
...
MozReview-Commit-ID: KeJ2Qb3R5ET
--HG--
extra : rebase_source : 175a6dcac973d72a167a4e0e8d6d7e3c695203c8
2017-04-25 13:17:48 +03:00
emilio+bugs@crisal.io
92f1a57200
Bug 1348398: Keep deriving debug in StringRepr.
2017-03-24 15:14:30 -04:00
Michael Layzell
2be5900b6b
Bug 1347224 - Part 1: Expose fallible methods on the rust ns[C]String bindings, r=froydnj
...
This patch adds a series of fallible methods for the rust ns[C]String
bindings, as well as the `set_length` method, which is the same as the
`SetLength` method in C++. `set_length` is marked as unsafe.
The decision was made to make the fallible methods seperate from the
infallible methods, and to use seperate Rust->C++ bindings for each of
them, rather than only binding the fallible bindings, and unwrapping
them in rust-land. This is to try to match the C++ API as closely as
possible, and to ensure that the behavior matches.
MozReview-Commit-ID: FkSomkFUFGD
2017-03-20 14:40:45 -04:00
Emilio Cobos Álvarez
30bd5679fd
Bug 1344209: Handle empty strings gracefully in rust nsString bindings. r=mystor
...
MozReview-Commit-ID: 5lI8LXwZIML
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-03-03 17:49:37 +01:00
Michael Layzell
59bb3b9927
Bug 1339218 - Comment wording fixup, r=me
...
MozReview-Commit-ID: 8T0ibqe17Ru
2017-02-15 12:10:46 -05:00
Michael Layzell
58cab3c905
Bug 1339218 - Re-introduce the ns[C]StringRepr type for use in bindings with custom destructor logic, r=froydnj
...
MozReview-Commit-ID: 3VUWFA5tX1L
2017-02-15 12:02:54 -05:00
Michael Layzell
c3093f17b8
Bug 1316696 - Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings, r=froydnj
...
MozReview-Commit-ID: AMwAUq82vMo
2017-02-08 14:17:42 -05:00
Emilio Cobos Álvarez
c7cae408eb
Bug 1334579: Integrate nsstring bindings with leak logging. r=mystor
...
MozReview-Commit-ID: 368DwwuaMqr
--HG--
extra : rebase_source : e8e2149ca7169556df668615d654423ae9080097
2017-01-27 21:12:22 +01:00
Hiroyuki Ikezoe
a4cf573971
Bug 1330824 - Add truncate for nsAString and nsACString. r=mystor
...
MozReview-Commit-ID: 2ND5ra3buxI
2017-01-14 15:02:14 +09:00
Michael Layzell
92086b33cd
Backout of Bug 1316696 as we don't want to require rustc 1.13 yet, a=froydnj
2016-11-28 14:19:12 -05:00
Michael Layzell
a2ede4255a
Bug 1316696 - Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings, r=froydnj
...
MozReview-Commit-ID: AMwAUq82vMo
2016-11-24 13:48:38 -05:00
Michael Layzell
29905acb08
Bug 1319083 - Relax the Sized constraint on nsA[C]String::assign/append, r=froydnj
...
MozReview-Commit-ID: Js5GOrnqtsg
2016-11-21 10:41:48 -05:00
Michael Layzell
fb03faf0e0
Bug 1316964 - Make the append and assign methods on the rust nsstring types more generic, r=froydnj
...
MozReview-Commit-ID: 5y30BnUDKsT
2016-11-15 17:01:36 -05:00
Kyle Machulis
05c2031bce
Bug 1313160 - Add From<&'a String> and From<&'a Vec<u8>> conversions for rust nsstring lib; r=mystor
...
MozReview-Commit-ID: EBHFA8sjnM6
2016-10-27 13:07:50 -07:00
Xidorn Quan
78bf314c48
Bug 1312338 part 1 - Add as_str_unchecked() to nsACString. r=mystor
...
MozReview-Commit-ID: 8FwxFGtnhjp
--HG--
extra : source : d91104ea4dd66d39f1d9a00eff3a2027f6870176
2016-10-25 10:19:45 +11:00
Michael Layzell
c5faf7265c
Bug 1307615 - Avoid depending on potentially-undefined behavior in the rust nsstring bindings, r=froydnj
...
MozReview-Commit-ID: AbISqKM9hcg
2016-10-05 11:54:51 -04:00
Michael Layzell
78329bec42
Bug 1299261 - De-duplicate code in rust ns[C]String binding layout verification code, r=bholley
...
MozReview-Commit-ID: 1qJ2njeUrpS
2016-09-23 14:55:32 -04:00
Michael Layzell
0f0181c55e
Bug 1295762 - Part 2: Add tests to ensure that the layout of rust's ns[C]String matches C++'s, r=froydnj
...
MozReview-Commit-ID: FH18iSXkhX5
2016-09-20 11:26:43 -04:00
Michael Layzell
dace0b2e39
Bug 1295762 - Part 1: Implement rust bindings to XPCOM's string types, r=froydnj
...
MozReview-Commit-ID: 7fnWSc3AzlR
2016-09-20 11:26:43 -04:00