mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
721 649 коммитов 613 Ветки 98 Теги 5,8 GiB
Граф коммитов

721649 Коммитов

Автор SHA1 Сообщение Дата
Timothy Nikkel a7100c9def Bug 1656802. Add a comment explaining how overlay scrollbars work with their negative margin. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D85703
 2020-08-08 07:07:57 +00:00
Timothy Nikkel 0a37053b5b Bug 1656802. Add state variables to the scroll frame to track when scrollbars are only created to scroll the visual viewport within the layout viewport. r=emilio,kats 
We need to distinguish these special scrollbars for several different reasons in upcoming patches.

Differential Revision: https://phabricator.services.mozilla.com/D85702
 2020-08-07 11:40:47 +00:00
Timothy Nikkel bdf314cb67 Bug 1656802. Calculate if we need scrollbars to scroll the visual viewport. r=emilio,kats 
This fixes the regression we created with the first patch.

Differential Revision: https://phabricator.services.mozilla.com/D85701
 2020-08-07 11:40:46 +00:00
Timothy Nikkel 54832c7143 Bug 1656802. Add flags that let us differentiate not showing scrollbars because something is overflow hidden from not showing scrollbars for other reasons. r=emilio 
For the former we are still allowed to show scrollbars if we need to scroll the visual viewport inside the layout viewport (as long as they take up no layout space). For the latter we still do not want to show scrollbars.

The ShowScrollbar enum is now only from layouts perspective and doesn't take into account anything about the visual viewport.

Differential Revision: https://phabricator.services.mozilla.com/D85700
 2020-08-07 11:40:47 +00:00
Timothy Nikkel c389e0f6e6 Bug 1656802. When deciding if we want a scrollbar we need to consider only if the scrolled rect overflows the scrollport (not the visual viewport). r=emilio,kats 
This will actually regress behaviour when overflow is auto and pinch zooming creates scrollable overflow (scrolling the visual viewport inside the layout viewport). We will fix that in later patches.

The reason that this is necessary is that the code as-is is incorrect if we have layout scrollbars (scrollbars that take up space). If we have layout scrollbars and we pinch zoom and we go from not needing a scrollbar to needing a scrollbar then that scrollbar cannot take up layout space (even though it is a layout scrollbar). The scrollbar cannot change the size of the layout viewport (it does, however, change the size of the visual viewport).

In later patches we fix this situation as well as the situation with an overflow hidden document (which also needs to create scrollbars when pinch zoomed).

Differential Revision: https://phabricator.services.mozilla.com/D85699
 2020-08-07 11:40:50 +00:00
Timothy Nikkel 076621eeeb Bug 1656802. Add comment pointing to bug about enabling new desktop zooming scrollbars by default. 
Differential Revision: https://phabricator.services.mozilla.com/D86328
 2020-08-07 11:40:49 +00:00
Dimi Lee 491612fa0b Bug 1658010 - Add null pointer check before notifying content block event r=xeonchen 
Differential Revision: https://phabricator.services.mozilla.com/D86421
 2020-08-08 06:00:00 +00:00
Julian Descottes 06dea32c55 Bug 1657899 - Do not assume any resource order in browser_resources_stylesheets.js - part 2 r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D86360
 2020-08-08 00:42:21 +00:00
Masayuki Nakano 5b78d2b3c1 Bug 1657052 - Make `HTMLEditor::HandleDeleteAroundCollapsedSelection()` take ranges to delete instead of retrieving them via `Selection` r=m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D85965
 2020-08-07 06:13:00 +00:00
Butkovits Atila 796c05057e Backed out changeset 9825feb6a05e (bug 1658027) for failure at browser_creditCard_telemetry.js 2020-08-08 07:35:07 +03:00
Andreea Pavel aed7669de9 Bug 1654648 - fix whitespace linting failure r=test-only 2020-08-08 07:14:40 +03:00
Evan Welsh 2e8ba0e06f Bug 1654696 - Implement code coverage JSAPI. r=nbp,jwalden 
Differential Revision: https://phabricator.services.mozilla.com/D85808
 2020-08-08 03:23:31 +00:00
Zibi Braniecki 59fb3f227d Bug 1658027 - Separate visual interactions on Credit Card Autofill for A/B testing. r=abr 
Differential Revision: https://phabricator.services.mozilla.com/D86445
 2020-08-08 03:36:42 +00:00
Zibi Braniecki b144e9c01e Bug 1654648 - Fine tune field type duplication heuristics for section splitting. r=abr 
Differential Revision: https://phabricator.services.mozilla.com/D86277
 2020-08-08 03:33:53 +00:00
Simon Fraser 3befe6d707 Bug 1657409 Remove obsolete S3 bucket r=nthomas,Callek 
Differential Revision: https://phabricator.services.mozilla.com/D86168
 2020-08-06 21:41:46 +00:00
Gijs Kruitbosch 7be797a434 Bug 1654098 - fix a few racist epithets missing 'exclude from suggestions' annotation, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D86559
 2020-08-10 15:21:20 +00:00
Harry Twyford 72560dd5f9 Bug 1647890 - Replace token alias with indicator when the token alias is confirmed or fully typed. r=adw 
This patch changes the paramters to setSearchMode. The original patch to introduce search mode passed engineName to setSearchMode instead of the entire engine object. It was suggested in review that the nsISearchEngine be passed so we could run instanceof to distinguish it from a RESULT_TYPE. This patch reverses this and passes engineName instead through a destructured parameter.

In pickResult, we need to enter search mode synchronously based on the information in a result payload. Result payloads can't/shouldn't pass around complex objects like an nsISearchEngine, so we just pass engineName and the alias as strings. Since pickResult is synchronous, we can't use UrlbarSearchUtils to look up the engine based on the engineName. Besides, setSearchMode only uses engineName, so looking up the engine only to just use its name seems like a waste of resources.

This patch also disables autofill in search mode queries. Autofill was interfering with alias replacement. We were already half doing this (https://searchfox.org/mozilla-central/rev/26b13464c2beb26e0d864d561c30e817a85c348a/browser/components/urlbar/UrlbarController.jsm#391) but adding the searchMode check to UrlbarInput._maybeAutofillOnInput should resolve bug 1655473.

There's still one more bug I'm working through where the placeholder disappears after alias replacement. I though I'd get this out to start review regardless since we want to get the three patches discussed in Thursday's meeting out ASAP.

Differential Revision: https://phabricator.services.mozilla.com/D86389
 2020-08-10 15:16:40 +00:00
Tooru Fujisawa ba5257fbf6 Bug 1656749 - Update opcode for bug 1655465. r=jorendorff 
Differential Revision: https://phabricator.services.mozilla.com/D86455
 2020-08-10 15:16:27 +00:00
Chris H-C 0a0fa4aa3d Bug 1651107 - Document best practices for Glean definitions files in-tree r=janerik DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D86419
 2020-08-10 14:39:48 +00:00
Kimberly Sereduck 66f2b807f4 Bug 1656979 - Add chromedriver for Chrome 84 r=perftest-reviewers,sparky 
fixed browsertime.yaml file

Differential Revision: https://phabricator.services.mozilla.com/D85906
 2020-08-06 17:28:04 +00:00
Emilio Cobos Álvarez 9d054b84e4 Bug 1639328 - Make sure BrowserChilds for OOP iframes start in a consistent state. r=smaug 
Right now they start with a FullyHidden() effect info, but with a
"visible" widget, and thus active docshell and so on.

That's no good :)

Differential Revision: https://phabricator.services.mozilla.com/D86364
 2020-08-10 14:50:27 +00:00
Julian Descottes a0acf13c9c Bug 1651033 - Prevent default for pointerup/down events with DevTools node picker r=gl 
Differential Revision: https://phabricator.services.mozilla.com/D86502
 2020-08-10 14:37:50 +00:00
Sebastian Hengst 0636e8e389 Bug 1655720 - Adjust expectation for access-reporting/property.https.html on Linux x64 opt. r=jmaher DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D86540
 2020-08-10 14:25:14 +00:00
Butkovits Atila 1faa0e8ac9 Bug 1579831 - Disabled browser_UITour_showProtectionReport.js test on linux for frequent failures r=jmaher 
Differential Revision: https://phabricator.services.mozilla.com/D86458
 2020-08-10 14:21:39 +00:00
ffxbld 0d46e87486 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM 
Differential Revision: https://phabricator.services.mozilla.com/D86553
 2020-08-10 14:20:05 +00:00
Mike Conley f652d0465b Bug 1658052 - Only remember allowed shared browser tabs for tabbrowser <browser> elements. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D86444
 2020-08-10 09:20:29 +00:00
Mirko Brodesser 1f712acadc Bug 1649121: part 72) Rename `mEndNodes` to `mInclusiveAncestorsOfEndContainer`. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D84834
 2020-08-10 12:54:02 +00:00
Mirko Brodesser 70847b14fc Bug 1649121: part 71) Factor `DetermineLastContent` out. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D84833
 2020-08-10 12:53:50 +00:00
Mirko Brodesser 343ba883bf Bug 1649121: part 70) Move more code to `DetermineCandidateForLastContent`. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D84832
 2020-08-10 12:43:13 +00:00
Mirko Brodesser 768316041d Bug 1649121: part 69) Factor `DetermineCandidateForLastContent` out. r=masayuki 
Please see the following review too, because there more code is moved to
that method.

Differential Revision: https://phabricator.services.mozilla.com/D84831
 2020-08-10 12:52:27 +00:00
Mirko Brodesser 2a0f6f803c Bug 1649121: part 68) Factor `DetermineFirstContent` out. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D84795
 2020-08-10 12:49:41 +00:00
Mirko Brodesser 3850a9eec3 Bug 1649121: part 67) Move more code to `DetermineCandidateForFirstContent`. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D84794
 2020-08-10 12:42:50 +00:00
Mirko Brodesser 4d83d55c27 Bug 1649121: part 66) Factor `DetermineCandidateForFirstContent` out. r=masayuki 
Please see the next review too, because it moves more code to that
method.

Differential Revision: https://phabricator.services.mozilla.com/D84793
 2020-08-10 12:48:36 +00:00
Mirko Brodesser 14102fe248 Bug 1649121: part 65) Declare more methods in `ContentIteratorBase` `static`. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D84792
 2020-08-10 12:42:40 +00:00
Mirko Brodesser a596885d18 Bug 1649121: part 64) Don't reuse local `offset` variable in `InitWithRange`. r=masayuki 
Simplifies factoring determining `firstCandidate` and `lastCandidate`
out.

Differential Revision: https://phabricator.services.mozilla.com/D84791
 2020-08-10 12:42:32 +00:00
Mirko Brodesser c864ad17c6 Bug 1649121: part 63) Factor `CacheInclusiveAncestorsOfEndContainer` out. r=masayuki 
Hides details and "inclusive" ancestors is more precise.

Differential Revision: https://phabricator.services.mozilla.com/D84790
 2020-08-10 12:47:05 +00:00
Mirko Brodesser c5b7430f3b Bug 1649121: part 62) Replace `bool ContentIterator::mPre` with `enum class`. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D84522
 2020-08-10 12:46:29 +00:00
Mirko Brodesser 81b2cf7d74 Bug 1649121: part 61) Rename `mCommonParent` to `mClosestCommonInclusiveAncestor`. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D84510
 2020-08-10 09:40:41 +00:00
Mirko Brodesser a280d7bf1f Bug 1649121: part 60) Declare some methods in `ContentIteratorBase` `static`. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D84509
 2020-08-10 09:40:38 +00:00
Mirko Brodesser 568c938b9d Bug 1649121: part 59) Declare `mPre` `const`. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D84491
 2020-08-10 09:40:31 +00:00
Mirko Brodesser 59d52d5f33 Bug 1649121: part 58) Change `DetermineLastNode` to return the found node. r=masayuki 
Clearer.

Differential Revision: https://phabricator.services.mozilla.com/D84371
 2020-08-10 10:03:24 +00:00
Mirko Brodesser 3c61cc9fd4 Bug 1649121: part 57) Change `DetermineFirstNode` to return the found node. r=masayuki 
Clearer.

Differential Revision: https://phabricator.services.mozilla.com/D84370
 2020-08-10 09:40:15 +00:00
Valentin Gosu 5e3e1f6296 Bug 1651672 - Clear and remove DataStorageClass::TRRBlacklist r=kershaw,necko-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D86520
 2020-08-10 09:46:32 +00:00
Ian Neal d177afdd2a Bug 1658191 - The removed UILocale command line option is still mentioned in help output. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D86484
 2020-08-10 02:09:51 +00:00
David Teller 54dbe87afb Bug 1647695 - Make Windows GetProcInfo a bit more resilient;r=tarek 
GetProcInfo is designed to collect process & thread data while they're running,
which means that it needs to handle the case in which a thread shuts down while
we're looking at it.

By design, in case of failure, GetProcInfo return partial data in case of failure.
This patch ensures that we always either set the thread ID (which we use to display about:processes) correctly or remove
the thread entirely from the list.

Differential Revision: https://phabricator.services.mozilla.com/D86055
 2020-08-10 10:15:44 +00:00
Jan de Mooij cdfd50ad61 Bug 1657372 - Don't create/increment ScriptCounts in Baseline when Warp is enabled. r=iain 
Differential Revision: https://phabricator.services.mozilla.com/D86194
 2020-08-06 16:40:16 +00:00
Dorel Luca c243829674 Backed out 5 changesets (bug 1623764) for WPT failures in /editing/run/forwarddelete.html. CLOSED TREE 
Backed out changeset 838b1a256f25 (bug 1623764)
Backed out changeset 00911e3c92c3 (bug 1623764)
Backed out changeset 5f7d278953d7 (bug 1623764)
Backed out changeset 0059379a3c29 (bug 1623764)
Backed out changeset 6e3a9276ec41 (bug 1623764)
 2020-08-10 09:07:48 +03:00
Dorel Luca 25b814837c Backed out changeset 527908cfaa56 (bug 1647890) for Browser-chrome failures on browser/browser_searchModeIndicator.js. CLOSED TREE 2020-08-10 08:02:29 +03:00
Emma Malysz 58a912dc5e Bug 1648530, implement sidebar telemetry probes to track how often it was opened and what type of panel was viewed. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D81165
 2020-08-10 04:16:07 +00:00
Bogdan Tara 8f8501a84b Backed out changeset 8829157669b1 (bug 1655324) for SVGAnimatedClassOrString.h related bustage CLOSED TREE 2020-08-10 07:28:20 +03:00