When no marionette port is explicitly specified, and the Firefox
version is >= 95, pass in a port number of 0 from geckodriver to
firefox, so that marionette binds on a free port. Then read the port
it used from the profile. This avoids the possibility of races between
geckodriver picking a free port and marionette binding to that port.
This could also be used on Android, but isn't implemented as part of
this patch.
Differential Revision: https://phabricator.services.mozilla.com/D136740
The policy is now as follows:
* The `--host` command line flag can now be an actual hostname as well
as in IP address.
* By default only requests with a `Host` header that is an IP address,
or matching the value of the `--host` argument are accepted.
* If `--host` is a local IP address, we by default accept `localhost`
in the `Host` header.
* When `--allow-hosts` is provided, only requests with a hostname
matching the listed values, or an IP address, are accepted.
* By default any request with an `Origin` header is rejected.
* When `--allow-origins` is provided, only requests with no `Origin`
header, or an origin matching the given values, are accepted.
Differential Revision: https://phabricator.services.mozilla.com/D129012
The policy is now as follows:
* The `--host` command line flag can now be an actual hostname as well
as in IP address.
* By default only requests with a `Host` header that is an IP address,
or matching the value of the `--host` argument are accepted.
* If `--host` is a local IP address, we by default accept `localhost`
in the `Host` header.
* When `--allow-hosts` is provided, only requests with a hostname
matching the listed values, or an IP address, are accepted.
* By default any request with an `Origin` header is rejected.
* When `--allow-origins` is provided, only requests with no `Origin`
header, or an origin matching the given values, are accepted.
Differential Revision: https://phabricator.services.mozilla.com/D129012
Starting with geckodriver 0.25.0 the "handle" argument (available
since Firefox 67) for the "WebDriver:SwitchToWindow" call to
Marionette has been added. Since then the "name" argument in
Marionette has been removed (Firefox 80).
That means sending "name" is no longer necessary, and can be
removed. By doing that the minimum supported Firefox version
will be bumped to Firefox 80.0.
Differential Revision: https://phabricator.services.mozilla.com/D88958
This removes the `@CommandProvider` decorator and the need to implement
mach commands inside subclasses of `MachCommandBase`, and moves all
existing commands out from classes to module level functions.
Differential Revision: https://phabricator.services.mozilla.com/D121512
This removes the `@CommandProvider` decorator and the need to implement
mach commands inside subclasses of `MachCommandBase`, and moves all
existing commands out from classes to module level functions.
Differential Revision: https://phabricator.services.mozilla.com/D121512
This removes the `@CommandProvider` decorator and the need to implement
mach commands inside subclasses of `MachCommandBase`, and moves all
existing commands out from classes to module level functions.
Differential Revision: https://phabricator.services.mozilla.com/D121512
This removes the `@CommandProvider` decorator and the need to implement
mach commands inside subclasses of `MachCommandBase`, and moves all
existing commands out from classes to module level functions.
Differential Revision: https://phabricator.services.mozilla.com/D121512
Check that the Host header is set and that the host and port are local
or match the address that the WebDriver server is running on.
Differential Revision: https://phabricator.services.mozilla.com/D83499
This step removes all the dependencies of mach commands to
having a MachCommandBase as the `self` by using the `command_context`
argument instead. This also removes any remaining statefulness from those
classes that implement mach commands, ultimately making it easier to move
existing commands out of classes in a follow-up.
Differential Revision: https://phabricator.services.mozilla.com/D118058
This step removes all the dependencies of mach commands to
having a MachCommandBase as the `self` by using the `command_context`
argument instead. This also removes any remaining statefulness from those
classes that implement mach commands, ultimately making it easier to move
existing commands out of classes in a follow-up.
Differential Revision: https://phabricator.services.mozilla.com/D118058
Henrik Skupin
Cristian Tuns
Andi-Bogdan Postelnicu
James Graham
Mike Hommey
Sandor Molnar
Marian-Vasile Laza
David Burns
Alex Lopez
Butkovits Atila
Noemi Erli
Andrei Oprea
Barret Rennie
Julian Descottes