Gijs Kruitbosch
3a1283d7da
Bug 1613069 - don't trip over null mousemove tasks when destroying PictureInPictureChild actors, r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D61551
--HG--
extra : moz-landing-system : lando
2020-02-06 17:32:28 +00:00
Brad Werth
67081368c7
Bug 1516413 Part 2: Make browser FullZoom act on the new zoom change events. r=mstange
...
This replaces the handling of the ZoomChangeUsingMouseWheel event with
2 new zoom events that trigger the actual zoom changes. As a side effect,
this allows the mousewheel and zoom in/out key events to have an effect
on Reader and PDFJS views as well.
Differential Revision: https://phabricator.services.mozilla.com/D59260
--HG--
extra : moz-landing-system : lando
2020-01-30 17:17:26 +00:00
Brian Grinstead
3d2d2d0ea7
Bug 1608281 - Automated rewrite away from reading properties on the global `this` in JSM files - round 1 r=mossop
...
This patch was generated with a script. It doesn't include all files:
- Files that use the preprocessor or fail to parse are skipped
- Files that are loaded as JSMs but don't use the .jsm extension are skipped (those will be renamed in Bug 1609269)
It was generated with the following command using d855222aa2/no-this-property-read.js
:
```
hg revert --all &&
cp .gitignore .rgignore &&
rg --files-without-match -g '*.jsm' '^#endif|^#include|^#filter' | jscodeshift --stdin --transform ~/Code/jsm-rewrites/no-this-property-read.js --ignore-pattern ./mobile/android/modules/Sanitizer.jsm --ignore-pattern ./js/xpconnect/tests/unit/syntax_error.jsm &&
./mach eslint `hg st | rg '^M ' | sed 's/^M //'`
```
Differential Revision: https://phabricator.services.mozilla.com/D60187
--HG--
extra : moz-landing-system : lando
2020-01-29 21:50:04 +00:00
Gabriel Luong
aa684c0c76
Bug 1602841 - Implement keystroke handling for PiP window for video controls. r=mconley
...
This implements keystroke handling behind a pref "media.videocontrols.picture-in-picture.keyboard-controls.enabled".
This patch handles all the keystrokes for video controls, which include play, pause,
volume decrease and increase, mute, unmute, seek forward and backward for 15 seconds
or by 10% of the max video duration, seek to beginning and seek to end.
This reuses the key handler logic from https://searchfox.org/mozilla-central/rev/cfd1cc461f1efe0d66c2fdc17c024a203d5a2fd8/toolkit/content/widgets/videocontrols.js#1687-1810 .
Differential Revision: https://phabricator.services.mozilla.com/D60631
--HG--
extra : moz-landing-system : lando
2020-01-26 06:21:23 +00:00
Neil Deakin
0355257f83
Bug 1505915, move view source components to use JSWindowActor. This allows view frame source to work in out of process child frames, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D60253
--HG--
rename : toolkit/components/viewsource/content/viewSource-content.js => toolkit/actors/ViewSourceChild.jsm
rename : toolkit/components/viewsource/content/viewSource-content.js => toolkit/actors/ViewSourcePageChild.jsm
rename : toolkit/components/viewsource/ViewSourceBrowser.jsm => toolkit/actors/ViewSourcePageParent.jsm
extra : moz-landing-system : lando
2020-01-24 19:53:55 +00:00
Mike Conley
86b88adf07
Bug 1596169 - Do a better job of cleaning up inside of PictureInPictureChild::willDestroy. r=mstriemer
...
Inside of PictureInPictureChild's willDestroy, we were calling removeMouseButtonListeners();,
which gets rid of all of the event listeners that we use to detect clicks on the page to
check for clicking on the PiP toggle.
There are, however, other event listeners that weren't being removed, and more importantly,
there were DeferredTask's that weren't being disarmed and torn down. This was causing us to
sometimes log error messages to the console when navigating between pages, because the
JSWindowActorChild has gone away by the time the DeferredTask runs.
So now we call stopTrackingMouseOverVideos instead, which also shuts down the DeferredTask's
(and also calls removeMouseButtonListeners).
Differential Revision: https://phabricator.services.mozilla.com/D52903
--HG--
extra : moz-landing-system : lando
2019-11-14 18:38:56 +00:00
Ciure Andrei
19fa2bbadb
Backed out 2 changesets (bug 1516413) for causing browser_viewport_zoom_resolution_invariant.js to perma fail CLOSED TREE
...
Backed out changeset 0647ffc0cc6f (bug 1516413)
Backed out changeset a8d9460cdbd6 (bug 1516413)
2020-01-23 02:53:08 +02:00
Brad Werth
7aba9ae0bf
Bug 1516413 Part 2: Make browser FullZoom act on the new zoom change events. r=mstange
...
This replaces the handling of the ZoomChangeUsingMouseWheel event with
2 new zoom events that trigger the actual zoom changes. As a side effect,
this allows the mousewheel and zoom in/out key events to have an effect
on Reader and PDFJS views as well.
Differential Revision: https://phabricator.services.mozilla.com/D59260
--HG--
extra : moz-landing-system : lando
2020-01-22 23:14:20 +00:00
Bogdan Tara
6b44dbdf87
Backed out 2 changesets (bug 1516413) for valgrind failure CLOSED TREE
...
Backed out changeset 8eb500f31661 (bug 1516413)
Backed out changeset 333368f257b3 (bug 1516413)
2020-01-23 00:53:42 +02:00
Brad Werth
0549d5f10b
Bug 1516413 Part 2: Make browser FullZoom act on the new zoom change events. r=mstange
...
This replaces the handling of the ZoomChangeUsingMouseWheel event with
2 new zoom events that trigger the actual zoom changes. As a side effect,
this allows the mousewheel and zoom in/out key events to have an effect
on Reader and PDFJS views as well.
Differential Revision: https://phabricator.services.mozilla.com/D59260
--HG--
extra : moz-landing-system : lando
2020-01-22 21:43:14 +00:00
Mike Conley
ea70cbeec9
Bug 1576917 - Port PopupBlocker to JSWindowActors to make it Fission-compatible. r=NeilDeakin
...
This patch was started by Alex Vamvounis <a.vamvounis@gmail.com> and finished by
Mike Conley <mconley@mozilla.com>
Differential Revision: https://phabricator.services.mozilla.com/D53075
--HG--
extra : moz-landing-system : lando
2020-01-22 21:24:19 +00:00
Jonathan Watt
2cf93a059a
Bug 1607671. Back out changeset edf3df2adebb (bug 1602410) for regressions. kmag r=RyanVM
...
Differential Revision: https://phabricator.services.mozilla.com/D59785
--HG--
extra : moz-landing-system : lando
2020-01-22 14:43:46 +00:00
Alexander Surkov
b8bdb342d2
Bug 1606108
- Autoscroll works only once in iframe r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D58390
--HG--
extra : moz-landing-system : lando
2020-01-10 13:41:27 +00:00
Jonathan Watt
57bb12cc12
Bug 1602410. Make `window.print()` invoke printing via the parent process using a JSWindowActor. r=Gijs,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D56414
--HG--
extra : moz-landing-system : lando
2019-12-21 12:33:11 +00:00
Narcis Beleuzu
bd3cee1d8c
Backed out changeset bc3a104f8b20 (bug 1602410) for build bustages on nsGlobalWindowOuter.cpp . CLOSED TREE
2019-12-21 04:13:43 +02:00
Mike Conley
8416f879eb
Bug 1592286 - Add URL-mapped policy support to the Picture-in-Picture toggle. r=mstriemer
...
I went with "policy" rather than "position" since "hidden" isn't really a position.
Differential Revision: https://phabricator.services.mozilla.com/D57177
--HG--
extra : moz-landing-system : lando
2019-12-21 00:24:06 +00:00
Jonathan Watt
87c7d4f638
Bug 1602410. Make `window.print()` invoke printing via the parent process using a JSWindowActor. r=Gijs,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D56414
--HG--
extra : moz-landing-system : lando
2019-12-21 00:22:42 +00:00
Alexander Surkov
f9f8b6c906
Bug 1597765 - support auto scroll in out of process frames r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D54596
--HG--
rename : toolkit/modules/AutoScrollController.jsm => toolkit/actors/AutoScrollChild.jsm
extra : moz-landing-system : lando
2019-12-19 02:35:57 +00:00
Bogdan Tara
bda0db5d2d
Backed out changeset c53bf87f1e5d (bug 1597765) for test_login_item.html failures CLOSED TREE
...
--HG--
rename : toolkit/actors/AutoScrollChild.jsm => toolkit/modules/AutoScrollController.jsm
2019-12-19 04:31:36 +02:00
Alexander Surkov
caa3428343
Bug 1597765 - support auto scroll in out of process frames r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D54596
--HG--
rename : toolkit/modules/AutoScrollController.jsm => toolkit/actors/AutoScrollChild.jsm
extra : moz-landing-system : lando
2019-12-18 15:09:50 +00:00
Brad Werth
086c76ec1b
Bug 1579178 Part 2: Move the full zoom save-and-restore of resolution into the ZoomActorChild. r=mconley
...
For the existing RDM UI, the saving and restoring of resolution is done
in the content frame script, which is no longer loaded in the new UI.
This approach is flexible enough that it will work for BOTH UIs. The
next part of the patch contains the removal of the old method.
Differential Revision: https://phabricator.services.mozilla.com/D56267
--HG--
extra : moz-landing-system : lando
2019-12-13 19:11:42 +00:00
Neil Deakin
c93677f198
Bug 1595154, change FormAutofillParent to inherit from JSWindowActor, r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D52722
--HG--
extra : moz-landing-system : lando
2019-12-11 13:37:59 +00:00
Neil Deakin
75efe08ebc
Bug 1595154, replace the frame script FormAutofillFrameScript.js with an actor and fix up setTimeout calls in places that were relying on Timer.jsm being loaded in that frame script, r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D52721
--HG--
rename : browser/extensions/formautofill/content/FormAutofillFrameScript.js => browser/extensions/formautofill/FormAutofillChild.jsm
extra : moz-landing-system : lando
2019-12-11 13:37:51 +00:00
Alex Henrie
00867c4809
Bug 202251 - Add an option to ignore diacritics when searching. r=fluent-reviewers,mikedeboer,jfkthame,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D51841
--HG--
extra : moz-landing-system : lando
2019-12-09 19:26:40 +00:00
Kris Maglione
7ae4407d5f
Bug 1588839 - Part 2: Return the actual rejection value when a sendQuery handler rejects. r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D50882
--HG--
extra : moz-landing-system : lando
2019-12-07 18:59:21 +00:00
Ciure Andrei
cbb1fe8008
Backed out 4 changesets (bug 1588839) for causing JSWindowActor.cpp failures CLOSED TREE
...
Backed out changeset 7cfcd0f5da4f (bug 1588839)
Backed out changeset cde41501372a (bug 1588839)
Backed out changeset 65cc1910918c (bug 1588839)
Backed out changeset 2f8b5b48c896 (bug 1588839)
2019-12-07 19:41:36 +02:00
Kris Maglione
42c0feff20
Bug 1588839 - Part 2: Return the actual rejection value when a sendQuery handler rejects. r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D50882
--HG--
extra : moz-landing-system : lando
2019-12-07 05:32:51 +00:00
Brindusan Cristian
4b11b63400
Backed out changeset b89936db7178 (bug 202251) for bc failures at browser_misused_characters_in_strings.js. CLOSED TREE
2019-12-05 23:10:09 +02:00
Alex Henrie
ca467c4b3f
Bug 202251 - Add an option to ignore diacritics when searching. r=fluent-reviewers,mikedeboer,jfkthame,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D51841
--HG--
extra : moz-landing-system : lando
2019-12-05 18:08:20 +00:00
Mark Striemer
a549522726
Bug 1535437 - Part 2: Resize PiP window when video source resizes r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D50139
--HG--
extra : moz-landing-system : lando
2019-12-05 16:59:04 +00:00
Razvan Maries
fbea30c915
Backed out 3 changesets (bug 1535437, bug 1591253) for perma fails on browser_resizeVideo.js. CLOSED TREE
...
Backed out changeset 8222591127e9 (bug 1591253)
Backed out changeset d95a64f744b0 (bug 1535437)
Backed out changeset d5a82a15e3a5 (bug 1535437)
2019-12-04 23:14:45 +02:00
Mark Striemer
1d76749625
Bug 1535437 - Part 2: Resize PiP window when video source resizes r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D50139
--HG--
extra : moz-landing-system : lando
2019-12-03 21:45:30 +00:00
Ciure Andrei
7229b5803b
Backed out 5 changesets (bug 1595154) for causing talos performance tests failures CLOSED TREE
...
Backed out changeset 498f750ed88a (bug 1595154)
Backed out changeset 45481561c120 (bug 1595154)
Backed out changeset 8ca3c106fc8d (bug 1595154)
Backed out changeset 7ffa8f958d0a (bug 1595154)
Backed out changeset 444505b4936b (bug 1595154)
--HG--
rename : browser/extensions/formautofill/FormAutofillChild.jsm => browser/extensions/formautofill/content/FormAutofillFrameScript.js
2019-12-04 21:07:05 +02:00
Neil Deakin
84e9411376
Bug 1595154, change FormAutofillParent to inherit from JSWindowActor, r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D52722
--HG--
extra : moz-landing-system : lando
2019-12-04 11:45:15 +00:00
Neil Deakin
0fe11bd612
Bug 1595154, replace the frame script FormAutofillFrameScript.js with an actor and fix up setTimeout calls in places that were relying on Timer.jsm being loaded in that frame script, r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D52721
--HG--
rename : browser/extensions/formautofill/content/FormAutofillFrameScript.js => browser/extensions/formautofill/FormAutofillChild.jsm
extra : moz-landing-system : lando
2019-12-04 11:45:10 +00:00
Jonathan Watt
ce8382d606
Bug 1594391. Move PrintingChild.jsm print telemetry logging to the parent process. r=Gijs,chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D51992
--HG--
extra : moz-landing-system : lando
2019-12-02 14:35:36 +00:00
Andrew McCreight
38dac812ea
Bug 1599175, part 1 - Remove unused 'browingContextId' message field in PictureInPictureChild. r=mconley
...
This field is misspelled. Don't worry though, it is also unused.
Differential Revision: https://phabricator.services.mozilla.com/D54565
--HG--
extra : moz-landing-system : lando
2019-11-25 18:19:01 +00:00
Tim Nguyen
c466b25172
Bug 1597844 - Fix positioning of form validation and date/time input popups. r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D53902
--HG--
extra : moz-landing-system : lando
2019-11-22 00:13:15 +00:00
Andreea Pavel
03a2c54d6f
Backed out 3 changesets (bug 1595154) for failing bc at browser_autocomplete_marked_detached_tab.js on a CLOSED TREE
...
Backed out changeset f512953534ac (bug 1595154)
Backed out changeset 803a2dfdda82 (bug 1595154)
Backed out changeset ddd336d5bf1a (bug 1595154)
--HG--
rename : browser/extensions/formautofill/FormAutofillChild.jsm => browser/extensions/formautofill/content/FormAutofillFrameScript.js
2019-11-20 05:03:37 +02:00
Neil Deakin
0541c1228b
Bug 1595154, change FormAutofillParent to inherit from JSWindowActor, r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D52722
--HG--
extra : moz-landing-system : lando
2019-11-20 01:25:27 +00:00
Neil Deakin
a6095ebaf4
Bug 1595154, replace the frame script FormAutofillFrameScript.js with an actor and fix up setTimeout calls in places that were relying on Timer.jsm being loaded in that frame script, r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D52721
--HG--
rename : browser/extensions/formautofill/content/FormAutofillFrameScript.js => browser/extensions/formautofill/FormAutofillChild.jsm
extra : moz-landing-system : lando
2019-11-20 01:25:20 +00:00
Ciure Andrei
c24561eb05
Backed out 3 changesets (bug 1535437, bug 1591253) for causing browser_resizeVideo.js to permafail CLOSED TREE
...
Backed out changeset f7cc2f6d9640 (bug 1591253)
Backed out changeset bc637c20c7d4 (bug 1535437)
Backed out changeset 46b4eb05f2ae (bug 1535437)
2019-11-14 23:25:26 +02:00
Mark Striemer
54c97d535f
Bug 1535437 - Part 2: Resize PiP window when video source resizes r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D50139
--HG--
extra : moz-landing-system : lando
2019-11-12 20:51:51 +00:00
Neil Deakin
bf4c789cae
Bug 1595875, fix handling of return value of FormAutoComplete:GetSelectedIndex that was incorrectly removed by 1573836, r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D52720
--HG--
extra : moz-landing-system : lando
2019-11-14 10:07:52 +00:00
Neil Deakin
fd6f562cbe
Bug 1533943, modify WebNavigation to inherit from JSWindowActor, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D50886
--HG--
extra : source : 6e3c105cfcde3a6821120a83674f77692f5c7bf2
2019-11-14 00:53:29 +00:00
Daniel Varga
cc80b874b2
Backed out changeset 6e3c105cfcde (bug 1533943) for causing mochitest failures at mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html on a CLOSED TREE
2019-11-14 08:30:55 +02:00
Neil Deakin
641485fae3
Bug 1533943, modify WebNavigation to inherit from JSWindowActor, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D50886
--HG--
extra : moz-landing-system : lando
2019-11-14 00:53:29 +00:00
Neil Deakin
de0e62029f
Bug 1590445, only adjust zoom level for FullZoomChange and TextZoomChange events for top-level frames, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D51617
--HG--
extra : moz-landing-system : lando
2019-11-05 00:08:18 +00:00
Mike Conley
83b7a85186
Bug 1582600 - Make PiP code handle the case where sometimes calling .get() on a weak reference throws NS_ERROR_XPC_BAD_CONVERT_NATIVE (bug 800957). r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D51939
--HG--
extra : moz-landing-system : lando
2019-11-07 18:31:42 +00:00
Carson Greene
6b4dc767f9
Bug 1591494 - Make KeyPressEventModelCheckerChild a JSWindowActorChild instead of ActorChild r=barret,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D51429
--HG--
extra : moz-landing-system : lando
2019-11-07 14:07:04 +00:00