Previously the WebProgressListener in AboutWelcomeChild was detecting
OnLocationChange notifications for loading about:welcome rather than
notifications for navigating away from it, meaning that
AWTerminate.UNKNOWN was almost immediately replaced as soon as the
document was loaded, rather than only when navigating away. The
DOMDocElementInserted event fires slightly later than DOMWindowCreated
so the actor no longer sees the OnLocationChange notification for the
current document, causing tests to fail.
As this telemetry is no longer actively monitored, this patch removes
AWTerminate.UNKNOWN to preserve the existing behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D118620
Patch appends screen order in message id to be passed in Impression and Click telemetry from respective screen. This is useful to keep onboarding engagement dashboard consistent across releases by using message id that begins with 'feature id_screen order_%'
Differential Revision: https://phabricator.services.mozilla.com/D119345
Update yamscripts to use sass command line interface with input:output args and appropriate --options, and also fix incorrect watchmc as bundle:css was && chained. Fix up sass errors (multiline string variable) and warnings (divide vs css / separator).
Differential Revision: https://phabricator.services.mozilla.com/D117484
Update yamscripts to use sass command line interface with input:output args and appropriate --options, and also fix incorrect watchmc as bundle:css was && chained. Fix up sass errors (multiline string variable) and warnings (divide vs css / separator).
Differential Revision: https://phabricator.services.mozilla.com/D117484
The tests do not reflect reality, see the bug for more details.
The content area of the Proton `about:welcome` uses
`var(--in-content-page-color)` and `var(--in-content-page-background)`
for the text and background color. The main background itself already
has colors distinct from the default background. Moreover,
`about:welcome` is part of the onboarding experience, at which point
users will likely not have a custom theme, so it's not necessary to
adjust the colors.
Differential Revision: https://phabricator.services.mozilla.com/D116453
Make the default screens show pin then default then import then theme. Detect if the pin screen should be default or start and remove the 2nd screen default if necessary.
Differential Revision: https://phabricator.services.mozilla.com/D116203
Update ShellService to also check mac pinned but only from the main process, so have AboutWelcomeChild request pinned for use in getDefaults and prepareContent. Remove windows images and consolidate back to single shared css without spacers and instead use margin: auto with logo that is no longer fixed. Split out pin strings to own screen/section and use PLATFORM. Add macOS default prompt message without touching existing windows one.
Differential Revision: https://phabricator.services.mozilla.com/D115967
Prepare content for both isProton and pre-proton designs. Also deep clone to avoid directly deleting from pre-proton DEFAULT object.
Differential Revision: https://phabricator.services.mozilla.com/D115834
Switch themes to flex to allow items to be equally sized and evenly spaced with adjusted whitespace. Allow wrapping for pre-proton design.
Differential Revision: https://phabricator.services.mozilla.com/D115732
Remove explicit section-left children widths to allow the parent to flex with a static width section-main for initial screen. Clean up some breakpoint sizing with percent/viewport widths.
Differential Revision: https://phabricator.services.mozilla.com/D115546
Allow transitions to be remotely configured. Use hooks to insert transition-{in,out} class when adding and removing screens. Specify desired in/out styles to transition from/to. Also flex/push buttons/steps to the bottom to be the same position on the latter screens.
Differential Revision: https://phabricator.services.mozilla.com/D114192
Switch about:welcome and upgrade dialog to use url(icon.svg) to avoid high contrast hiding gradients. Also adjusts customize mode styling to better match proton.
Differential Revision: https://phabricator.services.mozilla.com/D113701
Switch about:welcome and upgrade dialog to use url(icon.svg) to avoid high contrast hiding gradients. Also adjusts customize mode styling to better match proton.
Differential Revision: https://phabricator.services.mozilla.com/D113701
Punam Dahiya
Emily McMinn
Andrei Oprea
Csoregi Natalia
Nika Layzell
Ed Lee
Sandor Molnar
Rob Wu
Punam Dahiya
Butkovits Atila
Dorel Luca
Shane Caraveo
Brindusan Cristian