This patch is to improve the way to detect an injected dependent module for
automatic DLL blocking (bug 1659438).
In the previous version, we created a list of dependent modules in the launcher
process and shared it with other processes via the shared section. However, it
was not compatible with third-party applications who tamper the Import Table and
revert it in the injected module's DllMain (bug 1682834) because we parsed the
Import Table in the launcher process after it was reverted.
With this patch, we check the Import Table in `patched_NtMapViewOfSection`,
so we can see tampering before it's reverted. More specifically, we create
a list of dependent modules in the browser process as below.
1. The launcher process creates a section object and initializes
the kernel32.dll's functions in it.
2. The launcher process transfers a writable handle of the shared
section to the browser process.
3. In the browser process, if an injected dependent module is being
mapped by `NtMapViewOfSection`, we add its NT path to the shared
section and block it with `REDIRECT_TO_NOOP_ENTRYPOINT`.
4. The `main` function of the browser process converts the writable
handle of the shared section into a readonly handle.
5. The browser process transfers a readonly handle of the shared
section to a sandbox process.
Since automatic DLL blocking may still cause a compat issue like bug 1682304,
we activate it only in Nightly for now.
Differential Revision: https://phabricator.services.mozilla.com/D101460
To clarify the two separate SubDialog managers managed by TabDialogManager, this patch renames `_.dialogManager` to `._tabDialogManager`.
Depends on D100066
Differential Revision: https://phabricator.services.mozilla.com/D100955
The TabDialogBox will manage two separate SubDialog managers at the tab and content level. Dialogs managed at the tab level will always be on top of content ones and should always receive focus first when tab switching or refocusing the window.
Differential Revision: https://phabricator.services.mozilla.com/D100066
This patch is to improve the way to detect an injected dependent module for
automatic DLL blocking (bug 1659438).
In the previous version, we created a list of dependent modules in the launcher
process and shared it with other processes via the shared section. However, it
was not compatible with third-party applications who tamper the Import Table and
revert it in the injected module's DllMain (bug 1682834) because we parsed the
Import Table in the launcher process after it was reverted.
With this patch, we check the Import Table in `patched_NtMapViewOfSection`,
so we can see tampering before it's reverted. More specifically, we create
a list of dependent modules in the browser process as below.
1. The launcher process creates a section object and initializes
the kernel32.dll's functions in it.
2. The launcher process transfers a writable handle of the shared
section to the browser process.
3. In the browser process, if an injected dependent module is being
mapped by `NtMapViewOfSection`, we add its NT path to the shared
section and block it with `REDIRECT_TO_NOOP_ENTRYPOINT`.
4. The `main` function of the browser process converts the writable
handle of the shared section into a readonly handle.
5. The browser process transfers a readonly handle of the shared
section to a sandbox process.
Since automatic DLL blocking may still cause a compat issue like bug 1682304,
we activate it only in Nightly for now.
Differential Revision: https://phabricator.services.mozilla.com/D101460
To clarify the two separate SubDialog managers managed by TabDialogManager, this patch renames `_.dialogManager` to `._tabDialogManager`.
Depends on D100066
Differential Revision: https://phabricator.services.mozilla.com/D100955
The TabDialogBox will manage two separate SubDialog managers at the tab and content level. Dialogs managed at the tab level will always be on top of content ones and should always receive focus first when tab switching or refocusing the window.
Differential Revision: https://phabricator.services.mozilla.com/D100066
I focused this on fixing what the bug describes: updating the doc for our new
development model where we create experimental APIs inside each extension
instead of landing APIs in mozilla-central. There are a number of other changes
I want to make to this doc but didn't here in order to keep it scoped. I filed
bug 1684069 for those other changes. I can imagine that some of the changes that
this patch makes will be overidden or updated by that bug.
This also fixes a broken link or two.
Differential Revision: https://phabricator.services.mozilla.com/D100417
Adding a check for updates option to the application menu, changing the about dialog styling to match the mockup, and adding a minimum delay to the checking for updates message.
Differential Revision: https://phabricator.services.mozilla.com/D95195
* Move shared open-in-new and print icons into toolkit and update references
* The pendingpaint.png reference will be removed in bug 1679133
Differential Revision: https://phabricator.services.mozilla.com/D101239
To clarify the two separate SubDialog managers managed by TabDialogManager, this patch renames `_.dialogManager` to `._tabDialogManager`.
Depends on D100066
Differential Revision: https://phabricator.services.mozilla.com/D100955
The TabDialogBox will manage two separate SubDialog managers at the tab and content level. Dialogs managed at the tab level will always be on top of content ones and should always receive focus first when tab switching or refocusing the window.
Differential Revision: https://phabricator.services.mozilla.com/D100066
With Fission it is no longer guaranteed that loading a document that
makes a browser remote will trigger an SSTabRestored event, which
makes this particular part of the test fail. Instead waiting for page
load to finish solves the issue.
Differential Revision: https://phabricator.services.mozilla.com/D100674
This will cause the default for any new policy engine in a profile, or an updated engine, to be UTF-8, unless specified by the policy.
Differential Revision: https://phabricator.services.mozilla.com/D100666
Implementing grid layout using flex may sometimes triggers edge cases where some columns go out of alignment. In this bug, the misalignment is due to the different length value given by -moz-available when Ubuntu font is used on the page.
Differential Revision: https://phabricator.services.mozilla.com/D100395
Mihai Alexandru Michis
Dão Gottwald
Simon Weckler
Marco Bonardo
amy churchwell
Toshihito Kikuchi
Micah Tigley
Paul Zuehlcke
smolnar
Erica Wright
Butkovits Atila
prathiksha
harry
Drew Willcoxon
Dan Mosedale
Dale Harvey
Noemi Erli
Razvan Maries
Neil Deakin
Ryan VanderMeulen
Bogdan Tara
Bernard Igiri
ttran
Scott
Sam Foster
Francesco Lodolo (:flod)
Andrei Oprea
Gijs Kruitbosch
Andreea Pavel
Andreas Farre
Emilio Cobos Álvarez
Mark Banner
Kenrick
Mike Conley