Граф коммитов

105 Коммитов

Автор SHA1 Сообщение Дата
Valentin Gosu 6b419daeb0 Bug 1702529 - Pass NetAddr pointers to rust instead of a serialization r=necko-reviewers,dragana
It seems that the serialization generated by inet_ntop_internal via
getnameinfo is sometimes wrong, returning `?` instead of serializing the
IP we pass in.
It's also inefficient to keep passing the serialization to and from rust
code - instead it's much easier to just pass a pointer to the NetAddr
union and build a proper SocketAddr instance on the rust side from
from the bytes instead of parsing the serialization

Differential Revision: https://phabricator.services.mozilla.com/D129489
2021-10-27 15:28:41 +00:00
Cristian Tuns d766fa0f20 Backed out changeset ba94ff2a7696 (bug 1702529) for causing build bustages. CLOSED TREE 2021-10-27 07:07:17 -04:00
Valentin Gosu 609bf1922f Bug 1702529 - Pass NetAddr pointers to rust instead of a serialization r=necko-reviewers,dragana
It seems that the serialization generated by inet_ntop_internal via
getnameinfo is sometimes wrong, returning `?` instead of serializing the
IP we pass in.
It's also inefficient to keep passing the serialization to and from rust
code - instead it's much easier to just pass a pointer to the NetAddr
union and build a proper SocketAddr instance on the rust side from
from the bytes instead of parsing the serialization

Differential Revision: https://phabricator.services.mozilla.com/D129489
2021-10-27 10:44:46 +00:00
Valentin Gosu 990245fb6a Bug 1729897 - CSP Upgrade-insecure-requests is upgrading localhost websocket r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D125533
2021-09-15 11:28:13 +00:00
Nicklas Boman ad454095ed Bug 1308103 - Replace PL_strcmp/PL_strncmp with strcmp/strncmp in netwerk/ r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D123877
2021-09-09 19:36:10 +00:00
Valentin Gosu c46e217683 Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-10 09:26:01 +00:00
Valentin Gosu 2487615b47 Bug 1708116 - Add NetAddr::InitFromString r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D98952
2021-05-10 09:26:00 +00:00
Brindusan Cristian 31acb9e00c Backed out 2 changesets (bug 1708116) for causing xpcshell failures in test_udpsocket_offline.js and bc failures in browser_cookies_ipv6.js. CLOSED TREE
Backed out changeset 0c9b303226f1 (bug 1708116)
Backed out changeset e3be13d3c045 (bug 1708116)
2021-05-06 16:35:48 +03:00
Valentin Gosu 301361bdfb Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-06 10:06:46 +00:00
Valentin Gosu 6de6a52f1e Bug 1708116 - Add NetAddr::InitFromString r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D98952
2021-05-06 10:06:46 +00:00
Sandor Molnar f7b8c6b3d1 Backed out 2 changesets (bug 1708116) for causing build bustages. CLOSED TREE
Backed out changeset d1488e9d64a6 (bug 1708116)
Backed out changeset 44ed91f0b7b4 (bug 1708116)
2021-05-04 18:41:36 +03:00
Valentin Gosu 5ae9a468e0 Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-04 14:05:59 +00:00
Valentin Gosu 9e72439569 Bug 1708116 - Add NetAddr::InitFromString r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D98952
2021-05-04 14:05:58 +00:00
Valentin Gosu ca325c9add Bug 1700076 - Fix modernize-use-default-member-init clang-tidy warnings in netwerk/dns/ r=necko-reviewers,dragana
This patch consists of the changes generated by running
`./mach static-analysis check --fix` on `netwerk/dns` after adding the
`modernize-use-default-member-init` clang-tidy lint.
Some additional changes were made by hand to ensure consistent results.
This patch ensures that all member variables are initialized in the header,
so when adding or changing constructors we don't miss one resulting in
uninitialized memory.

Differential Revision: https://phabricator.services.mozilla.com/D109339
2021-04-07 07:29:54 +00:00
Cosmin Sabou a9dd657e32 Backed out 18 changesets (bug 1700076, bug 1699691) for causing windows xpcshell failures on test_trr_cancel.js. CLOSED TREE
Backed out changeset 5f3eb0797c06 (bug 1699691)
Backed out changeset 768e56ccd244 (bug 1699691)
Backed out changeset d89075d72c83 (bug 1700076)
Backed out changeset fcf92dd5158a (bug 1700076)
Backed out changeset 8094a7ffc6a4 (bug 1700076)
Backed out changeset 9bc2539a1f5d (bug 1700076)
Backed out changeset fcf27f3c7b69 (bug 1700076)
Backed out changeset 753f4df63689 (bug 1700076)
Backed out changeset 1315c00d2137 (bug 1700076)
Backed out changeset 776c44be95f5 (bug 1700076)
Backed out changeset 2b8d8d63cacd (bug 1700076)
Backed out changeset bc92b34e5d71 (bug 1700076)
Backed out changeset 016c856573da (bug 1700076)
Backed out changeset c085324cb20e (bug 1700076)
Backed out changeset 26dc88b74377 (bug 1700076)
Backed out changeset 8dc21acb87f9 (bug 1700076)
Backed out changeset f36e9cb05851 (bug 1700076)
Backed out changeset fb3f2329ca37 (bug 1700076)
2021-04-06 21:49:20 +03:00
Valentin Gosu 3f1f271f39 Bug 1700076 - Fix modernize-use-default-member-init clang-tidy warnings in netwerk/dns/ r=necko-reviewers,dragana
This patch consists of the changes generated by running
`./mach static-analysis check --fix` on `netwerk/dns` after adding the
`modernize-use-default-member-init` clang-tidy lint.
Some additional changes were made by hand to ensure consistent results.
This patch ensures that all member variables are initialized in the header,
so when adding or changing constructors we don't miss one resulting in
uninitialized memory.

Differential Revision: https://phabricator.services.mozilla.com/D109339
2021-04-06 13:18:25 +00:00
Kershaw Chang a2532cb1f3 Bug 1689987 - P1: Don't mess up TRR telemetry when ODoH is used r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D104799
2021-02-18 12:50:02 +00:00
Valentin Gosu 24e6fdf63c Bug 1672528 - Check IPv4-mapped IPv6 addresses for being local r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95414
2020-11-04 13:48:54 +00:00
Frédéric Wang 70d15af587 Bug 1220810 - Hardcode localhost to loopback, r=ckerschb,necko-reviewers,dragana
This patch make localhost addresses resolve to a loopback address,
thereby ensuring that we can safely treat http://localhost/ and
http://*.localhost/ as "Potentially Trustworthy". This addresses
various bug reports from developers and aligns with specifications.

See https://groups.google.com/g/mozilla.dev.platform/c/sZdEYTiEBdE

Differential Revision: https://phabricator.services.mozilla.com/D92716
2020-10-22 07:36:15 +00:00
smolnar b70b9de731 Backed out changeset a5a35a205a44 (bug 1220810) for causing test_dns_offline and fontface-override-descriptor-getter-setter failures. CLOSED TREE 2020-10-21 13:00:01 +03:00
Frédéric Wang 4e6e6c7714 Bug 1220810 - Hardcode localhost to loopback, r=ckerschb,necko-reviewers,dragana
This patch make localhost addresses resolve to a loopback address,
thereby ensuring that we can safely treat `http://localhost/` and
`http://*.localhost/` as "Potentially Trustworthy". This addresses
various bug reports from developers and aligns with specifications.

See https://groups.google.com/g/mozilla.dev.platform/c/sZdEYTiEBdE

Differential Revision: https://phabricator.services.mozilla.com/D92716
2020-10-21 07:42:23 +00:00
Simon Giesecke de7bab0f06 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Valentin Gosu 07362aeaa4 Bug 1663657 - Turn IsIpAddr* functions into NetAddr methods r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D89552
2020-09-15 10:39:56 +00:00
Razvan Maries c8e604eb78 Backed out 4 changesets (bug 1660970, bug 1525854, bug 1663657, bug 1645108) for perma failures on test_trr_additional_section.js. CLOSED TREE
Backed out changeset ad6c2e8af09b (bug 1663657)
Backed out changeset 419e26e3f452 (bug 1525854)
Backed out changeset 55bf856faf33 (bug 1660970)
Backed out changeset c543a3a008fa (bug 1645108)
2020-09-15 02:35:05 +03:00
Valentin Gosu 6d149e6e7a Bug 1663657 - Turn IsIpAddr* functions into NetAddr methods r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D89552
2020-09-14 12:06:27 +00:00
Valentin Gosu 0cf5f5e5ac Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
2020-09-01 07:22:14 +00:00
Valentin Gosu 934d895d74 Bug 1659132 - Get rid of NetAddrElement. Make mAddresses an array r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D87090
2020-09-01 07:38:03 +00:00
Butkovits Atila cdf1ae5211 Backed out 2 changesets (bug 1659132) for failures at browser_cleanFlow.js. CLOSED TREE
Backed out changeset 7952fd59f59b (bug 1659132)
Backed out changeset fa8ce4af10a0 (bug 1659132)
2020-08-25 13:02:33 +03:00
Valentin Gosu b4b3279a00 Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
2020-08-25 08:02:22 +00:00
Valentin Gosu 240eeaae88 Bug 1659132 - Get rid of NetAddrElement. Make mAddresses an array r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D87090
2020-08-25 08:01:36 +00:00
Butkovits Atila 73a14f1b36 Backed out 2 changesets (bug 1659132) for build bustage. CLOSED TREE
Backed out changeset 1caace74f89e (bug 1659132)
Backed out changeset 58fdbfbe05a1 (bug 1659132)
2020-08-25 09:43:01 +03:00
Valentin Gosu ec0be3efef Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
2020-08-24 12:23:06 +00:00
Valentin Gosu 125efe18dd Bug 1659132 - Get rid of NetAddrElement. Make mAddresses an array r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D87090
2020-08-24 11:38:01 +00:00
Narcis Beleuzu d27be427c9 Backed out changeset 83749e9e67bd (bug 1220810) for bc failures on browser_fall_back_to_https.js . CLOSED TREE 2020-07-10 18:42:17 +03:00
Andrea Marchesini 23052342cb Bug 1220810 - Hardcode localhost to loopback, r=ckerschb,dragana
Differential Revision: https://phabricator.services.mozilla.com/D64586
2020-07-10 14:30:58 +00:00
Mihai Alexandru Michis b62be4d15f Backed out changeset 1b035d80fb9f (bug 1220810) for causing bustages in netwerk/dns/DNS.cpp
CLOSED TREE
2020-07-10 17:17:20 +03:00
Andrea Marchesini f498accc17 Bug 1220810 - Hardcode localhost to loopback, r=ckerschb,dragana
Differential Revision: https://phabricator.services.mozilla.com/D64586
2020-07-10 13:08:14 +00:00
Mihai Alexandru Michis 44cad01e29 Backed out changeset 1b44f13206d0 (bug 1220810) for causing gecko decision task bustages.
CLOSED TREE
2020-07-10 15:37:45 +03:00
Andrea Marchesini 2144af13e9 Bug 1220810 - Hardcode localhost to loopback, r=ckerschb,dragana
Differential Revision: https://phabricator.services.mozilla.com/D64586
2020-07-10 12:23:46 +00:00
Mihai Alexandru Michis 61006875dd Backed out changeset 36f368ba214c (bug 1220810) for causing gecko decision task bustages.
CLOSED TREE
2020-07-10 15:00:15 +03:00
Andrea Marchesini f36d351374 Bug 1220810 - Hardcode localhost to loopback, r=ckerschb,dragana
Differential Revision: https://phabricator.services.mozilla.com/D64586
2020-07-10 11:34:10 +00:00
Mihai Alexandru Michis 93ec4f0381 Backed out changeset f01596089356 (bug 1220810) for causing crashes in test_performance_attributes_exist_in_object.html
CLOSED TREE
2020-03-19 17:12:32 +02:00
Andrea Marchesini e4db0e4496 Bug 1220810 - Hardcode localhost to loopback, r=ckerschb,dragana
Differential Revision: https://phabricator.services.mozilla.com/D64586

--HG--
extra : moz-landing-system : lando
2020-03-19 13:06:48 +00:00
Simon Giesecke 14dbfcaa29 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in netwerk. r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D65496

--HG--
extra : moz-landing-system : lando
2020-03-06 09:22:49 +00:00
Dragana Damjanovic 31caeebb2e Bug 1610253 - Expose network timing to trr DNS records. r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D60544

--HG--
extra : moz-landing-system : lando
2020-02-04 11:09:11 +00:00
Ehsan Akhgari 625509f19c Bug 1399803 - Consider all IPv4 loopback addresses as secure context; r=bzbarsky,dragana
Differential Revision: https://phabricator.services.mozilla.com/D43633

--HG--
extra : moz-landing-system : lando
2019-08-30 07:57:34 +00:00
Henrik Skupin 1803585259 Bug 1570104 - Add shared IPv4 range from RFC 6598 (100.64/10) to allowed list of IP addresses for testing. r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D40167

--HG--
extra : moz-landing-system : lando
2019-08-28 10:58:48 +00:00
Sylvestre Ledru e226046cb8 Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956

--HG--
extra : moz-landing-system : lando
2019-05-01 08:47:10 +00:00
Sylvestre Ledru ef0bfc3822 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D24168

--HG--
extra : moz-landing-system : lando
2019-03-31 15:12:55 +00:00
Valentin Gosu a2d6b63946 Bug 1420677 - Make AddrInfo.mAddresses an AutoCleanLinkedList r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D22960

--HG--
extra : moz-landing-system : lando
2019-03-19 12:22:10 +00:00