Граф коммитов

10978 Коммитов

Автор SHA1 Сообщение Дата
Masayuki Nakano c0624f4771 Bug 1713757 - Make `mozInlineSpellChecker`, `mozInlineSpellWordUtil` and `TextServicesDocument` use `EditorBase` instead of `TextEditor` r=m_kato
Depends on D117117

Differential Revision: https://phabricator.services.mozilla.com/D117118
2021-06-09 09:02:31 +00:00
Deian Stefan 1030b2a3e3 Bug 1653659 - Part 3: Only allow non-empty paths in RLBoxHunspell r=tjr
Differential Revision: https://phabricator.services.mozilla.com/D116547
2021-06-08 17:45:26 +00:00
Julian Descottes 7240e461cc Bug 1715123 - Remove unused method broadcastPermissionsForPrincipalToAllContentProcesses in PermissionManager r=timhuang,necko-reviewers,dragana
Depends on D116850

Differential Revision: https://phabricator.services.mozilla.com/D116852
2021-06-08 08:08:48 +00:00
Dylan Roeh 9aee13c478 Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D112042
2021-06-07 17:57:24 +00:00
Alexandru Michis e8904db16a Backed out 5 changesets (bug 1699480) for causing lint failures.
CLOSED TREE

Backed out changeset 5ed626994de6 (bug 1699480)
Backed out changeset e4be23f4dbe9 (bug 1699480)
Backed out changeset 68b5f5c2f1e6 (bug 1699480)
Backed out changeset 425aa354f1ca (bug 1699480)
Backed out changeset e3005001299c (bug 1699480)
2021-06-07 20:52:25 +03:00
Dylan Roeh 648ddb2f54 Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D112042
2021-06-07 17:02:26 +00:00
Valentin Gosu aa5e042347 Bug 1682240 - Kill ntlm_auth process instead of waiting for it to complete r=necko-reviewers,kershaw
This avoids hangs when the process might be unresponsive.

Differential Revision: https://phabricator.services.mozilla.com/D116715
2021-06-07 07:15:37 +00:00
Brindusan Cristian ca49f15f7d Backed out 14 changesets (bug 1705659, bug 472823, bug 669675) as requested by valentin for causing regressions. CLOSED TREE
Backed out changeset d920aa17a468 (bug 669675)
Backed out changeset adad38c05584 (bug 1705659)
Backed out changeset 361c177ed131 (bug 1705659)
Backed out changeset 46e559f45338 (bug 1705659)
Backed out changeset 3c9556a8df55 (bug 1705659)
Backed out changeset a179695a56c9 (bug 1705659)
Backed out changeset e688986c7011 (bug 1705659)
Backed out changeset de990e6c944d (bug 1705659)
Backed out changeset 0ea348abee78 (bug 1705659)
Backed out changeset 2f0aacbd42b1 (bug 1705659)
Backed out changeset c977551bad6e (bug 1705659)
Backed out changeset 5449d9e08034 (bug 1705659)
Backed out changeset b6b51bc167ac (bug 1705659)
Backed out changeset 27e709923ecb (bug 472823)
2021-05-31 13:16:34 +03:00
Mirko Brodesser f271c866cf Bug 1687263: part 4) Defer and in some cases avoid removing spellchecking-ranges. r=smaug
Removing ranges is expensive. This reduces flickering of the spelling
mistakes and prevents 100% CPU usage of 1 core on slower machines.

The essence of this patch is, that when text doesn't change, all
existing spellchecking ranges are reused.

Before this patch, removing ranges was done as part of the time slice in
`mozInlineSpellChecker::SpellCheckSlice`. That is, slow removals of
ranges contributed to the amount of words to be spellchecked
asynchronously.
Therefore, the amount of words to be spellchecked in one chunk could
increase from the minimum, `INLINESPELL_MINIMUM_WORDS_BEFORE_TIMEOUT` to
the maxium `INLINESPELL_MAXIMUM_CHUNKED_WORDS_PER_TASK`.
Consequently, the asynchronous checking might take longer. If that turns
out to be problematic, reducing
`INLINESPELL_MAXIMUM_CHUNKED_WORDS_PER_TASK` could be a fix.

Differential Revision: https://phabricator.services.mozilla.com/D116096
2021-05-28 07:56:13 +00:00
Mirko Brodesser 81d2b2a2d9 Bug 1687263: part 3) Move removing ranges into `CheckWordsAndUpdateRangesForMisspellings`. r=smaug
This might lead to increased exceeding of the time slice, because the
ranges are removed after the time limit was checked. Therefore, this
change should only be landed together with the following review which
will remove unnecessary remove- and add-operations for ranges. It's a
separate review only to simplify reviewing and potential debugging.

Differential Revision: https://phabricator.services.mozilla.com/D116095
2021-05-28 07:56:13 +00:00
Mirko Brodesser 80b835b192 Bug 1687263: part 2) Add `NodeOffsetRange::operator==(const nsRange& aRange)`. r=smaug
The fix of bug 1687263 will require determining which `nsRange`s of a
previous time slice to keep and for which `NodeOffsetRange`s to create
new `nsRange`s. The operator will be used in a following review.

Differential Revision: https://phabricator.services.mozilla.com/D116094
2021-05-28 07:56:12 +00:00
Mirko Brodesser ed9c8cebed Bug 1687263: part 1) Add `NodeOffset::operator==(const RangeBoundary)`. r=smaug
Required for the following review.

Differential Revision: https://phabricator.services.mozilla.com/D116093
2021-05-28 07:56:12 +00:00
Mirko Brodesser 59984954da Bug 1708422: part 21) Reduce scope of `erv` variable in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D115687
2021-05-26 10:04:36 +00:00
Mirko Brodesser 0694578bb0 Bug 1708422: part 20) Const-qualify some variables in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
Clearer.

Differential Revision: https://phabricator.services.mozilla.com/D115686
2021-05-26 10:04:36 +00:00
Mirko Brodesser 93ac6f9a56 Bug 1708422: part 19) Replace output arguments with a single argument in `mozInlineSpellWordUtil::GetNextWord`. r=smaug
Clearer and helps to simplify its caller.

Differential Revision: https://phabricator.services.mozilla.com/D115597
2021-05-26 10:04:35 +00:00
Valentin Gosu 69c6a23516 Bug 1705659 - Static-analysis check auto fix for auth code r=necko-reviewers,dragana
Depends on D112604

Differential Revision: https://phabricator.services.mozilla.com/D112605
2021-05-26 09:27:21 +00:00
Valentin Gosu 16a4c26f4c Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
Depends on D112601

Differential Revision: https://phabricator.services.mozilla.com/D112603
2021-05-26 09:27:20 +00:00
Valentin Gosu 1fb3a73493 Bug 1705659 - Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana
Depends on D112597

Differential Revision: https://phabricator.services.mozilla.com/D112598
2021-05-26 09:27:19 +00:00
Mirko Brodesser 40b6793a72 Bug 1700051: part 45) Remove outdated part of comment in <mozInlineSpellChecker.cpp>. r=smaug
Depends on D113300

Differential Revision: https://phabricator.services.mozilla.com/D113301
2021-05-25 10:08:15 +00:00
Masayuki Nakano ae69b73075 Bug 1540037 - part 18: Move `ReplaceTextAsAction()` and `ReplaceSelectionAsSubAction()` to `EditorBase` r=m_kato
They are used by setting text value of `TextEditor` or replacing a misspelled
word with a new word in both `TextEditor` and `HTMLEditor`.  Therefore,
they should be in the `EditorBase` rather than `TextEditor`.

Note that the path of the former case may be in a hot path.  Therefore, we need
to keep redirecting to `TextEditor` for keeping the performance only in the
case.

Depends on D115785

Differential Revision: https://phabricator.services.mozilla.com/D115786
2021-05-25 04:26:14 +00:00
Mirko Brodesser 55db5ff457 Bug 1708422: part 18) Factor `mozInlineSpellChecker::SpellCheckerSlice::IsInNoCheckRange` out. r=smaug
Hides details.

Differential Revision: https://phabricator.services.mozilla.com/D115469
2021-05-20 13:00:01 +00:00
Mirko Brodesser e74f6c42f1 Bug 1708422: part 17) Rename `words` to `normalizedWords` in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D115366
2021-05-20 09:03:30 +00:00
Mirko Brodesser b05af40fa3 Bug 1708422: part 16) Rename `mozInlineSpellChecker::SpellCheckerTimeSlice` to `mozInlineSpellChecker::SpellCheckerSlice`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D115352
2021-05-20 09:03:30 +00:00
Mirko Brodesser e5983d6bde Bug 1708422: part 14) Extend documentation of `mozInlineSpellChecker::SpellCheckerTimeSlice::CheckWordsAndAddRangesForMisspellings`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D114333
2021-05-20 09:03:29 +00:00
Mirko Brodesser c080bbd4cc Bug 1708422: part 13) Factor code out to `mozInlineSpellChecker::SpellCheckerTimeSlice::RemoveRanges`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D114332
2021-05-20 09:03:28 +00:00
Mirko Brodesser a89ff13783 Bug 1708422: part 12) Move some code into `mozInlineSpellChecker::SpellCheckerTimeSlice::ShouldSpellCheckRange`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D114331
2021-05-20 09:03:28 +00:00
Mirko Brodesser 9c30eeb984 Bug 1708422: part 11) Remove unnecessary block scope in `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D114105
2021-05-20 09:03:28 +00:00
Mirko Brodesser ddbcce9316 Bug 1708422: part 10) Factor `ShouldSpellCheckRange` out. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D114104
2021-05-20 09:03:27 +00:00
Mirko Brodesser 882cc710a4 Bug 1708422: part 9) Declare `mozInlineSpellChecker::ShouldSpellCheckNode` `static`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D114103
2021-05-20 09:03:27 +00:00
Mirko Brodesser 19a242b989 Bug 1708422: part 8) Move `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug
Simplifies `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute`.

Differential Revision: https://phabricator.services.mozilla.com/D114102
2021-05-20 09:03:26 +00:00
Mirko Brodesser a2355f8bc1 Bug 1708422: part 7) Annotate `mozInlineSpellChecker::SpellCheckerTimeSlice` as `MOZ_STACK_CLASS`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D114101
2021-05-20 09:03:26 +00:00
Mirko Brodesser 92c6fda0fa Bug 1708422: part 6) Change some pointer members of `mozInlineSpellChecker::SpellCheckerTimeSlice` to references. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D114100
2021-05-20 09:03:26 +00:00
Mirko Brodesser d99bbf18cb Bug 1708422: part 5) Surround statements in `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute` with curly braces. r=smaug
To match the style guide.

Differential Revision: https://phabricator.services.mozilla.com/D114099
2021-05-20 09:03:25 +00:00
Mirko Brodesser 4e3d4abbad Bug 1708422: part 4) Break out method object for `mozInlineSpellChecker::DoSpellCheck`. r=smaug
Should help to simplify it. Please read the following reviews before
commenting on this one.

Differential Revision: https://phabricator.services.mozilla.com/D114098
2021-05-20 09:03:25 +00:00
Dylan Roeh d488467816 Bug 1699480 - Back out permissions changes at AC's request, r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D115515
2021-05-19 18:07:28 +00:00
Butkovits Atila 6b729f46ac Backed out 2 changesets (bug 1653659) for causing failures at test_hunspell.js. CLOSED TREE
Backed out changeset 018859776d85 (bug 1653659)
Backed out changeset b187a1b158df (bug 1653659)
2021-05-18 04:05:15 +03:00
Deian Stefan 351efdd226 Bug 1653659 - Part 3: Only allow non-empty paths in RLBoxHunspell r=tjr
Differential Revision: https://phabricator.services.mozilla.com/D114925
2021-05-17 18:19:27 +00:00
Dylan Roeh ff4369ad7c Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D112042
2021-05-17 15:55:21 +00:00
Mirko Brodesser ff7e90c539 Bug 1708422: part 3) Add some documentation to `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D114097
2021-05-17 13:46:59 +00:00
Dorel Luca 6bb805571d Backed out 2 changesets (bug 1653659) for Mochitest failures in mochitest/events/test_focus_general.html. CLOSED TREE
Backed out changeset 523e4bc2aa47 (bug 1653659)
Backed out changeset fac526423ccb (bug 1653659)
2021-05-14 21:45:58 +03:00
Deian Stefan a31d580731 Bug 1653659 - Part 3: Safely handle empty strings in RLBoxHunspell r=tjr
Differential Revision: https://phabricator.services.mozilla.com/D114925
2021-05-14 13:30:48 +00:00
Valentin Gosu c46e217683 Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-10 09:26:01 +00:00
Paul Zuehlcke 6a64e4c3cf Bug 1597751 - Import default permissions for privateBrowsing. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D98200
2021-05-06 17:46:32 +00:00
Alexandru Michis 574bea557a Backed out 14 changesets (bug 1705659, bug 472823, bug 669675) for causing bustages in nsHttpChannelAuthProvider.cpp
CLOSED TREE

Backed out changeset 42561f42313d (bug 669675)
Backed out changeset 2aee05c2d6f3 (bug 1705659)
Backed out changeset ff4348e0a307 (bug 1705659)
Backed out changeset 897868e22c81 (bug 1705659)
Backed out changeset c808bf01dfe8 (bug 1705659)
Backed out changeset 5c13ec25cc2e (bug 1705659)
Backed out changeset 4337214c8846 (bug 1705659)
Backed out changeset 18d3a604336a (bug 1705659)
Backed out changeset 3af362aa2b25 (bug 1705659)
Backed out changeset 36eff14cf2ea (bug 1705659)
Backed out changeset 8af29f96ac77 (bug 1705659)
Backed out changeset eab68e8bea29 (bug 1705659)
Backed out changeset 05492b6578a9 (bug 1705659)
Backed out changeset 3259a8cb3db1 (bug 472823)
2021-05-06 17:37:17 +03:00
Valentin Gosu ec981ec694 Bug 1705659 - Static-analysis check auto fix for auth code r=necko-reviewers,dragana
Depends on D112604

Differential Revision: https://phabricator.services.mozilla.com/D112605
2021-05-06 13:17:23 +00:00
Valentin Gosu b690e62ff7 Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
Depends on D112601

Differential Revision: https://phabricator.services.mozilla.com/D112603
2021-05-06 13:17:22 +00:00
Valentin Gosu 3618a7ca40 Bug 1705659 - Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana
Depends on D112597

Differential Revision: https://phabricator.services.mozilla.com/D112598
2021-05-06 13:17:21 +00:00
Brindusan Cristian 31acb9e00c Backed out 2 changesets (bug 1708116) for causing xpcshell failures in test_udpsocket_offline.js and bc failures in browser_cookies_ipv6.js. CLOSED TREE
Backed out changeset 0c9b303226f1 (bug 1708116)
Backed out changeset e3be13d3c045 (bug 1708116)
2021-05-06 16:35:48 +03:00
Valentin Gosu 301361bdfb Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-06 10:06:46 +00:00
Sandor Molnar f7b8c6b3d1 Backed out 2 changesets (bug 1708116) for causing build bustages. CLOSED TREE
Backed out changeset d1488e9d64a6 (bug 1708116)
Backed out changeset 44ed91f0b7b4 (bug 1708116)
2021-05-04 18:41:36 +03:00