mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
760 382 коммитов 613 Ветки 98 Теги 5,8 GiB
Граф коммитов

10978 Коммитов

Автор SHA1 Сообщение Дата
Andrea Marchesini b523b552a4 Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D70040

--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
 2020-04-09 22:08:02 +00:00
Andrea Marchesini f78d7b4bd4 Bug 1363541 - Modernize the PermissionManager - part 3 - DB handling in a separate thread, r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D69965

--HG--
extra : moz-landing-system : lando
 2020-04-10 06:36:03 +00:00
Andrea Marchesini 3961346cfc Bug 1363541 - Modernize the PermissionManager - part 2 - PermissionDelegateHandler to mozilla::PermissionDelegateHandler, r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D69964

--HG--
extra : moz-landing-system : lando
 2020-04-09 22:08:02 +00:00
Andrea Marchesini 2ab42cd711 Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D69963

--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
 2020-04-09 22:08:02 +00:00
Coroiu Cristina d37de5ed78 Backed out 6 changesets (bug 1363541) for browser-chrome failures at browser/base/content/test/performance/browser_startup_mainthreadio.js on a CLOSED TREE 
Backed out changeset 947073be919f (bug 1363541)
Backed out changeset 1f397b686c11 (bug 1363541)
Backed out changeset d2ba944a47a3 (bug 1363541)
Backed out changeset 80d4d1f0c921 (bug 1363541)
Backed out changeset 9d6b9052f413 (bug 1363541)
Backed out changeset aeaa10789071 (bug 1363541)

--HG--
rename : extensions/permissions/Permission.cpp => extensions/permissions/nsPermission.cpp
rename : extensions/permissions/Permission.h => extensions/permissions/nsPermission.h
rename : extensions/permissions/PermissionManager.cpp => extensions/permissions/nsPermissionManager.cpp
rename : extensions/permissions/PermissionManager.h => extensions/permissions/nsPermissionManager.h
 2020-04-10 01:00:15 +03:00
Andrea Marchesini 25ea79a516 Bug 1363541 - Modernize the PermissionManager - part 6 - moving code around, r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D70164

--HG--
extra : moz-landing-system : lando
 2020-04-09 13:28:23 +00:00
Andrea Marchesini 3e892fdba4 Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D70041

--HG--
extra : moz-landing-system : lando
 2020-04-09 13:27:53 +00:00
Andrea Marchesini 8764c55c53 Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D70040

--HG--
rename : extensions/permissions/nsPermissionManager.cpp => extensions/permissions/PermissionManager.cpp
rename : extensions/permissions/nsPermissionManager.h => extensions/permissions/PermissionManager.h
extra : moz-landing-system : lando
 2020-04-09 13:27:35 +00:00
Andrea Marchesini f71aefda4e Bug 1363541 - Modernize the PermissionManager - part 3 - DB handling in a separate thread, r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D69965

--HG--
extra : moz-landing-system : lando
 2020-04-09 13:26:29 +00:00
Andrea Marchesini cefe8accad Bug 1363541 - Modernize the PermissionManager - part 2 - PermissionDelegateHandler to mozilla::PermissionDelegateHandler, r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D69964

--HG--
extra : moz-landing-system : lando
 2020-04-09 13:25:56 +00:00
Andrea Marchesini 23b424cd70 Bug 1363541 - Modernize the PermissionManager - part 1 - nsPermission to mozilla::Permission, r=timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D69963

--HG--
rename : extensions/permissions/nsPermission.cpp => extensions/permissions/Permission.cpp
rename : extensions/permissions/nsPermission.h => extensions/permissions/Permission.h
extra : moz-landing-system : lando
 2020-04-09 14:07:34 +00:00
Andreas Farre b529c76594 Bug 1620594 - Part 6: Use AbstractThread::MainThread instead of SystemGroup::AbstractThread. r=nika 
Depends on D67635

Differential Revision: https://phabricator.services.mozilla.com/D67636

--HG--
extra : moz-landing-system : lando
 2020-04-07 15:17:14 +00:00
Andreas Farre 63e21eec70 Bug 1620594 - Part 1: Rework NS_ReleaseOnMainThreadSystemGroup. r=nika 
To be able to remove SystemGroup, NS_ReleaseOnMainThreadSystemGroup
needs to have its dependency on SystemGroup removed. Since all
releases using SystemGroup would've released on the main thread anyway
we can safely replace NS_ReleaseOnMainThreadSystemGroup with
NS_ReleaseOnMainThread.

Depends on D64390

Differential Revision: https://phabricator.services.mozilla.com/D67631

--HG--
extra : moz-landing-system : lando
 2020-04-07 15:16:23 +00:00
Kearwood Gilbert 9136ce65cf Bug 1614496 - Implement WebXR Core Module DOM Interfaces r=jgilbert,daoshengmu,webidl,smaug,baku,imanol 
Implement DOM interfaces for the WebXR Core Module. Additional work to implement the WebXR Core Module are marked with TODO (Bug #) comments within the patch and must be landed before enabling the dom.vr.webxr.enabled flag.

Differential Revision: https://phabricator.services.mozilla.com/D62369

--HG--
extra : moz-landing-system : lando
 2020-04-06 19:33:32 +00:00
Cosmin Sabou 2db886518c Backed out changeset 848221b2e156 (bug 1620402) for causing several test failures. 
CLOSED TREE
 2020-03-30 11:35:20 +03:00
Sebastian Streich e23cc2cd7f Bug 1620402 - Refactor nsPermissionManager.cpp r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D65606

--HG--
extra : moz-landing-system : lando
 2020-03-30 07:34:37 +00:00
Makoto Kato 8e9a1c655f Bug 1619883 - Don't include spellchecker dictionary in omni.ja of GeckoView. r=geckoview-reviewers,agi 
Actually, we don't turn on hunspell spellchecker for Android, but, omni.ja seems have hunspell's dictionary. Let's remove it from package.

Differential Revision: https://phabricator.services.mozilla.com/D65477

--HG--
extra : moz-landing-system : lando
 2020-03-23 15:46:06 +00:00
Tim Huang 7057b877bd Bug 1612378 - Part 8: Remove "trackingprotection" and "trackingprotection-pb" from the preload permission list. r=dimi,baku 
We can remove this two permissions from the preload list since we would
only access these two permissions in the parent process. So, it doesn't
need to be sent to content processes anymore.

Differential Revision: https://phabricator.services.mozilla.com/D66215

--HG--
extra : moz-landing-system : lando
 2020-03-25 13:22:09 +00:00
Chris Fronk d5b004443b Bug 1143478 - Rename mozilla::Pair to CompactPair. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D64511

--HG--
rename : mfbt/Pair.h => mfbt/CompactPair.h
extra : moz-landing-system : lando
 2020-03-17 12:42:12 +00:00
Mirko Brodesser ec9cb4d8ef Bug 1622199: annotate `Selection::AddRangeAndSelectFramesAndNotifyListeners` with `MOZ_CAN_RUN_SCRIPT`. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D66759

--HG--
extra : moz-landing-system : lando
 2020-03-13 15:46:13 +00:00
aarushivij 679f1a2799 Bug 1580866 - PermissionTestUtils should throw for undefined r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D66413

--HG--
extra : moz-landing-system : lando
 2020-03-12 19:15:48 +00:00
shindli b02b3a6e1a Backed out changeset a08637fb30c8 (bug 1143478) for causing bustages in /builds/worker/checkouts/gecko/ipc/mscom/Registration.cpp CLOSED TREE 
--HG--
rename : mfbt/CompactPair.h => mfbt/Pair.h
 2020-03-11 14:30:54 +02:00
Chris Fronk a27e438c2d Bug 1143478 - Rename mozilla::Pair to CompactPair. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D64511

--HG--
rename : mfbt/Pair.h => mfbt/CompactPair.h
extra : moz-landing-system : lando
 2020-03-11 12:18:13 +00:00
Ehsan Akhgari 4369044005 Bug 1620322 - Part 6: Refactor the code related to user interactions out of AntiTrackingCommon.cpp; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D65819

--HG--
extra : moz-landing-system : lando
 2020-03-09 23:36:35 +00:00
Narcis Beleuzu 0186cbe565 Backed out 8 changesets (bug 1620322) for bustages on nsContentSink.cpp . CLOSED TREE 
Backed out changeset f41739c64dff (bug 1620322)
Backed out changeset be942a7f329e (bug 1620322)
Backed out changeset a916987c7c71 (bug 1620322)
Backed out changeset ead3484ffb5f (bug 1620322)
Backed out changeset 4e1e8b9afa1a (bug 1620322)
Backed out changeset 473bba698e5a (bug 1620322)
Backed out changeset 0e5e5d41597d (bug 1620322)
Backed out changeset 31b24d79db3d (bug 1620322)

--HG--
rename : toolkit/components/antitracking/ContentBlockingLog.cpp => dom/base/ContentBlockingLog.cpp
rename : toolkit/components/antitracking/ContentBlockingLog.h => dom/base/ContentBlockingLog.h
rename : toolkit/components/antitracking/ContentBlocking.cpp => toolkit/components/antitracking/AntiTrackingCommon.cpp
rename : toolkit/components/antitracking/ContentBlocking.h => toolkit/components/antitracking/AntiTrackingCommon.h
 2020-03-09 22:18:36 +02:00
Ehsan Akhgari a95fb737fd Bug 1620322 - Part 6: Refactor the code related to user interactions out of AntiTrackingCommon.cpp; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D65819

--HG--
extra : moz-landing-system : lando
 2020-03-09 18:12:35 +00:00
Noemi Erli a48fac9e3b Backed out 8 changesets (bug 1620322) for causing bustages in ContentBlockingLog.cpp CLOSED TREE 
Backed out changeset 3dcf513e36cb (bug 1620322)
Backed out changeset 46714855ce1d (bug 1620322)
Backed out changeset 0eb2b5f7322f (bug 1620322)
Backed out changeset 72d640fa0740 (bug 1620322)
Backed out changeset 4533bb4e5177 (bug 1620322)
Backed out changeset 659270edd419 (bug 1620322)
Backed out changeset 6802c18b1914 (bug 1620322)
Backed out changeset 60ff34db9f15 (bug 1620322)

--HG--
rename : toolkit/components/antitracking/ContentBlockingLog.cpp => dom/base/ContentBlockingLog.cpp
rename : toolkit/components/antitracking/ContentBlockingLog.h => dom/base/ContentBlockingLog.h
rename : toolkit/components/antitracking/ContentBlocking.cpp => toolkit/components/antitracking/AntiTrackingCommon.cpp
rename : toolkit/components/antitracking/ContentBlocking.h => toolkit/components/antitracking/AntiTrackingCommon.h
 2020-03-09 19:19:41 +02:00
Ehsan Akhgari 300024b8c3 Bug 1620322 - Part 6: Refactor the code related to user interactions out of AntiTrackingCommon.cpp; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D65819

--HG--
extra : moz-landing-system : lando
 2020-03-09 10:22:14 +00:00
Mark Banner 15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
 2020-03-07 10:09:44 +00:00
Mirko Brodesser 4be580237d Bug 1619617: part 1) Annotate `RemoveRangeAndUnselectFramesAndNotifyListeners` with `MOZ_CAN_RUN_SCRIPT`. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D65511

--HG--
extra : moz-landing-system : lando
 2020-03-06 12:03:23 +00:00
Tim Huang 04d44bae12 Bug 1616570 - Part 1: Rename CookieSettings to CookieJarSettings. r=Ehsan 
Given that we are going to add ContentBlockingAllowList in
CookieSettings, so CookieSettings will be responsible for more stuff than the
cookie behavior and cookie permission. We should use a proper name to
reflect the purpose of it. The name 'CookieSettings' is misleading that
this is only for cookie related stuff. So, we decide to rename
'CookieSettins' to 'CookieJarSettings' which serves better meaning here.

Differential Revision: https://phabricator.services.mozilla.com/D63935

--HG--
rename : netwerk/cookie/CookieSettings.cpp => netwerk/cookie/CookieJarSettings.cpp
rename : netwerk/cookie/nsICookieSettings.idl => netwerk/cookie/nsICookieJarSettings.idl
extra : moz-landing-system : lando
 2020-03-04 08:59:08 +00:00
Mike Conley aef458a960 Bug 1614639 - Clear expired permissions from the database during idle off of the main thread. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D64749

--HG--
extra : moz-landing-system : lando
 2020-02-28 17:50:19 +00:00
Masatoshi Kimura 2a6dcf4db7 Bug 1617338 - Suppress warnings from third-party code in extensions/spellcheck/hunspell/glue/. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D63749

--HG--
extra : moz-landing-system : lando
 2020-02-27 14:52:00 +00:00
Ehsan Akhgari 7a072c5114 Bug 1617893 - Ensure that we properly strip OriginAttributes when deciding which permissions to send for a principal; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D64428

--HG--
extra : moz-landing-system : lando
 2020-02-26 18:39:30 +00:00
Ehsan Akhgari cc9c416a87 Bug 1618251 - Remove the duplicated call to GetKeyForPrincipal() which got added during rebasing; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D64404

--HG--
extra : moz-landing-system : lando
 2020-02-26 16:49:59 +00:00
Brindusan Cristian a58c69be12 Backed out changeset 358b1ecca80b (bug 1617338) for build bustages on Unified_cpp_hunspell_glue0. CLOSED TREE 2020-02-26 19:28:54 +02:00
Masatoshi Kimura cb9e7bf077 Bug 1617338 - Suppress warnings from third-party code in extensions/spellcheck/hunspell/glue/ r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D63749

--HG--
extra : moz-landing-system : lando
 2020-02-26 16:45:29 +00:00
Kris Maglione c31aa68fb4 Bug 1535617: Part 2 - Clear weak references for most cycle collected objects on unlink. r=mccr8 
This covers most cycle collected objects which support weak references, but
not the ones which inherit from a cycle collected class and don't do any cycle
collection on their own.

Differential Revision: https://phabricator.services.mozilla.com/D63962

--HG--
extra : moz-landing-system : lando
 2020-02-25 19:44:39 +00:00
Simon Giesecke aaf6cb4e75 Bug 1617628 - Hide nsBaseHashtable Put overloads in nsRefPtrHashtable subclass. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D63899

--HG--
extra : moz-landing-system : lando
 2020-02-25 17:03:36 +00:00
Simon Giesecke 32c9aeaad4 Bug 1617542 - Remove nsRefPtrHashtable::Put overload accepting already_AddRefed and adapt all uses. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D63865

--HG--
extra : moz-landing-system : lando
 2020-02-25 09:36:12 +00:00
Cosmin Sabou 7f1afff492 Backed out 5 changesets (bug 1617604, bug 1617542, bug 1617546) for causing build bustages on ipc/mscom/Interceptor.cpp. 
CLOSED TREE

Backed out changeset 5faa54ad950e (bug 1617542)
Backed out changeset cb38779e1eb6 (bug 1617604)
Backed out changeset 3aea18e0396f (bug 1617542)
Backed out changeset bc3eeefdfb6c (bug 1617542)
Backed out changeset b76a3aa5ff6f (bug 1617546)
 2020-02-24 19:50:13 +02:00
Simon Giesecke df538d9a79 Bug 1617542 - Remove nsRefPtrHashtable::Put overload accepting already_AddRefed and adapt all uses. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D63865

--HG--
extra : moz-landing-system : lando
 2020-02-24 17:08:30 +00:00
Ehsan Akhgari 8cf4826b61 Bug 1617205 - In nsPermissionManager::AddInternal(), only compute the origin string when it is needed, and when the caller doesn't have it available; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D63678

--HG--
extra : moz-landing-system : lando
 2020-02-24 15:06:54 +00:00
Ehsan Akhgari a8ca0713ed Bug 1614831 - Speed up the transmission of permissions to content processes upon navigation; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D63674

--HG--
extra : moz-landing-system : lando
 2020-02-24 15:21:51 +00:00
pbz 490d6db508 Bug 1614956 - Removed invalid IsOAForceStripPermission call in nsPermissionManager. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D62610

--HG--
extra : moz-landing-system : lando
 2020-02-12 18:50:02 +00:00
Simon Giesecke b50347f917 Bug 1611415 - Prefer using std::move over forget. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
 2020-02-13 14:38:48 +00:00
shindli 91aa0518dd Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE 2020-02-12 20:13:29 +02:00
Simon Giesecke f604a47fa5 Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D60980

--HG--
extra : moz-landing-system : lando
 2020-02-12 17:24:41 +00:00
Mirko Brodesser 36437a9d2d Bug 1613378: part 9) Clarify dependency to `mFrameSelection` in `Selection` when adding/removing ranges. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D62198

--HG--
extra : moz-landing-system : lando
 2020-02-12 12:27:32 +00:00
Ehsan Akhgari 299cb321f2 Bug 1595542 - Update the spellchecker dictionary to SCOWL 2019.10.06 
Differential Revision: https://phabricator.services.mozilla.com/D62069

--HG--
extra : amend_source : 44ea926d595dcfa8d0adedd559cc3b545eca119d
 2020-02-07 20:15:26 +02:00
Masayuki Nakano 450b71f763 Bug 1612085 - part 1: Hide constructor of `nsRange` r=smaug 
`nsRange` instances are allocated a lot in the heap especially by editor and
spellchecker.  The allocation cost is too bad for benchmarks.  Therefore,
we should reuse released instances as far as possible.  For managing it in
static factory methods of `nsRange`, we need to hide `nsRange` constructor.

Differential Revision: https://phabricator.services.mozilla.com/D61237

--HG--
extra : moz-landing-system : lando
 2020-01-30 13:23:35 +00:00
pbz 0d5e5faea7 Bug 1357107 - Remove nsContentBlocker. r=bzbarsky 
Differential Revision: https://phabricator.services.mozilla.com/D59696

--HG--
extra : moz-landing-system : lando
 2020-01-21 19:19:17 +00:00
Sylvestre Ledru 187e9bafaf Bug 1519636 - Automatically reformat recent changes using clang-format r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D60354

--HG--
extra : moz-landing-system : lando
 2020-01-21 09:51:27 +00:00
Emilio Cobos Álvarez 256c124f94 Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj 
This was done by:

This was done by applying:

```
diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
index 789affde7bbf..fe33c4c7d4d1 100644
--- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
+++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
@@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
         from subprocess import Popen, PIPE, check_output, CalledProcessError

         diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
-        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
+        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']

         if not output_file:
             args.append("-i")
```

Then running `./mach clang-format -c <commit-hash>`

Then undoing that patch.

Then running check_spidermonkey_style.py --fixup

Then running `./mach clang-format`

I had to fix four things:

 * I needed to move <utility> back down in GuardObjects.h because I was hitting
   obscure problems with our system include wrappers like this:

0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration
0:03.94 extern void *realloc (void *__ptr, size_t __size)
0:03.94              ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here
0:03.94 MALLOC_DECL(realloc, void*, void*, size_t)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL'
0:03.94     MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__);
0:03.94                                ^
0:03.94 <scratch space>:178:1: note: expanded from here
0:03.94 realloc_impl
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl'
0:03.94 #define realloc_impl mozmem_malloc_impl(realloc)

   Which I really didn't feel like digging into.

 * I had to restore the order of TrustOverrideUtils.h and related files in nss
   because the .inc files depend on TrustOverrideUtils.h being included earlier.

 * I had to add a missing include to RollingNumber.h

 * Also had to partially restore include order in JsepSessionImpl.cpp to avoid
   some -WError issues due to some static inline functions being defined in a
   header but not used in the rest of the compilation unit.

Differential Revision: https://phabricator.services.mozilla.com/D60327

--HG--
extra : moz-landing-system : lando
 2020-01-20 16:19:48 +00:00
Emilio Cobos Álvarez aa3a695712 Bug 1609996 - Remove mozilla/Move.h. r=froydnj 
rg -l 'mozilla/Move.h' | xargs sed -i 's/#include "mozilla\/Move.h"/#include <utility>/g'

Further manual fixups and cleanups to the include order incoming.

Differential Revision: https://phabricator.services.mozilla.com/D60323

--HG--
extra : moz-landing-system : lando
 2020-01-20 16:18:20 +00:00
pbz 9f91b02a4c Bug 1591748 - Added test for oa strip permission list. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D58832

--HG--
extra : moz-landing-system : lando
 2020-01-08 12:17:05 +00:00
pbz 2945018d83 Bug 1591748 - nsPermissionMgr: Added principal oa strip permission list for userContext and privateBrowsing. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D58831

--HG--
extra : moz-landing-system : lando
 2020-01-08 13:06:28 +00:00
Noemi Erli c2e009f1e0 Backed out 2 changesets (bug 1591748) for causing bustages in nsPermissionManager.cpp CLOSED TREE 
Backed out changeset 18fe0c505632 (bug 1591748)
Backed out changeset 94d8942709df (bug 1591748)
 2020-01-07 02:28:04 +02:00
pbz 2eac1bb2bf Bug 1591748 - Added test for oa strip permission list. r=Ehsan 
Depends on D58831

Differential Revision: https://phabricator.services.mozilla.com/D58832

--HG--
extra : moz-landing-system : lando
 2020-01-06 20:11:07 +00:00
pbz f5737d34aa Bug 1591748 - nsPermissionMgr: Added principal oa strip permission list for userContext and privateBrowsing. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D58831

--HG--
extra : moz-landing-system : lando
 2020-01-06 23:49:10 +00:00
Thomas Nguyen b4435e40e5 Bug 1603674 - Add a new API to check if permission delegation and Feature Policy are enabled r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D57077

--HG--
extra : moz-landing-system : lando
 2020-01-06 15:28:12 +00:00
Makoto Kato 7e2d6cdef4 Bug 1602526 - Part 1. Don't use implicit cast from char to uint32_t r=masayuki 
This is regerssion by bug 1571339.

Non-ASCII character such as 0xf9 will be casted to 0xfff9 etc by implicit cast.
So I should cast from char to uint8_t or add char version fucntions.

Differential Revision: https://phabricator.services.mozilla.com/D58090

--HG--
extra : moz-landing-system : lando
 2019-12-26 03:34:49 +00:00
Chris Peterson 406763af7f Bug 1570499 - Part 1: Replace MOZ_FALLTHROUGH macro with C++17's [[fallthrough]] attribute. r=froydnj 
This changeset is a simple find and replace of `MOZ_FALLTHROUGH` and `[[fallthrough]]`.

Unfortunately, the MOZ_FALLTHROUGH_ASSERT macro (to assert on case fallthrough in debug builds) is still necessary after switching from [[clang::fallthrough]] to [[fallthrough]] because:

* MOZ_ASSERT(false) followed by [[fallthrough]] triggers a -Wunreachable-code warning in DEBUG builds
* but MOZ_ASSERT(false) without [[fallthrough]] triggers a -Wimplicit-fallthrough warning in NDEBUG builds.

Differential Revision: https://phabricator.services.mozilla.com/D56440

--HG--
extra : moz-landing-system : lando
 2019-12-20 07:16:43 +00:00
Ehsan Akhgari 77edf2c060 Bug 1603969 - Part 2: Update existing 'storageAccessAPI' permissions with granted origin used in them; r=baku 
This permission manager migration drops the granted origin part of the
permission type.

Differential Revision: https://phabricator.services.mozilla.com/D57494

--HG--
extra : moz-landing-system : lando
 2019-12-19 02:56:54 +00:00
Gurzau Raul bed8b9f116 Backed out 4 changesets (bug 1603969) for failing at /browser_startup_mainthreadio.js on a CLOSED TREE. 
Backed out changeset c4d79087eef1 (bug 1603969)
Backed out changeset 2c0198f3506c (bug 1603969)
Backed out changeset c5ad252c525b (bug 1603969)
Backed out changeset a334451b95eb (bug 1603969)
 2019-12-19 02:08:09 +02:00
Ehsan Akhgari 5cd834fdd4 Bug 1603969 - Part 2: Update existing 'storageAccessAPI' permissions with granted origin used in them; r=baku 
This permission manager migration drops the granted origin part of the
permission type.

Differential Revision: https://phabricator.services.mozilla.com/D57494

--HG--
extra : moz-landing-system : lando
 2019-12-18 19:14:55 +00:00
Gurzau Raul e92fa08412 Backed out 4 changesets (bug 1603969) for failing at /browser_startup_mainthreadio.js on a CLOSED TREE. 
Backed out changeset 959f12e42db9 (bug 1603969)
Backed out changeset 18bf461b9630 (bug 1603969)
Backed out changeset 8c3bb23a048b (bug 1603969)
Backed out changeset 450eec13d73e (bug 1603969)
 2019-12-18 20:53:13 +02:00
Ehsan Akhgari 1211dd7e49 Bug 1603969 - Part 2: Update existing 'storageAccessAPI' permissions with granted origin used in them; r=baku 
This permission manager migration drops the granted origin part of the
permission type.

Differential Revision: https://phabricator.services.mozilla.com/D57494

--HG--
extra : moz-landing-system : lando
 2019-12-18 15:49:17 +00:00
Kris Maglione 94e3b0bd8d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-13 20:36:16 +00:00
pbz a937a753bc Bug 1601256 - nsPermissionManager: Store all private browsing permissions with session expiry. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D56183

--HG--
extra : moz-landing-system : lando
 2019-12-13 12:27:10 +00:00
Henri Sivonen 5c2bad25ab Bug 1551276 - Autodetect legacy encodings on unlabeled pages. r=emk 
Differential Revision: https://phabricator.services.mozilla.com/D56362

--HG--
extra : moz-landing-system : lando
 2019-12-12 17:50:19 +00:00
Oana Pop Rus df78d6011c Backed out changeset 0810ad586986 (bug 1551276) for wpt failures in ar-ISO-8859-6-late.tentative.html on a CLOSED TREE 2019-12-12 16:38:54 +02:00
Henri Sivonen 07527a83c9 Bug 1551276 - Autodetect legacy encodings on unlabeled pages. r=emk 
Differential Revision: https://phabricator.services.mozilla.com/D56362

--HG--
extra : moz-landing-system : lando
 2019-12-12 12:59:47 +00:00
Kearwood Kip Gilbert 19ba3b0322 Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol 
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
 2019-12-12 03:10:51 +00:00
Tom Tung 83eb41d14a Bug 1474608 - P1 - Clear origin attributes directly for deleteDataFromOriginAttributesPattern if it's possible; r=asuth,baku 
The idea of this patch is to try to not use oberver mechanism as possible. To
achieve that, it introduces deleteByOriginAttributes() to cleaners. Different
from other methods, it would only be executed if it's implemented from a
cleaner.

It doesn't remove oberver mechanism entirely since some cleaners are still using
that for other deleteByXXX() functions. So, it only applies removing stuff to
PushService, QuotaManagerService, ServiceWorkerManager, nsPermissionManager,
nsApplicationCacheService, and nsCookieService.

Since the original issue is related to QuotaManagerService, it adds xpcshell
test under the dom/quota/test/unit/ to ensure the behavior won't be changed
accidentally in the future.

Differential Revision: https://phabricator.services.mozilla.com/D33758

--HG--
extra : moz-landing-system : lando
 2019-12-02 19:47:13 +00:00
Megha 08ae52fe49 Bug 1556380 - Enable more ESLint rules for extensions/. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D43355

--HG--
extra : moz-landing-system : lando
 2019-12-06 21:05:20 +00:00
Mark Banner 2103c3b16a Bug 1601681 - Switch recently added files with Windows line endings to Unix. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D55990

--HG--
extra : moz-landing-system : lando
 2019-12-11 08:12:49 +00:00
Brindusan Cristian 9c36dcbf23 Backed out 2 changesets (bug 1580567, bug 1599927) for mochitest failures at test_interfaces.html. CLOSED TREE 
Backed out changeset 0e0d88942d33 (bug 1599927)
Backed out changeset 522c8d183bd5 (bug 1580567)

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js
 2019-12-11 05:31:08 +02:00
Kearwood Kip Gilbert 7c8ce74b8f Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol 
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
 2019-12-11 01:38:17 +00:00
shindli 652f3b0296 Backed out 2 changesets (bug 1580567, bug 1599927) for causing permafailures in dom/tests/mochitest/general/test_interfaces.html CLOSED TREE 
Backed out changeset aeceec922866 (bug 1599927)
Backed out changeset 29809135f18e (bug 1580567)

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js
 2019-12-11 03:32:44 +02:00
shindli 91924fedc7 Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE 
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
 2019-12-11 03:09:26 +02:00
Kearwood Kip Gilbert 6a9c22db45 Bug 1580567 - Implement XR device access permission UI r=fluent-reviewers,bzbarsky,pbz,daoshengmu,imanol 
Added @rbarker as a reviewer to check if this will work well within GeckoView for FxR / Android.
Added @bzbarsky for test_interfaces.html.  -- I'd like to re-land the secure origin requirement for WebVR as part of this patch, as it doesn't help to have UI that can't guarantee the identity of the origin.  (This was backed out due to test failures originally, and since been fixed)

Differential Revision: https://phabricator.services.mozilla.com/D45951

--HG--
rename : browser/components/privatebrowsing/test/browser/browser_privatebrowsing_geoprompt.js => browser/components/privatebrowsing/test/browser/browser_privatebrowsing_rememberprompt.js
extra : moz-landing-system : lando
 2019-12-10 23:55:05 +00:00
Kris Maglione 16a9b29848 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-10 23:07:13 +00:00
Noemi Erli 82d41a33b2 Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures 
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
 2019-12-07 22:26:43 +02:00
Kris Maglione 910eab35d2 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-07 19:11:58 +00:00
Daniel Varga 84a601a6d4 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE 
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
 2019-12-07 03:12:07 +02:00
Kris Maglione 20da940e14 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato 
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740

--HG--
extra : moz-landing-system : lando
 2019-12-06 22:14:14 +00:00
Gabriele Svelto 69790bc62e Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan 
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55443

--HG--
extra : moz-landing-system : lando
 2019-12-06 09:16:44 +00:00
Boris Zbarsky 75124bdd98 Bug 1517588. Use nsIPrincipal::IsSystemPrincipal instead of nsContentUtils::IsSystemPrincipal r=bzbarsky 
Differential Revision: https://phabricator.services.mozilla.com/D53067

--HG--
extra : moz-landing-system : lando
 2019-12-05 04:44:32 +00:00
Thomas Nguyen 1e82cdc161 Bug 1483631 - Prompt with both first party and third party origin if we are delegating permission with allows all feature policy. r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D51839

--HG--
extra : moz-landing-system : lando
 2019-12-04 15:39:26 +00:00
Thomas Nguyen fd744cea01 Bug 1483631 - Restrict nested permission requests in ContentPermissionPrompt with permission delegate r=baku,mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D47416

--HG--
extra : moz-landing-system : lando
 2019-12-04 15:39:03 +00:00
Gurzau Raul 4f21dcd081 Backed out 4 changesets (bug 1483631) for failing at browser_temporary_permissions.js on a CLOSED TREE. 
Backed out changeset f5bb5f6a148f (bug 1483631)
Backed out changeset c5e562c1d590 (bug 1483631)
Backed out changeset 7ef09193a7ef (bug 1483631)
Backed out changeset a909dcbbea2b (bug 1483631)
 2019-12-03 21:57:55 +02:00
Emma Malysz c502777f53 Bug 1597847, rename remaining misc xul files from within /view, /gfx, /extensions, and /testing to .xhtml format r=marionette-reviewers,bgrins,whimboo,gbrown 
Differential Revision: https://phabricator.services.mozilla.com/D54035

--HG--
rename : extensions/spellcheck/tests/chrome/test_add_remove_dictionaries.xul => extensions/spellcheck/tests/chrome/test_add_remove_dictionaries.xhtml
rename : gfx/tests/crashtests/593526.xul => gfx/tests/crashtests/593526.xhtml
rename : testing/marionette/chrome/test.xul => testing/marionette/chrome/test.xhtml
rename : testing/marionette/chrome/test2.xul => testing/marionette/chrome/test2.xhtml
rename : testing/marionette/chrome/test_dialog.xul => testing/marionette/chrome/test_dialog.xhtml
rename : testing/marionette/chrome/test_nested_iframe.xul => testing/marionette/chrome/test_nested_iframe.xhtml
rename : testing/marionette/reftest.xul => testing/marionette/reftest.xhtml
rename : testing/mochitest/baselinecoverage/chrome/test_baselinecoverage.xul => testing/mochitest/baselinecoverage/chrome/test_baselinecoverage.xhtml
rename : testing/mochitest/browser-harness.xul => testing/mochitest/browser-harness.xhtml
rename : testing/mochitest/chrome/test_chromeGetTestFile.xul => testing/mochitest/chrome/test_chromeGetTestFile.xhtml
rename : testing/mochitest/chrome/test_sample.xul => testing/mochitest/chrome/test_sample.xhtml
rename : testing/mochitest/chrome/test_sanityEventUtils.xul => testing/mochitest/chrome/test_sanityEventUtils.xhtml
rename : testing/mochitest/chrome/test_sanityException.xul => testing/mochitest/chrome/test_sanityException.xhtml
rename : testing/mochitest/chrome/test_sanityException2.xul => testing/mochitest/chrome/test_sanityException2.xhtml
rename : testing/mochitest/chrome/test_sanityManifest.xul => testing/mochitest/chrome/test_sanityManifest.xhtml
rename : testing/mochitest/chrome/test_sanityManifest_pf.xul => testing/mochitest/chrome/test_sanityManifest_pf.xhtml
rename : testing/mochitest/chrome/test_tasks_skip.xul => testing/mochitest/chrome/test_tasks_skip.xhtml
rename : testing/mochitest/chrome/test_tasks_skipall.xul => testing/mochitest/chrome/test_tasks_skipall.xhtml
rename : testing/mochitest/harness.xul => testing/mochitest/harness.xhtml
rename : testing/talos/talos/pageloader/chrome/pageloader.xul => testing/talos/talos/pageloader/chrome/pageloader.xhtml
rename : view/crashtests/382756-1.xul => view/crashtests/382756-1.xhtml
rename : view/crashtests/38589-1.xul => view/crashtests/38589-1.xhtml
extra : moz-landing-system : lando
 2019-12-02 19:16:22 +00:00
Thomas Nguyen 14991f5ba2 Bug 1483631 - Prompt with both first party and third party origin if we are delegating permission with allows all feature policy. r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D51839

--HG--
extra : moz-landing-system : lando
 2019-12-03 16:24:39 +00:00
Thomas Nguyen d48ace2c5f Bug 1483631 - Restrict nested permission requests in ContentPermissionPrompt with permission delegate r=baku,mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D47416

--HG--
extra : moz-landing-system : lando
 2019-12-03 16:25:51 +00:00
Christian Holler aef146a43a Bug 1597931 - Add libFuzzer instrumentation to extensions/auth/. r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D53988

--HG--
extra : moz-landing-system : lando
 2019-11-22 14:46:17 +00:00
Christian Holler fcad9f8bf9 Bug 1595692 - Handle missing base64 challenge in NegotiateAuth. r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D53989

--HG--
extra : moz-landing-system : lando
 2019-11-22 21:17:10 +00:00
Masayuki Nakano b91249c508 Bug 1599318 - `TextEditor` shouldn't put `\r` into its anonymous text node r=m_kato 
Starting from bug 1597679, `HTMLTextAreaElement::GetValueInternal()` stops
converting `\r\n` and `\r` with `\n` because it may be in hot path and the scan
cost of `\r` in `nsContentUtils::PlatformToDOMLineBreaks()` is redundant in
most cases.

However, there are still some paths to input `\r`.  This patch makes them
call `nsContentUtils::PlatformToDOMLineBreaks()` if they have not done it.

Differential Revision: https://phabricator.services.mozilla.com/D54906

--HG--
extra : moz-landing-system : lando
 2019-11-28 05:51:41 +00:00
Masayuki Nakano 20699e2189 Bug 1597679 - part 2: Make `nsITextControlElement` inherit `nsGenericHTMLFormElementWithState` r=smaug 
Sub classes of `nsITextControlElement` are only `HTMLInputElement` and
`HTMLTextAreaElement`. And both base class is
`nsGenericHTMLFormElementWithState`.  Therefore, we can make
`nsITextControlElement` inherit `nsGenericHTMLFormElementWithState` and
make `HTMLInputElement` and `HTMLTextAreaElement` inherit
`nsITextControlElement`.  Then, we can get rid of a lot of QI between
`nsINode`/`nsIContent`/`Element` and `nsITextControlElement` (and note that
some of them in a hot path).

Additionally, this patch renames `nsITextControlElement` to
`mozilla::TextControlElement`.

Differential Revision: https://phabricator.services.mozilla.com/D54330

--HG--
rename : dom/html/nsITextControlElement.h => dom/html/TextControlElement.h
extra : moz-landing-system : lando
 2019-11-25 06:35:15 +00:00
Coroiu Cristina 84bf2b6d25 Backed out 3 changesets (bug 1597679) for Android debug build bustage at build/src/dom/base/nsContentAreaDragDrop.cpp 
Backed out changeset 6a73b58e0db4 (bug 1597679)
Backed out changeset 90a172eff2de (bug 1597679)
Backed out changeset d4a156cf28ff (bug 1597679)

--HG--
rename : dom/html/TextControlElement.h => dom/html/nsITextControlElement.h
 2019-11-24 09:02:53 +02:00
Masayuki Nakano eea1784f2d Bug 1597679 - part 2: Make `nsITextControlElement` inherit `nsGenericHTMLFormElementWithState` r=smaug 
Sub classes of `nsITextControlElement` are only `HTMLInputElement` and
`HTMLTextAreaElement`. And both base class is
`nsGenericHTMLFormElementWithState`.  Therefore, we can make
`nsITextControlElement` inherit `nsGenericHTMLFormElementWithState` and
make `HTMLInputElement` and `HTMLTextAreaElement` inherit
`nsITextControlElement`.  Then, we can get rid of a lot of QI between
`nsINode`/`nsIContent`/`Element` and `nsITextControlElement` (and note that
some of them in a hot path).

Additionally, this patch renames `nsITextControlElement` to
`mozilla::TextControlElement`.

Differential Revision: https://phabricator.services.mozilla.com/D54330

--HG--
rename : dom/html/nsITextControlElement.h => dom/html/TextControlElement.h
extra : moz-landing-system : lando
 2019-11-24 05:38:02 +00:00
Paul Zuehlcke 97a444cc97 Bug 1597541 - Added pref and disabled nsContentBlocker by default. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D53975

--HG--
extra : moz-landing-system : lando
 2019-11-22 14:32:44 +00:00
alwu 0d289c99b1 Bug 1596988 - remove telemetry ping 'AUTOPLAY_SITES_SETTING_CHANGE'. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D53752

--HG--
extra : moz-landing-system : lando
 2019-11-19 14:39:16 +00:00
Ehsan Akhgari 659d5a38ee Bug 1596843 - Part 4: Remove some native only methods from nsIPermissionManager; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53240

--HG--
extra : moz-landing-system : lando
 2019-11-17 22:22:34 +00:00
Ehsan Akhgari d3690a33cf Bug 1596843 - Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53239

--HG--
extra : moz-landing-system : lando
 2019-11-17 22:22:26 +00:00
Ehsan Akhgari 64828b7697 Bug 1596843 - Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53238

--HG--
extra : moz-landing-system : lando
 2019-11-17 22:22:24 +00:00
Ehsan Akhgari d793147c0c Bug 1596843 - Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53237

--HG--
extra : moz-landing-system : lando
 2019-11-17 22:22:21 +00:00
Moritz Birghan 975648e245 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN 
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
 2019-11-18 13:03:58 +00:00
Noemi Erli 117375bafe Backed out 4 changesets (bug 1596843) for causing nsPermissionManager related failures 
Backed out changeset 48577632f4b3 (bug 1596843)
Backed out changeset b9061f93d045 (bug 1596843)
Backed out changeset 691397c2fde6 (bug 1596843)
Backed out changeset 88e8383dc3e4 (bug 1596843)
 2019-11-17 23:00:23 +02:00
Ehsan Akhgari ce669bf3af Bug 1596843 - Part 4: Remove some native only methods from nsIPermissionManager; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53240

--HG--
extra : moz-landing-system : lando
 2019-11-17 20:06:11 +00:00
Ehsan Akhgari 5478509264 Bug 1596843 - Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53239

--HG--
extra : moz-landing-system : lando
 2019-11-17 20:06:08 +00:00
Ehsan Akhgari c05273a531 Bug 1596843 - Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53238

--HG--
extra : moz-landing-system : lando
 2019-11-17 20:06:06 +00:00
Ehsan Akhgari bab3fe707f Bug 1596843 - Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53237

--HG--
extra : moz-landing-system : lando
 2019-11-17 20:06:04 +00:00
Ehsan Akhgari 7abf369283 Bug 1595935 - Remove a couple of long expired telemetry probes from the permission manager; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D52762

--HG--
extra : moz-landing-system : lando
 2019-11-17 07:22:02 +00:00
Gurzau Raul 9c990aad98 Backed out 4 changesets (bug 1596843) for XPCShellTestsTests build bustage ona CLOSED TREE. 
Backed out changeset 69ee727d5b45 (bug 1596843)
Backed out changeset a9827fae8655 (bug 1596843)
Backed out changeset 8b2220bc47af (bug 1596843)
Backed out changeset b10aec041377 (bug 1596843)
 2019-11-17 11:07:15 +02:00
Ehsan Akhgari 0ad4207862 Bug 1596843 - Part 4: Remove some native only methods from nsIPermissionManager; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53240

--HG--
extra : moz-landing-system : lando
 2019-11-17 07:23:39 +00:00
Ehsan Akhgari 2e390a7aa7 Bug 1596843 - Part 3: Remove the unused nsIPermissionManager.updateExpireTime() method; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53239

--HG--
extra : moz-landing-system : lando
 2019-11-17 07:23:32 +00:00
Ehsan Akhgari a6b7fa0902 Bug 1596843 - Part 2: Stop exposing nsIPermissionManager.removePermissionsWithAttributes(); r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53238

--HG--
extra : moz-landing-system : lando
 2019-11-17 07:23:29 +00:00
Ehsan Akhgari 7664cbc2d4 Bug 1596843 - Part 1: Remove the unused nsIPermissionManager.testPermissionFromWindow() method; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D53237

--HG--
extra : moz-landing-system : lando
 2019-11-17 07:23:27 +00:00
Valentin Gosu eb1c1972b8 Bug 1595242 - Move the offthread negotiate auth to dispatch to the background thread pool r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D52904

--HG--
extra : moz-landing-system : lando
 2019-11-15 19:45:17 +00:00
Andrew McCreight c18473df1d Bug 1596834 - Use forceNewProcess in browser_permmgr_sync.js. r=mconley 
Also fix a few typos in comments.

Differential Revision: https://phabricator.services.mozilla.com/D53229

--HG--
extra : moz-landing-system : lando
 2019-11-15 17:24:11 +00:00
Michael Kaply fcf89c6721 Bug 1594584 - Marionette test for autoconfig. r=whimboo,kmag 
Differential Revision: https://phabricator.services.mozilla.com/D52106

--HG--
extra : moz-landing-system : lando
 2019-11-12 18:18:49 +00:00
Thomas Nguyen 17a6860942 Bug 1591113 - Remove support for third-party vibrate r=baku,snorp 
Differential Revision: https://phabricator.services.mozilla.com/D52531

--HG--
extra : moz-landing-system : lando
 2019-11-12 08:42:02 +00:00
Thomas Nguyen 7e65be9414 Bug 1583142 - Remove third-party "persistent-storage" prompting support r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D50908

--HG--
extra : moz-landing-system : lando
 2019-11-07 14:29:02 +00:00
Ciure Andrei c5a6643d39 Backed out changeset dde0354521ab (bug 1583142) for causing PermissionDelegateHandler.cpp bustages CLOSED TREE 2019-11-07 14:17:02 +02:00
Thomas Nguyen f431604a62 Bug 1583142 - Remove third-party "persistent-storage" prompting support r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D50908

--HG--
extra : moz-landing-system : lando
 2019-11-07 11:56:28 +00:00
Coroiu Cristina 27a753cc4a Backed out changeset 96048cce4b80 (bug 1571656) for xpcshell failures at toolkit/components/places/tests/unifiedcomplete/test_autofill_origins.js on a CLOSED TREE 2019-11-06 22:59:45 +02:00
Moritz Birghan 70c7a633fb Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN 
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
 2019-11-06 18:07:54 +00:00
Jorg K 376642ff2c Bug 1592922 - Fix typo in autoconfig's prefcalls.js. r=mkaply DONTBUILD 
Adding DONTBUILD for a one character change in a string.

Differential Revision: https://phabricator.services.mozilla.com/D51256

--HG--
extra : moz-landing-system : lando
 2019-10-31 16:18:57 +00:00
Paul Zuehlcke 7fcc94c765 Bug 1422056 - Put remaining permission userContextId OA stripping behind pref. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D50811

--HG--
extra : moz-landing-system : lando
 2019-10-30 12:21:14 +00:00
Ehsan Akhgari a8a01884db Bug 1591803 - Part 2: Rename nsIPermissionManager.enumerator to all and turn it into an Array; r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D50753

--HG--
extra : moz-landing-system : lando
 2019-10-29 01:56:25 +00:00
Arthur Iakab 9c93bb3a7a Backed out 2 changesets (bug 1591803) for causing build bustages on XULAlerts.cpp CLOSED TREE 
Backed out changeset 7eff50262110 (bug 1591803)
Backed out changeset c0b6f37d24d2 (bug 1591803)
 2019-10-29 03:37:07 +02:00
Ehsan Akhgari 8c1d9bf15d Bug 1591803 - Part 2: Rename nsIPermissionManager.enumerator to all and turn it into an Array; r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D50753

--HG--
extra : moz-landing-system : lando
 2019-10-28 20:26:21 +00:00
Ehsan Akhgari 05b288d47f Bug 1591746 - Make nsIPermissionManager.getAllForPrincipal() return an Array<> instead of an XPCOM enumerator; r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D50717

--HG--
extra : moz-landing-system : lando
 2019-10-29 01:13:57 +00:00
Arthur Iakab 470c5a07f1 Backed out 2 changesets (bug 1591803) for causing build busatges on PermissionManager.idl. CLOSED TREE 
Backed out changeset 060f159fa43d (bug 1591803)
Backed out changeset b53a3d8c408d (bug 1591803)
 2019-10-28 22:12:01 +02:00
Ehsan Akhgari f7eef9ebc5 Bug 1591803 - Part 2: Rename nsIPermissionManager.enumerator to all and turn it into an Array; r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D50753

--HG--
extra : moz-landing-system : lando
 2019-10-28 13:55:56 +00:00
Ehsan Akhgari 9a5d7b4dfa Bug 1589407 - Part 1: Avoid calling nsPermissionManager::GetAllForPrincipal() if no permissions are available in the current process; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D50710

--HG--
extra : moz-landing-system : lando
 2019-10-28 10:57:51 +00:00
Rob Wu 57e66afc2a Bug 1589754 - Rename nsGlobalWindowInner::GetTopLevelPrincipal r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D50068

--HG--
extra : moz-landing-system : lando
 2019-10-24 12:57:21 +00:00
Rob Wu 1884e2a75a Bug 1589754 - Fix permissions.query in top-level document r=tnguyen 
Differential Revision: https://phabricator.services.mozilla.com/D50067

--HG--
extra : moz-landing-system : lando
 2019-10-24 12:57:23 +00:00
Paul Zuehlcke 46e33fe965 Bug 1422056 - Added permission manager OA strip test. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D49960

--HG--
extra : moz-landing-system : lando
 2019-10-24 14:20:03 +00:00
Paul Zuehlcke c462a0fcba Bug 1422056 - Updated tests to account for permission manager OA stripping. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D48665

--HG--
extra : moz-landing-system : lando
 2019-10-24 14:19:57 +00:00
Paul Zuehlcke 7b483252bd Bug 1588461 - Added OA StripAttributes flag for privateBrowsingId. r=johannh,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D49174

--HG--
extra : moz-landing-system : lando
 2019-10-24 14:18:54 +00:00
Paul Zuehlcke b68b9d1297 Bug 1422056 - nsPermissionManager: Disabled OA stripping for private browsing and added OA strip prefs. r=johannh,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D48664

--HG--
extra : moz-landing-system : lando
 2019-10-25 10:26:45 +00:00
Narcis Beleuzu ba16f78901 Backed out 2 changesets (bug 1589754) for mochitest failures on test_notification_permissions.html CLOSED TREE 
Backed out changeset 120203cf34b0 (bug 1589754)
Backed out changeset 49e887cef91d (bug 1589754)

--HG--
extra : rebase_source : 9444ef674a85faec70c0d891caeb59af557d2de7
 2019-10-24 15:51:34 +03:00
Rob Wu bcccc1d738 Bug 1589754 - Rename nsGlobalWindowInner::GetTopLevelPrincipal r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D50068

--HG--
extra : moz-landing-system : lando
 2019-10-23 18:14:44 +00:00
Rob Wu fcb704f351 Bug 1589754 - Fix permissions.query in top-level document r=tnguyen 
Differential Revision: https://phabricator.services.mozilla.com/D50067

--HG--
extra : moz-landing-system : lando
 2019-10-23 16:12:13 +00:00
Emilio Cobos Álvarez 698db0028a Bug 1589327 - Remove some other various fennec-dependent code. r=snorp,botond 
Some of this may be able to be cleaned up further.

Differential Revision: https://phabricator.services.mozilla.com/D49587

--HG--
extra : moz-landing-system : lando
 2019-10-18 18:49:49 +00:00
Ehsan Akhgari dab85e2115 Bug 1588164 - Remove an unused declaration for nsPermissionManager::GetPermissionHashKey; r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D48991

--HG--
extra : moz-landing-system : lando
 2019-10-14 09:50:50 +00:00
Emilio Cobos Álvarez 536c1bc0bb Bug 1581467 - Fix checks for display: inline{,-block} which don't account for inline list items. r=mats 
Differential Revision: https://phabricator.services.mozilla.com/D48346

--HG--
extra : moz-landing-system : lando
 2019-10-12 21:05:16 +00:00
Perry Jiang d42e87a765 Bug 1587365 - Allow multiple callers to wait for permissions r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D49043

--HG--
extra : moz-landing-system : lando
 2019-10-12 03:21:41 +00:00
Brian Grinstead 5cfb7798a4 Bug 1586878 - Replace <xul:textbox> with <html:input> in test_add_remove_dictionaries.xul;r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D48419

--HG--
extra : moz-landing-system : lando
 2019-10-08 17:13:43 +00:00
Paul Zuehlcke c34871acfc Bug 1402957 - Removed URI based nsIPermissionManager methods. r=johannh,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D47254

--HG--
extra : moz-landing-system : lando
 2019-09-27 14:55:53 +00:00
Paul Zuehlcke abeca18f1c Bug 1402957 - Refactored nsIPermissionManager tests to use principals. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D47251

--HG--
rename : extensions/permissions/test/unit/test_permmanager_getAllForURI.js => extensions/permissions/test/unit/test_permmanager_getAllForPrincipal.js
extra : moz-landing-system : lando
 2019-09-27 09:48:39 +00:00
Sebastian Streich 88670a47e9 Bug 1580782 - Change Callsites to use nsIPrincipal->SchemeIs r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D45654

--HG--
extra : moz-landing-system : lando
 2019-09-26 10:47:16 +00:00
David Major 8f0fcd819e Bug 1583332 - Define HUNSPELL_STATIC to silence warnings on Windows about importing intra-DLL code r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D47069

--HG--
extra : moz-landing-system : lando
 2019-09-26 09:19:22 +00:00
Paul Zuehlcke 7dbb6cb72e Bug 1574473 - Updated nsContentBlocker::TestPermission to use LegacyTestPermissionFromURI. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D46180

--HG--
extra : moz-landing-system : lando
 2019-09-19 17:06:29 +00:00
Paul Zuehlcke 2189ac4496 Bug 1574469 - Implemented nsPermissionManager::LegacyTestPermissionFromURI for nsIURI queries with origin attributes. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D45847

--HG--
extra : moz-landing-system : lando
 2019-09-19 17:07:22 +00:00
Thomas Nguyen cf867199bc Bug 1560570- FeaturePolicy should be considered when permissions.query() is called r=baku,johannh 
Differential Revision: https://phabricator.services.mozilla.com/D44210

--HG--
extra : moz-landing-system : lando
 2019-09-21 08:38:26 +00:00
Henri Sivonen c193518677 Bug 1490601 part 2 - Move C++ entry points to encoding_c_mem to mfbt/. r=jwalden 
Differential Revision: https://phabricator.services.mozilla.com/D43957

--HG--
extra : moz-landing-system : lando
 2019-09-18 08:26:34 +00:00
Emma Malysz 6a694db9bd Bug 599996, remove nsPermissionManager::Import to avoid main-thread IO r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D45921

--HG--
extra : moz-landing-system : lando
 2019-09-17 15:22:55 +00:00
Makoto Kato 50895a5db7 Bug 1571339 - Don't use nsTextFragment::AppendTo to get string in TextNodeContainsDOMWordSeparator. r=masayuki 
Actually, spellchecker always allocates the heap to get text from text node. But it is unnecessary to allocate another heap here since `WordSplitState` walks text only and it is stack class.

If text is in '<textarea>', text node may be too large, so we shouldn't allocate memory to walk character in `WordSplitState` if possible. Because `TextNodeContainsDOMWordSeparator` will be called per input.

And `mWordUtil` is unused, so we should remove it.

Differential Revision: https://phabricator.services.mozilla.com/D42257

--HG--
extra : moz-landing-system : lando
 2019-09-09 03:42:45 +00:00
Tom Ritter d922064696 Bug 1547519 - Rename NS_STRINGIFY to MOZ_STRINGIFY, move to mfbt, and unify stragglers r=glandium 
Differential Revision: https://phabricator.services.mozilla.com/D39961

--HG--
extra : moz-landing-system : lando
 2019-09-04 02:40:32 +00:00
Dylan Roeh 9f71be1805 Bug 1572191 - Prevent nsPermissionManager from persisting certain permissions to disk under GeckoView. r=snorp,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D43759

--HG--
extra : moz-landing-system : lando
 2019-08-30 21:41:47 +00:00
Ehsan Akhgari c771ae8334 Bug 1572240 - Part 6: Remove nsIPermissionManager.testPermissionOriginNoSuffix; r=baku 
This is now dead code which will be kept alive by the vtable,
and introduces needless overhead inside the permission manager.

Differential Revision: https://phabricator.services.mozilla.com/D42207

--HG--
extra : moz-landing-system : lando
 2019-08-19 14:38:47 +00:00
Ciure Andrei 9a123fb597 Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE 2019-08-19 13:00:44 +03:00
Moritz Birghan 240771fa29 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN 
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
 2019-08-19 07:17:12 +00:00
Paul Zuehlcke f2675da6d6 Bug 1531303 - Implemented a PermissionTestUtils module. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D41028

--HG--
extra : moz-landing-system : lando
 2019-08-15 14:32:46 +00:00
Ciure Andrei b454daea7a Backed out 3 changesets (bug 1531303) for causing close_window/close.py and browser_permissions_dialog.js to perma fail CLOSED TREE 
Backed out changeset 87305e83174e (bug 1531303)
Backed out changeset 0c75c3bac00b (bug 1531303)
Backed out changeset 865c2a5d40da (bug 1531303)
 2019-08-14 13:07:55 +03:00
Paul Zuehlcke 160cf2c1df Bug 1531303 - Implemented a PermissionTestUtils module. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D41028

--HG--
extra : moz-landing-system : lando
 2019-08-14 08:36:41 +00:00
Tom Schuster 0e913c22c4 Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D40677

--HG--
extra : moz-landing-system : lando
 2019-08-07 19:49:40 +00:00
Cosmin Sabou c3430326e6 Backed out changeset ca88862d6b63 (bug 1558915) for causing build bustages on StartupCacheUtils. CLOSED TREE 2019-08-07 13:20:32 +03:00
Tom Schuster 8bc1f5ada8 Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D40677

--HG--
extra : moz-landing-system : lando
 2019-08-07 09:36:56 +00:00
Razvan Maries eedbf1137f Backed out changeset b197ca57677a (bug 1558915) for build bustages. CLOSED TREE 2019-08-07 01:04:43 +03:00
Tom Schuster 03c7998ef2 Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D40677

--HG--
extra : moz-landing-system : lando
 2019-08-06 20:19:41 +00:00
Makoto Kato 79bf4210ee Bug 1565919 - Don't separate words by contextual-based character. r=Ehsan 
Original regression was by bug 1362858, and bug 1418629 wasn't enough to fix.

By bug 1362858, we use `CHAR_CLASS_SEPARATOR` in additional to DOM word separator. But some characters such as single quote, `@` and etc are `CHAR_CLASS_SEPARATOR`, so we may check spell by incomplete word.

We shouldn't separate word by characters that is email part, URL part or conditional punctuation.

And I also update test cases for this situation. `<textarea>` is better for spell checking since it can has multiple anonymous text nodes.

Differential Revision: https://phabricator.services.mozilla.com/D39829

--HG--
extra : moz-landing-system : lando
 2019-08-03 13:44:56 +00:00
Jorg K 864c351bc8 Bug 1570719 - Skip more elements in spellcheck for MailNews. r=masayuki 2019-08-02 10:49:17 +02:00
Kris Maglione 0962c2b731 Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8 
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
 2019-07-15 16:19:32 -07:00
Gurzau Raul 21df1f7413 Merge inbound to mozilla-central. a=merge 2019-07-17 06:48:50 +03:00
Mirko Brodesser 8135a5859f Bug 1566046: move `nsContentUtils::ContentIsShadowIncludingDescendantOf` to `nsINode::IsShadowIncludingInclusiveDescendantOf`. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D38079
 2019-07-16 09:25:02 +02:00
Noemi Erli af897e281a Merge inbound to mozilla-central. a=merge 2019-07-16 00:42:51 +03:00
Mirko Brodesser 2f40f072ab Bug 1565584: move `nsIContentUtils::ContentIsDescendantOf` to `nsINode::IsInclusiveDescendantOf`. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D37880
 2019-07-15 10:02:21 +02:00
Barret Rennie c1d06a6c0c Bug 1289211 - Rename InfallibleTArray to nsTArray in extensions/spellcheck/ r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D36952

--HG--
extra : moz-landing-system : lando
 2019-07-10 03:28:47 +00:00
Boris Zbarsky 5062731c15 Bug 1565688. Remove unused IOService arg from NS_NewURI. r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D37968

--HG--
extra : moz-landing-system : lando
 2019-07-15 13:39:51 +00:00
Sylvestre Ledru e77bfc655d Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D38057

--HG--
extra : moz-landing-system : lando
 2019-07-16 07:33:44 +00:00
Ryan VanderMeulen d4d246dca3 Bug 1517477 - Upgrade Hunspell to version 1.7.0. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D15652

--HG--
extra : moz-landing-system : lando
 2019-07-03 16:18:23 +00:00
Jonathan Kingston 31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
 2019-07-08 16:37:45 +00:00
Alex Catarineu dbce01f2ff Bug 467035 - Add new internal DTD content types r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D35232

--HG--
extra : moz-landing-system : lando
 2019-07-03 17:28:25 +00:00
Sylvestre Ledru fc2eb5393c Bug 1562642 - Part 2 - Add missing MPL2 headers r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D37146

--HG--
extra : moz-landing-system : lando
 2019-07-08 09:27:47 +00:00
Victor Porof 5af464dcc4 Bug 1561435 - Format extensions/, a=automatic-formatting 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35902

--HG--
extra : source : 31cb194f2a6651332aa71a41c0f06a29daf8a186
 2019-07-05 10:46:07 +02:00
Mirko Brodesser 6b67de025f Bug 1562876: rename `Selection::RemoveRange` to `Selection::RemoveRangeAndUnselectFramesAndNotifyListeners`. r=smaug 
The name of the corresponding webidl interface of course remains unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D36607
 2019-07-03 13:26:14 +02:00
Mirko Brodesser 63b4627d28 Bug 1562876: rename `Selection::AddRange` to `Selection::AddRangeAndSelectFramesAndNotifyListeners`. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D36602
 2019-07-03 13:26:13 +02:00
Masayuki Nakano da61ea3112 Bug 1444847 - part 3: Create `RangeUtils` to place public static methods of `nsRange` r=smaug 
Some `nsRange` static methods are useful in `StaticRange` and some of them
are used in a lot of places but not related to `nsRange` directly.  This
patch moves them into new static method only class, `mozilla::RangeUtils`.

Differential Revision: https://phabricator.services.mozilla.com/D35142

--HG--
extra : moz-landing-system : lando
 2019-06-28 07:48:07 +00:00
Makoto Kato 5f9abd3366 Bug 1444847 - part 1: Create `mozilla::dom::AbstractRange` r=smaug 
This patch is based on the patch created by Makoto Kato-san.

`Range` and `StaticRange` have common base interface, `AbstractRange`.
https://dom.spec.whatwg.org/#abstractrange

This interface has simply returns `startContainer`, `endContainer`,
`startOffset`, `endOffset` and `collapsed`.

Different from the original patch's approach, this patch moves related
members in `nsRange` to `AbstractRange` since this approach avoids
virtual call cost.  Additionally, this patch makes them not throw as
declared by the spec.  As far as I know, the destruction cost of
`ErrorResult` may appear in profile so that we should avoid creating
the instance if we can avoid it.

Unfortunately, the instance size of `nsRange` becomes larger with this
patch.  The size is changed from 176 to 184.  I.e., now, `nsRange`
requires bigger chunk.

Differential Revision: https://phabricator.services.mozilla.com/D35140

--HG--
extra : moz-landing-system : lando
 2019-06-28 07:46:35 +00:00
Makoto Kato cb97dec989 Bug 1560517 - Update LICENSE, README and license.hunspell to 1.6.1 r=RyanVM 
No one includes `license.hunspell`, so we don't need our custimze block (`#include "config.h"`)

Also, some files isn't updated to 1.6.1, so we should update it.

Depends on D35516

Differential Revision: https://phabricator.services.mozilla.com/D35517

--HG--
extra : moz-landing-system : lando
 2019-06-21 14:26:53 +00:00
Makoto Kato e20f6f80c7 Bug 1560517 - Add update script and patch files for hunspell library r=masayuki 
Add `update.sh` script and patch files to update hunspell library easily.

Differential Revision: https://phabricator.services.mozilla.com/D35516

--HG--
extra : moz-landing-system : lando
 2019-06-21 18:57:35 +00:00
Boris Zbarsky 9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike 
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
 2019-06-11 15:51:51 +00:00
Boris Zbarsky dc2b7685d7 Bug 1557231. Stop using [array] in nsIInlineSpellChecker. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D33908

--HG--
extra : moz-landing-system : lando
 2019-06-06 06:59:37 +00:00
Boris Zbarsky d0cff2d0c6 Bug 1556925 part 2. Stop using [array] in mozISpellCheckingEngine.getDictionaryList. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D33744

--HG--
extra : moz-landing-system : lando
 2019-06-05 12:57:32 +00:00
Boris Zbarsky bfd87b53d8 Bug 1556925 part 1. Stop using [array] in mozISpellCheckingEngine.suggest. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D33743

--HG--
extra : moz-landing-system : lando
 2019-06-05 12:50:13 +00:00
Boris Zbarsky 9b956f652d Bug 1556922. Stop using [array] in nsIEditorSpellCheck. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D33742

--HG--
extra : moz-landing-system : lando
 2019-06-05 04:07:28 +00:00
Cosmin Sabou e13e0af55b Merge mozilla-inbound to mozilla-central. a=merge 2019-06-03 19:01:53 +03:00
Henri Sivonen 3c70419a2b Bug 1543077 part 3 - Remove the old Japanese detector from the tree. r=emk. 
Differential Revision: https://phabricator.services.mozilla.com/D27794
 2019-06-03 15:30:41 +03:00
Andrea Marchesini 0a9fe4ff98 Bug 1553867 - Reduce the number of ClonePrincipalForPermission() call in CookieSettings, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D32364

--HG--
extra : moz-landing-system : lando
 2019-06-03 11:14:38 +00:00
Cosmin Sabou 482c1fdb41 Backed out 2 changesets (bug 1554527, bug 1553867) as requested by Sylvestre for causing huge perf regressions. a=backout 
Backed out changeset 1e85291f97de (bug 1554527)
Backed out changeset daf113171d63 (bug 1553867)
 2019-05-29 09:57:29 +03:00
Mihai Alexandru Michis 1dd6cb6ee5 Backed out 6 changesets (bug 1543077) for causing bc failures at docshell/test/browser/browser_bug1543077.js 
Backed out changeset f593045cc48f (bug 1543077)
Backed out changeset 25449ba8aceb (bug 1543077)
Backed out changeset ccc438262e29 (bug 1543077)
Backed out changeset 4573c25b1ce0 (bug 1543077)
Backed out changeset 1cbaafb9373a (bug 1543077)
Backed out changeset 1a0e7ced8e47 (bug 1543077)

--HG--
extra : rebase_source : f04bf405303fe03776f0e70b03db076c0a41ae45
 2019-05-27 12:00:21 +03:00
Henri Sivonen 1447a771cc Bug 1543077 part 3 - Remove the old Japanese detector from the tree. r=emk 
Depends on D27793

Differential Revision: https://phabricator.services.mozilla.com/D27794

--HG--
extra : moz-landing-system : lando
 2019-05-27 07:55:25 +00:00
Liang-Heng Chen 5b28bc4e4b Bug 1330467 - part 7. Confirm FPI in permission manager tests; r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D19928

--HG--
extra : moz-landing-system : lando
 2019-05-17 13:23:02 +00:00
Liang-Heng Chen c42628e988 Bug 1330467 - part 1. Don't strip first party domain from permissions key; r=johannh,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D19922

--HG--
extra : moz-landing-system : lando
 2019-05-17 13:23:16 +00:00
Andrea Marchesini c926d65d2f Bug 1553867 - Reduce the number of ClonePrincipalForPermission() call in CookieSettings, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D32364

--HG--
extra : moz-landing-system : lando
 2019-05-24 19:05:35 +00:00
Mark Banner 6971980f49 Bug 1554121 - Enable most ESLint rules for extensions/permissions, extensions/spellcheck and extensions/universalchardet. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D32450

--HG--
extra : moz-landing-system : lando
 2019-05-24 17:17:02 +00:00
Mihai Alexandru Michis 97df17e745 Backed out 11 changesets (bug 1330467) as requested by xeonchen on IRC. CLOSED TREE 
Backed out changeset 0229d5353d50 (bug 1330467)
Backed out changeset 2f2308fe5747 (bug 1330467)
Backed out changeset 2cd09bae2bdf (bug 1330467)
Backed out changeset 2648f5bb1804 (bug 1330467)
Backed out changeset 4686eebd8962 (bug 1330467)
Backed out changeset b43fa07d5756 (bug 1330467)
Backed out changeset 35d96a4ff659 (bug 1330467)
Backed out changeset 6ac44130d2bb (bug 1330467)
Backed out changeset f939c61e051f (bug 1330467)
Backed out changeset 0ae215d91758 (bug 1330467)
Backed out changeset 1d48bdbb4035 (bug 1330467)
 2019-05-17 16:19:06 +03:00
Andrea Marchesini 6cd7a6d9dd Bug 1549912 - Support downgrade versioning of permissions database, r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D31192

--HG--
extra : moz-landing-system : lando
 2019-05-16 19:51:34 +00:00
Oana Pop Rus 39769bf17e Backed out changeset f8dfee6dc6e5 (bug 1549912) for xpcshell failure on test_permmanager_migrate_9-10.js CLOSE TREE. 2019-05-16 22:04:19 +03:00
Andrea Marchesini 221097ff40 Bug 1549912 - Support downgrade versioning of permissions database, r=mayhemer 
Differential Revision: https://phabricator.services.mozilla.com/D31192

--HG--
extra : moz-landing-system : lando
 2019-05-16 14:24:45 +00:00
Liang-Heng Chen 55a638f5b0 Bug 1330467 - part 7. Confirm FPI in permission manager tests; r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D19928

--HG--
extra : moz-landing-system : lando
 2019-05-07 22:18:56 +00:00
Liang-Heng Chen bcff5a6630 Bug 1330467 - part 1. Don't strip first party domain from permissions key; r=johannh,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D19922

--HG--
extra : moz-landing-system : lando
 2019-05-08 13:41:57 +00:00
Makoto Kato d75677fa6d Bug 1524443 - Hold mozSpellChecker when using async IPC. r=masayuki 
When using `CheckAsync` IPC, we don't hold `mozSpellChecker`. It causes that
`mozSpellChecker` may be destroyed during IPC call.

The destructor of `mozSpellChecker` destroys actor of spellchecker IPC via
`Send__delete__`. Although IPC rejects pending promises of async IPC during
destroying actor, it cannot remove replay messages from parent process.
So route error occurs.

So we have to keep `mozSpellChecker` during async IPC.

And we cannot convert attached test case to crashtest or mochitest since this
depends on navigation and timing. So I don't add it.

Differential Revision: https://phabricator.services.mozilla.com/D30347

--HG--
extra : moz-landing-system : lando
 2019-05-08 13:21:55 +00:00
Makoto Kato bda6300874 Bug 1418629 - Single quotation mark shouldn't always separator. r=Ehsan 
This seems to be regression by bug 1362858.

Actually, single quotation mark is always separator for spellchecker after
landing bug 1462858. When user tries to input "doesn't",  "'" becomes separator
for spellchecker. Then "doesn" will be misspell word.

So we shouldn't mark single quotation mark as separator if user is inputting
word.

Differential Revision: https://phabricator.services.mozilla.com/D29153

--HG--
extra : moz-landing-system : lando
 2019-05-08 09:36:05 +00:00
Andrea Marchesini d08ebf5a40 Bug 1320404 - Remove appId from origin attributes - part 3 - Permissionmanager, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D29355

--HG--
extra : moz-landing-system : lando
 2019-05-03 17:14:21 +00:00
Andrea Marchesini f8565bf748 Bug 1320404 - Remove appId from origin attributes - part 1 - OriginAttributes and nsIPrincipal, r=Ehsan,flod 
Differential Revision: https://phabricator.services.mozilla.com/D29353

--HG--
extra : moz-landing-system : lando
 2019-05-03 17:13:17 +00:00
Bogdan Tara 386d23bfe7 Backed out 4 changesets (bug 1320404) for test_permmanager_load_invalid_entries.js failures 
Backed out changeset 7c2f4e64d38e (bug 1320404)
Backed out changeset a7e7c0251179 (bug 1320404)
Backed out changeset dd741b25a244 (bug 1320404)
Backed out changeset de9073c57d20 (bug 1320404)
 2019-05-03 06:12:25 +03:00
Andrea Marchesini fdc4e5b220 Bug 1320404 - Remove appId from origin attributes - part 3 - Permissionmanager, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D29355

--HG--
extra : moz-landing-system : lando
 2019-05-02 17:24:59 +00:00
Andrea Marchesini 138cee6dea Bug 1320404 - Remove appId from origin attributes - part 1 - OriginAttributes and nsIPrincipal, r=Ehsan,flod 
Differential Revision: https://phabricator.services.mozilla.com/D29353

--HG--
extra : moz-landing-system : lando
 2019-05-02 17:24:51 +00:00
Andrea Marchesini 4d844a27d0 Bug 1548580 - Remove a startup warning in PermissionManager, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D29682

--HG--
extra : moz-landing-system : lando
 2019-05-02 16:28:14 +00:00
Cosmin Sabou a884fb99d8 Backed out 4 changesets (bug 1320404) for xperf failures on permissions.sqlite-journal. 
Backed out changeset fbacf18b6532 (bug 1320404)
Backed out changeset fed7c475d75c (bug 1320404)
Backed out changeset 557b586f774a (bug 1320404)
Backed out changeset 5a20b5f43280 (bug 1320404)
 2019-05-02 04:51:18 +03:00
Andrea Marchesini 181c865701 Bug 1320404 - Remove appId from origin attributes - part 3 - Permissionmanager, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D29355

--HG--
extra : moz-landing-system : lando
 2019-05-01 23:21:56 +00:00
Andrea Marchesini 7e61125d8f Bug 1320404 - Remove appId from origin attributes - part 1 - OriginAttributes and nsIPrincipal, r=Ehsan,flod 
Differential Revision: https://phabricator.services.mozilla.com/D29353

--HG--
extra : moz-landing-system : lando
 2019-05-01 23:21:45 +00:00
Sylvestre Ledru e226046cb8 Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan 
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956

--HG--
extra : moz-landing-system : lando
 2019-05-01 08:47:10 +00:00
Ehsan Akhgari c541551107 Bug 1547397 - Part 3: Move the permission manager code to extensions/permissions; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D29116

--HG--
rename : extensions/cookie/nsPermission.cpp => extensions/permissions/nsPermission.cpp
rename : extensions/cookie/nsPermission.h => extensions/permissions/nsPermission.h
rename : extensions/cookie/nsPermissionManager.cpp => extensions/permissions/nsPermissionManager.cpp
rename : extensions/cookie/nsPermissionManager.h => extensions/permissions/nsPermissionManager.h
rename : extensions/cookie/test/.eslintrc.js => extensions/permissions/test/.eslintrc.js
rename : extensions/cookie/test/browser.ini => extensions/permissions/test/browser.ini
rename : extensions/cookie/test/browser_permmgr_sync.js => extensions/permissions/test/browser_permmgr_sync.js
rename : extensions/cookie/test/browser_permmgr_viewsrc.js => extensions/permissions/test/browser_permmgr_viewsrc.js
rename : extensions/cookie/test/gtest/PermissionManagerTest.cpp => extensions/permissions/test/gtest/PermissionManagerTest.cpp
rename : extensions/cookie/test/gtest/moz.build => extensions/permissions/test/gtest/moz.build
rename : extensions/cookie/test/moz.build => extensions/permissions/test/moz.build
rename : extensions/cookie/test/unit/test_permmanager_cleardata.js => extensions/permissions/test/unit/test_permmanager_cleardata.js
rename : extensions/cookie/test/unit/test_permmanager_default_pref.js => extensions/permissions/test/unit/test_permmanager_default_pref.js
rename : extensions/cookie/test/unit/test_permmanager_defaults.js => extensions/permissions/test/unit/test_permmanager_defaults.js
rename : extensions/cookie/test/unit/test_permmanager_expiration.js => extensions/permissions/test/unit/test_permmanager_expiration.js
rename : extensions/cookie/test/unit/test_permmanager_getAllForURI.js => extensions/permissions/test/unit/test_permmanager_getAllForURI.js
rename : extensions/cookie/test/unit/test_permmanager_getAllWithTypePrefix.js => extensions/permissions/test/unit/test_permmanager_getAllWithTypePrefix.js
rename : extensions/cookie/test/unit/test_permmanager_getPermissionObject.js => extensions/permissions/test/unit/test_permmanager_getPermissionObject.js
rename : extensions/cookie/test/unit/test_permmanager_idn.js => extensions/permissions/test/unit/test_permmanager_idn.js
rename : extensions/cookie/test/unit/test_permmanager_load_invalid_entries.js => extensions/permissions/test/unit/test_permmanager_load_invalid_entries.js
rename : extensions/cookie/test/unit/test_permmanager_local_files.js => extensions/permissions/test/unit/test_permmanager_local_files.js
rename : extensions/cookie/test/unit/test_permmanager_matches.js => extensions/permissions/test/unit/test_permmanager_matches.js
rename : extensions/cookie/test/unit/test_permmanager_matchesuri.js => extensions/permissions/test/unit/test_permmanager_matchesuri.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_4-7.js => extensions/permissions/test/unit/test_permmanager_migrate_4-7.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_4-7_no_history.js => extensions/permissions/test/unit/test_permmanager_migrate_4-7_no_history.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_5-7a.js => extensions/permissions/test/unit/test_permmanager_migrate_5-7a.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_5-7b.js => extensions/permissions/test/unit/test_permmanager_migrate_5-7b.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_6-7a.js => extensions/permissions/test/unit/test_permmanager_migrate_6-7a.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_6-7b.js => extensions/permissions/test/unit/test_permmanager_migrate_6-7b.js
rename : extensions/cookie/test/unit/test_permmanager_migrate_7-8.js => extensions/permissions/test/unit/test_permmanager_migrate_7-8.js
rename : extensions/cookie/test/unit/test_permmanager_notifications.js => extensions/permissions/test/unit/test_permmanager_notifications.js
rename : extensions/cookie/test/unit/test_permmanager_removeall.js => extensions/permissions/test/unit/test_permmanager_removeall.js
rename : extensions/cookie/test/unit/test_permmanager_removebytype.js => extensions/permissions/test/unit/test_permmanager_removebytype.js
rename : extensions/cookie/test/unit/test_permmanager_removebytypesince.js => extensions/permissions/test/unit/test_permmanager_removebytypesince.js
rename : extensions/cookie/test/unit/test_permmanager_removeforapp.js => extensions/permissions/test/unit/test_permmanager_removeforapp.js
rename : extensions/cookie/test/unit/test_permmanager_removepermission.js => extensions/permissions/test/unit/test_permmanager_removepermission.js
rename : extensions/cookie/test/unit/test_permmanager_removesince.js => extensions/permissions/test/unit/test_permmanager_removesince.js
rename : extensions/cookie/test/unit/test_permmanager_subdomains.js => extensions/permissions/test/unit/test_permmanager_subdomains.js
rename : extensions/cookie/test/unit/xpcshell.ini => extensions/permissions/test/unit/xpcshell.ini
extra : moz-landing-system : lando
 2019-04-30 14:06:53 +00:00
Ehsan Akhgari 868c13b5e5 Bug 1547397 - Part 2: Move some xpcshell tests for cookies out of extensions/cookies; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D29115

--HG--
rename : extensions/cookie/test/unit/head_cookies.js => netwerk/test/unit/head_cookies.js
rename : extensions/cookie/test/unit/test_bug526789.js => netwerk/test/unit/test_bug526789.js
rename : extensions/cookie/test/unit/test_bug650522.js => netwerk/test/unit/test_bug650522.js
rename : extensions/cookie/test/unit/test_bug667087.js => netwerk/test/unit/test_bug667087.js
rename : extensions/cookie/test/unit/test_cookies_async_failure.js => netwerk/test/unit/test_cookies_async_failure.js
rename : extensions/cookie/test/unit/test_cookies_persistence.js => netwerk/test/unit/test_cookies_persistence.js
rename : extensions/cookie/test/unit/test_cookies_privatebrowsing.js => netwerk/test/unit/test_cookies_privatebrowsing.js
rename : extensions/cookie/test/unit/test_cookies_profile_close.js => netwerk/test/unit/test_cookies_profile_close.js
rename : extensions/cookie/test/unit/test_cookies_read.js => netwerk/test/unit/test_cookies_read.js
rename : extensions/cookie/test/unit/test_cookies_sync_failure.js => netwerk/test/unit/test_cookies_sync_failure.js
rename : extensions/cookie/test/unit/test_cookies_thirdparty.js => netwerk/test/unit/test_cookies_thirdparty.js
rename : extensions/cookie/test/unit/test_cookies_thirdparty_nonsecure_session.js => netwerk/test/unit/test_cookies_thirdparty_nonsecure_session.js
rename : extensions/cookie/test/unit/test_cookies_thirdparty_session.js => netwerk/test/unit/test_cookies_thirdparty_session.js
rename : extensions/cookie/test/unit/test_domain_eviction.js => netwerk/test/unit/test_domain_eviction.js
rename : extensions/cookie/test/unit/test_eviction.js => netwerk/test/unit/test_eviction.js
rename : extensions/cookie/test/unit/test_schema_2_migration.js => netwerk/test/unit/test_schema_2_migration.js
rename : extensions/cookie/test/unit/test_schema_3_migration.js => netwerk/test/unit/test_schema_3_migration.js
extra : moz-landing-system : lando
 2019-04-30 14:06:27 +00:00
Ehsan Akhgari 3252b3943e Bug 1547397 - Part 1: Move some mochitests and browser-chrome tests for cookies out of extensions/cookies; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D29117

--HG--
rename : extensions/cookie/test/browser_test_favicon.js => netwerk/test/browser/browser_test_favicon.js
rename : extensions/cookie/test/damonbowling.jpg => netwerk/test/browser/damonbowling.jpg
rename : extensions/cookie/test/damonbowling.jpg^headers^ => netwerk/test/browser/damonbowling.jpg^headers^
rename : extensions/cookie/test/beltzner.jpg => netwerk/test/mochitests/beltzner.jpg
rename : extensions/cookie/test/beltzner.jpg^headers^ => netwerk/test/mochitests/beltzner.jpg^headers^
rename : extensions/cookie/test/file_chromecommon.js => netwerk/test/mochitests/file_chromecommon.js
rename : extensions/cookie/test/file_domain_hierarchy_inner.html => netwerk/test/mochitests/file_domain_hierarchy_inner.html
rename : extensions/cookie/test/file_domain_hierarchy_inner_inner.html => netwerk/test/mochitests/file_domain_hierarchy_inner_inner.html
rename : extensions/cookie/test/file_domain_hierarchy_inner_inner_inner.html => netwerk/test/mochitests/file_domain_hierarchy_inner_inner_inner.html
rename : extensions/cookie/test/file_domain_inner.html => netwerk/test/mochitests/file_domain_inner.html
rename : extensions/cookie/test/file_domain_inner_inner.html => netwerk/test/mochitests/file_domain_inner_inner.html
rename : extensions/cookie/test/file_image_inner.html => netwerk/test/mochitests/file_image_inner.html
rename : extensions/cookie/test/file_image_inner_inner.html => netwerk/test/mochitests/file_image_inner_inner.html
rename : extensions/cookie/test/file_loadflags_inner.html => netwerk/test/mochitests/file_loadflags_inner.html
rename : extensions/cookie/test/file_localhost_inner.html => netwerk/test/mochitests/file_localhost_inner.html
rename : extensions/cookie/test/file_loopback_inner.html => netwerk/test/mochitests/file_loopback_inner.html
rename : extensions/cookie/test/file_subdomain_inner.html => netwerk/test/mochitests/file_subdomain_inner.html
rename : extensions/cookie/test/file_testcommon.js => netwerk/test/mochitests/file_testcommon.js
rename : extensions/cookie/test/file_testloadflags.js => netwerk/test/mochitests/file_testloadflags.js
rename : extensions/cookie/test/file_testloadflags_chromescript.js => netwerk/test/mochitests/file_testloadflags_chromescript.js
rename : extensions/cookie/test/image1.png => netwerk/test/mochitests/image1.png
rename : extensions/cookie/test/image1.png^headers^ => netwerk/test/mochitests/image1.png^headers^
rename : extensions/cookie/test/image1.png => netwerk/test/mochitests/image2.png
rename : extensions/cookie/test/image2.png^headers^ => netwerk/test/mochitests/image2.png^headers^
rename : extensions/cookie/test/test1.css => netwerk/test/mochitests/test1.css
rename : extensions/cookie/test/test1.css^headers^ => netwerk/test/mochitests/test1.css^headers^
rename : extensions/cookie/test/test1.css => netwerk/test/mochitests/test2.css
rename : extensions/cookie/test/test2.css^headers^ => netwerk/test/mochitests/test2.css^headers^
rename : extensions/cookie/test/test_different_domain_in_hierarchy.html => netwerk/test/mochitests/test_different_domain_in_hierarchy.html
rename : extensions/cookie/test/test_differentdomain.html => netwerk/test/mochitests/test_differentdomain.html
rename : extensions/cookie/test/test_image.html => netwerk/test/mochitests/test_image.html
rename : extensions/cookie/test/test_loadflags.html => netwerk/test/mochitests/test_loadflags.html
rename : extensions/cookie/test/test_same_base_domain.html => netwerk/test/mochitests/test_same_base_domain.html
rename : extensions/cookie/test/test_same_base_domain_2.html => netwerk/test/mochitests/test_same_base_domain_2.html
rename : extensions/cookie/test/test_same_base_domain_3.html => netwerk/test/mochitests/test_same_base_domain_3.html
rename : extensions/cookie/test/test_same_base_domain_4.html => netwerk/test/mochitests/test_same_base_domain_4.html
rename : extensions/cookie/test/test_same_base_domain_5.html => netwerk/test/mochitests/test_same_base_domain_5.html
rename : extensions/cookie/test/test_same_base_domain_6.html => netwerk/test/mochitests/test_same_base_domain_6.html
rename : extensions/cookie/test/test_samedomain.html => netwerk/test/mochitests/test_samedomain.html
extra : moz-landing-system : lando
 2019-04-30 14:07:12 +00:00
Ehsan Akhgari bba7e3c8b0 Bug 1547114 - Part 8: Move nsCookiePermission to netwerk/cookie; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D29078

--HG--
rename : extensions/cookie/nsCookiePermission.cpp => netwerk/cookie/nsCookiePermission.cpp
rename : extensions/cookie/nsCookiePermission.h => netwerk/cookie/nsCookiePermission.h
extra : moz-landing-system : lando
 2019-04-26 22:31:57 +00:00
Ehsan Akhgari a18d1e13f4 Bug 1547114 - Part 7: Get rid of nsCookieModule.h/cpp; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D28998

--HG--
extra : moz-landing-system : lando
 2019-04-26 15:42:24 +00:00
Ehsan Akhgari 31a8a7053e Bug 1547114 - Part 6: Convert network.cookie.lifetimePolicy into a static pref; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D28997

--HG--
extra : moz-landing-system : lando
 2019-04-26 15:42:01 +00:00
Ehsan Akhgari c8fea1ecad Bug 1547114 - Part 5: Remove nsICookiePermission::CanAccess(); r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D28996

--HG--
extra : moz-landing-system : lando
 2019-04-26 15:41:07 +00:00
Ehsan Akhgari 2fbc24f3bc Bug 1547114 - Part 3: Remove nsCookiePermission::mThirdPartyUtil; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D28916

--HG--
extra : moz-landing-system : lando
 2019-04-26 15:49:21 +00:00
Ehsan Akhgari ee308fca8a Bug 1547114 - Part 2: Read the cookie lifetime policy from nsContentUtils; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D28915

--HG--
extra : moz-landing-system : lando
 2019-04-26 15:49:19 +00:00
Ehsan Akhgari 565bc7aba8 Bug 1547114 - Part 1: Remove nsICookiePermission::CanAccessURI(); r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D28914

--HG--
extra : moz-landing-system : lando
 2019-04-26 15:49:17 +00:00
Andreea Pavel 81b8902215 Backed out 4 changesets (bug 1547114) for multiple failures e.g. xpcshell at test_SitePermissions.js on a CLOSED TREE 
Backed out changeset 4167117f548f (bug 1547114)
Backed out changeset 0a4180b074ea (bug 1547114)
Backed out changeset c92df939a4d6 (bug 1547114)
Backed out changeset fc4e5936eeae (bug 1547114)
 2019-04-26 18:35:28 +03:00
Ehsan Akhgari 502f90b3a8 Bug 1547114 - Part 3: Remove nsCookiePermission::mThirdPartyUtil; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D28916

--HG--
extra : moz-landing-system : lando
 2019-04-26 12:02:21 +00:00
Ehsan Akhgari 29825d4324 Bug 1547114 - Part 2: Read the cookie lifetime policy from nsContentUtils; r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D28915

--HG--
extra : moz-landing-system : lando
 2019-04-26 14:30:27 +00:00
Ehsan Akhgari 9421931e25 Bug 1547114 - Part 1: Remove nsICookiePermission::CanAccessURI(); r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D28914

--HG--
extra : moz-landing-system : lando
 2019-04-26 12:02:20 +00:00
Honza Bambas 5f945421d4 Bug 1493599 - Expose reason of security blocking on nsILoadInfo and add new http observer notification for failed asyncOpens, r=Honza,dragana 
Differential Revision: https://phabricator.services.mozilla.com/D23150

--HG--
extra : moz-landing-system : lando
 2019-04-26 10:59:41 +00:00
Andrew McCreight f242e71c8a Bug 1545822 - Clean up some whitespace in XPIDL files. r=froydnj 
The attributes for an interface should be on the line right before the
interface.

Interface attributes should be separated by spaces.

Clean up some trailing whitespace in widget/.

Differential Revision: https://phabricator.services.mozilla.com/D28234

--HG--
extra : moz-landing-system : lando
 2019-04-21 01:47:00 +00:00
Johann Hofmann f296ce765f Bug 1536454 - Part 2 - Add modificationTime attribute to nsIPermission.idl. r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D26943

--HG--
extra : moz-landing-system : lando
 2019-04-18 13:43:10 +00:00
Brian Grinstead 381332c51e Bug 1544051 - Part 3 - Scripted change to remove references to AddTask.js r=ahal 
This was generated with the script at https://bug1544051.bmoattachments.org/attachment.cgi?id=9058672

Differential Revision: https://phabricator.services.mozilla.com/D27761

--HG--
extra : moz-landing-system : lando
 2019-04-18 16:51:01 +00:00
Brian Grinstead 911776d674 Bug 1544322 - Part 3 - Remove the [type] attribute for multiline <script> tags loading files in chrome://mochikit/content/ r=bzbarsky 
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the case where the script src is on the line below the script tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 3` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27458

--HG--
extra : moz-landing-system : lando
 2019-04-16 03:59:25 +00:00
Brian Grinstead ede8c44ef2 Bug 1544322 - Part 2.1 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in everything except for dom/ r=bzbarsky 
This excludes dom/, otherwise the file size is too large for phabricator to handle.

This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 2` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27456

--HG--
extra : moz-landing-system : lando
 2019-04-16 03:50:44 +00:00
Andrea Marchesini 123be5d3c8 Bug 1543911 - Move BasePrincipal::CloneStrippingUserContextIdAndFirst into nsPermission to avoid misuses, r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D27235

--HG--
extra : moz-landing-system : lando
 2019-04-15 10:26:09 +00:00
Sylvestre Ledru 7f60810d86 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D27245

--HG--
extra : moz-landing-system : lando
 2019-04-12 13:14:25 +00:00
Makoto Kato e6c2e7bc87 Bug 1543585 - Clean up finding words for spellchecker. r=masayuki 
`mozSpellChecker::Replace` and `mozSpellChecker::NextMisspelledWord` have a loop
to find word from text content. But `mozEnglishWordUtils::FindNextWord` always
returns `NS_OK` and some code doesn't check error even if `nsresult` local
variable is used.

So I would like to clean up this loop.

- `mozEnglishWordUtils::FindNextWord` should return true if word is found
- We should use reference type for some `TextServicesDocument`'s methods.
- Add more check for error

Differential Revision: https://phabricator.services.mozilla.com/D27037

--HG--
extra : moz-landing-system : lando
 2019-04-12 03:54:18 +00:00
Andrea Marchesini 85f93c4ddc Bug 1541934 - mozStorageConnection can crash on shutdown, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D26491

--HG--
extra : moz-landing-system : lando
 2019-04-11 16:43:13 +00:00
Andreea Pavel 35a8067dab Backed out changeset 6e87244c4b89 (bug 1541934) for failing xpcshell at test_removeDataFromDomain.js on a CLOSED TREE 2019-04-11 16:57:19 +03:00
Andrea Marchesini afbad5faf0 Bug 1541934 - mozStorageConnection can crash on shutdown, r=asuth 
Differential Revision: https://phabricator.services.mozilla.com/D26491

--HG--
extra : moz-landing-system : lando
 2019-04-11 11:14:51 +00:00
Henri Sivonen ec150294ab Bug 1513799 - Remove windows-1252 as a Japanese detection outcome. r=emk. 
If this removal turns out to be OK, we should be able to make the detector
decide more quickly between the remaining options.

Differential Revision: https://phabricator.services.mozilla.com/D26283
 2019-04-08 14:43:26 +03:00
Sylvestre Ledru 03c8e8c2dd Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
 2019-04-05 21:41:42 +00:00
Csoregi Natalia ba58e936bd Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE 2019-04-05 09:48:19 +03:00
Sylvestre Ledru d1c1878603 Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
 2019-04-04 21:36:16 +00:00
Narcis Beleuzu 24dbe577a5 Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE 2019-04-05 00:27:56 +03:00
Sylvestre Ledru 399dbd28fe Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan 
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
 2019-04-04 20:12:23 +00:00
Erica Wright fccf274cc5 Bug 1524883 - Clear storageAccessAPI permissions when history is cleared. r=johannh,Ehsan 
When history is cleared, clear the flag that indicates a user has visited the domain.

Differential Revision: https://phabricator.services.mozilla.com/D24404

--HG--
extra : moz-landing-system : lando
 2019-03-28 18:44:08 +00:00
Boris Zbarsky 92f7b5dd5e Bug 1539716. Remove nsIHashable. r=froydnj 
It's dead code.

Differential Revision: https://phabricator.services.mozilla.com/D25190

--HG--
extra : moz-landing-system : lando
 2019-03-28 13:07:05 +00:00
Mark Banner dba6983e75 Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D23850

--HG--
extra : moz-landing-system : lando
 2019-03-28 09:38:14 +00:00
Masayuki Nakano 0a753c3aac Bug 1533293 - part 3: Make editor and ContentEventHandler not use Selection::Extend() due to too slow r=m_kato 
`Selection::Extend()` is too slow but editor and ContentEventHandler use it in
some places.  We should make them use `Selection::SetStartAndEndInLimiter()` or
`Selection::SetBaseAndExtentInLimiter()`.  The former is usable only when caller
guarantees the start point is prior to the end point in the DOM tree.
Otherwise, we need to use the latter even though it's slower than the former.

Differential Revision: https://phabricator.services.mozilla.com/D23462

--HG--
extra : moz-landing-system : lando
 2019-03-26 10:09:47 +00:00
Masayuki Nakano 534fd23ca4 Bug 1533293 - part 2: Rewrite EditorBase::SelectEntireDocument() and its overrides r=m_kato 
`EditorBase::SelectEntierDocument()` uses `Selection::Extend()` but it's too
slow.  It should use `Selection::SetStartAndEndInLimiter()` instead.

Additionally, `TextEditor::SelectEntierDocument()` shrink the result of
`EditorBase::SelectEntierDocument()` with `Selection::Extend()` if there is
a `moz-<br>` element.  So, `TextEditor::SelectEntinerDocument()` should set
its expected selection with a call for saving the runtime cost.

Then, we don't need to make `EditorBase::SelectEntierDocument()` as non-pure
virtual method.  So, this patch makes each its callers call
`Selection->SelectAllChildren()` directly.

Differential Revision: https://phabricator.services.mozilla.com/D23461

--HG--
extra : moz-landing-system : lando
 2019-03-26 10:06:43 +00:00
Noemi Erli 165f0d8c1c Backed out 3 changesets (bug 1533293) for causing Bug 1536595 a=backout 
Backed out changeset d011dfe83683 (bug 1533293)
Backed out changeset e536f6e123d8 (bug 1533293)
Backed out changeset 19cff61f4fed (bug 1533293)
 2019-03-20 13:29:17 +02:00
Masayuki Nakano 6dd0ecdd8e Bug 1533293 - part 3: Make editor and ContentEventHandler not use Selection::Extend() due to too slow r=m_kato 
`Selection::Extend()` is too slow but editor and ContentEventHandler use it in
some places.  We should make them use `Selection::SetStartAndEndInLimiter()` or
`Selection::SetBaseAndExtentInLimiter()`.  The former is usable only when caller
guarantees the start point is prior to the end point in the DOM tree.
Otherwise, we need to use the latter even though it's slower than the former.

Differential Revision: https://phabricator.services.mozilla.com/D23462

--HG--
extra : moz-landing-system : lando
 2019-03-18 01:52:36 +00:00
Masayuki Nakano 448571fd81 Bug 1533293 - part 2: Rewrite EditorBase::SelectEntireDocument() and its overrides r=m_kato 
`EditorBase::SelectEntierDocument()` uses `Selection::Extend()` but it's too
slow.  It should use `Selection::SetStartAndEndInLimiter()` instead.

Additionally, `TextEditor::SelectEntierDocument()` shrink the result of
`EditorBase::SelectEntierDocument()` with `Selection::Extend()` if there is
a `moz-<br>` element.  So, `TextEditor::SelectEntinerDocument()` should set
its expected selection with a call for saving the runtime cost.

Then, we don't need to make `EditorBase::SelectEntierDocument()` as non-pure
virtual method.  So, this patch makes each its callers call
`Selection->SelectAllChildren()` directly.

Differential Revision: https://phabricator.services.mozilla.com/D23461

--HG--
extra : moz-landing-system : lando
 2019-03-18 01:51:53 +00:00
Sebastian Hengst cee711baf9 Bug 1535353 - update Core :: DOM: * bugzilla product and component meta data in moz.build files after reorganization in bug 1533440 r=hsinyi 
Differential Revision: https://phabricator.services.mozilla.com/D23546

--HG--
extra : moz-landing-system : lando
 2019-03-17 23:13:22 +00:00
Sylvestre Ledru 4aa92e3091 Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D22514
 2019-03-13 10:19:06 +01:00
Nathan Froyd 646507261e Bug 1533750 - pack members of PermissionEntry better on 64-bit platforms; r=jdm 
The current ordering leaves a hole after `mExpireType` due to the need
to align a 64-bit `mExpireTime` and another one after
`mNonSessionExpireTime` to pad out the structure.  We can group members
by their type (and initialize them in that order to avoid compiler
warnings) to avoid the holes and save a little bit of space.

Differential Revision: https://phabricator.services.mozilla.com/D22713

--HG--
extra : moz-landing-system : lando
 2019-03-11 18:36:44 +00:00
Andrea Marchesini b27c7a2194 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21697

--HG--
extra : moz-landing-system : lando
 2019-03-08 09:04:57 +00:00
Andrea Marchesini 8e20bbbc9a Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538

--HG--
extra : moz-landing-system : lando
 2019-03-08 09:04:11 +00:00
Andrea Marchesini 6b7df33f3a Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18958

--HG--
extra : moz-landing-system : lando
 2019-03-08 09:03:15 +00:00
Ciure Andrei 712dd2bb8c Backed out 16 changesets (bug 1525245) for perma failing test_document_cookie.html CLOSED TREE 
Backed out changeset 3fd27215698f (bug 1525245)
Backed out changeset d9a9e8e77873 (bug 1525245)
Backed out changeset 0e6f7be92e3f (bug 1525245)
Backed out changeset 6790802e2fa5 (bug 1525245)
Backed out changeset a5a9e01116ed (bug 1525245)
Backed out changeset 66e19a0c38dd (bug 1525245)
Backed out changeset fb90d51ba853 (bug 1525245)
Backed out changeset 4772db3625b3 (bug 1525245)
Backed out changeset 9affaf0cb998 (bug 1525245)
Backed out changeset a91b7ebe8bdd (bug 1525245)
Backed out changeset c2a13a7480e1 (bug 1525245)
Backed out changeset abe4482fa137 (bug 1525245)
Backed out changeset b3920c0bcf84 (bug 1525245)
Backed out changeset 0821b81f2724 (bug 1525245)
Backed out changeset 70bed2ad7899 (bug 1525245)
Backed out changeset 5f72ba232cc8 (bug 1525245)
 2019-03-07 17:54:18 +02:00
Andrea Marchesini f5aaaac0e2 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21697

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:22:18 +00:00
Andrea Marchesini 6856f88972 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:21:15 +00:00
Andrea Marchesini 48b3f2b792 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18958

--HG--
extra : moz-landing-system : lando
 2019-03-07 10:18:07 +00:00
Dorel Luca ac34e1d973 Backed out 16 changesets (bug 1525245) for Android failures. CLOSED TREE 
Backed out changeset 9f8a1b410320 (bug 1525245)
Backed out changeset 0ef284a9a1d5 (bug 1525245)
Backed out changeset 835e5f642a03 (bug 1525245)
Backed out changeset 362f5a8d033c (bug 1525245)
Backed out changeset 9da3ab33cf67 (bug 1525245)
Backed out changeset 6aacd2d6e835 (bug 1525245)
Backed out changeset 8ff9e8f45e02 (bug 1525245)
Backed out changeset 2020227181cc (bug 1525245)
Backed out changeset fc3c64c330b9 (bug 1525245)
Backed out changeset 2762bf88e050 (bug 1525245)
Backed out changeset ffc10fdc50a6 (bug 1525245)
Backed out changeset bb6ade1207d7 (bug 1525245)
Backed out changeset 1875eb5085e4 (bug 1525245)
Backed out changeset 7e4f67a6d6f1 (bug 1525245)
Backed out changeset e671fc9581eb (bug 1525245)
Backed out changeset b89f5def8d0d (bug 1525245)
 2019-03-06 21:07:49 +02:00
Andrea Marchesini 4643d957ad Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21697

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:04:55 +00:00
Andrea Marchesini 4fabb4a2a8 Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21538

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:04:06 +00:00
Andrea Marchesini cc69a8960f Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18958

--HG--
extra : moz-landing-system : lando
 2019-03-06 17:03:08 +00:00
Ryan Hunt f11762a961 Bug 1523969 part 7 - Move method definition inline comments to new line in 'extensions/'. r=ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D21107

--HG--
extra : rebase_source : 464cdd0563865fcfd4f6fc9617f7b235892af2a4
 2019-02-25 16:05:47 -06:00
Jonathan Kingston f6680698bd Bug 1525319 - Removing context from OnDataAvailable r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
 2019-02-27 23:42:27 +00:00
Jonathan Kingston c4853316e7 Bug 1525319 - Removing context from OnStopRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20770

--HG--
extra : moz-landing-system : lando
 2019-02-27 23:41:31 +00:00
Jonathan Kingston f7e35ae39e Bug 1525319 - Removing context from OnStartRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20769

--HG--
extra : moz-landing-system : lando
 2019-02-27 23:41:04 +00:00
Ciure Andrei 8d2894e70d Backed out 12 changesets (bug 1525245) for failing worker-interception.https.html CLOSED TREE 
Backed out changeset 009e7457b990 (bug 1525245)
Backed out changeset efb2e8fca464 (bug 1525245)
Backed out changeset 6a8401de3237 (bug 1525245)
Backed out changeset 38e802661b14 (bug 1525245)
Backed out changeset d02e3f436390 (bug 1525245)
Backed out changeset 10afd61b7582 (bug 1525245)
Backed out changeset 6b92fb3666d1 (bug 1525245)
Backed out changeset 476af2d7efe5 (bug 1525245)
Backed out changeset 43ad14e323a1 (bug 1525245)
Backed out changeset 94295e3fb027 (bug 1525245)
Backed out changeset d01ead2270e9 (bug 1525245)
Backed out changeset 6bdda622a04a (bug 1525245)
 2019-02-28 00:55:39 +02:00
Andrea Marchesini eaa983a53f Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D18958

--HG--
extra : moz-landing-system : lando
 2019-02-27 19:57:47 +00:00
Dorel Luca 4a4dcd57fa Backed out 4 changesets (bug 1525319) for Android failures in dom/base/test/test_progress_events_for_gzip_data.html 
Backed out changeset b73f033efb41 (bug 1525319)
Backed out changeset 1d318d5c6b98 (bug 1525319)
Backed out changeset 6d73418988d4 (bug 1525319)
Backed out changeset 84ca79bd2dc3 (bug 1525319)
 2019-02-25 04:06:11 +02:00
Jonathan Kingston 63ab2bd8aa Bug 1525319 - Removing context from OnDataAvailable r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
 2019-02-24 20:27:55 +00:00
Jonathan Kingston 332531fa9c Bug 1525319 - Removing context from OnStopRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20770

--HG--
extra : moz-landing-system : lando
 2019-02-24 20:26:59 +00:00
Jonathan Kingston 2441197975 Bug 1525319 - Removing context from OnStartRequest r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D20769

--HG--
extra : moz-landing-system : lando
 2019-02-24 20:26:16 +00:00
Ehsan Akhgari 3219a47956 Bug 1527505 - Part 11: Avoid looking up the effective TLD service repeatedly inside the permission manager; r=nika 
Depends on D20238

Differential Revision: https://phabricator.services.mozilla.com/D20239

--HG--
extra : moz-landing-system : lando
 2019-02-21 22:54:34 +00:00
Ehsan Akhgari 21eac68e65 Bug 1527505 - Part 10: Add a variation of TestPermissionFromPrincipal() that knows to not check for the presence of a default pref if the caller knows the permission type doesn't support default prefs, and use it in the anti-tracking backend; r=nika 
This gives us the additional benefit that it will provide a clean inlined path
for the common case of testing for permissions from the anti-tracking backend.

Depends on D20237

Differential Revision: https://phabricator.services.mozilla.com/D20238

--HG--
extra : moz-landing-system : lando
 2019-02-21 22:54:30 +00:00
Ehsan Akhgari b5a2bda7ee Bug 1527505 - Part 9: Make nsIPermissionManager accept ACString arguments for permission types instead of raw C strings; r=nika 
This will mean that in places like the tight loop in GetTypeIndex()
we would no longer require calling strlen() on the input type argument
once per loop iteration.

Depends on D20236

Differential Revision: https://phabricator.services.mozilla.com/D20237

--HG--
extra : moz-landing-system : lando
 2019-02-21 22:54:28 +00:00
Ehsan Akhgari b7a58af3de Bug 1527505 - Part 8: Lift the handling of expanded principals out of CommonTestPermissionInternal() into CommonPrepareToTestPermission(); r=nika 
This patch in the series ensures that the order of operations in
recursive invocations of CommonTestPermission() remains consistent
compared to before the patch series, even though it is not strictly
needed for the performance improvements that the series focuses on.

The core idea behind CommonPrepareToTestPermission() now is to do the checks
that do not depend on the host name being tested, and for
CommonTestPermissionInternal() itself to focus on the rest of the checks,
that is looking up our hashtable entry based on the host name being tested,
and everything else that's needed from that point on.

Depends on D20235

Differential Revision: https://phabricator.services.mozilla.com/D20236

--HG--
extra : moz-landing-system : lando
 2019-02-21 22:54:26 +00:00
Ehsan Akhgari b0243117bd Bug 1527505 - Part 7: Compute the default permission in the recursive loop only once; r=nika 
Depends on D20234

Differential Revision: https://phabricator.services.mozilla.com/D20235

--HG--
extra : moz-landing-system : lando
 2019-02-21 22:54:24 +00:00
Ehsan Akhgari d29bd70ee2 Bug 1527505 - Part 6: Use inline storage for storing the type array in order to speed up searching though it in the common case; r=nika 
Depends on D20233

Differential Revision: https://phabricator.services.mozilla.com/D20234

--HG--
extra : moz-landing-system : lando
 2019-02-21 22:54:16 +00:00
Ehsan Akhgari 0083cbb875 Bug 1527505 - Part 5: Inline nsPermissionManager::GetTypeIndex(); r=nika 
Depends on D20232

Differential Revision: https://phabricator.services.mozilla.com/D20233

--HG--
extra : moz-landing-system : lando
 2019-02-21 22:54:14 +00:00
Ehsan Akhgari ef76693c35 Bug 1527505 - Part 4: Compute the type index in the recursive loop only once; r=nika 
This patch alone decreases the runtime of the loop on my machine from about
1700 to 200-400ms ranges.  It turns out that computing the type index is
the most expensive part.  So perhaps we should look into improving that as
well.

The first thing that comes to mind is whether we can inline the loop in
GetTypeIndex().  The next part takes care of that, and it does help a bit.
But we need to do more still.

The next obvious thing is to optimize the memory access patterns.  Right
now we iterate over an array of dynamically allocated strings to compare
them, which amounts to pointer chasing to read a bit of memory, kind of
the worst possible way to access memory.  Then we look at replacing that
with fully sequential memory reads in the common cases.

Depends on D20231

Differential Revision: https://phabricator.services.mozilla.com/D20232

--HG--
extra : moz-landing-system : lando
 2019-02-21 22:54:12 +00:00