Valentin Gosu
cf8a03778f
Bug 1589337 - Use nsIClassInfoImpl in nsSimpleURI and children r=necko-reviewers,kershaw,xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D90257
2020-09-29 11:41:26 +00:00
Simon Giesecke
de7bab0f06
Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Christoph Kerschbaumer
c9b352a0f3
Bug 1666751: Use simple and never failing LoadInfo() getter because all channels should have a loadinfo r=freddyb,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D91119
2020-09-23 12:49:40 +00:00
Chris Peterson
f11ae60d32
Bug 1662964 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/file. r=baku
...
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
Differential Revision: https://phabricator.services.mozilla.com/D89237
2020-09-08 15:15:19 +00:00
Tom Schuster
6dec9a2c02
Bug 1660636 - Use download attribute filename instead of File.name. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D88571
2020-09-08 19:56:52 +00:00
Simon Giesecke
55a58f0a61
Bug 847347 - Ensure that FileReader::GetAsDataURL does not trigger a release-mode assertion failure on large files. r=jstutte,froydnj
...
We avoid going through Substring which imposes a limit on the string length of
INT32_MAX and failing a MOZ_RELEASE_ASSERT otherwise.
This adds a new `Base64EncodeAppend` function that takes 8-bit char input and
produces 16-bit char output, and appends to an existing string, which is what
we need here to avoid doing a large copy. Base64EncodeHelper is generalized
to accomodate for that.
So in addition to fixing the defect, this also optimizes performance and
memory usage.
Differential Revision: https://phabricator.services.mozilla.com/D87413
2020-08-19 08:11:42 +00:00
Tom Schuster
9e497a23ce
Bug 1650607 - Do not replace / with : in File constructor. r=baku
...
Basically a backout of https://hg.mozilla.org/mozilla-central/rev/1857e763332c .
Pending spec change: https://github.com/w3c/FileAPI/issues/41
Differential Revision: https://phabricator.services.mozilla.com/D86981
2020-08-17 09:52:14 +00:00
Andrea Marchesini
5fa9480158
Bug 1658878 - Isolate BlobURLs per agent-cluster - cleanup remove method, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D87059
2020-08-17 09:57:04 +00:00
Andrea Marchesini
6b8618a091
Bug 1658878 - Isolate BlobURLs per agent-cluster - pref, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D86968
2020-08-17 09:55:56 +00:00
Andrea Marchesini
2a7a7cfe86
Bug 1658878 - Isolate BlobURLs per agent-cluster - tests, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D86915
2020-08-17 09:55:32 +00:00
Andrea Marchesini
27d564c279
Bug 1658878 - Isolate BlobURLs per agent-cluster, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D86914
2020-08-14 19:45:52 +00:00
Bogdan Tara
694be205aa
Backed out 4 changesets (bug 1658878) for blob related leaks CLOSED TREE
...
Backed out changeset 0288ef9ab65b (bug 1658878)
Backed out changeset a5af0e097560 (bug 1658878)
Backed out changeset 33c4b81f99a1 (bug 1658878)
Backed out changeset 16a33c7b4ff3 (bug 1658878)
2020-08-14 22:41:05 +03:00
Andrea Marchesini
a4f8193237
Bug 1658878 - Isolate BlobURLs per agent-cluster - cleanup remove method, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D87059
2020-08-14 17:39:26 +00:00
Andrea Marchesini
8d8dfa8e36
Bug 1658878 - Isolate BlobURLs per agent-cluster - pref, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D86968
2020-08-14 17:39:14 +00:00
Andrea Marchesini
3ba2ef34df
Bug 1658878 - Isolate BlobURLs per agent-cluster - tests, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D86915
2020-08-14 16:59:42 +00:00
Andrea Marchesini
91ce718928
Bug 1658878 - Isolate BlobURLs per agent-cluster, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D86914
2020-08-14 16:59:44 +00:00
Mihai Alexandru Michis
33c1daa575
Backed out 4 changesets (bug 1658878) for causing failures in browser_blobURLIsolation.js
...
CLOSED TREE
Backed out changeset f69f80e5659f (bug 1658878)
Backed out changeset 20401a2adaa6 (bug 1658878)
Backed out changeset a8620aecc29f (bug 1658878)
Backed out changeset 3609760c1e5d (bug 1658878)
2020-08-14 19:55:25 +03:00
Andrea Marchesini
0920dd26fe
Bug 1658878 - Isolate BlobURLs per agent-cluster - cleanup remove method, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D87059
2020-08-14 15:57:45 +00:00
Andrea Marchesini
2175d60f4a
Bug 1658878 - Isolate BlobURLs per agent-cluster - pref, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D86968
2020-08-14 15:57:02 +00:00
Andrea Marchesini
b40d7a83c4
Bug 1658878 - Isolate BlobURLs per agent-cluster - tests, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D86915
2020-08-14 15:57:02 +00:00
Andrea Marchesini
5c2811edd6
Bug 1658878 - Isolate BlobURLs per agent-cluster, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D86914
2020-08-14 10:41:22 +00:00
Simon Giesecke
1e02318b49
Bug 1653335 - Replace MakeSpan uses by constructor calls. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D83817
2020-08-07 07:49:47 +00:00
ssengupta
49786eae4d
Bug 1619953 - P12 - Blob data is retrieved locally for non-http/https URLs r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D85868
2020-08-05 17:05:36 +00:00
ssengupta
fd9c765041
Bug 1619953 - P6 - BlobURLChannel creates BlobURLInputStream only when content stream is opened r=baku
...
Additionally, BlobURLChannel holds no strong reference to BlobURLInputStream. This is to avoid circular dependency.
Differential Revision: https://phabricator.services.mozilla.com/D81452
2020-08-05 17:06:04 +00:00
ssengupta
8d095d15bf
Bug 1619953 - P5 - BlobURLChannel allows loading blob data that is very recently revoked r=baku
...
Previously similar logic existed in BlobURLProtocolHandler, which has now been removed, since such checks are now for parent process only and should be abstracted from BlobURLProtocolHandler.
Depends on D75293
Differential Revision: https://phabricator.services.mozilla.com/D81126
2020-08-05 17:06:01 +00:00
ssengupta
6afc3aa5cd
Bug 1619953 - P4 - BlobURLChannel now creates BlobURLInputStream to acquire blob data r=baku
...
BlobURLProtocolHandler no longer passes blobImpl pointer to BlobURLChannel. Instead, acquisition and handling of blob data is offloaded to BlobURLInputStream.
Differential Revision: https://phabricator.services.mozilla.com/D75293
2020-08-05 17:05:59 +00:00
ssengupta
f600911e45
Bug 1619953 - P3 - Asynchronous BlobURLInputStream added r=baku
...
Reading from this stream type should be the preferred way to consume data from blob url. When created in the parent process, it requests blob data locally from BlobURLProtocolHandler. When created in a content process, it makes BlobURLDataRequest IPC call to the parent process. Should be wrapped in a nsBufferedInputStream, because ReadSegments() is currently not implemented for this stream type.
Differential Revision: https://phabricator.services.mozilla.com/D75292
2020-08-05 17:05:56 +00:00
Simon Giesecke
96f3e7e019
Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-04 11:27:07 +00:00
Noemi Erli
381fca9783
Backed out 4 changesets (bug 1654992, bug 1654991) for causing timeous in mask-opacity-1e.html
...
Backed out changeset 11f0f54c6e0a (bug 1654992)
Backed out changeset a353dd5b3f08 (bug 1654991)
Backed out changeset 6a7964ba549f (bug 1654991)
Backed out changeset cf3bfb91d98c (bug 1654991)
2020-08-03 22:09:36 +03:00
Simon Giesecke
032d2ac9d3
Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-03 14:54:18 +00:00
ssengupta
a9e4714041
Bug 1633880 - P2 - RemoteLazyInputStreamStorage::Get() now returns mozilla::Result<RefPtr<RemoteLazyInputStreamStorage>, nsresult> r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D80541
2020-07-03 12:59:19 +00:00
ssengupta
71d5e0b3aa
Bug 1633880 - P1 - gStorage in RemoteLazyInputStreamStorage is protected by gMutex r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D80540
2020-07-03 12:59:11 +00:00
Csoregi Natalia
4dcffa68cd
Backed out 9 changesets (bug 1619953) for causing leaks. CLOSED TREE
...
Backed out changeset 9f610c8c44de (bug 1619953)
Backed out changeset 4e66983a4f00 (bug 1619953)
Backed out changeset 38aac5691967 (bug 1619953)
Backed out changeset 062c0c9b132f (bug 1619953)
Backed out changeset 830eb658d70e (bug 1619953)
Backed out changeset fccda4625d51 (bug 1619953)
Backed out changeset 4668c99560de (bug 1619953)
Backed out changeset 77c24528c8c2 (bug 1619953)
Backed out changeset b79dc688bfc9 (bug 1619953)
2020-07-02 17:58:57 +03:00
ssengupta
8e3d58167d
Bug 1619953 - P6 - BlobURLChannel creates BlobURLInputStream only when content stream is opened r=baku
...
Additionally, BlobURLChannel holds no strong reference to BlobURLInputStream. This is to avoid circular dependency.
Differential Revision: https://phabricator.services.mozilla.com/D81452
2020-07-02 13:38:29 +00:00
ssengupta
30cf4ca723
Bug 1619953 - P5 - BlobURLChannel allows loading blob data that is very recently revoked r=baku
...
Previously similar logic existed in BlobURLProtocolHandler, which has now been removed, since such checks are now for parent process only and should be abstracted from BlobURLProtocolHandler.
Depends on D75293
Differential Revision: https://phabricator.services.mozilla.com/D81126
2020-07-02 13:38:26 +00:00
ssengupta
32ea535c07
Bug 1619953 - P4 - BlobURLChannel now creates BlobURLInputStream to acquire blob data r=baku
...
BlobURLProtocolHandler no longer passes blobImpl pointer to BlobURLChannel. Instead, acquisition and handling of blob data is offloaded to BlobURLInputStream.
Differential Revision: https://phabricator.services.mozilla.com/D75293
2020-07-02 13:38:06 +00:00
ssengupta
1bcf359b60
Bug 1619953 - P3 - Asynchronous BlobURLInputStream added r=baku
...
Reading from this stream type should be the preferred way to consume data from blob url. When created in the parent process, it requests blob data locally from BlobURLProtocolHandler. When created in a content process, it makes BlobURLDataRequest IPC call to the parent process. Should be wrapped in a nsBufferedInputStream, because ReadSegments() is currently not implemented for this stream type.
Differential Revision: https://phabricator.services.mozilla.com/D75292
2020-07-02 13:37:58 +00:00
Simon Giesecke
9364b353d4
Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80631
2020-07-01 08:42:31 +00:00
Simon Giesecke
e3c223da3e
Bug 1648010 - Fix uses of NS_LITERAL_STRING with C string literals. r=geckoview-reviewers,agi,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80861
2020-07-01 08:34:12 +00:00
Simon Giesecke
cd8b8939b9
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Andrea Marchesini
4c6f89824d
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 8 - mozilla namespace, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80931
2020-06-29 13:40:27 +00:00
Andrea Marchesini
34cbc7e2ed
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 7 - RemoteLazyInputStreamUtils, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80930
2020-06-29 11:02:59 +00:00
Andrea Marchesini
2c405fb804
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 6 - remoteLazyInputStream, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80929
2020-06-29 11:02:55 +00:00
Andrea Marchesini
c6e87ab4b6
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 5 - thread, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80928
2020-06-29 13:39:01 +00:00
Andrea Marchesini
5fc1253731
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 4 - IPDL actors, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80927
2020-06-29 11:03:02 +00:00
Andrea Marchesini
8f12e90e00
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 3 - PRemoteLazyInputStream, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80926
2020-06-29 11:03:04 +00:00
Andrea Marchesini
07f5abb16d
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 2 - RemoteLazyInputStreamStorage, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80925
2020-06-29 11:02:50 +00:00
Andrea Marchesini
5def6bbc8c
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 1 - mozIRemoteLazyInputStream interface, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80924
2020-06-29 11:02:53 +00:00
Razvan Maries
f7cb24cc7e
Backed out 8 changesets (bug 1648141
) for build bustages on RemoteLazyInputStreamThread.cpp. CLOSED TREE
...
Backed out changeset e9b4ca0ee700 (bug 1648141
)
Backed out changeset b9bb847cee47 (bug 1648141
)
Backed out changeset 11dfce46ec14 (bug 1648141
)
Backed out changeset d824d2f67f27 (bug 1648141
)
Backed out changeset e5b8292e7095 (bug 1648141
)
Backed out changeset c1a3d5fa0c61 (bug 1648141
)
Backed out changeset 24fdb83db3cd (bug 1648141
)
Backed out changeset 749d894dde52 (bug 1648141
)
2020-06-29 13:59:16 +03:00
Andrea Marchesini
c71431ab1b
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 8 - mozilla namespace, r=smaug,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D80931
2020-06-29 10:30:00 +00:00