The major change to the Iterator is due to the fact that the end of a
LinkedList is represented by nullptr.
Also delete the type conversion functions which are no longer needed.
MozReview-Commit-ID: 2lYtFW9pSon
--HG--
extra : rebase_source : c822e937679e57a9f2d3ab034e5147fc3aea9e8e
In our coding rules, variable names of nsresult should be rv. Indeed, when you see |rv| in the code, you must assume that its type if nsresult.
However, a lot of code under editor/ uses |res| for the variables of nsresult. Let's replace |res| with |rv|.
And this patch improves following points:
1. When |rv| is set in both |if| and |else| block and they are check outside of them, this moves the check into each |if| and |else| block because even if the failure is notified with warning, you cannot see which case was performed and failed. This change makes it clear.
2. When |return rv;| returns non-error code because |rv| is checked with NS_ENSURE_SUCCESS() immediately before, setting replacing it with |return NS_OK;| is clearer.
3. Move declaration of |nsresult rv| into smaller scope as far as possible. This prevents setting rv to unexpected value and easier to check its value at reading the code.
MozReview-Commit-ID: 9MAqj7sFey3
--HG--
extra : rebase_source : 0fd316b851ea616b3a95d8c1afc111ff55e11993
NS_FOUND_TARGET is now declared as an error code. However, making it as a success code makes the code simpler.
First, this patch renames it to NS_SUCCESS_EDITOR_FOUND_TARGET because it's usual naming rule (according to the other declarations).
Next, FindTargetNode() should return it when a nest call of itself returns NS_SUCCESS_EDITOR_FOUND_TARGET as it does now.
Finally, removing the code overwriting NS_FOUND_TARGET with NS_OK from HTMLEditor::CreateDOMFragmentFromPaste() since it doesn't cause hitting NS_ENSURE_SUCCESS() and the variable, rv, will be overwritten with other method's result.
MozReview-Commit-ID: 6GgZptrXXQa
--HG--
extra : rebase_source : 79418fc83fb087e559221f895c59c7c334980456
This removes the ability for ClearKey to instantiate persistent-license
sessions using the EME APIs.
MozReview-Commit-ID: KXyuRNMJKIZ
--HG--
extra : rebase_source : fd5c66f8929dfdb28ceb5cb82a75181a9168ca81
Note StateObject::HandleResumeVideoDecoding() doesn't check mIsReaderSuspended
because if the reader is suspended, MDSM must be in the dormant state and won't
resume video decoding.
MozReview-Commit-ID: FY4rdFmk56C
--HG--
extra : rebase_source : 000837b59944ad3f2efb12a367d7cc12c7a6deab
extra : source : a11fd583471f8a8e496a3152bb73bc17c6345a63
If MDSM becomes invisible while decoding metadata, VisibilityChanged() will return early
because mInfo is still nothing. And MDSM will never suspend video decoding if there are no
visibility changes later. We should delay the check util the timer goes off and MDSM
needs to switch on the blank decoder.
MozReview-Commit-ID: Ids9MncpC2l
--HG--
extra : rebase_source : 77ab76b09bae3dec3447950a8f0a7fcffff565b7
extra : source : 4527aed6f0b4f3ac11981df4517adacf9a43b4a2
tree_ordering test can not be moved because the test waits for animationend
event.
createPseudo() were picked from
testing/web-platform/tests/web-animations/testcommon.js .
MozReview-Commit-ID: EZ2sGEgdMFM
--HG--
extra : rebase_source : 1ebf46dd91f42ba75f5711e781d72e77948e6150
All of cleaning up code were dropped. Also some trivial comments were dropped.
Note that test cases can not be rewritten to synchronous test.
* Waiting for events, e.g. transitionend.
* single_transition
* single_animation
* Manipulated by style, e.g. style.animationDuraton = "0.5s".
* single_transition_cancelled_property
* single_transition_cancelled_value
* single_transition_cancelled_noninterpolable
* single_transition_reversed
* multiple_transitions
* single_animation_cancelled_name
* single_animation_cancelled_duration
* single_animation_cancelled_delay
* single_animation_cancelled_fill
* single_animation_cancelled_iteration_count
* single_animation_change_XXX
* coalesce_change_cancel
* Falling into a pending state, e.g. play() or pause().
* finish_from_pause
* finish_from_pause_pending
* play
* play_filling_forwards
* play_after_finish
* pause
* pause_while_pause_pending
* aborted_pause
MozReview-Commit-ID: 5bTzO7GtEHF
--HG--
extra : rebase_source : 905f5144706e20c743030b4bcff428ef124abfff
Phil Ringnalda
Kilik Kuo
Carsten "Tomcat" Book
Cameron McCormack
Mats Palmgren
Xue Fuqiao
Ting-Yu Lin
Masayuki Nakano
Chris Pearce
JW Wang
Wes Kocher
stefanh@inbox.com
Shu-yu Guo
James Willcox
Eitan Isaacson
Hiroyuki Ikezoe
Neil Deakin
Ted Mielczarek
Aaron Klotz