a558e51a4d
Bug 1590974 - Pass the toolbox document to MenuButton in the a11y panel. r=yzen.
...
This makes it possible for the menus to not be constrained
to the panel boundaries if they are taller than the panel
itself (which could be the case for the simulate menu as
it has lots of items).
We need to style the button with a link role in the toolbox
CSS so they don't look like real buttons.
Differential Revision: https://phabricator.services.mozilla.com/D50461
--HG--
extra : moz-landing-system : lando
2019-11-04 06:38:37 +00:00
d57b479711
Bug 1525939 - Use shared Accordion component in Inspector; r=yzen
...
Differential Revision: https://phabricator.services.mozilla.com/D43640
--HG--
extra : moz-landing-system : lando
2019-11-01 16:11:13 +00:00
b6846ec07b
Bug 1590823 - Fix scrollbars in accessibility panel by using --devtools-toolbar-height instead of --accessibility-toolbar-height r=fvsch
...
The accessibility panel is calculating the height of some of its containers by doing 100vh - toolbar height.
But the accessibility panel was relying on a local variable --accessibility-toolbar-height which was actually not used to set the height of the toolbar.
So when the toolbar height increased of 1px, all those calculations became wrong.
The --accessibility-toolbar-height is now the same as --theme-toolbar-height so I propose to remove the local variable and only use the devtools one.
Differential Revision: https://phabricator.services.mozilla.com/D50291
--HG--
extra : moz-landing-system : lando
2019-10-24 07:03:51 +00:00
494422872e
Bug 1585923 - Rename MenuButton doc prop to toolboxDoc. r=jdescottes.
...
This should make it more obvious what kind of document
the component is expecting.
Differential Revision: https://phabricator.services.mozilla.com/D50240
--HG--
extra : moz-landing-system : lando
2019-10-24 05:56:10 +00:00
0066803de3
Bug 1589597 - Rename accessibility jest test folder to node r=ladybenko
...
Depends on D49707
Following the naming convention decided in RFC Bug 1564431
Differential Revision: https://phabricator.services.mozilla.com/D49708
--HG--
rename : devtools/client/accessibility/test/jest/.eslintrc.js => devtools/client/accessibility/test/node/.eslintrc.js
rename : devtools/client/accessibility/test/jest/README.md => devtools/client/accessibility/test/node/README.md
rename : devtools/client/accessibility/test/jest/babel.config.js => devtools/client/accessibility/test/node/babel.config.js
rename : devtools/client/accessibility/test/jest/components/__snapshots__/accessibility-prefs.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/accessibility-prefs.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/accessibility-row-value.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/accessibility-row-value.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/accessibility-tree-filter.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/accessibility-tree-filter.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/audit-controller.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/audit-controller.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/audit-filter.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/audit-filter.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/audit-progress-overlay.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/audit-progress-overlay.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/badge.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/badge.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/badges.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/badges.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/check.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/check.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/contrast-badge.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/contrast-badge.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/keyboard-badge.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/keyboard-badge.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/keyboard-check.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/keyboard-check.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/text-label-badge.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/text-label-badge.test.js.snap
rename : devtools/client/accessibility/test/jest/components/__snapshots__/text-label-check.test.js.snap => devtools/client/accessibility/test/node/components/__snapshots__/text-label-check.test.js.snap
rename : devtools/client/accessibility/test/jest/components/accessibility-prefs.test.js => devtools/client/accessibility/test/node/components/accessibility-prefs.test.js
rename : devtools/client/accessibility/test/jest/components/accessibility-row-value.test.js => devtools/client/accessibility/test/node/components/accessibility-row-value.test.js
rename : devtools/client/accessibility/test/jest/components/accessibility-tree-filter.test.js => devtools/client/accessibility/test/node/components/accessibility-tree-filter.test.js
rename : devtools/client/accessibility/test/jest/components/audit-controller.test.js => devtools/client/accessibility/test/node/components/audit-controller.test.js
rename : devtools/client/accessibility/test/jest/components/audit-filter.test.js => devtools/client/accessibility/test/node/components/audit-filter.test.js
rename : devtools/client/accessibility/test/jest/components/audit-progress-overlay.test.js => devtools/client/accessibility/test/node/components/audit-progress-overlay.test.js
rename : devtools/client/accessibility/test/jest/components/badge.test.js => devtools/client/accessibility/test/node/components/badge.test.js
rename : devtools/client/accessibility/test/jest/components/badges.test.js => devtools/client/accessibility/test/node/components/badges.test.js
rename : devtools/client/accessibility/test/jest/components/check.test.js => devtools/client/accessibility/test/node/components/check.test.js
rename : devtools/client/accessibility/test/jest/components/contrast-badge.test.js => devtools/client/accessibility/test/node/components/contrast-badge.test.js
rename : devtools/client/accessibility/test/jest/components/keyboard-badge.test.js => devtools/client/accessibility/test/node/components/keyboard-badge.test.js
rename : devtools/client/accessibility/test/jest/components/keyboard-check.test.js => devtools/client/accessibility/test/node/components/keyboard-check.test.js
rename : devtools/client/accessibility/test/jest/components/text-label-badge.test.js => devtools/client/accessibility/test/node/components/text-label-badge.test.js
rename : devtools/client/accessibility/test/jest/components/text-label-check.test.js => devtools/client/accessibility/test/node/components/text-label-check.test.js
rename : devtools/client/accessibility/test/jest/fixtures/Services.js => devtools/client/accessibility/test/node/fixtures/Services.js
rename : devtools/client/accessibility/test/jest/fixtures/devtools-utils.js => devtools/client/accessibility/test/node/fixtures/devtools-utils.js
rename : devtools/client/accessibility/test/jest/fixtures/l10n.js => devtools/client/accessibility/test/node/fixtures/l10n.js
rename : devtools/client/accessibility/test/jest/fixtures/plural-form.js => devtools/client/accessibility/test/node/fixtures/plural-form.js
rename : devtools/client/accessibility/test/jest/fixtures/stub.js => devtools/client/accessibility/test/node/fixtures/stub.js
rename : devtools/client/accessibility/test/jest/helpers.js => devtools/client/accessibility/test/node/helpers.js
rename : devtools/client/accessibility/test/jest/jest.config.js => devtools/client/accessibility/test/node/jest.config.js
rename : devtools/client/accessibility/test/jest/package.json => devtools/client/accessibility/test/node/package.json
rename : devtools/client/accessibility/test/jest/setup.js => devtools/client/accessibility/test/node/setup.js
rename : devtools/client/accessibility/test/jest/yarn.lock => devtools/client/accessibility/test/node/yarn.lock
extra : moz-landing-system : lando
2019-10-18 13:56:15 +00:00
e8c33bda92
Bug 1583444 - Reuse DevToolsUtils.getTopWindow in HTMLTooltip r=yzen
...
Depends on D46958
The getTopWindow logic was duplicated between DevToolsUtils and HTMLTooltip.
This removes the duplication and adds a fixture to the accessibility panel to avoid loading the actual DevToolsUtils file in jest tests.
Differential Revision: https://phabricator.services.mozilla.com/D46959
--HG--
extra : moz-landing-system : lando
2019-09-30 09:53:33 +00:00
4a1c59f251
Bug 1500142 - Remove inspector bindings from toolbox. r=yulia,ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D40320
--HG--
extra : moz-landing-system : lando
2019-09-16 17:39:42 +00:00
f2aabeaa59
Backed out changeset 3182a1d6debb (bug 1500142) for xpcshell failures at test_oob_cert_auth.js. CLOSED TREE
2019-09-06 23:05:31 +03:00
1ba46b8359
Bug 1500142 - Remove inspector bindings from toolbox. r=ochameau,yulia
...
Differential Revision: https://phabricator.services.mozilla.com/D40320
--HG--
extra : moz-landing-system : lando
2019-09-06 18:18:04 +00:00
9a09073dc7
Bug 1572144 - Support search result navigation. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D43555
--HG--
extra : moz-landing-system : lando
2019-09-04 08:31:45 +00:00
5dcfb63635
Backed out changeset 4e344973418a (bug 1572144) for failing in browser_accessibility_mutations.js CLOSED TREE
2019-09-03 20:12:10 +03:00
d8ffcbc0d8
Bug 1572144 - Support search result navigation. r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D43555
--HG--
extra : moz-landing-system : lando
2019-09-03 15:55:02 +00:00
7c45433d96
Bug 1577759 - add strings and urls for a keyboard check type for non-focusable and non-semantic clickable elements. r=gl,fluent-reviewers,flod
...
Depends on D44232
Differential Revision: https://phabricator.services.mozilla.com/D44233
--HG--
extra : moz-landing-system : lando
2019-09-01 15:55:14 +00:00
c7fb1fa618
Bug 1577790 - fix dark theme best practices icon fill color. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D44234
--HG--
extra : moz-landing-system : lando
2019-08-30 20:30:57 +00:00
4c04690578
Bug 1567200 - Add telemetry for simulation menu usage, r=yzen
...
Differential Revision: https://phabricator.services.mozilla.com/D42254
--HG--
extra : moz-landing-system : lando
2019-08-30 03:14:51 +00:00
ce078800eb
Bug 1555770 - update badge icons to correspond to the score of the accessibility issue. r=fvsch
...
Differential Revision: https://phabricator.services.mozilla.com/D43812
--HG--
extra : moz-landing-system : lando
2019-08-29 13:55:47 +00:00
973268af17
Bug 1564999 - Add menu with simulation options to the a11y panel, r=yzen
...
Differential Revision: https://phabricator.services.mozilla.com/D38885
--HG--
extra : moz-landing-system : lando
2019-08-29 05:01:52 +00:00
ac9c3d58a3
Bug 1575786 - Use unprefixed user-select property in devtools CSS; r=ladybenko,jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D43217
--HG--
extra : moz-landing-system : lando
2019-08-29 10:12:25 +00:00
346739d4b9
Bug 1564968 - add keyboard audit filter/badge to the accessibility panel. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43446
--HG--
rename : devtools/client/accessibility/components/TextLabelBadge.js => devtools/client/accessibility/components/KeyboardBadge.js
extra : moz-landing-system : lando
2019-08-28 13:09:17 +00:00
722e0fdc59
Bug 1564968 - add keyboard check section within accessibility panel sidebar checks. r=gl,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D43445
--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:19 +00:00
00c46e63a1
Bug 1564968 - create Check component for a generic check result in the checks section of the accessibility panel sidebar. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43444
--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:21 +00:00
f025c6403a
Bug 1564968 - add highlighting support for keyboard issues. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D43443
--HG--
rename : devtools/server/tests/browser/browser_accessibility_infobar_audit_text_label.js => devtools/server/tests/browser/browser_accessibility_infobar_audit_keyboard.js
extra : moz-landing-system : lando
2019-08-28 13:09:23 +00:00
511b056b80
Bug 1564968 - adding keyboard audit type serverside support. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D43442
--HG--
extra : moz-landing-system : lando
2019-08-28 13:09:24 +00:00
8a3245ac6c
Bug 1568157 - Part 4: Replace `toolbox.walker` with the contextual WalkerFront. r=yulia
...
Differential Revision: https://phabricator.services.mozilla.com/D40317
--HG--
extra : moz-landing-system : lando
2019-08-28 11:54:42 +00:00
02e806d54a
Backed out 6 changesets (bug 1564968) by yzen's request CLOSED TREE
...
Backed out changeset 4b7516635108 (bug 1564968)
Backed out changeset c3227d4ff4b3 (bug 1564968)
Backed out changeset 868dbd59c79e (bug 1564968)
Backed out changeset db1a396ab58e (bug 1564968)
Backed out changeset e69163dc4683 (bug 1564968)
Backed out changeset c12857bc6980 (bug 1564968)
2019-08-28 16:06:23 +03:00
c094bf25b6
Bug 1564968 - add keyboard audit filter/badge to the accessibility panel. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43446
--HG--
rename : devtools/client/accessibility/components/TextLabelBadge.js => devtools/client/accessibility/components/KeyboardBadge.js
extra : moz-landing-system : lando
2019-08-27 23:37:54 +00:00
411f447380
Bug 1564968 - add keyboard check section within accessibility panel sidebar checks. r=gl,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D43445
--HG--
extra : moz-landing-system : lando
2019-08-27 18:17:19 +00:00
195b0a1aaf
Bug 1564968 - create Check component for a generic check result in the checks section of the accessibility panel sidebar. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D43444
--HG--
extra : moz-landing-system : lando
2019-08-27 23:34:29 +00:00
14f3ce0a9b
Bug 1564968 - add highlighting support for keyboard issues. r=rcaliman
...
Differential Revision: https://phabricator.services.mozilla.com/D43443
--HG--
rename : devtools/server/tests/browser/browser_accessibility_infobar_audit_text_label.js => devtools/server/tests/browser/browser_accessibility_infobar_audit_keyboard.js
extra : moz-landing-system : lando
2019-08-27 18:06:41 +00:00
07581454e5
Bug 1564968 - adding keyboard audit type serverside support. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D43442
--HG--
extra : moz-landing-system : lando
2019-08-28 12:12:59 +00:00
006d44d6b7
Bug 1568157 - Part 3: Replace `toolbox.highlighter` with the contextual HighlighterFront. r=yulia
...
Differential Revision: https://phabricator.services.mozilla.com/D40316
--HG--
extra : moz-landing-system : lando
2019-08-27 19:13:45 +00:00
3f07f4b7e3
Bug 1575002 - [RTL] Force LTR the "Properties" panel in the Accessibility tab and rotate the twisties to the correct direction r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D42543
--HG--
extra : moz-landing-system : lando
2019-08-21 20:14:07 +00:00
a05a7163d5
Bug 1551829 - Upgrade to ESLint 6.1.0. r=mossop
...
This picks up various improvements, especially to how configurations are handled and some new rules.
Differential Revision: https://phabricator.services.mozilla.com/D37271
--HG--
extra : moz-landing-system : lando
2019-08-21 19:08:44 +00:00
925311bc77
Bug 1568779 - Remove editors settings comments in devtools files. r=pbro.
...
Differential Revision: https://phabricator.services.mozilla.com/D42300
--HG--
extra : moz-landing-system : lando
2019-08-19 12:48:16 +00:00
b1970e6a2f
Bug 1571466 - Cleanup unnecessary ESLint global definitions. r=mossop
...
These are raised as redeclares or unused variables by ESLint 6.
Differential Revision: https://phabricator.services.mozilla.com/D37268
--HG--
extra : moz-landing-system : lando
2019-08-19 07:11:56 +00:00
29a67174de
Bug 1568053 - Redesign contrast info in color picker (front-end), r=yzen,gl
...
Differential Revision: https://phabricator.services.mozilla.com/D40925
--HG--
extra : moz-landing-system : lando
2019-08-16 00:55:27 +00:00
932dfb20d8
Bug 1573362 - update a copy for some of the text label checks messages. r=mtigley,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D41750
--HG--
extra : moz-landing-system : lando
2019-08-15 15:15:40 +00:00
898b6983d3
Bug 1573362 - update links for the text label checks documentation. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D41749
--HG--
extra : moz-landing-system : lando
2019-08-14 14:20:50 +00:00
0284ed4bdb
Bug 1569676 - Make accessibility panel's destroy synchronous. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D39708
--HG--
extra : moz-landing-system : lando
2019-08-12 13:47:06 +00:00
b444e8b17b
Bug 1565460 - add scroll into view preference to the accessibility panel. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D39119
--HG--
extra : moz-landing-system : lando
2019-08-12 00:21:56 +00:00
a4a33c2a52
Bug 1565460 - move the specific filter buttons for a11y panel audit from top level toolbar inside a menu. r=nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D39118
--HG--
extra : moz-landing-system : lando
2019-08-09 13:13:44 +00:00
6baad29f20
Bug 1550031 - Part 3: Centralize Redux store logic for various devtools. r=jlast
...
Differential Revision: https://phabricator.services.mozilla.com/D41122
--HG--
extra : moz-landing-system : lando
2019-08-09 01:27:53 +00:00
80a144be91
Backed out 8 changesets (bug 1569676) for failures on browser_toolbox_tool_ready.js CLOSED TREE
...
Backed out changeset 997ad11003a3 (bug 1569676)
Backed out changeset 2dab5e2243d0 (bug 1569676)
Backed out changeset 59660e3e2e53 (bug 1569676)
Backed out changeset c0b0e0410a66 (bug 1569676)
Backed out changeset 1bc927ef181a (bug 1569676)
Backed out changeset 5227c89295f4 (bug 1569676)
Backed out changeset 8365fc01396b (bug 1569676)
Backed out changeset 996c40dbc9e2 (bug 1569676)
2019-08-05 22:00:23 +03:00
d75ac50d93
Bug 1569676 - Make accessibility panel's destroy synchronous. r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D39708
--HG--
extra : moz-landing-system : lando
2019-08-05 10:46:50 +00:00
157da38e6c
Bug 1568914 - Update Fluent to @fluent/bundle 0.14.0 r=zbraniecki,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D39400
--HG--
extra : moz-landing-system : lando
2019-07-30 13:21:59 +00:00
9a4d844efc
Bug 1568602 - ensure toolbar buttons do not shift when in focus. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D39226
--HG--
extra : moz-landing-system : lando
2019-07-25 23:19:51 +00:00
357ef6d576
Bug 1552142 Text inside the contrast badges should be unselectable r=yzen
...
I added `-moz-user-select: none;` to the `.badge` class in devtools/client/accessibility/accessibility.css .
Differential Revision: https://phabricator.services.mozilla.com/D37730
--HG--
extra : moz-landing-system : lando
2019-07-20 15:14:27 +00:00
75cbed9086
Bug 1566135 - Remove devtools-separator margin variables; r=ntim
...
Differential Revision: https://phabricator.services.mozilla.com/D38105
--HG--
extra : moz-landing-system : lando
2019-07-16 06:22:12 +00:00
a94e63b533
Bug 1478156 - Move shared code to be used by color contrast feature, r=yzen,gl
...
Differential Revision: https://phabricator.services.mozilla.com/D32490
--HG--
extra : moz-landing-system : lando
2019-07-15 11:01:03 +00:00
cb456cb27d
Backed out 6 changesets (bug 1478156) for dt failures on browser_html_tooltip_xul-wrapper.js . CLOSED TREE
...
Backed out changeset 5ca694230ffa (bug 1478156)
Backed out changeset fcc9123589fd (bug 1478156)
Backed out changeset 83a10c635fe9 (bug 1478156)
Backed out changeset a363971fffb0 (bug 1478156)
Backed out changeset 314855eab887 (bug 1478156)
Backed out changeset 041f51c9d4d1 (bug 1478156)
--HG--
rename : devtools/client/inspector/rules/test/browser_rules_colorpicker-appears-on-swatch-click-or-keyboard-activation.js => devtools/client/inspector/rules/test/browser_rules_colorpicker-appears-on-swatch-click.js
2019-07-14 05:32:45 +03:00
Nicolas Chevobbe
Florens Verschelde
Julian Descottes
Gabriel Luong
Brindusan Cristian
lloan
Noemi Erli
Yura Zenevich
Maliha Islam
Bogdan Tara
Itiel
Mark Banner
Alexandre Poirot
Logan Smyth
Staś Małolepszy
Krishnal Ciccolella
Narcis Beleuzu