Shawn Wilsher
c5d856d3a0
Bug 580790 - Connection::initialize can access preferences off of the main thread
...
This fixes the storage service so that it caches the value from the
preference service, and obtains the value once on the main thread.
r=asuth
sr=shaver
a=blocking2.0
2010-08-06 10:28:46 -07:00
Serge Gautherie
5fe584f0a6
Bug 619350 - Better identify the 2 'Deadlock detector correctness' tests; (Av1) Remove unwanted ";" at end of macros, Make test names and (failed) result logs more explicit, Add a log when skipping TestDeadlockDetectorScalability tests.
...
r=jones.chris.g a=(test only).
2011-02-03 10:57:00 +01:00
Ryan VanderMeulen
653a54e069
Bug 586130 - Warning C4099 fixes (storage). r=sdwilsh a=bsmedberg
2011-01-20 19:49:09 -08:00
Andrew Sutherland
f495742d55
Bug 624051 - AsyncStatement destructor should finalize statements on the asynchronous thread when available to avoid blocking the main thread. r=sdwilsh, a=blocking2.0
2011-01-19 18:16:42 -08:00
Uli Link
a57d8184d7
Bug 617272 - AIX compilation error for Firefox-3.6.12 source storage/src/variantToSQLiteT_impl.h", line 56.12: 1540-0274 (S) The name lookup for "sqlit e3_T_null" did not find a declaration; r,a=sdwilsh
2011-01-17 12:25:17 -05:00
Chris Jones
227698aa53
Bug 594263: Bump up timeout to try to make orange go away. r=sdwilsh a=t
2011-01-13 18:07:43 -06:00
Jonas Sicking
182872882a
Bug 610823: Change a few users that use nsTArrays as buffers to explicitly use fallible tarray. r=jdaggett a=blocker
2011-01-06 20:45:10 -08:00
Chris Leary
b83b3feb7f
Merge mozilla-central to tracemonkey.
2010-12-29 19:25:04 -05:00
Ms2ger
9f6720d00d
Bug 620360 - Fix unused variable warning in StatementCache::FinalizeCachedStatements; r+a=sdwilsh
2010-12-21 15:03:01 -08:00
Phil Ringnalda
7146252c8d
Bug 619623 - reorder the parts of the error messages so tbpl can spot the filename, r=sdwilsh, a=test
2010-12-18 19:30:46 -08:00
Shawn Wilsher
f14c3b0dcc
Merge Places and mozilla-central
...
a=bsmedberg
2010-12-15 19:24:51 -08:00
Shawn Wilsher
7cd8f091ad
Merge mozilla-central to Places.
2010-12-13 15:08:04 -08:00
Shawn Wilsher
7a35d860e3
Merge mozilla-central into Places.
2010-11-29 08:43:57 -08:00
Asaf Romano
9ca049f7ee
Bug 617071 - SQLiteMutex.h breaks debug builds with system sqlite. r+a=sdwilsh.
2010-12-15 20:57:11 +02:00
Shawn Wilsher
8938033f35
Fix orange on linux opt builds by ifdefing around the problem. a=orange :(
2010-11-17 14:42:13 -08:00
Shawn Wilsher
cdb6fae3a8
Backed out changeset 6716b289e613.
2010-11-12 08:57:43 -08:00
Shawn Wilsher
8a72a947c4
Disables all link coloring lookups to the db. Wanted to run this on try, but it is not cooperating. There will be orange, but that's OK. This will be backed out shortly.
2010-11-12 08:56:09 -08:00
Shawn Wilsher
deaabcb2a2
Merge mozilla-central to Places
2010-11-10 09:38:08 -08:00
Shawn Wilsher
e9f0fde783
Bug 599969 - Add a statement cache helper object that is exported by storage.
...
This adds a templated StatementCache helper object (with tests!) that allows
consumers of storage to easily cache and reuse statements. Consumers only need
to pass in the query string, and the rest is handled for them.
r=asuth
sr=rs
2010-11-08 11:42:29 -08:00
Shawn Wilsher
3be92a2c5b
Merge mozilla-central into places.
2010-10-20 12:33:53 -07:00
Shawn Wilsher
b8cbaa99f9
Merging places and mozilla-central.
2010-10-15 09:26:15 -07:00
Shawn Wilsher
1fa11d7388
Bug 599970 - Add GetInterface for nsIEventTarget on Connection
...
r=asuth
2010-10-05 15:01:22 -07:00
Dan Witte
63fc2399a4
Bug 595925 - Use OpenUnsharedDatabase in cookies. r=sdwilsh, a=final+
2010-10-19 17:24:52 -07:00
Chris Jones
52d0f01838
Bug 550611: Make nsTArray optionally infallible. sr=bsmedberg a=blocking
...
--HG--
rename : xpcom/glue/nsTArray.cpp => xpcom/glue/nsTArray-inl.h
2010-11-08 20:48:59 -06:00
Michael Wu
4b756d5fdc
Bug 597215 - Don't do setGrowthIncrement on Android, r=sdwilsh a=blocking-fennec
2010-10-12 16:20:51 -07:00
Dan Witte
5cf671a843
Back out all cookie changes due to bug 602746. a=omgeverythingisbroken
2010-10-07 19:02:30 -07:00
Marco Bonardo
31b159651d
Bug 541373 (part 2) - Provide a global VACUUM component. Use idle-daily category. r=sdwilsh a=blocking
2010-10-19 15:46:51 +02:00
Marco Bonardo
0b05880afe
Bug 541373 (part 1) - Provide a global VACUUM component. r=sdwilsh sr=vlad a=blocking
2010-10-19 15:46:49 +02:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Cme%40shawnwilsher.com%3E)
9fbe8f25d1
Bug 573492 - Use WAL journaling for places.sqlite.
...
r=sdwilsh
r=mak
a=blocking2.0
2010-09-13 09:29:42 -07:00
Marco Bonardo
647ee9c68a
Bug 596970 - ASSERTION: You can't dereference a NULL nsCOMPtr with operator->() in AsyncStatement::~AsyncStatement(). r=asuth a=dietrich
2010-10-07 10:41:27 +02:00
Robert Sayre
7d6b688fcd
merge mozilla-central to tracemonkey.
2010-09-08 10:33:07 -04:00
Robert Sayre
9ec3408857
Merge mozilla-central to tracemonkey.
2010-09-01 22:27:07 -07:00
Taras Glek
96bd2a13d9
Bug 581606 - Avoid sqlite fragmentation via SQLITE_FCNTL_CHUNK_SIZE r=asuth sr=shaver a=b6
2010-09-01 20:35:46 -05:00
Ben Turner
8eb36f1ade
Bug 593045 - 'Add SQLite file size quota management to mozStorage'. Missed a comment change. r=ted+asuth, a=blocking2.0+.
2010-09-03 09:12:27 -07:00
Ben Turner
819fb6c21d
Bug 593045 - 'Add SQLite file size quota management to mozStorage'. r=ted+asuth, a=blocking2.0+.
2010-09-03 07:41:55 -07:00
Luke Wagner
719f726121
Bug 581263 - remove slow natives (r=waldo,mrbkap)
2010-08-16 12:35:04 -07:00
Dan Witte
658afc5efd
Bug 595925 - Use OpenUnsharedDatabase in cookies. r=sdwilsh, a=final+
2010-10-07 14:00:17 -07:00
Shawn Wilsher
0181f9b93c
Bug 583882 - Need a way to clone an existing connection.
...
r=asuth
sr=shaver
a=blocking2.0
2010-08-27 12:42:58 -07:00
Shawn Wilsher
28f18db546
Bug 519769 - Open shared/unshared connection with options instead of setting shared state always
...
Use the flags SQLite provides on sqlite3_open_v2 instead of using a mutex to
protect the shared cache state.
r=asuth
a=gavin
2010-08-27 12:42:55 -07:00
Joel Maher
adaba45072
Bug 586754 Xpcshell tests should use relativesrcdir instead of $MODULE (android prepartion) r=mitchell.field a=NPOTB
2010-08-26 14:47:28 -07:00
Clint Talbert
4fa6358e1b
Backed out changeset 49beef9387a0 due to Xpcshell orange a=backout
...
--HG--
extra : rebase_source : 01307f705ab07b7784401d69a53921b200544978
2010-08-25 14:03:44 -07:00
Joel Maher
fecae963b6
Bug 586754 Change xpcshell to use $relativesrcdir instead of $module for android support a=NPOTB r=mitchell.field
2010-08-25 11:47:39 -07:00
Jonas Sicking
32a03526e0
Backout bugs 586754, 574189, 584611 due to orange. a=backout
2010-08-20 11:08:43 -07:00
Joel Maher
a6d440687b
Bug 586754 xpcshell tests should use relativesrcdir instead of $MODULE r=:Mitch a=NPOTB
2010-08-20 09:32:58 -07:00
Luke Wagner
56b2810a26
Bug 609440, part 3 - remove fallible public APIs, update mozilla (r=bent,jst,mrbkap,waldo,sdwilsh)
2010-12-03 00:24:17 -08:00
Igor Bukanov
08acfd00c4
bug 610198 - Replacing JS_GetStringBytes usage with JS_EncodeString. r=gal
2010-11-11 21:40:29 +01:00
David Anderson
b4ec0dde6d
Backed out changeset 8e119f847f97 (build busted)
2010-11-11 11:19:42 -08:00
Igor Bukanov
048e1e0a13
bug 610198 - Replacing JS_GetStringBytes usage with JS_EncodeString. r=gal
2010-11-02 15:36:25 +01:00
Robert Sayre
48cc92a4b0
Merge mozilla-central to tracemonkey.
2010-11-09 15:29:44 -05:00
Igor Bukanov
c074b68d29
bug 607695 - Avoid unnecessary JS_GetStringBytes. r=gal
2010-10-28 17:15:53 +02:00
Doug Turner
880d22155e
Bug 616019 - Maemo - 10mb places.sqlite database due to aggressive file growth. r=sdwilsh a=blocking-fennec
...
--HG--
extra : rebase_source : 0a81467765657bed731e068a5e5d0af404577420
2010-12-09 10:14:16 -08:00
Luke Wagner
cc086b9c27
Bug 613457 - use *ById JSAPIs in storage (r=sdwilsh)
...
--HG--
extra : rebase_source : bc2548573f500f664b37b24e95bdc3b9502ba28f
2011-03-21 11:37:47 -07:00
Shawn Wilsher
c8614d1b1d
Back out changeset 0b3af3fef0fd (bug 580790) due to burnage on a CLOSED TREE
2010-08-06 10:45:16 -07:00
Shawn Wilsher
5751b59241
Bug 580790 - Connection::initialize can access preferences off of the main thread
...
This part fixes the storage service so that it caches the value from the
preference service, and obtains the value once on the main thread.
r=asuth
a=blocking2.0
2010-08-06 10:28:46 -07:00
Marco Bonardo
07aa3fcc0f
Bug 547190 - AsInt64 (and other AsXXX cpp helpers) ignores GetInt64 failures. r=sdwilsh
2010-06-22 02:01:33 +02:00
Dan Witte
2cdb9d738b
Bug 572223 - too much cookies.sqlite io. Part 3: sync read per domain. r=sdwilsh
2010-07-29 12:17:42 -07:00
Steve Fink
57bf70e615
Bug 580019: Fix functiontimer crash when opening db with NULL filename
2010-08-02 14:29:59 -07:00
Neil Rashbrook
b75248e83f
Backout previous changes to try to fix bustage
2010-08-02 00:30:12 +01:00
Neil Rashbrook
a005d3a682
Bug 522770 followup to fix shared build bustage r=khuey
2010-08-02 00:00:56 +01:00
Dan Witte
55339a9932
Revert bug 572223 to fix creation of duplicate cookies.
2010-08-01 12:24:38 -07:00
Kyle Huey
ef8a1429c9
Bug 522770: Link directly to object files instead of intermediate static libs. Patch originally written by Ted Mielczarek. Checking into a CLOSED TREE as a bustage fix. reviews pending.
...
--HG--
extra : rebase_source : 54a506a5815dcdedaf3f61ad7d6bdd0529d7f5f7
2010-08-01 01:48:21 -07:00
Robert Sayre
802a358676
Merge mozilla-central to tracemonkey.
2010-07-30 21:57:41 -07:00
Dan Witte
794bd4fe32
Bug 572223 - too much cookies.sqlite io. Part 3: sync read per domain. r=sdwilsh
2010-07-29 12:17:42 -07:00
Robert Sayre
ca1f1776fe
Merge mozilla-central to tracemonkey.
2010-07-27 13:09:04 -07:00
Shawn Wilsher
049124e527
Bug 578939 - Storage service cannot be initialized off of the main thread.
...
r=asuth
a=blocking2.0
2010-07-24 11:21:17 -07:00
Luke Wagner
7371ad00ed
Bug 549143 - fatvals
2010-07-14 23:19:36 -07:00
Robert Sayre
2fd899ed0f
Merge mozilla-central to tracemonkey.
2010-07-02 17:25:52 -07:00
Jeff Walden
7022f752dc
Remove a couple checks in test code that had asserted that Object.getOwnPropertyNames wasn't implemented. r=orange
2010-07-02 00:26:09 -07:00
Shawn Wilsher
67dac4b3bc
Bug 575667 - split about:memory reporting into more detailed sections for SQLite
...
r=vlad
a=vlad
2010-07-22 10:08:59 -07:00
Benjamin Smedberg
a08857c778
Final merge and landing of bug 568691 and dependent bugs to mozilla-central on a CLOSED TREE.
...
* bug 568691, register XPCOM components statically using manifests. r=mossop, with some test and build stuff r=vlad,sdwilsh
* bug 573557, rename categories with spaces to use hypens. r=jst
* bug 573739, Don't get the private browsing service during layout module initialization, r=ehsan
This initial merge does not include some work planned to land imminently:
* The extension manager still restarts. I need to solve a problem re-reading default preferences from extensions.
* MOZ_OMNIJAR is broken: there is a patch which I need to update in bug 568691.
* I will concurrently land a mobile-browser fix for component registration, but it may require some additional packaging changes.
2010-07-01 14:26:25 -04:00
Taras Glek
684ee6b525
Bug 416330 - Suboptimal SQLite page size r=sdwilsh
2010-07-01 10:57:13 -07:00
Benjamin Smedberg
822ccb0789
Merge mozilla-central into the static-xpcom-registration branch.
2010-06-23 17:26:25 -04:00
Benjamin Smedberg
0df0345c66
Merge mozilla-central into the "branch" for but 568691. The omnijar XPT/component/chrome registration was removed during this merge, and will be re-added to the component manager shortly.
...
--HG--
rename : content/base/public/nsIChromeRegistry.idl => chrome/public/nsIChromeRegistry.idl
2010-06-21 11:41:42 -04:00
Shawn Wilsher
cc3cc69a82
Bug 571599 - Use sqlite3_unlock_notify
...
sr=vlad
r=bent
r=asuth
2010-06-21 14:23:00 -07:00
Marco Bonardo
163467f9c7
backout bug 547190 due to test failure
2010-06-22 03:49:47 +02:00
Marco Bonardo
8c1235c183
Bug 547190 - AsInt64 (and other AsXXX cpp helpers) ignores GetInt64 failures. r=asuth
2010-06-22 02:01:33 +02:00
Benjamin Smedberg
a7e67d32ad
Bug 568691 part B - mechanical changes to in-tree binary modules needed to get them building and registering correctly. After this patch, xpcshell appears to work.
2010-06-10 14:11:40 -04:00
Phil Ringnalda
c18ea161d2
Remove test from backed out bug 416330 so the CLOSED TREE can actually pass tests
2010-06-28 18:19:39 -07:00
Shawn Wilsher
0b0e0a6ff5
Backout of bug 416330 so we can freeze for the beta on a CLOSED TREE.
2010-06-28 16:31:47 -07:00
Taras Glek
9f5a975360
Bug 416330 - Suboptimal SQLite page size r=sdwilsh
...
--HG--
extra : rebase_source : 053c7b1d975304ed7d402bb619874c889c71425c
2010-06-28 12:13:26 -07:00
Shawn Wilsher
a3e5650a14
Bug 571581 - Propagate SQLITE_CONSTRAINT as an nsresult
...
r=asuth
sr=vlad
2010-06-16 09:59:24 -07:00
Dave Townsend
0383c618f7
Bug 570529: mozIStorageStatement.execute() should reset itself even if an error occurs. r=sdwilsh
2010-06-07 15:06:56 -07:00
Saint Wesonga
f3d67d3162
Bug 492625 - "Stop using underscores to start #defines" [r=vlad]
...
--HG--
extra : rebase_source : d685fb8bc375ba4fcf97742298e9361ebfe9b851
2010-06-01 08:38:00 -04:00
Jeff Walden
5ec929857e
Bug 518663 - ES5: Object.getOwnPropertyNames. r=jorendorff
2009-09-24 14:33:14 -07:00
Chris Jones
a50cfc6399
Backed out changeset c60e3e48ea38
2010-06-24 19:56:14 -05:00
Taras Glek
a591dc4cb0
Bug 416330 - Suboptimal SQLite page size r=sdwilsh
2010-06-24 16:39:24 -07:00
Ehsan Akhgari
28ec17d596
Bug 567254 - Crash in Connection::getFilename for memory-based databases; r=sdwilsh
...
--HG--
extra : rebase_source : 9fb1300af8c6b35a4e1aa229af032cd08a76e721
2010-05-20 20:21:09 -04:00
Ehsan Akhgari
db9d404619
Bug 560647 - add startup timeline instrumentation; r=vlad
2010-05-19 19:22:19 -04:00
Vladimir Vukicevic
e94d4e8f48
b=566442; add memory reporters for sqlite; r=sdwilsh
2010-05-19 13:46:08 -07:00
Shawn Wilsher
839da6a299
Test for bug 562866. r=jorendorff r=asuth
...
--HG--
rename : storage/test/unit/test_js_helpers_enumerate.js => storage/test/unit/test_js_helpers.js
2010-05-11 14:14:54 -07:00
timeless@mozdev.org, Jason Orendorff
7f0a9916a3
Bug 562866 - StatementParams::NewResolve mishandles JSVAL_IS_STRING(aId). r=sdwilsh.
...
--HG--
extra : rebase_source : f9e1ea925fa38a26c806ba6dbddc52ef83646d55
2010-05-06 13:56:39 -05:00
Daniel Holbert
d0096803e1
Bug 560383, part 2: (storage directory) Use "!!" for converting int to bool, to avoid MSVC compile warning. r=sdwilsh
2010-05-06 11:53:12 -07:00
Marco Bonardo
979d0abc03
Bug 562787 - Fix getResultByName idl description to specify it needs an AS clause. r=asuth
2010-05-05 15:28:01 +02:00
timeless@mozdev.org
0aeeef4bfa
Bug 562855 - hook_sqlite_mutex in test_true_async.cpp should check the return value from sqlite3_initialize() and sqlite3_shutdown(), r=asuth
...
--HG--
extra : rebase_source : 648695de6bf0b68965cea43b27c7f9c089d8b945
2010-05-02 01:57:00 -07:00
Mitchell Field
f544d71a9d
Bug 560095 - Use mozilla::services::GetObserverService(). r=biesi,dveditz,gavin,josh,jst,mrbkap,roc,sdwilsh,shaver,sicking,smontagu,surkov
2010-04-29 18:59:13 +02:00
Marco Bonardo
cecf42574e
Bug 559678 - followup, make the warning less scarying. rs=sdwilsh
2010-04-22 14:53:56 +02:00
Marco Bonardo
77062d8c94
Bug 559678 - Better errors for Storage transactions misuse. r=asuth
2010-04-16 14:31:18 +02:00
Andrew Sutherland
759e351de7
Bug 555124 - Intermittent "ASSERTION: AsyncStatementSpinner not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file .../mozilla/storage/test/test_true_async.cpp, line 162". null out references on the main thread to avoid destruction on the async thread. r=sdwilsh.
2010-03-29 10:54:41 -07:00
Chris Jones
76eec45c74
Bug 550425: Bump up the timeout for expensive deadlock tests and print more info on failures. r=bsmedberg,sdwilsh
2010-03-24 19:12:32 -05:00
Andrew Sutherland
805fe0e096
Bug 507414 - Add a createAsyncStatement API on mozIStorageConnection. r=sdwilsh, sr=vlad.
...
--HG--
rename : storage/src/mozStorageStatementJSHelper.cpp => storage/src/mozStorageAsyncStatementJSHelper.cpp
rename : storage/src/mozStorageStatementJSHelper.h => storage/src/mozStorageAsyncStatementJSHelper.h
rename : storage/src/mozStorageStatementParams.cpp => storage/src/mozStorageAsyncStatementParams.cpp
rename : storage/src/mozStorageStatementParams.h => storage/src/mozStorageAsyncStatementParams.h
2010-03-24 00:32:40 -07:00
Shawn Wilsher
669c5430f9
Bug 536978 - Cookies should write to the database asynchronously.
...
This makes cookie insertion, updates, and deletions happen asynchronously off of
the main thread. The only I/O done on the main thread is the initial loading of
the database at each startup.
r=dwitte
2010-03-12 07:18:38 -08:00
Shawn Wilsher
3a38f90339
Bug 552092 - Expose a length property on mozIStorageBindingParamsArray
...
Expose the length so that consumers don't have to track if they added anything
to the array themselves.
r=asuth
sr=rob_strong
2010-03-15 10:23:39 -07:00
Shawn Wilsher
79cb4cb9fa
Bug 552003 - Passing an empty mozIStorageBindingParamsArray does not error
...
Throw instead of just asserting, which makes debugging this so much easier.
r=asuth
2010-03-15 10:23:39 -07:00
Marco Bonardo
6b282c76f6
Backing out bug 536978, due to a Storage assertion causing orange. CLOSED TREE
2010-03-12 17:41:28 +01:00
Shawn Wilsher
5f9bed4706
Bug 536978 - Cookies should write to the database asynchronously.
...
This makes cookie insertion, updates, and deletions happen asynchronously off of
the main thread. The only I/O done on the main thread is the initial loading of
the database at each startup.
r=dwitte
2010-03-12 07:18:38 -08:00
Shawn Wilsher
8c6d857784
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
2009-11-09 09:58:34 -08:00
Dan Witte
0f6caf5371
Fix regression in mozIStorageStatement.bindUTF8StringParameter such that it accepts arbitrary octets by
...
not converting string types. b=544496, r=sdwilsh
2010-02-22 13:57:45 -08:00
Justin Lebar
2fc408988c
Bug 500328 - Implement History.pushState(), History.replaceState() methods. r=smaug, r=zpao, sr=sicking
2009-09-01 09:45:05 -07:00
Daniel Holbert
585d440f02
Backed out changeset dc7a04be6904 on suspicion of causing bug 543034.
2010-01-29 18:50:46 -08:00
Justin Lebar
731c252671
Bug 500328 - Implement History.pushState(), History.replaceState() methods. r=smaug, r=zpao, sr=sicking
2009-09-01 09:45:05 -07:00
Reed Loden
8e6c7ce240
Backout patch from bug 489897 as the likely cause of pwmgr test failures.
2009-12-31 01:15:11 -06:00
David Dahl ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
d9b94920dd
Bug 489897 - implement StatementRow::NewEnumerate
...
for (let colName in stmt.row) now works!
r=sdwilsh
r=ddahl
sr=mrbkap
2009-10-12 17:49:00 -05:00
Shawn Wilsher
407f3e4e1e
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
2009-07-22 15:18:33 -07:00
Shawn Wilsher
6719a68ac1
Bug 525356 - windows debug unit tests: test_connection_executeAsync.js and test_statement_executeAsync.js failing frequently (fatal assertion)
...
Make sure to release the database connection on the thread it was opened on, not
the background thread!
r=asuth
a=beltzner
2009-12-02 10:53:46 -08:00
Shawn Wilsher
97709adefd
Backed out changeset f91a016416d1 (bug 496019)
2009-12-01 15:05:52 -08:00
Shawn Wilsher
79d8f44604
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
a=dbaron
--HG--
extra : rebase_source : 8470e30ef4ca1e9fb516284cafb77b070e46fde3
2009-11-09 09:58:34 -08:00
Shawn Wilsher
fbf7a39eca
Check to make sure that sqlite has been compiled with SQLITE_SECURE_DELETE (Bug 445164); r=asuth
2009-11-23 18:46:39 -05:00
L. David Baron
210879c30c
Backed out changeset 4a0bf3ffd767 due to test crashes.
2009-11-19 13:51:31 -08:00
Shawn Wilsher
528f812e53
Bug 525356 - windows debug unit tests: test_connection_executeAsync.js and test_statement_executeAsync.js failing frequently (fatal assertion)
...
Release on the calling thread so when the connections destructor is called, it
is not on the background thread.
r=asuth
2009-11-19 11:49:20 -08:00
Blair McBride
66bcafe3f5
Bug 528076 - Unsafe LIKE warning wrongly references mozIStorageConnection::escapeStringForLIKE. r=sdwilsh
2009-11-14 10:15:12 +01:00
Shawn Wilsher
89744c4f05
Backout of bug 496019 and bug 526601 due to window build bustage.
2009-11-09 12:16:39 -08:00
Shawn Wilsher
b35dae99b7
Bustage fix for windows.
2009-11-09 10:35:26 -08:00
Shawn Wilsher
020bb307a8
Bug 496019 - mozilla::storage::Connection::Close can spin a nested event loop
...
Creates a new close method that must be used when using asynchronous statements,
and disallow Close from being called in that case.
r=asuth
sr=vlad
2009-11-09 09:58:34 -08:00
Saint Wesonga
a0d4aaf78d
Bug 479730 - mozStorageConnection::Close logs closing improperly. r=vlad
2009-11-05 14:52:55 +01:00
David Dahl
6fb3a1a51c
Bug 524787 - crash [@mozStorageResultSet::GetNextRow(mozIStorageRow**) ]. r=sdwilsh
2009-10-31 11:38:31 +01:00
Ginn Chen
f4c4e9adf3
Bug 522157 Make -D__FUNCTION__=__func__ global for Sun Studio on Solaris r=benjamin
2009-10-26 14:25:40 +08:00
L. David Baron
824e696346
Disable test_deadlock_detector for failing on OS X. (Bug 523378)
2009-10-20 20:26:04 -04:00
Marco Bonardo
6084ceecd2
Bug 519326 - Variant.h(152) : warning C4244: '=' : conversion from 'PRInt64' to 'PRInt32', possible loss of data. r=sdwilsh
2009-10-09 22:15:19 +02:00
Dietrich Ayala
6386c8d29d
Bug 419893 - sort out PGO-triggered bugs (r=ted)
...
--HG--
extra : rebase_source : 028cd891e11df11abf768107f64b1d6bca541dca
2009-10-08 11:01:13 -07:00
Robert O'Callahan
082f716edb
Backed out changeset 59a6c227df86
2009-10-02 15:23:36 +10:00
Shawn Wilsher
967ffdcab4
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
--HG--
extra : rebase_source : 3f2f703274df0405bc395191dec8f522e5aa4e40
2009-07-22 15:18:33 -07:00
Shawn Wilsher
f9e43b71fe
Remove this test. It's not terribly useful (testing basic behavior of a
...
database which is covered by tests the SQLite group runs), and relies on a "bug"
that newer versions of SQLite fix. rs=mconnor
2009-09-30 14:38:43 -07:00
Shawn Wilsher
3ab01afc42
Test only change to make tests clean up better by using the free profile directory given to us. No bug. r="duh, why didn't we do this sooner"
2009-09-30 14:17:06 -07:00
Paul O’Shannessy
85430c442e
Bug 518440 - Deprecate mozIStorageStatementWrapper & mozIStorageStatement.step() in IDL. r=sdwilsh
...
--HG--
extra : rebase_source : 0ede87a6eb9a34475d9efafa433809e571a104d3
2009-09-25 15:32:21 -07:00
Shawn Wilsher
a0119d2b00
Bug 507674 - Safer protection of AsyncExecuteStatements::mState and AsyncExecuteStatements::mCancelRequested
...
This is essentially a backout of bug 506805, followed by changing the locking
protection rules to only protect mCancelRequested writing on the calling thread,
and reading on the background thread.
--HG--
extra : rebase_source : 249a61e40c2fd140527f034e36e8c1a53518baac
2009-09-02 13:30:24 -07:00
Shawn Wilsher
20421b1d48
Bug 507199 - Fix race condition in finalizing asynchronous storage statements
...
(was "test_browserGlue_corrupt_nobackup_default.js, test_browserGlue_corrupt_nobackup.js, test_browserGlue_shutdown.js randomly crash")
Fixes a race condition with asynchronous statements that causes a crash. We do
not always have access to the background thread, so we should not assume we
always can get it.
2009-08-25 23:54:56 -07:00
Benjamin Smedberg
ba372f3a4c
Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted
2009-08-25 08:59:31 -07:00
Ginn Chen
a778d6c4a5
Bug 507978 test_deadlock_detector.cpp failed to compile on Solaris r=bsmedberg
2009-08-11 14:56:58 +08:00
Jacek Caban
647310b4f6
Bug 505734 - mozStorageStatementParams.cpp compilation fails on MinGW. r=sdwilsh
2009-08-09 22:30:38 +02:00
Akshay Gupta
ac821eca4a
Bug 433456 - mozIStorageFunction should be a [function]; r=sdwilsh
2009-08-06 20:00:39 +02:00
Shawn Wilsher
c2ac8daba2
Bug 506805 - Remove locking in AsyncExecuteStatements
...
This removes the use of the shared mutex in AsyncExecuteStatements. We now rely
on PR_AtomicSet and the volatile keyword. This results in zero lock contention
between the calling thread and the background thread if cancel is ever called.
r=asuth
r=bent
sr=vlad
2009-07-29 17:24:50 -07:00
Shawn Wilsher
3e8d79a831
Bug 506959 - AsyncExecuteStatements assumes ms, but calls functions that assume microseconds
...
This fixes the code to use functions that expect milliseconds instead of
microseconds, and updates to use the new TimeStamp and TimeDuration class.
r=asuth
2009-07-28 13:18:10 -07:00
Shawn Wilsher
ef61780206
Bug 506022 - Avoid obtaining the database mutex at all costs in Connection::ExecuteAsync
...
Stop calling any SQLite functions that would acquire the database mutex inside
Connection::ExecuteAsync. Additionally, do not actually bind parameters when
the binding functions are called, but rather when we execute (so for async
statements, that will happen on the background thread creating no mutex
contention with the main thread).
r=asuth
2009-07-28 10:21:03 -07:00
Shawn Wilsher
cbf6d8a79c
Merge places to mozilla-central.
2009-07-27 08:50:26 -07:00
Curtis Bartley
0ac9a4e2a5
Bug 498938 - Add Levenshtein Edit Distance function to Sqlite so we can use it in queries. r=sdwilsh sr=vlad
2009-07-24 11:39:34 -04:00
Shawn Wilsher
3b8c5a49ad
Merge places to mozilla-central.
2009-07-23 13:10:26 -07:00
Shawn Wilsher
2b666b27ef
Merge places to mozilla-central.
2009-07-23 07:58:59 -07:00
timeless@mozdev.org
015f42221e
Bug 491196 don't implement static functions in headers
...
r=sdwilsh
Moving JSValStorageStatementBinder to mozStoragePrivateHelpers as bindJSValue
storage/src/mozStorageStatementParams.h: At global scope:
storage/src/mozStorageStatementParams.h:78: warning: ‘PRBool mozilla::storage::JSValStorageStatementBinder(JSContext*, mozIStorageStatement*, int, jsval)’ defined but not used
storage/src/mozStorageStatementParams.h:78: warning: ‘PRBool mozilla::storage::JSValStorageStatementBinder(JSContext*, mozIStorageStatement*, int, jsval)’ defined but not used
You get this once for each file that includes a header that defines a static function which is not used in that file.
2009-07-22 17:31:03 -05:00
Shawn Wilsher
b3404e8eeb
Bug 505550 - Acquire the db's mutex when cloning statements in Connection::ExecuteAsync
...
Hold the lock around all our API calls so we don't lose so much to the
background thread.
r=asuth
2009-07-22 15:18:33 -07:00
Shawn Wilsher
a4d8d9f5d2
Bug 494828 - Stop using our own mutexes and use SQLite's where possible.
...
Part 2: Use the helper object in a few places where we had our own mutexes.
r=asuth
2009-07-22 15:18:33 -07:00