It's a minor change that should align us better with our selection of locales
(Services.intl will use user selection of regional preference locales).
I also removed the western arabic numeral system limitation to allow persian locales
to use eastern arabic numerals correctly.
MozReview-Commit-ID: 8TXX0X9RY9z
--HG--
extra : rebase_source : a7c8f507d841945e47f2d4cc142b4b05bbfab08f
This reduces the side-effects of render (which should ideally be pure) and should improve performance. We already have the mutation observer anyways.
MozReview-Commit-ID: KVhCVEhSvhi
--HG--
extra : rebase_source : 7ed2401be658abcb15bdae3f8545450983904fa8
Programmatic changes don't dispatch the event in order to avoid infinite loops.
MozReview-Commit-ID: 1GYFaSasAZO
--HG--
extra : rebase_source : fb02340c31781c9d16691ff074625d933278f33e
This avoids re-creating elements and getting references via querySelector. It's also a bit cleaner IMO.
MozReview-Commit-ID: 9eUELShq5Yg
--HG--
extra : rebase_source : 8371def08bafaa962df35fd6d1c55cc50b4bfc9d
This avoids the magic of the select automatically making the first option selected without the application state having a good way to know about this.
MozReview-Commit-ID: 1OEsjh2KW1h
--HG--
extra : rebase_source : 49a69af9a49107ea63c308ce9bd945b4868d7485
It's no longer supported to change the selectedness of options directly since that state causes conflicts with the application's own state.
MozReview-Commit-ID: kioot4BXoX
--HG--
extra : rebase_source : 45613b70daa2757f83de5c2fdeaacc596d6ce012
This is useful to ensure that the UI state is properly represented in the store.
If the re-rendering causes visible changes then that means some state is not part
of the store or is not being rendered properly.
MozReview-Commit-ID: 3J5rKWCTMAj
--HG--
extra : rebase_source : d13f35010909a804d496f6da6266cb2fb6e0e56b
In Bug 1393538 I renamed MOZ_STATIC_ASSERT_UNUSED_ATTRIBUTE to MOZ_UNUSED_ATTRIBUTE,
moved it out of it's #define depth, and used it in toolkit. I also orphaned a
comment.
This was wrong. MOZ_UNUSED_ATTRIBUTE was basically identical to MOZ_MAYBE_UNUSED
which exists in Attributes.h (because it is an attribute, not an assertion.)
Undo that wrong thing: restore MOZ_STATIC_ASSERT_UNUSED_ATTRIBUTE to the correct
place, have toolkit use the correct macro, and remove MOZ_UNUSED_ATTRIBUTE.
MozReview-Commit-ID: 5BWWsXgbm9i
--HG--
extra : rebase_source : d07156068c877bf57d400bc6a71e115b7f1aef31
Fix several problems when building Breakpad with new NDK unified
headers.
- Unified headers define its own tgkill wrapper, so rename our own
wrapper to __tgkill.
- Unified headers define user_fpxregs_struct for all API levels, so
don't redefine it.
- Only the target sources under google-breakpad/src/common/linux should
use custom Android headers, so change the includes line in moz.build to
use OS_INCLUDES.
MozReview-Commit-ID: HGnUMu5vDUM
--HG--
extra : rebase_source : f5c29c9949a48a8376f84dcc676e5f8df886f130
Apply commit afa9c52715db1e4bfaa4b01c9aec40cc249b689b from the Breakpad
upstream to support building with NDK r16.
MozReview-Commit-ID: D6xafYkjhjt
--HG--
extra : rebase_source : 41921455b9cb5351695f6d0257f130ec9121c20a
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
On my MacBook Pro, this change reduces this loop's time from ~4 ms to ~3 ms. This loop is not hot, but moving these xpconnect calls out of the loop is still a good idea.
MozReview-Commit-ID: ASwb6xZb6ur
--HG--
extra : rebase_source : 430e0ab0138b9e52affbd1e6ecacb61ab4c274bd
I thought that I fixed an off-by-one error in part 1 of this patch series,
but I didn't, I introduced one. I'm not sure why the original code didn't
work.
This patch also adds more testing (to avoid off-by-ones) and better logging
that may help if the original problem comes back.
--HG--
extra : rebase_source : f7c8e918c8acfec5b3d3248141de285b6e165b99
Extended the Telemetry::Accumulate() API to accept a string key and a nsTArray of Telemetry::LABELS_*
enums. The typesafety of the class templates ensures there are no label mismatches within the array.
Since there is no singular version for accumulating a single string label into a keyed categorical
histogram, support for the plural version with multiple string labels has not been included here.
We don't support Android for Gecko Profiler extension yet.
So for investigating arm issue, I would like to add initial support of
Gecko Profiler for Linux/arm.
--HG--
extra : rebase_source : f936a97a87b7eea2ebfefe3cbc7f8791bc90d03a
On my MacBook Pro, this change reduces this loop's time from ~4 ms to ~3 ms. This loop is not hot, but moving these xpconnect calls out of the loop is still a good idea.
MozReview-Commit-ID: ASwb6xZb6ur
--HG--
extra : rebase_source : 6cbeabb0d87fcccc8b255f9d5515537dc95ac8a4
extra : source : 62a64d4c6c7f86f5f07242bc13108ee58b79231f
Fix several problems when building Breakpad with new NDK unified
headers.
- Unified headers define its own tgkill wrapper, so rename our own
wrapper to __tgkill.
- Unified headers define user_fpxregs_struct for all API levels, so
don't redefine it.
- Only the target sources under google-breakpad/src/common/linux should
use custom Android headers, so change the includes line in moz.build to
use OS_INCLUDES.
MozReview-Commit-ID: HGnUMu5vDUM
--HG--
extra : rebase_source : 07da575044ca805a3f7f8ba87be8a8c279f17379
Apply commit afa9c52715db1e4bfaa4b01c9aec40cc249b689b from the Breakpad
upstream to support building with NDK r16.
MozReview-Commit-ID: D6xafYkjhjt
--HG--
extra : rebase_source : 92f92d04ab13ffab6e8891ca048679b6749ab1c7
Since the synced bookmark mirror is currently disabled by default, we
can do this without a migration.
MozReview-Commit-ID: LWOwWCFHpuK
--HG--
extra : rebase_source : 687557ee95c2d74908d53cf4b2d63d4aeae5377e
Telemetry::Accumulate now supports two new signatures: Accumulate(HistogramId, nsTArray stringLabels) and
Accumulate(nsTArray enumValues). In the stringLabels case, if the array contains an invalid label, then no
samples are accumulated at all. In the enumValues array case, the class template ensures that we do not have
a mismatch of labels in the array, since the enumValues class is tied to the id of the histogram we want to
accumulate to.
* Markup and CSS changes to start laying out the UI - treating the order details as an overlay on the payment summary
* Use the orderDetailsShowing store property to toggle hidden on the order details section, when rendering PaymentDialog
* Update the orderDetailsShowing property when clicking the view all items button
* Test for the payment-dialog's view-all-items functionality
MozReview-Commit-ID: HXNGmBatVYU
--HG--
extra : rebase_source : 229849d6aca10cd4489ef5b595fe12aee0d1f466
The MACHTYPE bash variable is an odd thing that returns e.g.
x86_64-redhat-linux-gnu on a CentOS system, but x86_64-pc-linux-gnu
on a Debian system, and possibly something different on other distros.
mach valgrind-test is the only place actually relying on MACHTYPE.
Others rely on information from python modules. Uniformize that, and use
the more generic 'pc' rather than 'redhat'.
--HG--
rename : build/valgrind/i386-redhat-linux-gnu.sup => build/valgrind/i386-pc-linux-gnu.sup
rename : build/valgrind/x86_64-redhat-linux-gnu.sup => build/valgrind/x86_64-pc-linux-gnu.sup
extra : rebase_source : ad94ce69e8094d2b9ddae97a3d261945886c0a61
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
Right now, we only expect classes.dex, and even --with-gradle we copy
it out of $topobjdir/mobile/android/base. This commit changes that
for --with-gradle: we only take classes.dex from the given .ap_ file,
and we also handle multiple classesN.dex files (for future multi-dex
support). The moz.build system stays the same.
This avoids an issue with newer Android-Gradle plugins, where the
classes.dex produced could be either in dex/ or in dexMerger/,
depending on whether any external libraries needed merging. By
extracting classes.dex from the .ap_ file, we don't need to know what
Gradle build steps actually occur.
The classes.dex in the package-manifest.in has been irrelevant since
Bug 1260241.
MozReview-Commit-ID: FozKwjTcMzU
--HG--
extra : rebase_source : 62b18c7ffe596be73cec4c9565333eac222b018e
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
Prior to the first patch for this bug, users with non-ascii characters
in the path to their profile directory got bad data in extensions.json.
With that bug fixed, now force a rebuild to rescue those users.
MozReview-Commit-ID: F3l87A67Ojc
--HG--
extra : rebase_source : d28322dafdcdff4dcc00e9b816f3f47b8f425de6
With emulated flex display we wrap inline-level children into anonymous
wrapper-blocks, and those wrapper blocks serve as the flex items. Using
display: block and then resetting the hardcoded width/height does the trick.
MozReview-Commit-ID: Grh1KsSmngP
--HG--
extra : rebase_source : d0792b19387e50d7c70a50a741c060655d4a3669
There are still known issues with the browser chrome when emulating, but this changeset is
done in service of getting the UI to be close enough to start running Talos tests against
it in Bug 1425330.
MozReview-Commit-ID: B0w1aOmi4FJ
--HG--
extra : rebase_source : e8b13f9203f0e368fb6f36bc9d2059fff7061b54
This is a short-term solution to our inability to apply CSP to
chrome-privileged documents.
Ideally, we should be preventing all inline script execution in
chrome-privileged documents, since the reprecussions of XSS in chrome
documents are much worse than in content documents. Unfortunately, that's not
possible in the near term because a) we don't support CSP in system principal
documents at all, and b) we rely heavily on inline JS in our static XUL.
This stop-gap solution at least prevents some of the most common vectors of
XSS attack, by automatically sanitizing any HTML fragment created for a
chrome-privileged document.
MozReview-Commit-ID: 5w17celRFr
--HG--
extra : rebase_source : 1c0a1448a06d5b65e548d9f5362d06cc6d865dbe
extra : amend_source : 7184593019f238b86fd1e261941d8e8286fa4006
This adds a dignostic assertion that the name pointer is actually within the
static name table.
--HG--
extra : rebase_source : 4f82f72c83444a3ccd5be270080837f60110766e
This switches from `nsDependentCString` to `nsLiteralCString` when adding
histograms to the table. It will help save some memory and should avoid the OOM
smalls we have been seeing.
--HG--
extra : rebase_source : b59725b1ffa40353d4dd5b3016d201b8a65325d4
Don't use the parent node options when creating new folder nodes, since they should retain
their original options.
Additionally, we can filter nodes in the queries rather than building a lot of nodes that
will be filtered out.
MozReview-Commit-ID: MmlGDe5QgV
--HG--
extra : rebase_source : 66eea325825007266e08424630b092b9e8d75b67
Zibi Braniecki
Matthew Noorenberghe
Tom Ritter
Luke Crouch
Ian Moody
Christian Holler
Gijs Kruitbosch
Jim Chen
Kris Maglione
Marco Castelluccio
Csoregi Natalia
Chris Peterson
Paul Bone
Bryce Van Dyk
Aditya Bharti
Makoto Kato
Gurzau Raul
Boris Zbarsky
Narcis Beleuzu
Cosmin Sabou
Kit Cambridge
Sam Foster
Mike Hommey
Nick Alexander
Brindusan Cristian
Kartikaya Gupta
Margareta Eliza Balazs
shindli
Andrea Marchesini
Coroiu Cristina
Mark Striemer
vinoth
Noemi Erli
Andreea Pavel
Dzmitry Malyshau
Ryan VanderMeulen
Marco Bonardo
Andrew Swan
Brian Grinstead
arthur.iakab
Chris H-C
Eric Rahm
Alejandro Rodriguez