394ac42d42
Bug 1657348: Simplify CouldBeHttpsOnlyError within docshell. r=JulianWels
...
Differential Revision: https://phabricator.services.mozilla.com/D86009
2020-08-05 15:18:01 +00:00
1c71a222fc
Bug 1653729 - Part 1: Generalize do_QueryActor API, r=kmag
...
This changes the set of types which can be passed as the second argument to
do_QueryActor to ones which can be unambiguously converted to a JSActorManager,
and combines nsCOMPtr_helper implementations.
Differential Revision: https://phabricator.services.mozilla.com/D84067
2020-08-04 21:34:29 +00:00
2d1151529c
Bug 1654922 - Part 1: Remove DocumentChannel pref usage from tests and document navigation code, r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D85483
2020-08-01 16:36:12 +00:00
96f3e7e019
Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-04 11:27:07 +00:00
381fca9783
Backed out 4 changesets (bug 1654992, bug 1654991) for causing timeous in mask-opacity-1e.html
...
Backed out changeset 11f0f54c6e0a (bug 1654992)
Backed out changeset a353dd5b3f08 (bug 1654991)
Backed out changeset 6a7964ba549f (bug 1654991)
Backed out changeset cf3bfb91d98c (bug 1654991)
2020-08-03 22:09:36 +03:00
032d2ac9d3
Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84807
2020-08-03 14:54:18 +00:00
843f943758
Bug 1519636 - Reformat recent changes to the Google coding style r=andi
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D85678
2020-08-02 15:29:15 +00:00
6ceacee1c3
Bug 1646567 - fix nsDocShell::HasUnloadedParent to work for OOP frames. r=nika
...
With fission enabled, walking the docshell tree to find unloaded
parents would stop at the first OOP parent. Instead we now walk
the `BrowsingContext`/`WindowContext` tree. To still check parents
which are OOP, we take advantage of the fact that a parent
`WindowContext` will no longer be the current `WindowContext` if
the parent was unloaded. For in process docshell's we additionally
check the docshell directly.
Differential Revision: https://phabricator.services.mozilla.com/D85328
2020-07-31 19:58:09 +00:00
336243e692
Backed out changeset 6164e09df60e (bug 1646567) for nsDocShell failures. CLOSED TREE
2020-07-31 21:26:45 +03:00
ae5aa0f5bf
Bug 1646567 - fix nsDocShell::HasUnloadedParent to work for OOP frames. r=nika
...
With fission enabled, walking the docshell tree to find unloaded
parents would stop at the first OOP parent. Instead we now walk
the `BrowsingContext`/`WindowContext` tree. To still check parents
which are OOP, we take advantage of the fact that a parent
`WindowContext` will no longer be the current `WindowContext` if
the parent was unloaded. For in process docshell's we additionally
check the docshell directly.
Differential Revision: https://phabricator.services.mozilla.com/D85328
2020-07-31 16:23:58 +00:00
5ae385d240
Bug 1613431 - Part 4: Require that synced field setters' return value is handled. r=nika
...
Depends on D83647
Differential Revision: https://phabricator.services.mozilla.com/D83648
2020-07-31 13:37:20 +00:00
b13577d8e4
Bug 1613431 - Part 3: Handle synced setters return value. r=nika
...
Depends on D83646
Differential Revision: https://phabricator.services.mozilla.com/D83647
2020-07-31 13:37:13 +00:00
8d7d0ec85c
Bug 1613431 - Part 2: Ignore synced setters return value. r=nika
...
Depends on D83645
Differential Revision: https://phabricator.services.mozilla.com/D83646
2020-07-31 13:37:00 +00:00
336fe46681
Bug 1613431 - Part 1: Have synced setters return nsresult. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D83645
2020-07-31 13:36:45 +00:00
26b28f1b65
Bug 1654525 - Ensure loads initiated from session history in parent reuse the existing SHEntries, r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D85173
2020-07-29 14:23:09 +00:00
ca634b6fb5
Bug 1635253 - Add new about:glean to control Glean SDK debugging, logging r=janerik,flod
...
Included documentation, but no tests, as it doesn't yet actually control the
Glean SDK.
Differential Revision: https://phabricator.services.mozilla.com/D83977
2020-07-30 16:35:17 +00:00
bcb0efc158
Bug 1654569 - Keep BrowsingContextGroup alive throughout the process switch, r=farre,annyG
...
This builds on the new API added in bug 1652085 to reduce the chance of a
different BrowsingContextGroup instance being used for process selection at the
start of a process switch, and BrowsingContext creation at the end.
While this would probably not be a serious issue right now, as we always have
only a single "extension" process, it could become an issue in the future if the
specific group specifier is used in more places.
Differential Revision: https://phabricator.services.mozilla.com/D84549
2020-07-30 20:27:44 +00:00
5ed1074194
Bug 1652085 - Delay BrowsingContextGroup destruction until acked, r=farre
...
This should ensure that any BrowsingContexts racily created during the discard
process don't end up creating a separate BrowsingContextGroup from their
relatives, and triggering group mismatch assertions.
Differential Revision: https://phabricator.services.mozilla.com/D84548
2020-07-30 20:27:41 +00:00
06dd04520e
Bug 1652144 - Part 2: Consider current BrowsingContextGroup for process selection, r=farre
...
This requires keeping track of the current process used to host documents with a
particular remote type loaded in each BrowsingContextGroup. Due to lifecycle
oddities, this set is kept separate from the existing subscribers set on
BrowsingContextGroup.
Differential Revision: https://phabricator.services.mozilla.com/D84061
2020-07-30 20:27:37 +00:00
59bd2d5f83
Bug 1652144 - Part 1: Remove unused argument from process launch methods, r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D84060
2020-07-30 20:27:34 +00:00
baee2f562d
Bug 1587418 - cache shortcuts permission on WindowContext. r=farre
...
We now cache the shortcuts permission in a synced field on
`WindowContext`. This will allow checking the permission quickly and
without IPC when Fission is enabled and the top-level document is
in another process.
Differential Revision: https://phabricator.services.mozilla.com/D84182
2020-07-30 12:26:24 +00:00
e3ebda1914
Bug 1223932 - delete guard object uses from the tree; r=jwalden
...
CLOSED TREE
We don't need these macros anymore, for two reasons:
1. We have static analysis to provide the same sort of checks via `MOZ_RAII`
and friends.
2. clang now warns for the "temporary that should have been a declaration" case.
The extra requirements on class construction also show up during debug tests
as performance problems.
This change was automated by using the following sed script:
```
# Remove declarations in classes.
/MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER/d
/MOZ_GUARD_OBJECT_NOTIFIER_INIT/d
# Remove individual macros, carefully.
{
# We don't have to worry about substrings here because the closing
# parenthesis "anchors" the match.
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_TO_PARENT)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_IN_IMPL)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_IN_IMPL)/)/g;
# Remove the longer identifier first.
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_TO_PARENT//g;
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM//g;
}
# Remove the actual include.
\@# *include "mozilla/GuardObjects.h"@d
```
and running:
```
find . -name \*.cpp -o -name \*.h | grep -v 'GuardObjects.h' |xargs sed -i -f script 2>/dev/null
mach clang-format
```
Differential Revision: https://phabricator.services.mozilla.com/D85168
2020-07-30 14:22:38 +00:00
a911a108d0
Backed out changeset ac9c811bc427 (bug 1223932) for causing spidermonkey rust failures.
...
CLOSED TREE
2020-07-30 18:23:21 +03:00
bec9f9b93a
Bug 1223932 - delete guard object uses from the tree; r=jwalden
...
We don't need these macros anymore, for two reasons:
1. We have static analysis to provide the same sort of checks via `MOZ_RAII`
and friends.
2. clang now warns for the "temporary that should have been a declaration" case.
The extra requirements on class construction also show up during debug tests
as performance problems.
This change was automated by using the following sed script:
```
# Remove declarations in classes.
/MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER/d
/MOZ_GUARD_OBJECT_NOTIFIER_INIT/d
# Remove individual macros, carefully.
{
# We don't have to worry about substrings here because the closing
# parenthesis "anchors" the match.
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_TO_PARENT)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_IN_IMPL)/)/g;
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_IN_IMPL)/)/g;
# Remove the longer identifier first.
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_TO_PARENT//g;
s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM//g;
}
# Remove the actual include.
\@# *include "mozilla/GuardObjects.h"@d
```
and running:
```
find . -name \*.cpp -o -name \*.h | grep -v 'GuardObjects.h' |xargs sed -i -f script 2>/dev/null
mach clang-format
```
Differential Revision: https://phabricator.services.mozilla.com/D85168
2020-07-30 14:22:38 +00:00
d0686776d2
Bug 1648955 - Check parent WC is in-proc rather than parent BC nsDocShell to tree, r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D85309
2020-07-30 12:27:12 +00:00
75b193e637
Bug 1655549 - Implement BrowsingContext::GetAllBrowsingContextsInSubtree, r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D85311
2020-07-29 21:10:36 +00:00
2e5bd98b61
Bug 1647449 - fix nsDocShell::DetermineContentType to work for OOP frames. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D85194
2020-07-29 15:41:40 +00:00
fb1d1dc1df
Bug 1558394 - Pass the TriggeringSandboxFlags to nsILoadinfo r=ckerschb,smaug,necko-reviewers,valentin
...
Add triggering Sandbox flags to loadinfo
***
Pass triggering Flags into Loadinfo
***
Fix triggeringSandboxflags passing
Differential Revision: https://phabricator.services.mozilla.com/D69588
2020-07-29 11:43:23 +00:00
bcde4b996a
Bug 1655735 - Remove nsIDocShell::GetOSHEId. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D85146
2020-07-28 14:17:49 +00:00
cf561cece0
Backed out 5 changesets (bug 1652144, bug 1654569, bug 1652085) for assertion failure nsDocShell.cpp. CLOSED TREE
...
Backed out changeset 4388af0c7d95 (bug 1654569)
Backed out changeset 66d5bb2ff027 (bug 1652085)
Backed out changeset 05132c178b4f (bug 1652144)
Backed out changeset fbdc7fd9cb96 (bug 1652144)
Backed out changeset 920a06a52b8b (bug 1652144)
2020-07-26 11:12:52 +03:00
09b3c13a42
Bug 1648955 - Stop process changing loads in inactive subframes, r=mattwoodrow,annyG
...
Differential Revision: https://phabricator.services.mozilla.com/D84752
2020-07-24 22:19:38 +00:00
82d3bd6bd5
Bug 1654569 - Keep BrowsingContextGroup alive throughout the process switch, r=farre,annyG
...
This builds on the new API added in bug 1652085 to reduce the chance of a
different BrowsingContextGroup instance being used for process selection at the
start of a process switch, and BrowsingContext creation at the end.
While this would probably not be a serious issue right now, as we always have
only a single "extension" process, it could become an issue in the future if the
specific group specifier is used in more places.
Differential Revision: https://phabricator.services.mozilla.com/D84549
2020-07-24 20:24:48 +00:00
9ad094035e
Bug 1652085 - Delay BrowsingContextGroup destruction until acked, r=farre
...
This should ensure that any BrowsingContexts racily created during the discard
process don't end up creating a separate BrowsingContextGroup from their
relatives, and triggering group mismatch assertions.
Differential Revision: https://phabricator.services.mozilla.com/D84548
2020-07-24 20:24:45 +00:00
fc494ad88c
Bug 1652144 - Part 2: Consider current BrowsingContextGroup for process selection, r=farre
...
This requires keeping track of the current process used to host documents with a
particular remote type loaded in each BrowsingContextGroup. Due to lifecycle
oddities, this set is kept separate from the existing subscribers set on
BrowsingContextGroup.
Differential Revision: https://phabricator.services.mozilla.com/D84061
2020-07-24 20:24:36 +00:00
03de005ca0
Bug 1652144 - Part 1: Remove unused argument from process launch methods, r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D84060
2020-07-24 20:24:33 +00:00
1b3d2a37fb
Bug 1647229 - Synchronize layouthistorystate to parent process, r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D81753
2020-07-23 19:35:29 +00:00
ff61891772
Bug 1653011 - Simplify and make WeakPtr<Derived> usable and compact. r=froydnj,sg,geckoview-reviewers,jgilbert,kvark,snorp
...
Having two classes in the inheritance chain inherit from SupportsWeakPtr
now won't compile, but you can use WeakPtr<Derived> when any base class
inherits from SupportsWeakPtr.
Differential Revision: https://phabricator.services.mozilla.com/D83674
2020-07-23 14:51:46 +00:00
37e1247796
Bug 1653839 - Fix error 'mozilla/dom/RTCCertificateBinding.h' file not found on mingw builds. r=keeler
...
Differential Revision: https://phabricator.services.mozilla.com/D84480
2020-07-22 16:22:55 +00:00
e9a6ea525b
Bug 1607092 - Add new quote from Book of Mozilla for GeckoView r=geckoview-reviewers,Pike,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D80575
2020-07-07 02:22:07 +00:00
e443211b53
Bug 1653229 - Remove unnecessary includes for BindingUtils.h. r=jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D83771
2020-07-22 15:12:10 +00:00
2d57d60bcc
Bug 1653000 - Use a fold expression within EachIndexInner instead of recursion. r=nika,farre
...
Differential Revision: https://phabricator.services.mozilla.com/D84131
2020-07-22 09:43:28 +00:00
49c7080ba4
Bug 1653000 - Part 2: Refactor CreateDetached to reduce callers of SetWithoutSyncing, r=farre
...
With the new implementation from part 1, this is now shorter to write than it
would be before.
Depends on D84063
Differential Revision: https://phabricator.services.mozilla.com/D84064
2020-07-22 09:13:20 +00:00
dc09e15686
Bug 1653000 - Part 1: Switch away from tuples in SyncedContext, r=farre,sg
...
This should help reduce the overhead of template instantiation in C++ code.
Differential Revision: https://phabricator.services.mozilla.com/D84063
2020-07-22 14:07:26 +00:00
3d27322bc3
Bug 1653000 - Declare WindowGlobalInit and SyncedContextInitializer uncomparable and remove unused equality operators. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D84299
2020-07-22 11:48:11 +00:00
ecaad75230
Bug 1639577 - Only suspend GeckoView tabs that are alone in their BrowsingContextGroup r=nika,geckoview-reviewers,agi
...
This avoids problems where a foreground tab tries to communicate with a background
tab via `window.opener`, but is unable to because the background tab
is suspended.
Differential Revision: https://phabricator.services.mozilla.com/D83693
2020-07-21 21:04:53 +00:00
081870285c
Bug 1646899 - P4: Handle object & embed via DocumentChannel. r=mattwoodrow,jya
...
Pass internal content policy type to DLL and switch behavior depending on type
being loaded. This implementation immediately redirects channel back to the
content process for further handling.
Depends on D80406
Differential Revision: https://phabricator.services.mozilla.com/D80407
2020-07-21 01:01:05 +00:00
06cb85265c
Bug 1646899 - P3: Modify CanUseDocumentChannel to take necessary vars. r=mattwoodrow
...
Allows checking if DocumentChannel can be used with out creating an
nsDocShellLoadState object.
Depends on D80405
Differential Revision: https://phabricator.services.mozilla.com/D80406
2020-07-21 01:01:03 +00:00
78c662789a
Bug 1617987 - Fix URLs by prefixing www. when users encounter bad cert domain errors. r=nika,keeler
...
Differential Revision: https://phabricator.services.mozilla.com/D82024
2020-07-18 13:38:59 +00:00
9717edb569
Bug 1637745. r=Gijs,necko-reviewers,mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D80345
2020-07-17 13:45:58 +00:00
02b5195413
Bug 1653482 - Tidy up after Bug 1647109 r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D83897
2020-07-17 09:39:59 +00:00
306b718cb8
Bug 1602115, make it possible to test async history.length handling even when session history lives in the child process, r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D79198
2020-07-16 23:04:18 +00:00
41fc87999f
Bug 1602115 - Make history.length Fission compatible, r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D79197
2020-07-16 22:23:29 +00:00
5cad4b348e
Bug 1652849: Use NotifyWhenScriptSafe for some additional observers. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D83845
2020-07-16 20:44:51 +00:00
86341ec4ef
Bug 1653214 - Part 2: Remove nsIBaseWindow::Create; r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D83767
2020-07-16 20:42:20 +00:00
beeae4cb08
Bug 1653214 - Part 1: Merge implementations of nsDocShell::Create into nsDocShell::InitWindow; r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D83766
2020-07-16 20:42:02 +00:00
4ccaec8564
Backed out 3 changesets (bug 1653123, bug 1602115) for perma failures on test_history_length_during_pageload.html. CLOSED TREE
...
Backed out changeset 6b3c0f542ef3 (bug 1653123)
Backed out changeset 951c0fd65a00 (bug 16021151602115
2020-07-16 23:21:18 +03:00
37f08f36a0
Bug 1647430 - part2 : store `DocTreeHadAudibleMedia` in WindowContext. r=nika
...
After we enable Fissions, we can't always access the top level document because it might be in another process.
Therefore, we should move `mDocTreeHadAudibleMedia` from document to the top window context, which can ensure that we set the value correctly even if setting `mDocTreeHadAudibleMedia` happens in a different process which is different from the process where the top level document exists.
Differential Revision: https://phabricator.services.mozilla.com/D83162
2020-07-16 19:53:49 +00:00
c75a803c6e
Bug 1646542: Fix GetInProcessParent usage in IsSameOrAncestor. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80097
2020-07-15 20:17:52 +00:00
e702898d75
Bug 1602115, make it possible to test async history.length handling even when session history lives in the child process, r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D79198
2020-07-16 19:02:49 +00:00
c142af0f58
Bug 1602115 - Make history.length Fission compatible, r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D79197
2020-07-16 19:01:36 +00:00
9db58fa8c3
Bug 1648040 - Use the new session history if pref is on. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80885
2020-07-16 14:04:59 +00:00
1493d7798d
Bug 1621403 - part2 : implement `seekto` action. r=chunmin,emilio
...
Implement `Seekto` action [1]. In addtion, as `seekto` can go with additional properties, we create a new structure `MediaControlAction` to wrap `MediaControlKey` and `SeekDetails`, which can be sent with `seekto`.
[1] https://w3c.github.io/mediasession/#dom-mediasessionaction-seekto
Differential Revision: https://phabricator.services.mozilla.com/D82816
2020-07-16 00:16:33 +00:00
da46069826
Bug 1648038 - Create session history entry in the parent without checking if session history is on for the browsing context, because we only find out later if session history is disabled. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80884
2020-07-14 10:41:04 +00:00
1ca3ccc2c4
Bug 1648038 - Don't require session history object when creating an entry. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80883
2020-07-14 11:14:46 +00:00
b2c2617436
Bug 1648400 - Make it possible to get back to nsISHEntry from SessionHistoryInfo ID, r=peterv
...
Using raw pointer to the hashtable to avoid static constructors.
Differential Revision: https://phabricator.services.mozilla.com/D81353
2020-07-15 15:54:02 +00:00
a7153982e8
Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
...
Differential Revision: https://phabricator.services.mozilla.com/D83490
2020-07-15 11:20:45 +00:00
7e76f843c7
Bug 1641467 - Remove temporary browser.fixup.defaultToSearch feature pref and its code. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D83554
2020-07-15 09:53:04 +00:00
58ab7096a2
Bug 1647431, make ReportShadowDOMUsage Fission compatible, r=edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D83471
2020-07-14 11:22:20 +00:00
4f6b5e6e2a
Backed out 2 changesets (bug 1648038) for build bustages on nsDocShell.cpp. CLOSED TREE
...
Backed out changeset 78b8a2b9277a (bug 1648038)
Backed out changeset b6b620d72e6b (bug 1648038)
2020-07-14 12:17:31 +03:00
48cb1143b8
Bug 1648038 - Create session history entry in the parent without checking if session history is on for the browsing context, because we only find out later if session history is disabled. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80884
2020-07-14 08:57:59 +00:00
f481f2b486
Bug 1648038 - Don't require session history object when creating an entry. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80883
2020-07-14 08:57:54 +00:00
c7c65a2a89
Bug 1644140 - Remove nsDocShell::AddChildSHEntryInternal and make some session history code in nsDocShell work with fission. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D78686
2020-07-13 15:42:15 +00:00
8981494089
Backed out 5 changesets (bug 1646899) for mochitest failures on DocumentLoadListener.cpp . CLOSED TREE
...
Backed out changeset f41ac122a801 (bug 1646899)
Backed out changeset 86a5e0827050 (bug 1646899)
Backed out changeset d2fd0f955e24 (bug 1646899)
Backed out changeset 7a7194146fe1 (bug 1646899)
Backed out changeset 4731d76dae88 (bug 1646899)
2020-07-13 05:43:30 +03:00
f5fd7b3d97
Bug 1646899 - P4: Handle object & embed via DocumentChannel. r=mattwoodrow,jya
...
Pass internal content policy type to DLL and switch behavior depending on type
being loaded. This implementation immediately redirects channel back to the
content process for further handling.
Differential Revision: https://phabricator.services.mozilla.com/D80407
2020-07-13 00:48:57 +00:00
8847465b59
Bug 1646899 - P3: Modify CanUseDocumentChannel to take necessary vars. r=mattwoodrow
...
Allows checking if DocumentChannel can be used with out creating an
nsDocShellLoadState object.
Differential Revision: https://phabricator.services.mozilla.com/D80406
2020-07-13 00:48:54 +00:00
b6be72f351
Bug 1649554: Part 1 - Move deprecated component registration helpers out of XPCOMUtils. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,whimboo,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D81749
2020-07-10 23:58:30 +00:00
9d78661f88
Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
4238e3d8e8
Bug 1648583: Add GetCurrentTopByBrowserId() to get the BrowsingContext for a tab r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D81181
2020-07-09 20:34:06 +00:00
17fbf88433
Bug 1649879 - Handle URIFixup that happens on a failed channel in DocumentLoadListener if available, rather than waiting for it to reach nsDocShell. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D81947
2020-07-08 23:38:22 +00:00
6aac98f0a2
Bug 1649879 - Implement WebNavigationFlagsToFixupFlags in C++ so that we avoid needing to call into the URIFixup JS module. r=kmag
...
This should be the exact same code, just avoiding needing to create the URIFixup service in order to run it.
Differential Revision: https://phabricator.services.mozilla.com/D81945
2020-07-08 23:37:42 +00:00
655377eb57
Bug 1649879 - Don't create nsIURIFixupInfo in content process nsDocShellLoadState construction. r=kmag
...
Rather than constructing an nsIURIFixupInfo from the IPC call return valuess, and then immediately querying the same data, this just use the results directly.
It also moves the firing of "keyword-uri-fixup" observers to the parent process side. As far as I can tell, the only consumer was URIFixupChild, which was also forwarding them to the parent process.
Differential Revision: https://phabricator.services.mozilla.com/D81944
2020-07-08 23:37:29 +00:00
38e792c270
Bug 1649879 - Fold GetFixupURIInfo into the calling code. r=kmag
...
This should be a no-op change, just to make the next patch a small diff.
Differential Revision: https://phabricator.services.mozilla.com/D81943
2020-07-08 23:37:17 +00:00
3f8ded27c9
Bug 1650163 - Part 2: Add a NOT_REMOTE_TYPE define to clarify calling code, r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D82106
2020-07-08 20:16:04 +00:00
22a65a237e
Bug 1650163 - Part 1: Switch native remoteType values to nsCString, r=farre,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D82104
2020-07-08 20:15:59 +00:00
1ba2a3f6f6
Backed out 3 changesets (bug 1650163) for causing bustages in nsContentSecurityManager.cpp
...
CLOSED TREE
Backed out changeset 51d7c644a1e6 (bug 1650163)
Backed out changeset 3d2b6908447a (bug 1650163)
Backed out changeset 79141707d47b (bug 1650163)
2020-07-08 21:18:44 +03:00
64031d88e9
Bug 1650163 - Part 2: Add a NOT_REMOTE_TYPE define to clarify calling code, r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D82106
2020-07-08 01:13:45 +00:00
c850a94434
Bug 1650163 - Part 1: Switch native remoteType values to nsCString, r=farre,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D82104
2020-07-08 14:54:48 +00:00
c44ea283e8
Bug 1644456 - Manage HTTPS-Only Mode permission with SitePermissions interface. r=necko-reviewers,pbz,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D79427
2020-07-08 12:06:02 +00:00
8359f16846
Backed out 7 changesets (bug 1650163, bug 1649477) for bustages on JSActor.cpp . CLOSED TREE
...
Backed out changeset 4a21afb65254 (bug 1650163)
Backed out changeset c41753a56f5a (bug 1650163)
Backed out changeset 5fb444c35764 (bug 1650163)
Backed out changeset 830aa93d2b0c (bug 1649477)
Backed out changeset eca6e9dce450 (bug 1649477)
Backed out changeset 5b217aa88289 (bug 1649477)
Backed out changeset 8959d02b840f (bug 1649477)
2020-07-08 04:09:27 +03:00
a3b4b6cba4
Bug 1650163 - Part 2: Add a NOT_REMOTE_TYPE define to clarify calling code, r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D82106
2020-07-06 20:27:59 +00:00
df351180c3
Bug 1650163 - Part 1: Switch native remoteType values to nsCString, r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D82104
2020-07-06 20:30:58 +00:00
cafcceeb34
Bug 1599579 - Part 1: Add the ability to specify a specific BrowsingContextGroup during process switch, r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D80254
2020-07-06 20:10:43 +00:00
4cb7f584bf
Bug 1647109 - Set the child history as in process when the BC is in process r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D82367
2020-07-07 01:10:01 +00:00
817b91a023
Bug 1581500 - Don't assert if there are multiple process switches in-flight, since we don't do anything to prevent this. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D82309
2020-07-06 19:31:33 +00:00
eb99a31f3b
Bug 1646609: Don't assert when an inactive/OOP inner window tries to navigate an OOP BrowsingContext. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D81731
2020-07-06 19:56:32 +00:00
402b0a5c46
Bug 1647719: Introduce Pref for HTTS-Only in Private Browsing Mode. r=JulianWels,jcj
...
Differential Revision: https://phabricator.services.mozilla.com/D80873
2020-07-06 08:52:02 +00:00
057efa89c8
Backed out 5 changesets (bug 1649879) for browser-chrome failures at browser/base/content/test/tabs/browser_progress_keyword_search_handling.js
...
Backed out changeset f9670eed4ac5 (bug 1649879)
Backed out changeset 76ab8adad34b (bug 1649879)
Backed out changeset 6dc2e9474f43 (bug 1649879)
Backed out changeset 6f905d33681f (bug 1649879)
Backed out changeset 13b19e14a332 (bug 1649879)
2020-07-06 10:44:56 +03:00
1ef58514bd
Bug 1649879 - Handle URIFixup that happens on a failed channel in DocumentLoadListener if available, rather than waiting for it to reach nsDocShell. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D81947
2020-07-06 04:29:33 +00:00
830392048a
Bug 1649879 - Implement WebNavigationFlagsToFixupFlags in C++ so that we avoid needing to call into the URIFixup JS module. r=kmag
...
This should be the exact same code, just avoiding needing to create the URIFixup service in order to run it.
Differential Revision: https://phabricator.services.mozilla.com/D81945
2020-07-06 04:29:08 +00:00
970c9c00b8
Bug 1649879 - Don't create nsIURIFixupInfo in content process nsDocShellLoadState construction. r=kmag
...
Rather than constructing an nsIURIFixupInfo from the IPC call return valuess, and then immediately querying the same data, this just use the results directly.
It also moves the firing of "keyword-uri-fixup" observers to the parent process side. As far as I can tell, the only consumer was URIFixupChild, which was also forwarding them to the parent process.
Differential Revision: https://phabricator.services.mozilla.com/D81944
2020-07-06 04:29:06 +00:00
bdc50cf48e
Bug 1649879 - Fold GetFixupURIInfo into the calling code. r=kmag
...
This should be a no-op change, just to make the next patch a small diff.
Differential Revision: https://phabricator.services.mozilla.com/D81943
2020-07-06 04:29:04 +00:00
3305455259
Bug 1649772 - Simplify nsIWebPageDescriptor, r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D81871
2020-07-02 14:58:15 +00:00
356e90f2b6
Bug 1647301 - Remove forceCharset from nsIContentViewer. r=m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D80470
2020-07-02 06:23:24 +00:00
ed35966cff
Bug 1648679 - Allow setting UseErrorPages from the parent process. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D81484
2020-07-02 00:53:18 +00:00
9364b353d4
Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80631
2020-07-01 08:42:31 +00:00
e3c223da3e
Bug 1648010 - Fix uses of NS_LITERAL_STRING with C string literals. r=geckoview-reviewers,agi,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80861
2020-07-01 08:34:12 +00:00
cd8b8939b9
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
31d8600b73
Backed out changeset 6debf3390ba2 (bug 1646609) for mochitest failures on docshell/base/BrowsingContext.cpp
2020-07-01 08:39:53 +03:00
d646c6cbe9
Bug 1646609: Don't assert when an inactive/OOP inner window tries to navigate an OOP BrowsingContext. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D81731
2020-06-30 22:19:56 +00:00
e01165cdfc
Backed out changeset 6d882a42cfbe (bug 1646519) for causing failure on WindowContext.cpp. CLOSED TREE
2020-07-01 01:11:52 +03:00
6f9317a061
Bug 1646519: Fix GetInProcessTopInternal usage in GetZone. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80092
2020-06-25 21:13:10 +00:00
146ad267af
Backed out 6 changesets (bug 1599579) for bc failures at test_chrome_ext_contentscript_data_uri.html.
...
Backed out changeset b767f26b10ed (bug 1599579)
Backed out changeset c5bc0ea42193 (bug 1599579)
Backed out changeset cfdd8d5973d4 (bug 1599579)
Backed out changeset 73f6c956fc30 (bug 1599579)
Backed out changeset 14698ab42ee4 (bug 1599579)
Backed out changeset b4bdd8759433 (bug 1599579)
2020-06-30 21:41:27 +03:00
824c8da580
Bug 1599579 - Part 1: Add the ability to specify a specific BrowsingContextGroup during process switch, r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D80254
2020-06-30 16:52:53 +00:00
c056aaf0b8
Bug 1623461 - Clear nsDocShell::mBlankTiming when providing an existing timing object from a process switch. r=jya
...
Differential Revision: https://phabricator.services.mozilla.com/D81636
2020-06-30 03:32:43 +00:00
7d65de1298
Bug 1647557 - Add preffed-off code for controlling document loads directly from CanonicalBrowsingContext. r=nika,jya,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D70629
2020-06-30 01:19:15 +00:00
751fe6358b
Bug 1647557 - Implement RemoteWebProgress using CanonicalBrowsingContext instead of MessageManager. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D70626
2020-06-30 01:18:47 +00:00
d606440481
Bug 1646928 - Bogus scheme typo correction in URIFixup. r=harry
...
Differential Revision: https://phabricator.services.mozilla.com/D81329
2020-06-29 14:06:06 +00:00
269822540c
Bug 1646892 - Disable DocumentChannel process switching into the parent process when the old-RDM is running, since we don't support switching out of a nested <iframe mozbrowser>. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D81262
2020-06-27 04:10:48 +00:00
213fab51e4
Bug 1646892 - Allow DocumentChannel process switches into the parent process. r=jya,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80327
2020-06-27 04:10:23 +00:00
bcf1de6e49
Bug 1647972 - Add a new PlatformOverride field onto BrowsingContext r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D81285
2020-06-26 14:17:08 +00:00
c04b0a1b46
Bug 1648270: Get rid of unused ContentParent 'opener' field. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80971
2020-06-26 16:26:50 +00:00
26e71bd99d
Bug 1648033 - Call session history listener for reload in the parent process if session history in the parent is on. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80882
2020-06-26 14:34:12 +00:00
88ce7f0c92
Backed out changeset c6d8b979af47 (bug 1644140) for causing Bug 1644213 to regress
2020-06-26 14:21:41 +03:00
f47ca94618
Backed out changeset 840d3dc313f1 (bug 1648270) for causing build bustages on ProtocolFuzzer.cpp. CLOSED TREE
2020-06-26 01:57:49 +03:00
8fa4e5c092
Bug 1626362 - Make mOriginalUriString available in DocumentLoadListener and docshell. r=nika,necko-reviewers,valentin
...
This also fixes a bug where we were setting mOriginalUriString in docshell before InternalLoad (which clears it), instead of after.
Differential Revision: https://phabricator.services.mozilla.com/D80110
2020-06-25 04:33:14 +00:00
f0b769ce30
Bug 1626362 - Move nsDocShell::mUserErrorPages to BrowsingContext. r=nika
...
This is only used by Thunderbird, and is always true for Firefox. I've made CanSet only allow the embedder process, which is the desired behaviour, and should work for non-e10s.
Differential Revision: https://phabricator.services.mozilla.com/D80109
2020-06-25 04:32:51 +00:00
19c4b43cba
Bug 1626362 - Move url classifier notifications to parent process. r=nika,necko-reviewers,JuniorHsu
...
We shouldn't need to handle this with an early return in docshell, since the classifier failure codes won't display an error page anyway.
Differential Revision: https://phabricator.services.mozilla.com/D80108
2020-06-25 04:32:28 +00:00
5f0218a196
Bug 1626362 - Combine two load error page functions into one. r=nika
...
I don't think we need these to be done at different times, since the set of checks that happen before uri fixup are error codes that won't be affected by fixup.
Differential Revision: https://phabricator.services.mozilla.com/D80107
2020-06-25 04:32:06 +00:00
0f894bda06
Bug 1626362 - Move checks for deciding if we should load an error page into helpers. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80106
2020-06-25 04:32:04 +00:00
d545a61edb
Bug 1626362 - Move docshell uri fixup code into a static helper. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80104
2020-06-25 04:32:01 +00:00
f1d85755a8
Bug 1648270: Get rid of unused ContentParent 'opener' field. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80971
2020-06-25 20:30:33 +00:00
366cbc5518
Backed out changeset 3468660179b1 (bug 1648270) for bustages at ContentParent.h. CLOSED TREE
2020-06-25 22:06:46 +03:00
e7b1c3e32f
Bug 1647307 - Simplify SessionHistoryInfo ID handling, r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D80553
2020-06-25 16:20:32 +00:00
f465a90bb0
Bug 1648270: Get rid of unused ContentParent 'opener' field. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80971
2020-06-25 17:53:39 +00:00
2d63627ce0
Bug 1647728 - Unify kCharsetFromUserForced and kCharsetFromParentForced. r=m_kato
...
For making further changes less messy.
Differential Revision: https://phabricator.services.mozilla.com/D80813
2020-06-25 03:25:03 +00:00
a383fd6b63
Bug 1637035 - Do not inherit COEP from opener for non-http or non-initial-about:blank documents r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80414
2020-06-25 02:14:29 +00:00
e67ceab432
Backed out 9 changesets (bug 1626362) for failures on a-download-click-404.html. CLOSED TREE
...
Backed out changeset d29ac651a4fd (bug 1626362)
Backed out changeset 5ba5cf98a95d (bug 1626362)
Backed out changeset 69b5b01da9c1 (bug 1626362)
Backed out changeset 1d31061f4421 (bug 1626362)
Backed out changeset a627870e35fb (bug 1626362)
Backed out changeset 5f3ee46032b6 (bug 1626362)
Backed out changeset 5b170666991e (bug 1626362)
Backed out changeset 4d31c2ede058 (bug 1626362)
Backed out changeset 66a9ba0f87cb (bug 1626362)
2020-06-25 02:45:52 +03:00
e9d06799ca
Bug 1626362 - Make mOriginalUriString available in DocumentLoadListener and docshell. r=nika,necko-reviewers,valentin
...
This also fixes a bug where we were setting mOriginalUriString in docshell before InternalLoad (which clears it), instead of after.
Differential Revision: https://phabricator.services.mozilla.com/D80110
2020-06-24 22:03:39 +00:00
3eda9e7d73
Bug 1626362 - Move nsDocShell::mUserErrorPages to BrowsingContext. r=nika
...
This is only used by Thunderbird, and is always true for Firefox. I've made CanSet only allow the embedder process, which is the desired behaviour, and should work for non-e10s.
Differential Revision: https://phabricator.services.mozilla.com/D80109
2020-06-24 22:03:16 +00:00
87cdbac816
Bug 1626362 - Move url classifier notifications to parent process. r=nika,necko-reviewers,JuniorHsu
...
We shouldn't need to handle this with an early return in docshell, since the classifier failure codes won't display an error page anyway.
Differential Revision: https://phabricator.services.mozilla.com/D80108
2020-06-24 22:03:04 +00:00
55f60f13b9
Bug 1626362 - Combine two load error page functions into one. r=nika
...
I don't think we need these to be done at different times, since the set of checks that happen before uri fixup are error codes that won't be affected by fixup.
Differential Revision: https://phabricator.services.mozilla.com/D80107
2020-06-24 22:02:56 +00:00
89307a1e82
Bug 1626362 - Move checks for deciding if we should load an error page into helpers. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80106
2020-06-24 22:01:55 +00:00
28c5ddf563
Bug 1626362 - Move docshell uri fixup code into a static helper. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80104
2020-06-24 22:01:43 +00:00
00dc8d3d73
Bug 1646582 - Remove DOM(Inner)WindowID from nsIWebProgress. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80128
2020-06-24 19:58:15 +00:00
7639e4f712
Bug 1643093 - Remove references to 'whitelist' in browser/components/urlbar. r=jaws
...
Depends on D78124
Differential Revision: https://phabricator.services.mozilla.com/D78122
2020-06-24 15:59:04 +00:00
90a64f0da1
Backed out 4 changesets (bug 1646582) for Browser-chrome failures on nsIWebProgress.addProgressListener. CLOSED TREE
...
Backed out changeset 2111dd0d6dc0 (bug 1646582)
Backed out changeset e6c496c5a4b1 (bug 1646582)
Backed out changeset 49b4ae8c8be0 (bug 1646582)
Backed out changeset 9d42ec89240c (bug 1646582)
2020-06-24 07:50:07 +03:00
21ac707a3b
Bug 1646582 - Remove DOM(Inner)WindowID from nsIWebProgress. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80128
2020-06-24 03:24:21 +00:00
78dfb0a991
Bug 1590762 - Part 3: Keep track of current loads in BrowsingContext. r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D75110
2020-06-23 13:01:37 +00:00
ca5db92916
Bug 1590762 - Part 2: Bump the id for channel registration to uint64_t. r=mattwoodrow,necko-reviewers,valentin
...
This patch also makes the identifier for channels global, in the sense
that the generated identifier is generated outside of and passed to
the nsIRedirectChannelRegistrar.
Differential Revision: https://phabricator.services.mozilla.com/D79820
2020-06-23 13:18:56 +00:00
87438519f0
Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
...
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.
This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget
Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
Christoph Kerschbaumer
Nika Layzell
Anny Gakhokidze
Simon Giesecke
Noemi Erli
Sylvestre Ledru
Steven MacLeod
Butkovits Atila
Andreas Farre
Olli Pettay
Chris H-C
Nathan Froyd
Mihai Alexandru Michis
Kashav Madan
Sebastian Streich
Peter Van der Beken
Emilio Cobos Álvarez
prathiksha
Jonathan Almeida [:jonalmeida]
James Willcox
Dan Glastonbury
Marco Bonardo
Paul Bone
Kris Maglione
Edgar Chen
Razvan Maries
alwu
Frederik Braun
Narcis Beleuzu
Randell Jesup
Matt Woodrow
julianwels
Coroiu Cristina
Henri Sivonen
Gabriel Luong
Dorel Luca
Eden Chuang
Csoregi Natalia
Jared Wein
Jean-Yves Avenard