Simon Giesecke
97d4011b9b
Bug 1626570 - Improve handling of copying arrays in MozPromise. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D73641
2020-05-05 13:01:43 +00:00
André Bargull
14ca007916
Bug 1625138 - Part 41: Remove no longer needed includes for mozilla/TypeTraits. r=froydnj
...
Also adds missing includes in some files, these were previously only transivitely
included through mozilla/TypeTraits.h.
Differential Revision: https://phabricator.services.mozilla.com/D68561
--HG--
extra : moz-landing-system : lando
2020-03-28 16:00:09 +00:00
André Bargull
f70fd1c1bd
Bug 1625138 - Part 37: Replace mozilla::IsSame with std::is_same in xpcom/. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68556
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:21 +00:00
André Bargull
2712714d84
Bug 1625138 - Part 35: Replace mozilla::TrueType with std::true_type. r=froydnj,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D68554
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:20 +00:00
André Bargull
f8eb4c162e
Bug 1625138 - Part 34: Replace mozilla::FalseType with std::false_type. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68553
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:20 +00:00
André Bargull
9de017ffb8
Bug 1625138 - Part 33: Replace mozilla::IntegralConstant with std::integral_constant. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68552
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:19 +00:00
André Bargull
42d4ebbda9
Bug 1625138 - Part 27: Replace mozilla::DeclVal with std::declval. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68545
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:18 +00:00
André Bargull
cae4e1fdbc
Bug 1606962: Replace mozilla::EnableIf with std::enable_if. r=froydnj,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D68401
--HG--
extra : moz-landing-system : lando
2020-03-28 13:35:31 +00:00
André Bargull
1be056677a
Bug 1625138 - Part 26: Replace mozilla::Conditional with std::conditional. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68381
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:18 +00:00
André Bargull
3ee851a1a5
Bug 1625138 - Part 25: Replace mozilla::RemoveReference with std::remove_reference. r=froydnj,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D68380
--HG--
extra : moz-landing-system : lando
2020-03-28 14:16:19 +00:00
André Bargull
08a8c3fc78
Bug 1625138 - Part 24: Replace mozilla::IsConvertible with std::is_convertible. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68379
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:17 +00:00
André Bargull
a08be4177e
Bug 1625138 - Part 17: Replace mozilla::Decay with std::decay. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68372
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:15 +00:00
André Bargull
b0c9db06e3
Bug 1625138 - Part 12: Replace mozilla::IsPointer with std::is_pointer. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68366
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:14 +00:00
Chris Peterson
b1f54173e8
Bug 1624776 - Replace MOZ_MUST_USE with [[nodiscard]] in xpcom. r=xpcom-reviewers,KrisWright
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Also remove MOZ_MUST_USE from nsIMemoryReporter's function pointer typedefs. [[nodiscard]] is an attribute of a function's declaration, not the function's type, and thus can't be applied to function pointers or lambdas.
Differential Revision: https://phabricator.services.mozilla.com/D68138
--HG--
extra : moz-landing-system : lando
2020-03-27 17:21:48 +00:00
Simon Giesecke
b06d1c3205
Bug 1616848 - Remove monitor from MozPromiseHolder and provide separate MozMonitoredPromiseHolder class. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D63478
--HG--
extra : moz-landing-system : lando
2020-02-20 14:53:20 +00:00
Simon Giesecke
9350e6b741
Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
...
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.
Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.
Differential Revision: https://phabricator.services.mozilla.com/D62604
--HG--
extra : moz-landing-system : lando
2020-02-20 11:40:14 +00:00
Dorel Luca
d5f9df8ee1
Backed out 2 changesets (bug 1613985) for Build bustage on Windows2012. CLOSED TREE
...
Backed out changeset fd177b40b561 (bug 1613985)
Backed out changeset fb6d62b7f28d (bug 1613985)
2020-02-19 22:22:41 +02:00
Simon Giesecke
59b23375c0
Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
...
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.
Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.
Differential Revision: https://phabricator.services.mozilla.com/D62604
--HG--
extra : moz-landing-system : lando
2020-02-19 18:05:38 +00:00
Simon Giesecke
b50347f917
Bug 1611415 - Prefer using std::move over forget. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D60980
--HG--
extra : moz-landing-system : lando
2020-02-13 14:38:48 +00:00
shindli
91aa0518dd
Backed out changeset 0c982bc69cb3 (bug 1611415) for causing build bustages in /builds/worker/workspace/build/src/obj-firefox/dist/include/nsCOMPtr CLOSED TREE
2020-02-12 20:13:29 +02:00
Simon Giesecke
f604a47fa5
Bug 1611415 - Applied FixItHints from mozilla-non-std-move. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D60980
--HG--
extra : moz-landing-system : lando
2020-02-12 17:24:41 +00:00
Simon Giesecke
30984f7bab
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in xpcom. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D62543
--HG--
extra : moz-landing-system : lando
2020-02-12 11:13:33 +00:00
Simon Giesecke
884563052a
Bug 1614395 - MozPromiseHolder::operator=(MozPromiseHolder&&) shouldn't copy its mPromise member. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D62299
--HG--
extra : moz-landing-system : lando
2020-02-10 17:20:23 +00:00
Emilio Cobos Álvarez
cde7beaaa4
Bug 1608064
- Replace Is{Rvalue,Lvalue,}Reference with <type_traits> equivalents. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D59309
--HG--
extra : moz-landing-system : lando
2020-01-10 10:40:34 +00:00
Eric Rahm
bf24e992e3
Bug 1241518 - Part 3: Switch various nsAutoPtr uses to UniquePtr in xpcom/ r=kmag
...
This converts straightforward `nsAutoPtr` usage over to `UniquePtr`.
`nsClassHashtable` is left alone for now as that will have a larger impact.
`nsThread` is left alone for now as it has non-trivial ownership concepts.
Differential Revision: https://phabricator.services.mozilla.com/D58284
--HG--
extra : moz-landing-system : lando
2020-01-07 00:06:05 +00:00
Jean-Yves Avenard
912b0df630
Bug 1575744 - P4. Add MozPromise::FromDomPromise. r=bholley
...
Similar to MozPromise::FromGeckoResult.
Allows to create a MozPromise that will be resolved/rejected when the JS promise does the same.
It would be nice to be able to chain the two promise types, but it would be an additional effort.
MozPromise::FromDomPromise is limited to primitive types only and the reject value type must be nsresult.
Differential Revision: https://phabricator.services.mozilla.com/D46017
--HG--
extra : moz-landing-system : lando
2019-09-20 04:09:46 +00:00
Bogdan Tara
bee28f01d7
Backed out 8 changesets (bug 1575744) for HttpChannelParent related assertion failures
...
Backed out changeset af61675dd488 (bug 1575744)
Backed out changeset bf794b9373c8 (bug 1575744)
Backed out changeset 39ffb74d2e12 (bug 1575744)
Backed out changeset c1547b3df672 (bug 1575744)
Backed out changeset 382ee8672027 (bug 1575744)
Backed out changeset 5abb38484f11 (bug 1575744)
Backed out changeset d5244c1bbfe8 (bug 1575744)
Backed out changeset c74b81debf73 (bug 1575744)
--HG--
rename : netwerk/base/nsIProcessSwitchRequestor.idl => netwerk/base/nsICrossProcessSwitchChannel.idl
2019-09-20 06:58:44 +03:00
Jean-Yves Avenard
bafae6af97
Bug 1575744 - P4. Add MozPromise::FromDomPromise. r=bholley
...
Similar to MozPromise::FromGeckoResult.
Allows to create a MozPromise that will be resolved/rejected when the JS promise does the same.
It would be nice to be able to chain the two promise types, but it would be an additional effort.
MozPromise::FromDomPromise is limited to primitive types only and the reject value type must be nsresult.
Differential Revision: https://phabricator.services.mozilla.com/D46017
--HG--
extra : moz-landing-system : lando
2019-09-20 02:21:12 +00:00
Bobby Holley
c14858c637
Bug 1571092 - Mark various MozPromise-returning methods MOZ_MUST_USE. r=jld
...
Differential Revision: https://phabricator.services.mozilla.com/D40528
--HG--
extra : moz-landing-system : lando
2019-08-05 20:10:58 +00:00
Bobby Holley
5d23efb2eb
Bug 1566583
- Bridge GeckoResult to MozPromise and return a GeckoResult from GeckoProcessManager::start. r=snorp
...
Differential Revision: https://phabricator.services.mozilla.com/D38436
--HG--
extra : moz-landing-system : lando
2019-07-24 21:10:14 +00:00
Coroiu Cristina
f3386dea34
Backed out 4 changesets (bug 1566583
) for apilint and checkstyle failure at geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java on a CLOSED TREE
...
Backed out changeset 3700ef585384 (bug 1566583
)
Backed out changeset fbc829be6c4f (bug 1566583
)
Backed out changeset 14ea9c84bb0e (bug 1566583
)
Backed out changeset 92f3b1bb34a4 (bug 1566583
)
2019-07-24 22:59:54 +03:00
Bobby Holley
53719788a1
Bug 1566583
- Bridge GeckoResult to MozPromise and return a GeckoResult from GeckoProcessManager::start. r=snorp
...
Differential Revision: https://phabricator.services.mozilla.com/D38436
--HG--
extra : moz-landing-system : lando
2019-07-24 19:19:40 +00:00
Sylvestre Ledru
03c8e8c2dd
Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
...
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D26098
--HG--
extra : moz-landing-system : lando
2019-04-05 21:41:42 +00:00
Csoregi Natalia
ba58e936bd
Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE
2019-04-05 09:48:19 +03:00
Sylvestre Ledru
d1c1878603
Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
...
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D26098
--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:16 +00:00
Narcis Beleuzu
24dbe577a5
Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE
2019-04-05 00:27:56 +03:00
Sylvestre Ledru
399dbd28fe
Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
...
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D26098
--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Ehsan Akhgari
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Jean-Yves Avenard
cdec3ff52a
Bug 1512456 - P9. Re-enable assertion. r=gerald
...
Depends on D14032
Differential Revision: https://phabricator.services.mozilla.com/D14138
--HG--
extra : moz-landing-system : lando
2018-12-11 17:43:19 +00:00
Jean-Yves Avenard
38ed72f936
Bug 1512456 - P2. Make GenericPromise exclusive. r=gerald
...
We introduce GenericNonExclusivePromise that can be used to explicitly state than non-exclusive use is needed
We temporarily disable the assertion ensuring a promise is used exclusively when needed to allow for things to settle.
Differential Revision: https://phabricator.services.mozilla.com/D14025
--HG--
extra : moz-landing-system : lando
2018-12-11 10:46:17 +00:00
Jean-Yves Avenard
44594dd77a
Bug 1510265 - P1. Enforce template-parameter classes restrictions in MozPromise. r=gerald
...
And some required fixes to make things compile.
Differential Revision: https://phabricator.services.mozilla.com/D13868
--HG--
extra : moz-landing-system : lando
2018-12-06 16:26:01 +00:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Jean-Yves Avenard
31ed9de297
Bug 1504643 - Enforce template-parameter classes restrictions in MozPromise. r=gerald
...
Make thorough use of move semantic for MozPromise using nsTArray
Differential Revision: https://phabricator.services.mozilla.com/D11346
--HG--
extra : moz-landing-system : lando
2018-11-09 15:45:31 +00:00
Dorel Luca
c34d2cd0fa
Backed out changeset 157be32d85fe (bug 1504643) for conflicts while backing out bug 1471535
2018-11-09 12:13:54 +02:00
Jean-Yves Avenard
c30e8ca9f0
Bug 1504643 - Enforce template-parameter classes restrictions in MozPromise. r=gerald
...
Make thorough use of move semantic for MozPromise using nsTArray
Differential Revision: https://phabricator.services.mozilla.com/D11346
--HG--
extra : moz-landing-system : lando
2018-11-09 08:41:45 +00:00
Jean-Yves Avenard
91dbdb0a68
Bug 1504531 - P2. Add MozPromiseHolder::ResolveOrReject methods. r=gerald
...
Depends on D10833
Differential Revision: https://phabricator.services.mozilla.com/D10834
--HG--
extra : moz-landing-system : lando
2018-11-04 22:36:43 +00:00
Jean-Yves Avenard
6f99745b62
Bug 1504531 - P1. Use forward references in MozPromiseHolder. r=gerald
...
Differential Revision: https://phabricator.services.mozilla.com/D10833
--HG--
extra : moz-landing-system : lando
2018-11-05 14:26:23 +00:00
Jean-Yves Avenard
46cc265bba
Bug 1468241 - P1. Add MozPromise::CreateAndResolveOrReject method r=gerald
...
Useful when using promise chaining in combination with MozPromise::ResolveOrRejectValue parameter.
MozReview-Commit-ID: F8qMh7yFnHQ
Differential Revision: https://phabricator.services.mozilla.com/D1726
2018-06-20 22:14:05 +00:00
Emilio Cobos Álvarez
1e9c395548
Bug 1466168: Remove mozilla::Forward in favor of std::forward. r=froydnj
...
Same approach as the other bug, mostly replacing automatically by removing
'using mozilla::Forward;' and then:
s/mozilla::Forward/std::forward/
s/Forward</std::forward</
The only file that required manual fixup was TestTreeTraversal.cpp, which had
a class called TestNodeForward with template parameters :)
MozReview-Commit-ID: A88qFG5AccP
2018-06-02 09:33:26 +02:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00