Граф коммитов

20008 Коммитов

Автор SHA1 Сообщение Дата
Olli Pettay ebe2702267 Bug 1627935 - PrioritizedEventQueue::GetEvent doesn't return the correct priority value, r=bas
One could possibly make larger changes to make the setup less error prone, but hopefully we'll
replace this code with the new scheduler relatively soon.
And the assertion there should still enforce correct behavior.

Differential Revision: https://phabricator.services.mozilla.com/D69988

--HG--
extra : moz-landing-system : lando
2020-04-13 22:22:57 +00:00
Simon Giesecke 069ef2ef55 Bug 1628697 - nsTArray::AppendElements(mozilla::Span<const Item> aSpan) should use ActualAlloc. r=xpcom-reviewers,erahm
Differential Revision: https://phabricator.services.mozilla.com/D70381

--HG--
extra : moz-landing-system : lando
2020-04-09 17:31:08 +00:00
Tooru Fujisawa 8c0843c04c Bug 1432749 - Part 1: Add DefaultHasher for nsTString. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67836

--HG--
extra : moz-landing-system : lando
2020-04-14 06:00:05 +00:00
Cameron McCormack 4887043b29 Bug 1265030 - Show symbolic nsresult name in NS_ENSURE_SUCCESS warning. r=mccr8
Through their use of Smprintf, the existing warning message formatting
is resistant to OOM errors.  So I figured that we should probably use
something that doesn't infallibly allocate like GetErrorName does.

Differential Revision: https://phabricator.services.mozilla.com/D70771

--HG--
extra : moz-landing-system : lando
2020-04-13 23:39:19 +00:00
Nicholas Nethercote 8139b4051e Bug 1619840 - Remove `fix_{linux,macosx}_stack.py` and `fix_stack_using_bpsyms.py`. r=erahm
This commit removes `test_fix_stack_using_bpsyms.py`. That test can't easily be
modified to work with `fix_stacks.py` because it relies on internal
implementation details of `fix_stack_using_bpsym.py`. The unit testing done in
the `fix-stacks` repo provides test coverage that is as good or better.

Differential Revision: https://phabricator.services.mozilla.com/D66924

--HG--
extra : moz-landing-system : lando
2020-04-08 06:55:54 +00:00
Narcis Beleuzu 1783003a34 Backed out 3 changesets (bug 1624150, bug 1432749) for wpt failures at open-features-tokenization-top-left.html. CLOSED TREE
Backed out changeset ff061c8d9da9 (bug 1624150)
Backed out changeset 7e96d4acf317 (bug 1432749)
Backed out changeset a95f77732a1c (bug 1432749)
2020-04-13 22:51:48 +03:00
Tooru Fujisawa c2e8f7014c Bug 1432749 - Part 1: Add DefaultHasher for nsTString. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67836

--HG--
extra : moz-landing-system : lando
2020-04-13 15:42:06 +00:00
Cameron McCormack 396dcd374d Bug 1629342 - Print string stats on process exit only if there is a leak. r=erahm,mccr8
I don't think anyone particularly cares about these stats.

Differential Revision: https://phabricator.services.mozilla.com/D70638

--HG--
extra : moz-landing-system : lando
2020-04-12 17:23:12 +00:00
Honza Bambas aa4bbee2f9 Bug 1627572 - Use an atomic bool for a quick-return check in FilePreferences::IsAllowedPath, r=michal
Differential Revision: https://phabricator.services.mozilla.com/D69976

--HG--
extra : moz-landing-system : lando
2020-04-07 11:18:54 +00:00
Emma Malysz 92820f83c2 Bug 1625553, change cpuCount value to int to avoid incorrect telemetry r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D70116

--HG--
extra : moz-landing-system : lando
2020-04-09 19:33:13 +00:00
Jon Coppeard 11fc44d6aa Bug 1628371 - Check whether JS holders are single-zone in nightly builds too r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D70220

--HG--
extra : moz-landing-system : lando
2020-04-09 09:50:26 +00:00
Matt Woodrow e600940a82 Bug 1597159 - Defer creating DocumentLoadListener's stream filter until after we process switch. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D64698

--HG--
extra : moz-landing-system : lando
2020-04-09 07:03:49 +00:00
Gerald Squelart baa5044bbb Bug 1627097 - Profiler synchronously collect processor information - r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D69922

--HG--
extra : moz-landing-system : lando
2020-04-08 22:35:54 +00:00
Eric Rahm 905929aa4e Bug 1627131 - Part 3: Move nsTString<T>::Contains implementation. r=xpcom-reviewers,sg
`kNotFound` isn't actually defined in `nsTStringRepr.h`.

Differential Revision: https://phabricator.services.mozilla.com/D69468

--HG--
extra : moz-landing-system : lando
2020-04-08 10:46:25 +00:00
Eric Rahm 2c52ea2bb0 Bug 1627131 - Part 2: Move template function instantiations to definitions. r=xpcom-reviewers,sg
The instantiations of the externed templates need to be in the same translation unit as the definitions. Currently they work due to building in unified mode.

Differential Revision: https://phabricator.services.mozilla.com/D69467

--HG--
extra : moz-landing-system : lando
2020-04-08 10:46:02 +00:00
Eric Rahm 034401e7e4 Bug 1627131 - Part 1: Add missing includes to xpcom/string. r=xpcom-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D69466

--HG--
extra : moz-landing-system : lando
2020-04-03 21:08:13 +00:00
Eric Rahm 8e4a18ed64 Bug 1627392 - Add missing includes and namespaces to xpcom/base. r=xpcom-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D69658

--HG--
extra : moz-landing-system : lando
2020-04-08 10:12:33 +00:00
Marco Bonardo 758aa4f647 Bug 1496578 - convert nsDefaultURIFixup to URIFixup.jsm. r=Gijs,farre
Differential Revision: https://phabricator.services.mozilla.com/D66579

--HG--
extra : moz-landing-system : lando
2020-04-08 11:30:14 +00:00
Nika Layzell dd1ef62596 Bug 1616353 - Part 3: Use an attribute to set geckoViewUserContextId on a browser, r=geckoview-reviewers,esawin
This is necessary to avoid the use of setOriginAttributesBeforeLoading, which is
being removed in this patch set.

Differential Revision: https://phabricator.services.mozilla.com/D67042

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:04 +00:00
Razvan Maries 3b66f5f729 Backed out changeset b86e8f2cc5db (bug 1496578) for build bustages on nsDocShell.cpp. CLOSED TREE 2020-04-08 01:16:33 +03:00
Eric Rahm 73c5285b22 Bug 1627391 - Add missing includes and namespaces to xpcom/threads. r=xpcom-reviewers,sg
Also moves `nsThreadShutdownContext` to `nsThread.h` so it can be used by `nsThreadPool`.

Differential Revision: https://phabricator.services.mozilla.com/D69657

--HG--
extra : moz-landing-system : lando
2020-04-07 22:10:29 +00:00
Marco Bonardo 7457a384f2 Bug 1496578 - convert nsDefaultURIFixup to URIFixup.jsm. r=Gijs,farre
Differential Revision: https://phabricator.services.mozilla.com/D66579

--HG--
extra : moz-landing-system : lando
2020-04-07 21:55:24 +00:00
Eric Rahm 3442b6f2d5 Bug 1627393 - Add missing includes and namespaces to xpcom/tests. r=xpcom-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D69659

--HG--
extra : moz-landing-system : lando
2020-04-07 19:10:57 +00:00
Eric Rahm 2bd348aaf4 Bug 1627390 - Add missing includes and namespaces to xpcom/io. r=xpcom-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D69656

--HG--
extra : moz-landing-system : lando
2020-04-07 19:09:47 +00:00
Andreas Farre 25ca8d7890 Bug 1620594 - Part 7: Remove TabGroup and SystemGroup. r=nika,bas
TabGroup never really made any difference in which thread something go
dispatched to. This was the intended use, but development of TabGroups
with abstract main threads never made it that far. The good thing is
that thish makes it safe to also remove to the SystemGroup and instead
switch all SystemGroup dispatches to dispatches to main thread.

Timers for setTimeout and workers were the sole users of wrapped and
throttled event targets, that those throttled queues have been moved
to the BrowsingContextGroup and are now accessed explicitly.

The SchedulerEventTarget has been removed, since there are no longer a
separate event target for every TaskCategory. Instead a
LabellingEventTarget has been added to DocGroup to handle the case
where an event is dispatched do DocGroup or when an AbstractThread is
created using a DocGroup. This means that we'll actually label more
events correctly with the DocGroup that they belong to.

DocGroups have also been moved to BrowsingContextGroup.

Depends on D67636

Differential Revision: https://phabricator.services.mozilla.com/D65936

--HG--
extra : moz-landing-system : lando
2020-04-07 15:17:47 +00:00
Andreas Farre f2fa2e633c Bug 1620594 - Part 5: Use GetMainThreadSerialEventTarget instead of SystemGroup::EventTargetFor. r=nika
This patch also tries to remove the event target entirely if it would
default to the main thread on a null event target.

Depends on D67634

Differential Revision: https://phabricator.services.mozilla.com/D67635

--HG--
extra : moz-landing-system : lando
2020-04-07 15:17:07 +00:00
Andreas Farre 9e36af2ab6 Bug 1620594 - Part 3: Use default target for timers using SystemGroup. r=nika
Depends on D67632

Differential Revision: https://phabricator.services.mozilla.com/D67633

--HG--
extra : moz-landing-system : lando
2020-04-07 15:16:46 +00:00
Andreas Farre 36eaf82163 Bug 1620594 - Part 2: Use SchedulerGroup::Dispatch instead of SystemGroup::Dispatch. r=nika
Depends on D67631

Differential Revision: https://phabricator.services.mozilla.com/D67632

--HG--
extra : moz-landing-system : lando
2020-04-07 15:16:33 +00:00
Andreas Farre 63e21eec70 Bug 1620594 - Part 1: Rework NS_ReleaseOnMainThreadSystemGroup. r=nika
To be able to remove SystemGroup, NS_ReleaseOnMainThreadSystemGroup
needs to have its dependency on SystemGroup removed. Since all
releases using SystemGroup would've released on the main thread anyway
we can safely replace NS_ReleaseOnMainThreadSystemGroup with
NS_ReleaseOnMainThread.

Depends on D64390

Differential Revision: https://phabricator.services.mozilla.com/D67631

--HG--
extra : moz-landing-system : lando
2020-04-07 15:16:23 +00:00
Dave Townsend 2bdbc2936b Bug 1621116: Make the version and build ID of the previous instance of Firefox to use the current profile available. r=froydnj,glandium
We cache this information in compatibility.ini so we can just expose it on
nsIXULRuntime.

Differential Revision: https://phabricator.services.mozilla.com/D66112

--HG--
extra : moz-landing-system : lando
2020-04-07 08:23:32 +00:00
Eric Rahm 8b6c75d28a Bug 1627389 - Add missing using statements to xpcom/ds. r=xpcom-reviewers,KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D69655

--HG--
extra : moz-landing-system : lando
2020-04-06 22:35:20 +00:00
Cosmin Sabou 84ff986617 Merge mozilla-central to autoland. CLOSED TREE 2020-04-07 00:59:27 +03:00
Ciure Andrei 7de40f8ed0 Merge autoland to mozilla-central. a=merge 2020-04-07 00:46:53 +03:00
Mozilla Releng Treescript a17ce3b6b4 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-04-06 14:28:50 +00:00
Simon Giesecke 360c4632f4 Bug 1627198 - Make nsTHashtable a STL-style range. r=froydnj
This makes nsTHashtable usable with range-based for and STL-style algorithms.

Differential Revision: https://phabricator.services.mozilla.com/D69522

--HG--
extra : moz-landing-system : lando
2020-04-06 09:18:02 +00:00
Sylvestre Ledru 0aa6f03cf3 Bug 1519636 - Reformat recent changes to the Google coding style r=jgilbert
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D67574

--HG--
extra : moz-landing-system : lando
2020-04-05 13:34:58 +00:00
Eric Rahm ad908c0dfa Bug 1626439 - Part 1: Add an rvalue AppendElement to nsTObserverArray. r=xpcom-reviewers,nika
Needed so that you can append a `UniquePtr` to an `nsTObserverArray`.

Differential Revision: https://phabricator.services.mozilla.com/D69109

--HG--
extra : moz-landing-system : lando
2020-04-03 21:05:01 +00:00
Andrew McCreight 26736ce413 Bug 1627213 - Don't call HoldJSObjects in a superclass ctor. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D69586

--HG--
extra : moz-landing-system : lando
2020-04-03 16:57:10 +00:00
Bas Schouten 3c7916f406 Bug 1627741: Expect an idle token only if we're actually using cross-process idle scheduling. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D69846

--HG--
extra : moz-landing-system : lando
2020-04-06 17:25:06 +00:00
Kearwood Gilbert 9136ce65cf Bug 1614496 - Implement WebXR Core Module DOM Interfaces r=jgilbert,daoshengmu,webidl,smaug,baku,imanol
Implement DOM interfaces for the WebXR Core Module. Additional work to implement the WebXR Core Module are marked with TODO (Bug #) comments within the patch and must be landed before enabling the dom.vr.webxr.enabled flag.

Differential Revision: https://phabricator.services.mozilla.com/D62369

--HG--
extra : moz-landing-system : lando
2020-04-06 19:33:32 +00:00
Narcis Beleuzu f6ebb84618 Backed out 2 changesets (bug 1626884, bug 1627198) for bustages on ElfLoader.h CLOSED TREE
Backed out changeset b545e60f385c (bug 1627198)
Backed out changeset 16ee5dd004d3 (bug 1626884)

--HG--
extra : histedit_source : 21258c723c796773307977dabbd50de5aba6bd34
2020-04-03 21:56:38 +03:00
Simon Giesecke 017553af0a Bug 1627198 - Make nsTHashtable a STL-style range. r=froydnj
This makes nsTHashtable usable with range-based for and STL-style algorithms.

Differential Revision: https://phabricator.services.mozilla.com/D69522

--HG--
extra : moz-landing-system : lando
2020-04-03 14:27:17 +00:00
Erik Nordin ccc51b2ce0 Bug 1622322 - Improve print performance when sheets are adopted multiple times r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D68116

--HG--
extra : moz-landing-system : lando
2020-04-01 20:06:47 +00:00
Simon Giesecke 94fa08db9c Bug 1626267 - Added transformation algorithms with error handling. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68994

--HG--
extra : moz-landing-system : lando
2020-04-01 15:53:58 +00:00
Simon Giesecke 60a0dbdc2e Bug 1626206 - Fix definition of nsTArrayBackInserter operator++. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68980

--HG--
extra : moz-landing-system : lando
2020-03-31 13:55:35 +00:00
Tom Tung 5a6c32a460 Bug 1536796 - P5 - Changes on xpcom gtest to verify the fix; r=dom-workers-and-storage-reviewers,janv,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D60871

--HG--
extra : moz-landing-system : lando
2020-04-01 11:34:31 +00:00
Tom Tung 4e96941288 Bug 1536796 - P2 - Handle disable string paring in nsLocalFileWin; r=sg,dom-workers-and-storage-reviewers,froydnj,janv
In the Windows API, the maximum length for a path is MAX_PATH in general.
However, the Windows API has many functions that also have Unicode versions to
permit an extended-length path for a maximum total path length of 32,767
characters. To specify an extended-length path, use the "\\?\" prefix.

A path component which ends with a dot is not allowed for Windows API. However,
using the "\\?\" prefix can also resolved this issue.

This patch aims to fix the issues which are mentioned above by prepending the
prefix to the path of nsLocalFile if mDisableStringParsing is set to true.

Differential Revision: https://phabricator.services.mozilla.com/D67014

--HG--
extra : moz-landing-system : lando
2020-04-01 07:51:05 +00:00
Tom Tung 4debe01abb Bug 1536796 - P1 - Introduce a flag (useDOSDevicePathSyntax) to nsILocalFileWin and a method (QM_NewLocalFile) to QuotaCommon; r=janv,dom-workers-and-storage-reviewers,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D67873

--HG--
extra : moz-landing-system : lando
2020-04-01 07:26:27 +00:00
Simon Giesecke 1807bda32b Bug 1626200 - Replace mozilla::IsPod by std::is_trivially_copy_constructible in nsTArray::AssignRangeAlgorithm. r=froydnj
Depends on D68972

Differential Revision: https://phabricator.services.mozilla.com/D68976

--HG--
extra : moz-landing-system : lando
2020-03-31 13:15:23 +00:00
Lina Cambridge 80920e5871 Bug 1625286 - Expose dispatch flags to `moz_task`. r=KrisWright
This commit adds a `dispatch_with_options` method to Rust task
runnables, which takes a builder-style `DispatchOptions`
argument controlling how the runnable should be dispatched.
Currently, the only supported option is `may_block`, which
corresponds to `nsIEventTarget::DISPATCH_EVENT_MAY_BLOCK`.

Differential Revision: https://phabricator.services.mozilla.com/D68688

--HG--
extra : moz-landing-system : lando
2020-03-30 19:24:08 +00:00
André Bargull 14ca007916 Bug 1625138 - Part 41: Remove no longer needed includes for mozilla/TypeTraits. r=froydnj
Also adds missing includes in some files, these were previously only transivitely
included through mozilla/TypeTraits.h.

Differential Revision: https://phabricator.services.mozilla.com/D68561

--HG--
extra : moz-landing-system : lando
2020-03-28 16:00:09 +00:00
André Bargull f70fd1c1bd Bug 1625138 - Part 37: Replace mozilla::IsSame with std::is_same in xpcom/. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68556

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:21 +00:00
André Bargull 2712714d84 Bug 1625138 - Part 35: Replace mozilla::TrueType with std::true_type. r=froydnj,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D68554

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:20 +00:00
André Bargull f8eb4c162e Bug 1625138 - Part 34: Replace mozilla::FalseType with std::false_type. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68553

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:20 +00:00
André Bargull 9de017ffb8 Bug 1625138 - Part 33: Replace mozilla::IntegralConstant with std::integral_constant. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68552

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:19 +00:00
André Bargull 32cb16fc45 Bug 1625138 - Part 32: Replace mozilla::RemoveConst with std::remove_const. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68551

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:19 +00:00
André Bargull 8d7aa62e32 Bug 1625138 - Part 29: Replace mozilla::IsVoid with std::is_void. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68548

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:19 +00:00
André Bargull cf0b1e89e9 Bug 1625138 - Part 30: Replace mozilla::RemoveCV with std::remove_cv. r=froydnj,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D68547

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:18 +00:00
André Bargull 42d4ebbda9 Bug 1625138 - Part 27: Replace mozilla::DeclVal with std::declval. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68545

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:18 +00:00
André Bargull cae4e1fdbc Bug 1606962: Replace mozilla::EnableIf with std::enable_if. r=froydnj,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D68401

--HG--
extra : moz-landing-system : lando
2020-03-28 13:35:31 +00:00
André Bargull 1be056677a Bug 1625138 - Part 26: Replace mozilla::Conditional with std::conditional. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68381

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:18 +00:00
André Bargull 3ee851a1a5 Bug 1625138 - Part 25: Replace mozilla::RemoveReference with std::remove_reference. r=froydnj,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D68380

--HG--
extra : moz-landing-system : lando
2020-03-28 14:16:19 +00:00
André Bargull 08a8c3fc78 Bug 1625138 - Part 24: Replace mozilla::IsConvertible with std::is_convertible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68379

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:17 +00:00
André Bargull d53798e749 Bug 1625138 - Part 23: Replace mozilla::RemovePointer with std::remove_pointer. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68378

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:17 +00:00
André Bargull a08be4177e Bug 1625138 - Part 17: Replace mozilla::Decay with std::decay. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68372

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:15 +00:00
André Bargull 13e9ad3137 Bug 1625138 - Part 14: Replace mozilla::IsSigned with std::is_signed. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68369

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:15 +00:00
André Bargull 9ad58ea608 Bug 1625138 - Part 13: Replace mozilla::IsUnsigned with std::is_unsigned. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68368

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:14 +00:00
André Bargull b0c9db06e3 Bug 1625138 - Part 12: Replace mozilla::IsPointer with std::is_pointer. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68366

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:14 +00:00
André Bargull 907be0b57b Bug 1625138 - Part 11: Replace mozilla::IsConst with std::is_const. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68365

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:14 +00:00
André Bargull be0f9ade3d Bug 1625138 - Part 7: Replace mozilla::IsScalar with std::is_scalar. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68361

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:13 +00:00
André Bargull 086c1b8be3 Bug 1625138 - Part 6: Replace mozilla::IsClass with std::is_class. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68360

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:12 +00:00
André Bargull 1e4d8b891e Bug 1625138 - Part 4: Replace mozilla::MakeUnsigned with std::make_unsigned. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68358

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:12 +00:00
Marcos Cáceres c837a27119 Bug 1625384 - Remove window.onappinstalled event, as it was never used or shipped r=baku
removing this from spec

Differential Revision: https://phabricator.services.mozilla.com/D68506

--HG--
extra : moz-landing-system : lando
2020-03-27 08:28:09 +00:00
Chris Peterson b1f54173e8 Bug 1624776 - Replace MOZ_MUST_USE with [[nodiscard]] in xpcom. r=xpcom-reviewers,KrisWright
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Also remove MOZ_MUST_USE from nsIMemoryReporter's function pointer typedefs. [[nodiscard]] is an attribute of a function's declaration, not the function's type, and thus can't be applied to function pointers or lambdas.

Differential Revision: https://phabricator.services.mozilla.com/D68138

--HG--
extra : moz-landing-system : lando
2020-03-27 17:21:48 +00:00
Stefan Hindli aec1af5d13 Backed out changeset 8480828de5a6 (bug 1621116) for mda1 OSX permafailure CLOSED TREE 2020-03-26 18:19:11 +02:00
Kirk Steuber acc51b1485 Bug 1568994 - Add Update URL template to application.ini, XREAppData, and Services.appinfo r=glandium
This is being added to facilitate moving generation of the update URL to Rust (Bug 1567286). Once that has been completed, we should be able to remove the update URL from its current location in firefox.js so that it is not being duplicated in application.ini.

Differential Revision: https://phabricator.services.mozilla.com/D43300

--HG--
extra : moz-landing-system : lando
2020-03-26 00:57:13 +00:00
Dave Townsend 4eb0022624 Bug 1621116: Make the version and build ID of the previous instance of Firefox to use the current profile available. r=froydnj
We cache this information in compatibility.ini so we can just expose it on
nsIXULRuntime.

Differential Revision: https://phabricator.services.mozilla.com/D66112

--HG--
extra : moz-landing-system : lando
2020-03-26 14:15:52 +00:00
Jon Coppeard c98e59fc82 Bug 1624810 - Assert that only JS holders with the approprate flag set can contain pointers to GC things in more than one zone r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D68197

--HG--
extra : moz-landing-system : lando
2020-03-26 10:49:20 +00:00
Jon Coppeard c1e3671c97 Bug 1624810 - Set the multi-zone JS holder flag on appropriate cycle collected classes r=mccr8
Set the flag on the affected classes, which are:
 - CallbackTimeoutHandler
 - nsJSArgArray
 - CallbackObject
 - Console
 - MessageEvent
 - IDBIndexCursor
 - ExtendableMessageEvent
 - JSPurpleBuffer

Differential Revision: https://phabricator.services.mozilla.com/D68196

--HG--
extra : moz-landing-system : lando
2020-03-26 10:49:06 +00:00
Jon Coppeard 7c60c2b222 Bug 1624810 - Add a nsCycleCollectionParticipant flag for JS holders that can have GC things in multiple zones r=mccr8
This adds the flag itself and a means of setting it for a cycle collected class.

The proper way to do this would be to add versions of all the NS_DECL_CYCLE_COLLECTION_CLASS macros that also set this flag but we end up needing to create separate versions for five of these and it's a lot of macro code to add.  Here I added a version of NS_IMPL_CYCLE_COLLECTION_CLASS that sets the flag.  This has the disadvantage that it wouldn't work well if we needed to set the flag on a base class as we'd have to use this macro for every derived class.  However that situation doesn't actually arise (and ideally this flag will bet set on the fewest number of classes possible).

Differential Revision: https://phabricator.services.mozilla.com/D68195

--HG--
extra : moz-landing-system : lando
2020-03-26 10:48:30 +00:00
Jon Coppeard ff40627b14 Bug 1624810 - Replace individual nsCycleCollectionParticipant flags with a bit field to make it easier pass multiple flags through derived class oonstructors r=mccr8
Currently classes derived from nsCycleCollectionParicipant have one flag to pass and adding more makes the class delcaration macros get messy really quickly.  This patch replaces boolean flags with a bitfield which makes adding new flags easier.

Differential Revision: https://phabricator.services.mozilla.com/D68194

--HG--
extra : moz-landing-system : lando
2020-03-26 10:48:17 +00:00
Bas Schouten 6458fb2f4f Bug 1563335 - Part 2: Add a pref for serializing all JS threads that access shared SABs. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D66953

--HG--
extra : moz-landing-system : lando
2020-03-26 00:29:48 +00:00
Bas Schouten 1bc21ff19c Bug 1563335 - Part 1: Implement mechanism to throttle JS execution. r=smaug,asuth
Differential Revision: https://phabricator.services.mozilla.com/D59321

--HG--
extra : moz-landing-system : lando
2020-03-26 00:36:24 +00:00
Byron Campen [:bwc] a36e252242 Bug 1620308: Move RTCDTMFSender logic to a single c++ class. r=smaug,jib,mjf
Differential Revision: https://phabricator.services.mozilla.com/D67513

--HG--
extra : moz-landing-system : lando
2020-03-25 18:46:37 +00:00
Simon Giesecke 510cea31eb Bug 1624426 - Add MOZ_DECLARE_COPY_CONSTRUCTIBLE for nsTString<char>. r=froydnj
This is required for a Android build with --enable-tasktracer

Differential Revision: https://phabricator.services.mozilla.com/D68176

--HG--
extra : moz-landing-system : lando
2020-03-25 15:32:24 +00:00
Simon Giesecke d34d3a8d8a Bug 1620632 - Fix move assignment of AutoTArray from other nsTArray. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D67879

--HG--
extra : moz-landing-system : lando
2020-03-25 13:48:22 +00:00
Dzmitry Malyshau 3f4ede670b Bug 1624594 - Check for memory leak env vars on crashing r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D68031

--HG--
extra : moz-landing-system : lando
2020-03-24 15:53:16 +00:00
Mihai Alexandru Michis 40d1ce7288 Backed out changeset 86a23ca27412 (bug 1621116) for causing gtest and mochitest failures.
CLOSED TREE
2020-03-20 23:53:34 +02:00
Dave Townsend 5bcaed8ab0 Bug 1621116: Make the version and build ID of the previous instance of Firefox to use the current profile available. r=froydnj
We cache this information in compatibility.ini so we can just expose it on
nsIXULRuntime.

Differential Revision: https://phabricator.services.mozilla.com/D66112

--HG--
extra : moz-landing-system : lando
2020-03-20 19:41:14 +00:00
Bogdan Tara eddea671e7 Backed out 6 changesets (bug 1425450) for hazard failure complaining about nsWrapperCacheInlines CLOSED TREE
Backed out changeset c57ac2e125e8 (bug 1425450)
Backed out changeset 4238c59af7bb (bug 1425450)
Backed out changeset 2a00272e72ba (bug 1425450)
Backed out changeset 3e4a52d596bb (bug 1425450)
Backed out changeset 5da68de67491 (bug 1425450)
Backed out changeset efac091a3ba4 (bug 1425450)
2020-04-06 21:22:51 +03:00
Cosmin Sabou aefb5f9c88 Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp.
Backed out changeset 3a43210e4900 (bug 1616353)
Backed out changeset cb77e9149cf8 (bug 1616353)
Backed out changeset 3aacc7cfe33f (bug 1616353)
Backed out changeset c026b06063a5 (bug 1616353)
Backed out changeset 580e790c5d17 (bug 1616353)
Backed out changeset 6f09bc1c476d (bug 1616353)
Backed out changeset 6955906262c0 (bug 1616353)
Backed out changeset a7700472807a (bug 1616353)
Backed out changeset a4735096e01b (bug 1616353)
Backed out changeset bd1706c57d91 (bug 1616353)
Backed out changeset 363c13296fda (bug 1616353)
Backed out changeset e414df387524 (bug 1616353)
Backed out changeset 765d3364cca0 (bug 1616353)
Backed out changeset 8a13355b4ac4 (bug 1616353)
Backed out changeset ada17fb8fca7 (bug 1616353)
Backed out changeset 6b6b99af186d (bug 1616353)
Backed out changeset ea966e78b296 (bug 1616353)
Backed out changeset cb88e0bbb3b9 (bug 1616353)
Backed out changeset f89a89015114 (bug 1616353)
Backed out changeset ae6058552969 (bug 1616353)
Backed out changeset f42bb5b48c1b (bug 1616353)
Backed out changeset 1ab9d22c73bb (bug 1616353)
Backed out changeset 2692c2c1396b (bug 1616353)
Backed out changeset 11a279c8da08 (bug 1616353)
2020-04-06 20:03:02 +03:00
Jon Coppeard 2c04e31b6c Bug 1425450 - Only trace JS holders in collecting zones r=mccr8
Now that we have some per-zone vectors we can skip tracing those for zones that are not being collected.

Differential Revision: https://phabricator.services.mozilla.com/D68523

--HG--
extra : moz-landing-system : lando
2020-04-06 16:14:25 +00:00
Jon Coppeard 368614f774 Bug 1425450 - Use a per-zone vector of JS holders where possible r=mccr8
Currently the JS holders table is represented as a map which contains pointers to entries in a SegmentedVector.  This patch keeps the single map but use a vector per zone and also has a catch-all vector for where we don't know the zone or the holder can have pointers to more than one zone.

Differential Revision: https://phabricator.services.mozilla.com/D68522

--HG--
extra : moz-landing-system : lando
2020-04-06 16:14:03 +00:00
Andrew McCreight 081d4ec773 Bug 1425450 - Pass zone information through when preserving wrappers r=mccr8
This is bascially the same as your original patch.

Differential Revision: https://phabricator.services.mozilla.com/D68520

--HG--
extra : moz-landing-system : lando
2020-04-06 16:13:17 +00:00
Jon Coppeard 89e1fe3de4 Bug 1425450 - Remove unused IsJsHolder methods r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D68519

--HG--
extra : moz-landing-system : lando
2020-04-06 16:12:39 +00:00
Jon Coppeard af4d1860d1 Bug 1425450 - Remove dead JSHolderMap entries lazily when the vector is next iterated r=mccr8
Currently, to remove a holder entry from a vector we swap the entry with the last one in the vector and then shrink the vector (and fix up the map).  With per-zone vectors we won't have a reference to the vector to get the last entry.  One solution would be to store the zone in the entry and look up the vector in a map but I'd like to avoid this if possible because of the space overhead and the extra lookup.

This patch defers clears the entry's pointers when it is removed and actually removes it when the vector is next iterated.

Differential Revision: https://phabricator.services.mozilla.com/D68518

--HG--
extra : moz-landing-system : lando
2020-04-06 16:12:21 +00:00
Nika Layzell e1bf02fc4f Bug 1616353 - Part 3: Use an attribute to set geckoViewUserContextId on a browser, r=geckoview-reviewers,esawin
This is necessary to avoid the use of setOriginAttributesBeforeLoading, which is
being removed in this patch set.

Differential Revision: https://phabricator.services.mozilla.com/D67042

--HG--
extra : moz-landing-system : lando
2020-04-06 14:29:35 +00:00
Doug Thayer 48dd5d7d4e Bug 1623668 - Advance lateWriteChecksStage to xpcom-shutdown r=froydnj
Depends on D67542

Differential Revision: https://phabricator.services.mozilla.com/D67543

--HG--
extra : moz-landing-system : lando
2020-03-20 20:08:53 +00:00
Daniel Varga 156fc636e7 Backed out changeset 42851810d9e9 (bug 1621116) on request from the dev
CLOSED TREE
2020-03-20 21:35:01 +02:00
Dave Townsend 096dde646f Bug 1621116: Make the version and build ID of the previous instance of Firefox to use the current profile available. r=froydnj
We cache this information in compatibility.ini so we can just expose it on
nsIXULRuntime.

Differential Revision: https://phabricator.services.mozilla.com/D66112

--HG--
extra : moz-landing-system : lando
2020-03-20 19:22:24 +00:00
Simon Giesecke e3a19c9b3e Bug 1620632 - Added tests for moving nsTArray/AutoTArray/FallibleTArray with MoveOnly element type. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D66081

--HG--
extra : moz-landing-system : lando
2020-03-20 17:06:29 +00:00
Simon Giesecke 58d0171406 Bug 1620632 - Ensure nsTArray_Impl only declares a copy-constructor/assignment operator if E is copy-constructible. r=froydnj
To correctly implement this, it must be known on instantiation whether E is
copy-constructible, which is not the case if only a forward declaration is
available. This can be resolved either by making sure a full definition of E is
available, which is preferable. But in cases where this is not (easily) possible,
the information can be explicitly provided by the MOZ_DECLARE_COPY_CONSTRUCTIBLE
and MOZ_DECLARE_NON_COPY_CONSTRUCTIBLE macros. In particular, declarations for
IPDL-declared types are added to nsTArray.h itself, like it was already done
for MOZ_DECLARE_RELOCATE_USING_MOVE_CONSTRUCTOR.

Differential Revision: https://phabricator.services.mozilla.com/D66244

--HG--
extra : moz-landing-system : lando
2020-03-20 17:13:51 +00:00
Simon Giesecke 7e9a7de895 Bug 1620632 - Rename confusingly named types/macros for relocation handling of nsTArray. r=froydnj
Specifically, this renames
* nsTArray_CopyChooser to nsTArray_RelocationStrategy
* the Copy template argument of nsTArray_base to RelocationStrategy
* nsTArray_CopyWithConstructors to nsTArray_RelocateUsingMoveConstructor
* nsTArray_CopyWithMemutils to nsTArray_RelocateUsingMemutils
* DECLARE_USE_COPY_CONSTRUCTORS to MOZ_DECLARE_RELOCATE_USING_MOVE_CONSTRUCTOR

Differential Revision: https://phabricator.services.mozilla.com/D66243

--HG--
extra : moz-landing-system : lando
2020-03-20 17:04:27 +00:00
Gabriele Svelto d3eaf3858d Bug 1622452 - Remove the remote exception handler when a content process shuts down r=froydnj
This works on all platforms with the exception of Linux where we remove the
exception handler only if the sandbox is disabled. With the sandbox enabled we
would have to whitelist sigaltstack() which breakpad uses to remove the
alternate signal stack which is not worth the fuss.

Besides this patch refactors the code that sets and unsets the exception
handler, cutting down on the duplication:

* The XRE_UnsetRemoteExceptionHandler() call is removed from XULAppAPI.h since it
  was no longer used
* The duplicate checks for the special strings used to disable the remote exception
  handler have been removed from CrashReporter::UnsetRemoteExceptionHandler()
  leaving them in the calling code
* The SetRemoteExceptionHandler() function was consolidated into only one
  piece of code with only one non-platform-specific shared prototype
* Some additional code was factored out to improve the readability

These changes pave the way both for bug 1614933 and for the oxidation of the
exception handler code.

Differential Revision: https://phabricator.services.mozilla.com/D67213

--HG--
extra : moz-landing-system : lando
2020-03-19 14:06:31 +00:00
Simon Giesecke 5621715961 Bug 1622114 - Improve array manipulation in CleanupIDBTransactions. r=dom-workers-and-storage-reviewers,smaug,asuth
- Do not remove elements one-by-one but use remove-erase pattern.
- Move mPendingIDBTransactions array instead of copying.

Differential Revision: https://phabricator.services.mozilla.com/D67159

--HG--
extra : moz-landing-system : lando
2020-03-19 12:55:12 +00:00
Mike Hommey 0f365ba2c5 Bug 1621452 - Generate xpidllex.py and xpidlyacc.py with python2. r=rstewart
Ply doesn't actually support python3. The generation of the files seems
to work with python3 for some reason, but running the corresponding
tests doesn't. The only version of ply that supports python3 is
currently in beta, so upgrading ply is probably not an option at the
moment.

Other commands that do use ply (mach webidl-parser-test and
ipc/ipdl/Makefile.in) have not switched to python3 (probably because
they don't work). Let's go with the simpler thing for now: switch back
to python 2 for xpidllex.py and xpidlyacc.py, which will make them
deterministically created again.

Differential Revision: https://phabricator.services.mozilla.com/D67400

--HG--
extra : moz-landing-system : lando
2020-03-18 23:53:17 +00:00
Simon Giesecke 7434f710c9 Bug 1623325 - Fix nsTArrayBackInserter and add moving test. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D67337

--HG--
extra : moz-landing-system : lando
2020-03-18 16:07:12 +00:00
Jon Coppeard 8c62e61474 Bug 1622854 - Switch JSHolderMap to use HashMap r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D67018

--HG--
extra : moz-landing-system : lando
2020-03-18 14:01:22 +00:00
Jon Coppeard 1170608da0 Bug 1622854 - Factor out the JS holder map into a separate class r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D67017

--HG--
extra : moz-landing-system : lando
2020-03-17 19:42:57 +00:00
Emilio Cobos Álvarez 664a546418 Bug 1618260 - Fix number input so that it honors overflow-clip-box-block. r=mats
This never worked, but it's more visible with the new form controls which have
more padding.

Make the anonymous div and co a pseudo-element, so that they inherit from the
<input> properly in all cases. This works for non-number inputs because the
editor root is a direct child of the <input>, but it doesn't for number inputs
because there's a flex wrapper in between.

This way overflow-clip-box: inherit does what we want. Reset the padding in the
inline direction, as the padding for <input type=number> applies to the arrow
boxes as well, and thus we'd double-apply it.

Differential Revision: https://phabricator.services.mozilla.com/D65271

--HG--
extra : moz-landing-system : lando
2020-03-18 09:21:44 +00:00
Sean Feng 28bbd32a07 Bug 1377999 - Make Attribute to adapt the DOMArena changes r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D57700

--HG--
extra : moz-landing-system : lando
2020-03-17 14:53:13 +00:00
Sean Feng 053f3e648d Bug 1377999 - Make nsIContent to declare a final DeleteCycleCollectable r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D63263

--HG--
extra : moz-landing-system : lando
2020-03-17 14:53:00 +00:00
Sean Feng 91fd21bfd1 Bug 1377999 - Refactor some macros to support a final DeleteCycleCollectable r=smaug
There's no existing macro to allow use declare a final
DeleteCycleCollectable, this patch adds one

Differential Revision: https://phabricator.services.mozilla.com/D63262

--HG--
extra : moz-landing-system : lando
2020-03-17 14:52:58 +00:00
Markus Stange 93518320ab Bug 1620097 - Add markers and labels for category service observer notifications. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D66074

--HG--
extra : moz-landing-system : lando
2020-03-17 04:11:35 +00:00
André Bargull 0105311d41 Bug 1618258 - Part 1: Rename FinalizationGroup to FinalizationRegistry. r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D66930

--HG--
rename : js/src/builtin/FinalizationGroupObject.cpp => js/src/builtin/FinalizationRegistryObject.cpp
rename : js/src/builtin/FinalizationGroupObject.h => js/src/builtin/FinalizationRegistryObject.h
rename : js/src/gc/FinalizationGroup.cpp => js/src/gc/FinalizationRegistry.cpp
extra : moz-landing-system : lando
2020-03-16 10:41:08 +00:00
Lina Cambridge 9697819fb5 Bug 1622082 - Expose `NS_CreateBackgroundTaskQueue` to `moz_task`. r=KrisWright
This commit moves `NS_CreateBackgroundTaskQueue` into an `extern "C"`
block, adds a `create_background_task_queue` function to `moz_task`,
and makes it possible to dispatch Rust `TaskRunnable`s to any event
target, instead of just an `nsIThread`.

Differential Revision: https://phabricator.services.mozilla.com/D66700

--HG--
extra : moz-landing-system : lando
2020-03-13 21:15:51 +00:00
Kartikaya Gupta 6d4a82e018 Bug 1617427 - Add a DOMWindowUtils API to disable APZ on a particular element. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D66424

--HG--
extra : moz-landing-system : lando
2020-03-13 19:56:33 +00:00
Toshihito Kikuchi 3bc1f2c50b Bug 1605308 - Do not use ShellExecuteByExplorer when a downloaded file is an executable. r=Gijs,froydnj
This is one of the efforts to reduce usage of `ShellExecuteByExplorer`
(bug 1620335).

The purpose of using `ShellExecuteByExplorer` in the scenario to open a
downloaded file is to support applications which are not compatible with
the mitigation policies of our process.  When a downloaded file is an
executable, however, we prefer security to compatibility and in particular
we want to prevent binary planting on a user's download directory.

The proposed fix is to go to `ShellExecuteExW` straight if the target
file to launch is an executable.

Differential Revision: https://phabricator.services.mozilla.com/D66325

--HG--
extra : moz-landing-system : lando
2020-03-12 22:05:34 +00:00
Cosmin Sabou e7343ec23b Backed out changeset 01cef3030838 (bug 1605308) for build bustages on nsLocalFileWin.cpp
CLOSED TREE
2020-03-12 23:26:54 +02:00
Toshihito Kikuchi 156f519842 Bug 1605308 - Do not use ShellExecuteByExplorer when a downloaded file is an executable. r=Gijs,froydnj
This is one of the efforts to reduce usage of `ShellExecuteByExplorer`
(bug 1620335).

The purpose of using `ShellExecuteByExplorer` in the scenario to open a
downloaded file is to support applications which are not compatible with
the mitigation policies of our process.  When a downloaded file is an
executable, however, we prefer security to compatibility and in particular
we want to prevent binary planting on a user's download directory.

The proposed fix is to go to `ShellExecuteExW` straight if the target
file to launch is an executable.

Differential Revision: https://phabricator.services.mozilla.com/D66325

--HG--
extra : moz-landing-system : lando
2020-03-12 21:05:24 +00:00
Simon Giesecke ec9babdc85 Bug 1617170 - Move DECLARE_USE_COPY_CONSTRUCTORS for StructuredCloneReadInfo to dom/indexedDB/IndexedDatabase.h r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D65293

--HG--
extra : moz-landing-system : lando
2020-03-11 16:53:20 +00:00
David Teller 28e34497c9 Bug 1589493 - Extending BrowserTestUtils.crashFrame to allow crashing with an OOM;r=mconley,froydnj,dmajor
BrowserTestUtils.crashFrame now accepts additional `options`, with an argument `crashType` that may
take "CRASH_OOM" or "CRASH_INVALID_POINTER_DEREF"|null to specify the nature of the crash. The names
are taken from CrashTestUtils.jsm but this module cannot be imported as such as it has non-trivial
binary dependencies.

Depends on D54130

Differential Revision: https://phabricator.services.mozilla.com/D54700

--HG--
extra : moz-landing-system : lando
2020-03-10 14:00:27 +00:00
Oana Pop Rus 9bbf887ea0 Merge autoland to mozilla-central. a=merge 2020-03-09 23:47:11 +02:00
ffxbld 7a35fa9703 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-03-09 15:41:51 +00:00
Andrew McCreight f138cbb009 Bug 1619229, part 3 - Incrementally finalize for most internal GCs. r=smaug
Right now, we sync finalize for a sync GC, even if it is triggered by the JS
engine itself. This can cause issues because the finalizer can run JS, which
can break assumptions made by the JIT.

This patch avoids that by running the finalizers incrementally for most internal
GC triggers. We still run sync for DESTROY_RUNTIME because we're going to shut
down right away.

Differential Revision: https://phabricator.services.mozilla.com/D65649

--HG--
extra : moz-landing-system : lando
2020-03-06 13:23:32 +00:00
Andrew McCreight d8ecfbc863 Bug 1619229, part 1 - Thread GC reason into the GC callback. r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D65647

--HG--
extra : moz-landing-system : lando
2020-03-08 23:22:39 +00:00
Emma Malysz ff6fc06f79 Bug 1619317, ensure we set isWow64 to the correct value after taking it off the main thread r=aklotz
Differential Revision: https://phabricator.services.mozilla.com/D65127

--HG--
extra : moz-landing-system : lando
2020-03-09 14:29:32 +00:00
Boris Zbarsky 61e0515f43 Bug 1618011 part 6. Pass a BindingCallContext (if neded) and source description to primitive conversions. r=peterv
The BindingCallContext tracks what method the conversion is for, and the source
description is how the primitive is involved in that method (e.g. "argument 5").

Differential Revision: https://phabricator.services.mozilla.com/D64887

--HG--
extra : moz-landing-system : lando
2020-03-06 23:05:16 +00:00
Arthur Iakab 14247fb057 Backed out 11 changesets (bug 1618011)for Linting failure.
CLOSED TREE

Backed out changeset 8b11ddd8999f (bug 1618011)
Backed out changeset 11df2f359473 (bug 1618011)
Backed out changeset c50121035d50 (bug 1618011)
Backed out changeset 8b8c4c60c34b (bug 1618011)
Backed out changeset b01f8c66110b (bug 1618011)
Backed out changeset 433fdf04058c (bug 1618011)
Backed out changeset 29a9227d08ac (bug 1618011)
Backed out changeset b2dfa2e66d24 (bug 1618011)
Backed out changeset 85650ee945c4 (bug 1618011)
Backed out changeset 278a213e5304 (bug 1618011)
Backed out changeset 9119aeb72ea4 (bug 1618011)
2020-03-07 00:15:57 +02:00
Boris Zbarsky 0a681b4df5 Bug 1618011 part 6. Pass a BindingCallContext (if neded) and source description to primitive conversions. r=peterv
The BindingCallContext tracks what method the conversion is for, and the source
description is how the primitive is involved in that method (e.g. "argument 5").

Differential Revision: https://phabricator.services.mozilla.com/D64887

--HG--
extra : moz-landing-system : lando
2020-03-06 20:38:55 +00:00
Markus Stange aae2ad8790 Bug 1616400 - Do not recreate the inner reader for nested omni.ja archives if the Omnijar already has it. r=aklotz
This is already done for the outer nsJAR, but it wasn't done for the inner nsJAR.
(The omnijar is a nested zip archive on Android: the outer archive is the APK and the inner is the omnijar file.)
So we were re-using the file mapping but not the result of the uncompression.

Differential Revision: https://phabricator.services.mozilla.com/D63970

--HG--
extra : moz-landing-system : lando
2020-03-06 20:35:53 +00:00
Boris Zbarsky 4a89a400e1 Bug 1600331. When an idle runnable is queued from a background thread, lazily queue it from a non-idle runnable. r=smaug
Idle runnables do weird things involving unlocking the event queue mutex while
looking for runnables, such that queueing one from off the main thread might
cause it to basically never run if it gets queued during one of those
temporary-unlock periods.

Differential Revision: https://phabricator.services.mozilla.com/D65019

--HG--
extra : moz-landing-system : lando
2020-03-03 01:47:24 +00:00
Simon Giesecke 2d1ae94059 Bug 1619260 - Prevent assertion when processing nsStringBuffer leaks. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64949

--HG--
extra : moz-landing-system : lando
2020-03-02 14:31:09 +00:00
Marco Zehe 6d5bea032c Bug 1608961 - Support ARIA 1.3 aria-description property, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D64283

--HG--
extra : moz-landing-system : lando
2020-03-02 10:59:22 +00:00
Simon Giesecke 41c3e177f8 Bug 1618186 - Remove AnyStaticMutex. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64358

--HG--
extra : moz-landing-system : lando
2020-02-28 14:24:21 +00:00
Marco Zehe 93ff1614a5 Bug 1608965 Part 2 - Add ARIA suggestion role, r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D64546

--HG--
extra : moz-landing-system : lando
2020-03-01 19:37:33 +00:00
Mike Shal 43842108f2 Bug 1618620 - Convert ErrorList.py to py3; r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D64621

--HG--
extra : moz-landing-system : lando
2020-02-28 00:28:17 +00:00
Mike Shal 449e9c0820 Bug 1618620 - Convert gen_static_components.py to py3; r=firefox-build-system-reviewers,rstewart
Note that perfecthash.py is also used by other scripts, so it needs to
remain py2 compatible for now.

Differential Revision: https://phabricator.services.mozilla.com/D64620

--HG--
extra : moz-landing-system : lando
2020-02-28 21:27:17 +00:00
Tooru Fujisawa 9939f785e0 Bug 1612515 - Part 4: Move RunCBindgen.py to /build. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D64541

--HG--
rename : layout/style/RunCbindgen.py => build/RunCbindgen.py
extra : moz-landing-system : lando
2020-02-28 14:07:15 +00:00
Simon Giesecke 69b996524d Bug 1618165 - Provide BaseAutoLock and BaseAutoUnlock deduction guides for Mutex references. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64359

--HG--
extra : moz-landing-system : lando
2020-02-28 07:59:30 +00:00
Razvan Maries 166e40b3c8 Backed out changeset b6ce0a07d782 (bug 1618165) for build bustages on WeakRef.cpp. CLOSED TREE 2020-02-27 23:13:40 +02:00
Simon Giesecke 81fcf51f06 Bug 1618165 - Provide BaseAutoLock and BaseAutoUnlock deduction guides for Mutex references. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64359

--HG--
extra : moz-landing-system : lando
2020-02-27 15:37:41 +00:00
Andrew McCreight 4babb2b5ab Bug 1609815 - Remove Web Replay C++ implementation. r=jgilbert,jandem,gbrown
Patch by bhackett and jlaster. Also reviewed by mccr8.

Differential Revision: https://phabricator.services.mozilla.com/D60197

--HG--
extra : moz-landing-system : lando
2020-02-27 17:39:15 +00:00
Emilio Cobos Álvarez 87e0a1e02f Bug 1613564 - Minor nsstring cleanup / tweaks. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63968

--HG--
extra : moz-landing-system : lando
2020-02-27 15:42:58 +00:00
Ciure Andrei 00dd87f6f4 Backed out changeset d407a28318e6 (bug 1609815) for causing windows ming bustages CLOSED TREE
--HG--
extra : histedit_source : b2c748e31e0f6ba8fcf9960a336e0bbd361b07e6
2020-02-27 07:05:19 +02:00
Andrew McCreight b197e1f783 Bug 1609815 - Remove Web Replay C++ implementation. r=jgilbert,jandem,gbrown
Patch by bhackett and jlaster. Also reviewed by mccr8.

Differential Revision: https://phabricator.services.mozilla.com/D60197

--HG--
extra : moz-landing-system : lando
2020-02-27 04:43:48 +00:00
Emilio Cobos Álvarez 1a7371fd97 Bug 1346893 - Move the Geckoview UA sheet to layout/style. r=snorp
Make it a regular stylesheet.

This allows it to be cached in shared memory if possible, and will allow me to
stop adding the stylesheet based on a pref for bug 1618202.

Differential Revision: https://phabricator.services.mozilla.com/D64377

--HG--
rename : mobile/android/themes/geckoview/content.css => layout/style/res/geckoview.css
extra : moz-landing-system : lando
2020-02-26 22:03:08 +00:00
Cosmin Sabou e1ae464b64 Backed out changeset 8c1c55d16e1a (bug 1346893) for bc failures on browser_all_files_referenced.js.
--HG--
rename : layout/style/res/geckoview.css => mobile/android/themes/geckoview/content.css
extra : histedit_source : e5159e67631172a933b02ac22c838991da589170
2020-02-26 21:25:09 +02:00
David Major e5cd04c721 Bug 1616943 - Run GTests on Windows ASan builds r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D64210

--HG--
extra : moz-landing-system : lando
2020-02-25 22:43:49 +00:00
Emilio Cobos Álvarez 42b235642d Bug 1346893 - Move the Geckoview UA sheet to layout/style. r=snorp
Make it a regular stylesheet.

This allows it to be cached in shared memory if possible, and will allow me to
stop adding the stylesheet based on a pref for bug 1618202.

Differential Revision: https://phabricator.services.mozilla.com/D64377

--HG--
rename : mobile/android/themes/geckoview/content.css => layout/style/res/geckoview.css
extra : moz-landing-system : lando
2020-02-26 15:46:58 +00:00
Mike Conley 87d5aea554 Bug 1610560 - Collect Telemetry on whether or not Superfetch and Prefetch are enabled and set to default settings. r=dthayer,chutten,data-review=chutten
Differential Revision: https://phabricator.services.mozilla.com/D63359

--HG--
extra : moz-landing-system : lando
2020-02-25 19:28:42 +00:00
Kris Maglione 64a2c8bb8f Bug 1535617: Part 1 - Add macros to clear weak references on unlink. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D63961

--HG--
extra : moz-landing-system : lando
2020-02-25 19:44:27 +00:00
Sylvestre Ledru 3551670431 Bug 1617369 - Reformat xpcom using rustfmt r=froydnj
Depends on D63955

Differential Revision: https://phabricator.services.mozilla.com/D63956

--HG--
extra : moz-landing-system : lando
2020-02-25 16:17:12 +00:00
Simon Giesecke aaf6cb4e75 Bug 1617628 - Hide nsBaseHashtable Put overloads in nsRefPtrHashtable subclass. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63899

--HG--
extra : moz-landing-system : lando
2020-02-25 17:03:36 +00:00
Simon Giesecke a57a57b669 Bug 1617898 - Add nsBaseHashtable::RemoveIf function. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64090

--HG--
extra : moz-landing-system : lando
2020-02-25 15:31:07 +00:00
Simon Giesecke 3db3ebfab0 Bug 1617841 - Add nsClassHashtable::Put overloads accepting a UniquePtr rvalue. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64026

--HG--
extra : moz-landing-system : lando
2020-02-25 14:36:59 +00:00
Simon Giesecke f67e7d443b Bug 1617604 - Make fallible nsTArray::EmplaceBack callable. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63862

--HG--
extra : moz-landing-system : lando
2020-02-24 17:53:37 +00:00
Simon Giesecke 32c9aeaad4 Bug 1617542 - Remove nsRefPtrHashtable::Put overload accepting already_AddRefed and adapt all uses. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63865

--HG--
extra : moz-landing-system : lando
2020-02-25 09:36:12 +00:00
Simon Giesecke 166369d19b Bug 1617542 - Make nsRefPtrHashtable::Put accept a RefPtr rvalue. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63838

--HG--
extra : moz-landing-system : lando
2020-02-24 17:53:41 +00:00
Gabriele Svelto 978898caaa Bug 1617202 - Handle TelemetrySessionId like a regular crash annotation r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63687

--HG--
extra : moz-landing-system : lando
2020-02-25 07:25:20 +00:00
Doug Thayer b405df3a9a Bug 1615921 - Skip writing to pdf file if shutting down r=jwatt
We are intending to advance the toolkit.shutdown.lateWriteChecksStage
pref, to collect information (and crash on DEBUG) about writes which
happen during and after the xpcom-shutdown-threads notification. This
is producing failures in the PrintTargetPDF.cpp destructor because
we end up calling write_func and writing to (I presume) the target
PDF. This _feels_ like something we can just skip, so that's the
review request I am sending, but please let me know if it's critical
that we write to this file during shutdown.

Differential Revision: https://phabricator.services.mozilla.com/D63218

--HG--
extra : moz-landing-system : lando
2020-02-24 17:54:09 +00:00
Doug Thayer f6951a7a52 Bug 1615921 - Move lateWriteChecks earlier in shutdown r=froydnj
This moves the late write checking forward to before xpcom-shutdown-threads
in Nightly, and it turns it on for after the last cycle collection on
beta/release.

Differential Revision: https://phabricator.services.mozilla.com/D63215

--HG--
extra : moz-landing-system : lando
2020-02-24 17:54:09 +00:00
Cosmin Sabou 7f1afff492 Backed out 5 changesets (bug 1617604, bug 1617542, bug 1617546) for causing build bustages on ipc/mscom/Interceptor.cpp.
CLOSED TREE

Backed out changeset 5faa54ad950e (bug 1617542)
Backed out changeset cb38779e1eb6 (bug 1617604)
Backed out changeset 3aea18e0396f (bug 1617542)
Backed out changeset bc3eeefdfb6c (bug 1617542)
Backed out changeset b76a3aa5ff6f (bug 1617546)
2020-02-24 19:50:13 +02:00
Simon Giesecke 4732b5f842 Bug 1617604 - Make fallible nsTArray::EmplaceBack callable. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63862

--HG--
extra : moz-landing-system : lando
2020-02-24 16:17:19 +00:00
Simon Giesecke df538d9a79 Bug 1617542 - Remove nsRefPtrHashtable::Put overload accepting already_AddRefed and adapt all uses. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63865

--HG--
extra : moz-landing-system : lando
2020-02-24 17:08:30 +00:00
Simon Giesecke 51d21f99d6 Bug 1617542 - Make nsRefPtrHashtable::Put accept a RefPtr rvalue. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63838

--HG--
extra : moz-landing-system : lando
2020-02-24 16:15:48 +00:00
Sylvestre Ledru ca6530131a Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan,kvark
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D63787

--HG--
extra : moz-landing-system : lando
2020-02-24 15:33:38 +00:00
Bob Owen 481aab9295 Bug 1598585 Part 1: Make CanvasTranslator the PCanvas parent actor. r=mattwoodrow
We want to be able to send IPC messages from the translation in the parent. So
the simplest thing it move the top level actor parts of CanvasParent into
CanvasTranslator.
This patch also moves the canvas thread management parts out into a new
CanvasThreadHolder class and hopefully makes the lifecycle management of these
much more robust. This includes the use of a TaskQueue per CanvasTranslator to
manage serial processing on the canvas workers, instead of a boolean.

Differential Revision: https://phabricator.services.mozilla.com/D60887

--HG--
rename : gfx/layers/ipc/CanvasParent.cpp => gfx/layers/ipc/CanvasThread.cpp
rename : gfx/layers/ipc/CanvasParent.h => gfx/layers/ipc/CanvasThread.h
rename : gfx/layers/CanvasTranslator.cpp => gfx/layers/ipc/CanvasTranslator.cpp
rename : gfx/layers/CanvasTranslator.h => gfx/layers/ipc/CanvasTranslator.h
extra : moz-landing-system : lando
2020-02-24 11:15:41 +00:00
Sylvestre Ledru bdcdfeff72 Bug 1617437 - TaskQueue.h: Fix a -Wnon-c-typedef-for-linkage warning r=froydnj
Depends on D63781

Differential Revision: https://phabricator.services.mozilla.com/D63783

--HG--
extra : moz-landing-system : lando
2020-02-23 12:59:35 +00:00
Masatoshi Kimura a37fc61f17 Bug 1617415 - Remove nsTSubstring<T>::ReplaceASCII. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63775

--HG--
extra : moz-landing-system : lando
2020-02-23 01:01:33 +00:00
Ehsan Akhgari 4cee972976 Bug 1617256 - Remove the unused NS_ERROR_MAYBE_TRACKING_URI and NS_ERROR_TRACKING_ANNOTATION_URI error codes; r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D63701

--HG--
extra : moz-landing-system : lando
2020-02-21 22:10:36 +00:00
Cosmin Sabou abd119b6f3 Backed out changeset 39cc23a7483c (bug 1617256) for gv-junit failures on safebrowsingHarmful.
CLOSED TREE
2020-02-21 23:21:56 +02:00
Ehsan Akhgari 5065663562 Bug 1617256 - Remove the unused NS_ERROR_MAYBE_TRACKING_URI and NS_ERROR_TRACKING_ANNOTATION_URI error codes; r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D63701

--HG--
extra : moz-landing-system : lando
2020-02-21 20:01:22 +00:00
Doug Thayer ef59845575 Bug 1615921 - Suspend late write checks in Windows vprintf_stderr r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63216

--HG--
extra : moz-landing-system : lando
2020-02-21 18:51:37 +00:00
Kartikaya Gupta 50e5dda0da Bug 1617213 - Allow dot characters in log module names. r=erahm
Differential Revision: https://phabricator.services.mozilla.com/D63693

--HG--
extra : moz-landing-system : lando
2020-02-21 17:37:42 +00:00
Mike Shal c8abdd68c2 Bug 1616630 - Use py3_action for GENERATED_FILES that already support it; r=firefox-build-system-reviewers,kvark,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D63438

--HG--
extra : moz-landing-system : lando
2020-02-21 00:05:17 +00:00
Csoregi Natalia 6360b24e80 Backed out 2 changesets (bug 1616630) for Android bustage. CLOSED TREE
Backed out changeset 15016546c954 (bug 1616630)
Backed out changeset dcb7dc51633b (bug 1616630)
2020-02-20 21:24:11 +02:00
Mike Shal 39492660f4 Bug 1616630 - Use py3_action for GENERATED_FILES that already support it; r=firefox-build-system-reviewers,kvark,rstewart
Depends on D63437

Differential Revision: https://phabricator.services.mozilla.com/D63438

--HG--
extra : moz-landing-system : lando
2020-02-20 16:21:55 +00:00
Boris Zbarsky d2908d39ab Bug 1581172. Remove NS_ERROR_DOM_TYPE_ERR. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D63500

--HG--
extra : moz-landing-system : lando
2020-02-20 16:57:57 +00:00
Simon Giesecke b06d1c3205 Bug 1616848 - Remove monitor from MozPromiseHolder and provide separate MozMonitoredPromiseHolder class. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D63478

--HG--
extra : moz-landing-system : lando
2020-02-20 14:53:20 +00:00
Simon Giesecke 9350e6b741 Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.

Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.

Differential Revision: https://phabricator.services.mozilla.com/D62604

--HG--
extra : moz-landing-system : lando
2020-02-20 11:40:14 +00:00
Simon Giesecke 5cce787baa Bug 1613985 - Add macros to conditionally default ctor/dtor that only calls MOZ_COUNT_CTOR/MOZ_COUNT_DTOR. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D62603

--HG--
extra : moz-landing-system : lando
2020-02-19 20:26:11 +00:00
Dorel Luca d5f9df8ee1 Backed out 2 changesets (bug 1613985) for Build bustage on Windows2012. CLOSED TREE
Backed out changeset fd177b40b561 (bug 1613985)
Backed out changeset fb6d62b7f28d (bug 1613985)
2020-02-19 22:22:41 +02:00
Simon Giesecke 59b23375c0 Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.

Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.

Differential Revision: https://phabricator.services.mozilla.com/D62604

--HG--
extra : moz-landing-system : lando
2020-02-19 18:05:38 +00:00
Simon Giesecke 6635003021 Bug 1613985 - Add macros to conditionally default ctor/dtor that only calls MOZ_COUNT_CTOR/MOZ_COUNT_DTOR. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D62603

--HG--
extra : moz-landing-system : lando
2020-02-19 17:57:02 +00:00
Kershaw Chang 583ae04d36 Bug 1607445 - Clear tokens cache at places where SSL_ClearSessionCache() is called r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D62021

--HG--
extra : moz-landing-system : lando
2020-02-18 19:04:28 +00:00
Christoph Walcher ebfbff6817 Bug 1596490 - Remove NS_ERROR_XBL_BLOCKED from ErrorList.py r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D61082

--HG--
extra : moz-landing-system : lando
2020-02-17 12:05:36 +00:00
Mike Shal d8e4653d19 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-14 13:22:46 +00:00
Doug Thayer 3f9b0177d2 Bug 1616186 - Don't try to write StartupCache if it doesn't exist r=froydnj
The exact circumstances of how this is showing up in the wild aren't
clear - there seem to be a couple of ways we can get here. However it
all revolves around early shutdowns (i.e., from the select profile popup)
- before the StartupCache is ever initialized. In any case, the solution
shouldn't change based on the exact circumstances - if we don't have a
StartupCache, there's no need to write one. Also, don't bother lazy
initializing it if it doesn't exist yet.

Differential Revision: https://phabricator.services.mozilla.com/D63208

--HG--
extra : moz-landing-system : lando
2020-02-18 17:49:47 +00:00
Olli Pettay 62617da1ea Bug 1615607 - Consider to always treat high priority runnables as the highest priority runnables, r=farre
The patch removes the tad odd interleave behavior from the main thread and makes RefreshDriver to give
at least a tiny bit time for non-high priority tasks.
Given the recent change to have similar block-until behavior in child and parent process, this should work
consistently in all the processes.

Differential Revision: https://phabricator.services.mozilla.com/D63098

--HG--
extra : moz-landing-system : lando
2020-02-18 16:03:37 +00:00
Nathan Froyd e2ce985f34 Bug 1615072 - don't trigger the deadlock detector from static initializers for RWLock; r=mccr8
This change is a little gross, because we don't totally control where
the statically initialized instances of `RWLock` live, due to its uses
in third-party libraries.

Differential Revision: https://phabricator.services.mozilla.com/D62936

--HG--
extra : moz-landing-system : lando
2020-02-14 21:44:05 +00:00
Masayuki Nakano cf058a67c2 Bug 1615131 - Make `StaticRange` instances reused as far as possible like `nsRange` r=smaug
When we support `InputEvent.getTargetRanges()`, editor needs to create
`StaticRange` instances at starting to handle every edit operations/commands.
Therefore, we need a hack for saving allocation cost like `nsRange`.

This patch moves `nsRange::MaybeCacheToReuse()` and `nsRange::Shutdown()` to
`AbstractRange` to reduce copy&paste same code into `nsRange` and `StaticRange`.
However, `Create(nsINode*)` and `Release()` are duplicated unfortunately.

Differential Revision: https://phabricator.services.mozilla.com/D62692

--HG--
extra : moz-landing-system : lando
2020-02-14 15:02:43 +00:00
Kershaw Chang 26da4db75f Bug 1603504 - Use release_acquire in nsStringBuffer::IsReadonly for TSan build r=froydnj
TSan reports a benign race when accessing a string between main thread and IPDL background thread. The reason is that we use `memory_order_relaxed` to check the reference count of StringBuffer. To avoid the benign race, this patch uses `memory_order_acquire` to perform acquire memory synchronization only for TSan build.

Differential Revision: https://phabricator.services.mozilla.com/D57620

--HG--
extra : moz-landing-system : lando
2020-02-14 14:06:43 +00:00
Cosmin Sabou ff39f9206d Backed out 2 changesets (bug 1613263, bug 1611326) for presummably causing l10n langpack bustages. a=backout
Backed out changeset 77e54e76848a (bug 1611326)
Backed out changeset 36ba18ac3a68 (bug 1613263)
2020-02-14 15:02:21 +02:00
Mike Shal ad0c283ab2 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-13 23:07:04 +00:00
Brindusan Cristian e2fb6b8344 Backed out changeset 7fefed11f117 (bug 1611326) for build bustages at update-1.xpi.stub. CLOSED TREE 2020-02-13 23:33:34 +02:00
Mike Shal e6464dd404 Bug 1611326 - Default to py3_action, and add a py2 attribute to GENERATED_FILES; r=firefox-build-system-reviewers,rstewart
GENERATED_FILES now defaults to python3 unless py2=True is specified as
an argument. All existing GENERATED_FILES scripts and GeneratedFile
templates have the py2=True attribute added, so this patch should
effectively be a no-op.

Going forward, individual scripts can be converted to python3 and their
corresponding py2=True attribute can be deleted. In effect, this patch
will be backed out in pieces until all scripts run in python3, at which
point the py2 attribute itself can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D60919

--HG--
extra : moz-landing-system : lando
2020-02-13 20:31:50 +00:00
Doug Thayer 615de231ee Bug 1607505 - Move StartupCache destructor later in shutdown r=froydnj a=reland CLOSED TREE
Since we've decoupled the writing of the StartupCache from the freeing
of the StartupCache's tables (which takes nontrivial time), this patch
moves the StartupCache's destructor later in shutdown so it will be
skipped in the early _exit(0) efforts. There is a remaining
WaitOnWriteThread in the StartupCache's destructor, but this is a
minor sanity check to avoid use-after-frees in the write thread during
shutdown. In general it won't matter as we already wait for the write
thread in the xpcom-shutdown observer, and if we shut down during write,
the system is set up to be okay with that (because it already happens).

Differential Revision: https://phabricator.services.mozilla.com/D62295

--HG--
extra : source : d79f1d283acde1a971fe0e5e6f1a8db075f8589a
extra : histedit_source : 32a2b4fec1fcf35960155b0f4280a38bcb54ec19
2020-02-12 19:03:29 +00:00
Doug Thayer f564eb1f40 Bug 1607505 - Start writing StartupCache earlier in shutdown r=froydnj a=reland CLOSED TREE
The initial thought for getting the StartupCache out of the shutdown
path was to simply not write it during shutdown, as it should write
60 seconds after startup, and the theory was that if the user shut
down within the first 60 seconds of use, they were likely updating or
something and it shouldn't matter. However, considering how many of
our users only ever open one tab, I think it's rather likely that
users are starting up firefox to go to a web site, then closing it
when done with that website, and then maybe opening up a new instance
in order to go to a different website. Accordingly it still makes
sense to continue writing it. However, we may as well leverage a
background thread for this and get it kicked off earlier during
shutdown, so we don't sit there blocking in the destructor late
during shutdown.

Differential Revision: https://phabricator.services.mozilla.com/D62294

--HG--
extra : source : 7b7b147b6955cee07e0c115993446bfbd59cf7e2
extra : histedit_source : 6990122d6b1ac4939b0e4b0a5e452183fb981e19
2020-02-12 19:02:12 +00:00
Tuan 3fadc6333d Bug 1614139 - Copy constructor of nsPipeInputStream should not be declared explicit. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D62735

--HG--
extra : moz-landing-system : lando
2020-02-13 16:09:09 +00:00