Jonathan Kew
71e6f71f87
Bug 784648 - Implement the 'hanging' and 'each-line' options for CSS text-indent. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D191522
2023-10-23 15:12:23 +00:00
Marc Seibert
04d7ba785a
Bug 1853418 - Prepare remaining tests.r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D190557
2023-10-18 10:15:34 +00:00
Sylvestre Ledru
1e776756dd
Bug 1856795 - ride along: use = default; on some recently modified files r=emilio
...
More on:
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html
Command:
L=$(hg export -r tip|grep +++|cut -d/ -f2-)
./mach static-analysis check --checks="-*, modernize-use-equals-default" --fix $L
Differential Revision: https://phabricator.services.mozilla.com/D191016
2023-10-15 15:29:03 +00:00
Sylvestre Ledru
d0f6c7fc66
Bug 1856795 - Remove redundant member init r=emilio
...
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .
https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html
Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-15 15:29:02 +00:00
Cristina Horotan
6a90f5eded
Backed out 2 changesets (bug 1856795) for causing build bustage at BasicEvents.h CLOSED TREE
...
Backed out changeset 1d98b028923a (bug 1856795)
Backed out changeset eae2ac93e17c (bug 1856795)
2023-10-14 21:42:14 +03:00
Sylvestre Ledru
c164bd9937
Bug 1856795 - ride along: use = default; on some recently modified files r=emilio
...
More on:
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html
Command:
L=$(hg export -r tip|grep +++|cut -d/ -f2-)
./mach static-analysis check --checks="-*, modernize-use-equals-default" --fix $L
Differential Revision: https://phabricator.services.mozilla.com/D191016
2023-10-14 17:34:27 +00:00
Sylvestre Ledru
cc8a0ee742
Bug 1856795 - Remove redundant member init r=emilio
...
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .
https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html
Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-14 17:34:26 +00:00
Magnus Melin
9f36e5de25
Bug 1857233 - Fix null pointer crash [@ GetColumnHeaderCellsCB ]. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D190278
2023-10-09 08:25:59 +00:00
James Teh
92e74db106
Bug 1843832: Never return the text leaf child of a link when calling IAccessible::accHitTest on an ancestor of the link. r=nlapre
...
This is necessary to work around a bug in the Windows UI Automation -> IAccessible2 proxy.
See the code comments for details.
Differential Revision: https://phabricator.services.mozilla.com/D187529
2023-10-05 04:12:28 +00:00
James Teh
07a83e875e
Bug 1852190 part 4: Add Windows UIA interfaces, constants and utility functions to the Python environment. r=eeejay
...
This also adds a simple control type test which shows all of this working.
Differential Revision: https://phabricator.services.mozilla.com/D187756
2023-10-04 23:58:46 +00:00
James Teh
232e8c986c
Bug 1852190 part 3: Add Windows MSAA/IA2 interfaces, constants and utility functions to the Python environment. r=eeejay,jmaher
...
This also adds a simple role test which shows all of this working.
Differential Revision: https://phabricator.services.mozilla.com/D187746
2023-10-04 23:58:45 +00:00
James Teh
bd293df36c
Bug 1852190 part 2: Reintroduce the IAccessible2 typelib. r=nlapre
...
We need this so that Python comtypes can generate bindings for IAccessible2.
This is almost identical to what was here before, but it excludes some stuff that was only needed for the COM interceptor.
Differential Revision: https://phabricator.services.mozilla.com/D187745
2023-10-04 23:58:45 +00:00
James Teh
a3144bfdf5
Bug 1852190 part 1: Provide the ability for a11y browser tests to run Python code. r=eeejay,jmaher
...
Our mochitest harness always runs a pywebsocket3 server which supports handlers as files in any test directory.
We use this to implement a WebSocket which takes Python code as input and returns a JSON serialised result or exception.
The Python code is wrapped in a function so that it can return a result by simply using the return statement.
Python code run via the WebSocket has its own globals namespace.
OS specific things will be placed in this namespace for convenience in future patches.
Tests might also use Python globals to persist things they don't want to keep retrieving every call.
A runPython function has been added to shared-head.js to be called by browser tests.
This manages connection to the WebSocket, sending the code, asynchronously handling the response, etc.
It simply takes Python code as a string and returns the deserialised result.
Differential Revision: https://phabricator.services.mozilla.com/D187744
2023-10-04 23:58:44 +00:00
Yannis Juglaret
b24022bb02
Bug 1777960 - Patch msctf.dll to prevent a crash with ZoneAlarm Anti-Keylogger. r=gstoll,win-reviewers
...
Starting with Windows 11 22H2, Microsoft has made internal changes in
msctf.dll. The TF_Notify function, also known as CtfImmNotify from
imm32.dll, uses a new convention for its third argument. These changes
are incompatible with current versions of ZoneAlarm Anti-Keylogger,
resulting in crashes in our main process.
This patch converts messages forwarded by ZoneAlarm Anti-Keylogger to
the new convention. If we detect the product and an incompatible version
of msctf.dll, then we hook TF_Notify and detect any message using the
old convention, and convert it to the new convention.
Differential Revision: https://phabricator.services.mozilla.com/D189518
2023-10-03 15:24:47 +00:00
Makoto Kato
bef691023f
Bug 1848282 - Part 3. a11y's word segmenter should reference layout.word_select preferences. r=morgan
...
We need to consider `layout.word_select.stop_at_punctuation preference` even if
using new segmenter.
Differential Revision: https://phabricator.services.mozilla.com/D188786
2023-10-03 10:43:18 +00:00
Makoto Kato
9dde11abbe
Bug 1848282 - Part 1. Move IsPunctuation to nsUnicharUtils. r=TYLin
...
Remove duplication code.
Differential Revision: https://phabricator.services.mozilla.com/D188784
2023-10-03 10:43:17 +00:00
Sylvestre Ledru
4c29c24344
Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Natalia Csoregi
a03097876a
Backed out 3 changesets (bug 1848282) for causing gv-junit failures. CLOSED TREE
...
Backed out changeset d1fc71cc3817 (bug 1848282)
Backed out changeset 3446c1367bfd (bug 1848282)
Backed out changeset c800ae9f7943 (bug 1848282)
2023-09-28 08:03:34 +03:00
Makoto Kato
9e1a48232e
Bug 1848282 - Part 3. a11y's word segmenter should reference layout.word_select preferences. r=morgan
...
We need to consider `layout.word_select.stop_at_punctuation preference` even if
using new segmenter.
Differential Revision: https://phabricator.services.mozilla.com/D188786
2023-09-28 04:11:06 +00:00
Makoto Kato
750893b128
Bug 1848282 - Part 1. Move IsPunctuation to nsUnicharUtils. r=TYLin
...
Remove duplication code.
Differential Revision: https://phabricator.services.mozilla.com/D188784
2023-09-28 04:11:05 +00:00
Morgan Rae Reschenberg
99d3c904f5
Bug 1855310: Add HCM Settings documentation r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D189289
2023-09-27 18:56:31 +00:00
Eitan Isaacson
3a9cb41004
Bug 1854473 - Use screen's scale factor when providing accessible bounds in ATK. r=nlapre
...
Differential Revision: https://phabricator.services.mozilla.com/D188883
2023-09-26 18:41:32 +00:00
Morgan Rae Reschenberg
4d088e2687
Bug 1853255: Make parent relative bounds for IB-split descendants account for the parent's bounding box offset r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D188523
2023-09-25 21:49:08 +00:00
Noemi Erli
6c25733d95
Backed out changeset cf2c8ac2f33c (bug 1853255) for causing failures in Browser_zero_area.js CLOSED TREE
...
accessible/tests/browser/bounds/browser_position.js
2023-09-20 09:19:03 +03:00
Morgan Rae Reschenberg
adfbba681a
Bug 1853255: Make parent relative bounds for IB-split descendants account for the parent's bounding box offset r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D188523
2023-09-20 00:23:42 +00:00
Tom Marble
5d0e417af5
Bug 1853223 - convert .ini manifests to .toml: batch 4 accessible/**/browser.ini r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D188305
2023-09-15 14:32:09 +00:00
Marco Bonardo
70fdad6676
Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
...
This should make a bit clearer that it is only starting the load, not waiting
for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Masatoshi Kimura
217c7989da
Bug 1852806 - Remove macros for older Windows SDK from accessible/windows/msaa/. r=nlapre
...
Differential Revision: https://phabricator.services.mozilla.com/D188018
2023-09-15 03:19:25 +00:00
Cosmin Sabou
f8c16a8f94
Backed out 15 changesets (bug 1852806) for causing mda failures on test_video_low_power_telemetry.html. CLOSED TREE
...
Backed out changeset faea1f4cb9a9 (bug 1852806)
Backed out changeset 4db93c374f9b (bug 1852806)
Backed out changeset 7e40e0e04921 (bug 1852806)
Backed out changeset b0a66c4269ce (bug 1852806)
Backed out changeset 4ff3545936f9 (bug 1852806)
Backed out changeset 02c0a8eb3fd6 (bug 1852806)
Backed out changeset ae2c7b33acfb (bug 1852806)
Backed out changeset 2b89ba254a1a (bug 1852806)
Backed out changeset dfa4f73fc548 (bug 1852806)
Backed out changeset daffcc4c1877 (bug 1852806)
Backed out changeset 33855bcdf15e (bug 1852806)
Backed out changeset 694f29707f3e (bug 1852806)
Backed out changeset 1891eda22a59 (bug 1852806)
Backed out changeset 1b854941389c (bug 1852806)
Backed out changeset 2f7cfe04be59 (bug 1852806)
2023-09-15 09:48:27 +03:00
Masatoshi Kimura
dd10eddab9
Bug 1852806 - Remove macros for older Windows SDK from accessible/windows/msaa/. r=nlapre
...
Differential Revision: https://phabricator.services.mozilla.com/D188018
2023-09-15 03:19:25 +00:00
Vincent Hilla
1273773f91
Bug 1066940 - Align return type of HTMLFormElement::elements with spec. r=dom-core,webidl,peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D188246
2023-09-14 16:37:14 +00:00
Sandor Molnar
950a3c620d
Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
...
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
61f8ecc425
Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
...
This should make a bit clearer that it is only starting the load, not waiting
for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
Benjamin De Kosnik
3a6200ddc3
Bug 1830181 - Add PerfStats for DocAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D185615
2023-09-13 19:28:00 +00:00
Magnus Melin
f7eab3bd11
Bug 1850643 - Fix crash in [@ -[mozTableCellAccessible moxColumnHeaderUIElements]]. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D187763
2023-09-13 06:43:24 +00:00
James Teh
352ff65c6a
Bug 1851865: Include the subtree of <code>, <sup>, <sub>, <ins> and <del> when computing the a11y name if the element isn't the root node of the computation. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D187866
2023-09-12 01:17:24 +00:00
James Teh
5e1a54c589
Bug 1851288: Cache when a UIA client is not on the block list. r=nlapre
...
Previously, we cached when a UIA client was blocked or when there were no UIA clients.
However, we did not cache the result when a UIA client was present but *not* blocked.
This isn't normally a problem because a11y is normally instantiated in this case, which means we won't try to do any client detection again this session.
However, if a11y is force disabled via the pref, we still do detection, but we don't instantiate.
This meant that a UIA client which hammered us with queries would keep triggering the detection code, since we weren't caching the result.
That resulted in severe performance degradation for impacted users.
To fix this, cache the UIA detection result even if we do allow a11y instantiation.
Differential Revision: https://phabricator.services.mozilla.com/D187869
2023-09-12 01:09:49 +00:00
James Teh
80432ae524
Bug 1785412: Let ARIA reflection (non-idref) and default Accessibility Semantics for Custom Elements ride the trains. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D187439
2023-09-11 03:52:52 +00:00
Makoto Kato
ef2a0ed90f
Bug 1851105 - Use nsAString as parameter for WordBreaker::FindWord. r=TYLin
...
It is better to use nsAString rather than using pointer directly.
Differential Revision: https://phabricator.services.mozilla.com/D187256
2023-09-08 04:35:38 +00:00
Mike Hommey
633e2ac6ba
Bug 1851946 - Remove outdated mac SDK-version checks. r=mac-reviewers,media-playback-reviewers,bradwerth,alwu
...
Now that the minimum supported version of the mac SDK is 13.3, all the
macro-based checks for SDK versions older than that are always false.
Remove them.
Differential Revision: https://phabricator.services.mozilla.com/D187639
2023-09-08 01:44:07 +00:00
Gregory Pappas
4ae14d1518
Bug 1851541 - Remove html5.inert.enabled pref r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D187422
2023-09-07 01:01:13 +00:00
Masatoshi Kimura
57cbcde5bb
Bug 1849927 - Fix build error with WINVER >= 0x0A00 in accessible/windows/msaa/. r=nlapre
...
Differential Revision: https://phabricator.services.mozilla.com/D186745
2023-09-06 19:30:01 +00:00
James Teh
618a5cd667
Bug 1849007: Skip non-rendered characters in a11y cached character rects, since a11y only deals with rendered text. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D186521
2023-09-06 04:55:28 +00:00
Mike Hommey
9331b9fb07
Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw
...
For some reason, its value in the Google style we use is 80... except
for Objective-C, where it's 100, which led to things like:
https://hg.mozilla.org/mozilla-central/rev/31bf68247e6e
https://hg.mozilla.org/mozilla-central/rev/64ceb33533a4 .
There's probably a discussion to have about whether 80 is the right
limit, but since it's what's used for everything except ObjC, let's roll
with it.
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D187409
2023-09-05 11:23:01 +00:00
Stanca Serban
91cdc5cbc0
Backed out changeset b5748074bf70 (bug 1851541) for causing eslint failures.
2023-09-05 11:36:37 +03:00
Gregory Pappas
959520513e
Bug 1851541 - Remove html5.inert.enabled pref r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D187422
2023-09-05 07:49:53 +00:00
Christian Holler (:decoder)
5e6a80d7a8
Bug 1847728 - Handle nullptr in RemoteAccessible::ApplyCache. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D185691
2023-09-04 15:25:22 +00:00
James Teh
f47f70424f
Bug 1848991: Attach a RemoteAccessible to its parent before calling ProxyCreated. r=eeejay
...
This is what we did before the fix for bug 1779578.
Failure to do this meant that RemoteAccessible::IsLink() returned false even for a child of a HyperText Accessible, which meant the ATK object was created without the HyperLink interface.
This change requires that we move the handling of pending OOP child docs, since we can't add a child document until ProxyCreated has been called on the OuterDoc.
Differential Revision: https://phabricator.services.mozilla.com/D186423
2023-08-31 22:01:52 +00:00
Tom Marble
022d30e88c
Bug 1848994 Allow comments in manifestparser conditions. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D186999
2023-08-29 14:08:57 +00:00
Andrew Halberstadt
d814ef1e9d
Bug 1850409 - Skip accessible/tests/mochitest/events/docload/test_docload_shutdown.html with Wayland, r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D186969
2023-08-28 20:16:32 +00:00