DevRel have made it clear that one of the number one complaints they hear is that we are not supporting React in our tools.
So how about we have our event bubbles include React events and allow people to go to the event listener source in the debugger?
I don't believe that any other tool does this so it is totally worth doing... and in time for Christmas as well ;)
Works just fine in development and production versions of React.
It also works in the browser toolbox so it can be used to debug events in our own tools e.g. The Debugger.
The files under devtools/client/inspector/markup/test/ are either test or React library files so they only really need a cursory glance.
This means that you should focus on the following files when reviewing:
- devtools/client/locales/en-US/inspector.properties
- devtools/client/shared/widgets/tooltip/EventTooltipHelper.js
- devtools/server/actors/inspector.js
- devtools/server/event-parsers.js
Now allowed the use of JSX in mochitests and fixed all eslint errors.
MozReview-Commit-ID: AtxhainieQe
--HG--
extra : rebase_source : c57ce476875b19b99ef9e2dcf66df1274809fa54
Pass css-color-4 supporting status from css-property db to OutputParser and SwatchColorPickerTooltip.
MozReview-Commit-ID: N1ffWOlf9f
--HG--
extra : rebase_source : 94b281c2c101d27dc169a6ba6eeca5acf60b8f16
We were always opening the debugger when clicking on the location link,
which could be wrong since we can have CSS warnings, or logs coming from Scratchpad.
So we add the function to open in StyleEditor and Scratchpad, and copy some mochitests
that where testing the interaction with those links.
MozReview-Commit-ID: 73mQNfy199m
--HG--
rename : devtools/client/webconsole/test/browser_webconsole_bug_766001_JS_Console_in_Debugger.js => devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_location_debugger_link.js
rename : devtools/client/webconsole/test/browser_webconsole_scratchpad_panel_link.js => devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_location_scratchpad_link.js
rename : devtools/client/webconsole/test/browser_webconsole_bug_782653_CSS_links_in_Style_Editor.js => devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_location_styleeditor_link.js
rename : devtools/client/webconsole/test/test-bug-766001-console-log.js => devtools/client/webconsole/new-console-output/test/mochitest/test-location-debugger-link-console-log.js
rename : devtools/client/webconsole/test/test-bug-766001-js-errors.js => devtools/client/webconsole/new-console-output/test/mochitest/test-location-debugger-link-errors.js
rename : devtools/client/webconsole/test/test-bug-766001-js-console-links.html => devtools/client/webconsole/new-console-output/test/mochitest/test-location-debugger-link.html
rename : devtools/client/webconsole/test/test-bug-782653-css-errors-1.css => devtools/client/webconsole/new-console-output/test/mochitest/test-location-styleeditor-link-1.css
rename : devtools/client/webconsole/test/test-bug-782653-css-errors-2.css => devtools/client/webconsole/new-console-output/test/mochitest/test-location-styleeditor-link-2.css
rename : devtools/client/webconsole/test/test-bug-782653-css-errors.html => devtools/client/webconsole/new-console-output/test/mochitest/test-location-styleeditor-link.html
extra : rebase_source : a8494acb5e450f86fa9cddd34515265fc3494d17
Sometimes (e.g. for window.applicationCache), Reps was shown with a negative number
before the "more..." label. This was due to displaying the children of safeGeterValues
property but not taking them into account for the total number of properties in the object
when displaying the "more..." label.
We fix this and add a test case to make sure we won't have this bug later
MozReview-Commit-ID: 1qBCvehV0Jc
--HG--
extra : rebase_source : 44461f378681407665c6426c0b30be87ae95488a
Sébastien Blin
Wes Kocher
Towkir Ahmed
Aman Dwivedi
Tomer Cohen
Julian Descottes
Ryan VanderMeulen
Michael Ratcliffe
Phil Ringnalda
Carsten "Tomcat" Book
JerryShih
Sebastian Hengst
Xidorn Quan
Tim Nguyen
gtatum@mozilla.com
Nicolas Chevobbe
Fred Lin
Mythmon
Andrea Marchesini
Jarda Snajdr
Steve Chung
Iulian Radu
Gabriel Luong