That way, we only add that notification channel if the updater really is active,
i.e. not if we've been installed from the Play Store.
Unfortunately, using the UpdateServiceHelper requires a Context, so adding/re-
moving the UPDATER_CHANNEL_TAG cannot be done during variable initialisation.
Differential Revision: https://phabricator.services.mozilla.com/D4890
--HG--
extra : moz-landing-system : lando
Also, if entering PIP fails will make sure that upon restarting the activity
it's orientation will match device's.
Differential Revision: https://phabricator.services.mozilla.com/D5035
--HG--
extra : moz-landing-system : lando
The issue in this ticket was because of missing menuItemSecondaryActionBarStyle,
property of the menu items shown in the SecondaryActionBar.
The GeckoAppBase style from values-v23/themes.xml contained the properties
initially defined in the general values/themes.xml.
Now changed to contain the properties from the closest values-v21/themes.xml.
Differential Revision: https://phabricator.services.mozilla.com/D5031
--HG--
extra : moz-landing-system : lando
It appears that we don't actually need to load this plugin, since we're not
doing any JaCoCo-related operations on the build machine (like generating
reports). This has been left over since I integrated code coverage to gv-junit.
Depends on D4144
Differential Revision: https://phabricator.services.mozilla.com/D4145
--HG--
extra : moz-landing-system : lando
Skip tests that fail on debug and code coverage builds, either intermittently
or permanently. See bug 1481834 for details about why these tests are skipped.
Depends on D4218
Differential Revision: https://phabricator.services.mozilla.com/D4219
--HG--
extra : moz-landing-system : lando
Rename the command and extend it to also archive Fennec class files into
another artifact, target.app_classfiles.zip.
Depends on D4142
Differential Revision: https://phabricator.services.mozilla.com/D4143
--HG--
extra : moz-landing-system : lando
Don't send window changed event if a11y has been turned off in the mean
time.
Differential Revision: https://phabricator.services.mozilla.com/D5192
--HG--
extra : moz-landing-system : lando
When entering and exiting immersive mode multiple time (~30) the WebGL context can be lost. This is caused because GeckoSurfaceTexture things there are more than 200 textures created.
Differential Revision: https://phabricator.services.mozilla.com/D4235
--HG--
extra : moz-landing-system : lando
In my opinion this is an altogether nicer way of setting and resetting temporary
StrictMode exceptions. The only fly in the ointment is that this causes a
warning about a technically unused variable that subsequently needs suppressing.
Differential Revision: https://phabricator.services.mozilla.com/D4889
--HG--
extra : rebase_source : 706af6665b709c2ed29730cf266c3267417e4a52
extra : source : 54a3c14eff313baade8bc40523f69fa9c7aaba75
That way, we only add that notification channel if the updater really is active,
i.e. not if we've been installed from the Play Store.
Unfortunately, using the UpdateServiceHelper requires a Context, so adding/re-
moving the UPDATER_CHANNEL_TAG cannot be done during variable initialisation.
Differential Revision: https://phabricator.services.mozilla.com/D4890
--HG--
extra : moz-landing-system : lando
Previously, most of our notifications were silent, so we adopt a default
priority of IMPORTANCE_LOW instead of IMPORTANCE_DEFAULT.
Since we cannot change the priority setting for existing users on Nightly any
more, we technically have to retire the old default channel and replace it by
a new channel with a different ID. While in a way this is circumventing Google's
API design and destroys any existing customisation users have set for that
channel, we are only using this exceptionally to *lower* the initial priority of
our default notification channel, which we accidentally set too high. Besides,
it is unlikely that there are many users who really want to receive all kinds of
random Firefox notifications with a high priority.
Differential Revision: https://phabricator.services.mozilla.com/D4364
--HG--
extra : moz-landing-system : lando
nsISHEntry.index is readonly, but if you pass `true` as getEntryAtIndex()'s
second argument, nsISHEntry.index will be modified. This is pretty gross.
This patch changes `index` so it's not readonly (because it's not!) and removes
getEntryAtIndex()'s second argument.
--HG--
extra : rebase_source : c519d77fcc1c3bda2f260b5888ce9cd0f6cfdab5
This removes a number of references to rules that are now deprecated or removed from ESLint.
- no-native-reassign is replaced with no-global-assign
- no-spaced-func is replaced with func-call-spacing (where enabled)
Depends on D4944
Differential Revision: https://phabricator.services.mozilla.com/D4946
--HG--
extra : moz-landing-system : lando
Added a default channel for Leanplum push notifications as fallback to cover the cases where we receive
push notifications from server with an invalid channel and the case where there are no channels configured
on server.
Provided a valid default icon for push notifications in Leanplum required for fallback strategy.
Differential Revision: https://phabricator.services.mozilla.com/D4704
--HG--
extra : moz-landing-system : lando
If we don't have a saved session, we do nothing. If somebody called setSession
beforehand, we continue using that session, otherwise we create a fallback
session in onAttachedToWindow().
If we have a saved session and nobody called setSession, we use the saved
session. If the saved session was closed and doesn't have a runtime, we use the
default runtime as a fallback.
If we have both a saved session and somebody already called setSession, we
transfer what can be transferred from the saved session, unless the saved
session is closed and the session from setSession is open.
If the saved session was open, we use its runtime as well going forward (since
transferring the state from an open session transfers the window and the runtime
as well), otherwise we keep the old mRuntime.
Differential Revision: https://phabricator.services.mozilla.com/D4711
--HG--
extra : moz-landing-system : lando
Added an extra check for package name for a better user experience, because the push notifications with "about" protocol
in the URL message were still firing the chooser dialog.
Differential Revision: https://phabricator.services.mozilla.com/D4578
--HG--
extra : moz-landing-system : lando
Instead of stopping the foreground service whenever ACTION_PAUSE was triggered,
I created a new event where we notify the service to clear its foreground state.
Cleared usages of the NotificationManager and the onGoing attribute of the
MediaNotification because they are redundant. As of Android 4.3 a service in the
foreground state will always force the notification to be persistent and callling
stopForeground(false) will clear the onGoing flag while maintaining the notification.
Differential Revision: https://phabricator.services.mozilla.com/D4567
--HG--
extra : moz-landing-system : lando
From the PIP window the user can either return to the fullscreen app or exit
it entirely.
Fullscreen and subsequently hiding the status bar should only be done if the
user is returning to the app.
Differential Revision: https://phabricator.services.mozilla.com/D4676
--HG--
extra : moz-landing-system : lando
In my opinion this is an altogether nicer way of setting and resetting temporary
StrictMode exceptions. The only fly in the ointment is that this causes a
warning about a technically unused variable that subsequently needs suppressing.
Differential Revision: https://phabricator.services.mozilla.com/D4889
--HG--
extra : source : ac7659d4135e270b6d787499680aefc39a01fb4f
extra : histedit_source : bdffd8eee3fcf1e705316de6e84da7c7aac9340a
Doing so allow to use try-with-resources on all API levels supported by us, not
just starting from API19.
Unfortunately this step also introduces some additional ambiguities in overload
resolution, which means that one of GeckoResult's "then" overloads needs to be
renamed.
Differential Revision: https://phabricator.services.mozilla.com/D4887
--HG--
extra : rebase_source : 7173395484a9616ce739e9d2ba3aa0b8410be386
extra : source : 66955d05bb86c25b1fcb81d60b38be95018d09ca
Some common javadoc mistakes are logged as warnings and are being
overlooked. javadoc does not support warning-as-error natively, so this
patch scans the javadoc output in gradle and makes the task fail if any
warnings are detected.
Differential Revision: https://phabricator.services.mozilla.com/D3925
To avoid cluttering our notification settings on builds not using the built-in
updater, we only add that channel when required.
Passing a null channelId to the system NotificationManager, which can then
happen if someone attempts to use the UPDATER channel anyway, even though
MOZ_UPDATER is false, is safe. It just means that the NotificationManager will
return the system's default channel, which will silently swallow any
notifications posted to it from apps targeting Android O or above.
Differential Revision: https://phabricator.services.mozilla.com/D4584
--HG--
extra : moz-landing-system : lando
Fix Lollipop crashes because of android.content.res.ColorStateList.addFirstIfMissing()
The default app theme will be applied for the material Date/Time pickers on
API 21 and API 22. After this, on API >=23 they will be Photon themed.
Differential Revision: https://phabricator.services.mozilla.com/D4464
--HG--
extra : moz-landing-system : lando
Jean-Yves Avenard
Jan Henning
Petru Lingurar
Bogdan Tara
Tudor-Gabriel Vîjială
Jim Chen
arthur.iakab
Coroiu Cristina
Imanol Fernandez
Andreea Pavel
Margareta Eliza Balazs
Nicholas Nethercote
Gurzau Raul
Mark Banner
Kris Maglione
Andrei Lazar
Ciure Andrei
Vlad Baicu
Mike Hommey
Dennis Schubert