Sylvestre Ledru
fde06f6d21
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila
964cca3198
Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE
2020-11-04 10:54:36 +02:00
Sylvestre Ledru
5f29324f60
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Simon Giesecke
b13b4d3deb
Bug 1650076 - Clean up ThreadLocal. r=dom-workers-and-storage-reviewers,asuth
...
Move ThreadLocal to a separate header file.
Reuse LoggingIdString in ThreadLocal (and make use of nsAutoCStringN).
Differential Revision: https://phabricator.services.mozilla.com/D82018
2020-07-03 09:40:12 +00:00
Cosmin Sabou
a40ede8ab7
Backed out 4 changesets (bug 1650076) for build bustages on indexedDB/ProfilerHelpers.h. CLOSED TREE
...
Backed out changeset 42951b61e9dc (bug 1650076)
Backed out changeset 18b34fb0ddbd (bug 1650076)
Backed out changeset 1d378f2af866 (bug 1650076)
Backed out changeset 42df520d1cff (bug 1650076)
2020-07-03 11:49:58 +03:00
Simon Giesecke
4c5ca225c9
Bug 1650076 - Clean up ThreadLocal. r=dom-workers-and-storage-reviewers,asuth
...
Move ThreadLocal to a separate header file.
Reuse LoggingIdString in ThreadLocal (and make use of nsAutoCStringN).
Differential Revision: https://phabricator.services.mozilla.com/D82018
2020-07-03 08:08:27 +00:00
Simon Giesecke
85c8c0062e
Bug 1648454 - Use NotNull with IDBRequest where applicable. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D81078
2020-07-01 20:14:23 +00:00
Simon Giesecke
5f4d07aff0
Bug 1632128 - De-virtualize IDBRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74874
2020-05-14 09:42:18 +00:00
Simon Giesecke
18c7f261c4
Bug 1623278 - Use SafeRefPtr for IDBTransaction. r=dom-workers-and-storage-reviewers,ttung,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D67287
2020-04-21 14:32:51 +00:00
Jon Coppeard
9d03b9bd1a
Bug 1629843 - Mark indexedDB classes as able to have pointers into more than one JS zone r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D71289
2020-04-17 14:57:57 +00:00
Simon Giesecke
da859a31b2
Bug 1623278 - Use SafeRefPtr for IDBFactory. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D66972
--HG--
extra : moz-landing-system : lando
2020-04-01 09:54:43 +00:00
Eric Rahm
124379887c
Bug 1617327 - Part 2: Remove nsAutoPtr usage from ipc, security, IDB. r=mccr8,janv
...
This removes `nsAutoPtr` usage from ipc/. security/ failed to build due to missing includes so I fixed that as well. IDB was using `ThreadLocal` from ipc which had a member changed to a `UniquePtr` so needed to be updated as well. localstorage was missing some includes.
Differential Revision: https://phabricator.services.mozilla.com/D63745
--HG--
extra : moz-landing-system : lando
2020-02-24 19:26:40 +00:00
Emilio Cobos Álvarez
256c124f94
Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj
...
This was done by:
This was done by applying:
```
diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
index 789affde7bbf..fe33c4c7d4d1 100644
--- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
+++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
@@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
from subprocess import Popen, PIPE, check_output, CalledProcessError
diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
- args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
+ args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']
if not output_file:
args.append("-i")
```
Then running `./mach clang-format -c <commit-hash>`
Then undoing that patch.
Then running check_spidermonkey_style.py --fixup
Then running `./mach clang-format`
I had to fix four things:
* I needed to move <utility> back down in GuardObjects.h because I was hitting
obscure problems with our system include wrappers like this:
0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration
0:03.94 extern void *realloc (void *__ptr, size_t __size)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here
0:03.94 MALLOC_DECL(realloc, void*, void*, size_t)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL'
0:03.94 MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__);
0:03.94 ^
0:03.94 <scratch space>:178:1: note: expanded from here
0:03.94 realloc_impl
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl'
0:03.94 #define realloc_impl mozmem_malloc_impl(realloc)
Which I really didn't feel like digging into.
* I had to restore the order of TrustOverrideUtils.h and related files in nss
because the .inc files depend on TrustOverrideUtils.h being included earlier.
* I had to add a missing include to RollingNumber.h
* Also had to partially restore include order in JsepSessionImpl.cpp to avoid
some -WError issues due to some static inline functions being defined in a
header but not used in the rest of the compilation unit.
Differential Revision: https://phabricator.services.mozilla.com/D60327
--HG--
extra : moz-landing-system : lando
2020-01-20 16:19:48 +00:00
Emilio Cobos Álvarez
aa3a695712
Bug 1609996 - Remove mozilla/Move.h. r=froydnj
...
rg -l 'mozilla/Move.h' | xargs sed -i 's/#include "mozilla\/Move.h"/#include <utility>/g'
Further manual fixups and cleanups to the include order incoming.
Differential Revision: https://phabricator.services.mozilla.com/D60323
--HG--
extra : moz-landing-system : lando
2020-01-20 16:18:20 +00:00
Simon Giesecke
f048b16e15
Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D55494
--HG--
extra : moz-landing-system : lando
2019-12-19 09:23:47 +00:00
Simon Giesecke
1fb48dd681
Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D55478
--HG--
extra : moz-landing-system : lando
2019-12-13 12:31:10 +00:00
Andrea Marchesini
484db81418
Bug 1455020 - Extend CheckInnerWindowCorrectness() to check the state of the worker, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D25486
--HG--
extra : moz-landing-system : lando
2019-04-01 16:46:46 +00:00
Andrea Marchesini
da174a4757
Bug 1539407
- Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D25041
--HG--
extra : moz-landing-system : lando
2019-03-29 18:05:11 +00:00
Daniel Varga
7af208ab28
Backed out changeset 98452610cfcc (bug 1539407
) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE
...
--HG--
extra : histedit_source : 236c5d6a7a4440a7b545c1ec5a0a72a8c5777b6b
2019-03-29 18:01:58 +02:00
Andrea Marchesini
788d12712b
Bug 1539407
- Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D25041
--HG--
extra : moz-landing-system : lando
2019-03-29 14:12:04 +00:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Jan de Mooij
ed41af5ddc
Bug 1480678 part 9 - Assert IDBWrapperCache::mScriptOwner is a global and use JSAutoRealm instead of JSAutoRealmAllowCCW. r=mrbkap
2018-08-07 14:06:45 +02:00
Jan de Mooij
80adc67aba
Bug 1478955 part 1 - Rename JSAutoRealm to JSAutoRealmAllowCCW. r=luke
2018-07-28 12:12:26 +02:00
Jeff Gilbert
5b753da289
Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
...
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Jan de Mooij
80e44e8003
Bug 1461292 part 1 - Rename JSAutoCompartment to JSAutoRealm. r=bz,luke
2018-05-16 10:53:16 +02:00
Andrea Marchesini
d75b53e83e
Bug 1448247 - Port IDBRequest to WorkerRef, r=janv
2018-04-19 12:06:28 +02:00
Boris Zbarsky
14f26fccf6
Bug 1449631 part 8. Remove nsIDOMEventTarget::GetEventTargetParent. r=smaug
...
MozReview-Commit-ID: 5wQ2LYrjUxf
2018-04-05 13:42:41 -04:00
Boris Zbarsky
4292bca4ee
Bug 1449631 part 6. Remove nsIDOMEventTarget::DispatchEvent. r=smaug
...
MozReview-Commit-ID: 8YMgmMwZkAL
2018-04-05 13:42:41 -04:00
Andrea Marchesini
8cdf705535
Bug 1435174 - Remove the renaming 'using namespace workers', r=bkelly
2018-02-05 19:55:07 +01:00
Andrea Marchesini
26352bfee1
Bug 1432963 - Fixing workers headers - part 17 - no LIBS=[workers] in moz.build files, r=smaug
2018-01-31 08:25:30 +01:00
Andrea Marchesini
063723a1f0
Bug 1432963 - Fixing workers headers - part 13 - WorkerHolder without workers namespace, r=smaug
2018-01-31 08:23:44 +01:00
Olli Pettay
d78d3295c5
Bug 1412775
- Implement Event.composedPath, r=stone
...
--HG--
extra : rebase_source : a970c4a0daac4a7a02cec34733131734eb93b151
2017-12-18 18:07:36 +02:00
Andrea Marchesini
73712f7d05
Bug 1405290 - Improve logging of workers when shutting down - part 3 - WorkerHolder with names, r=asuth
2017-11-15 07:58:38 +01:00
Andrea Marchesini
baa04d619a
Bug 1120178 - Migrate DOMError to DOMExtension in FileReader, IndexedDB, DOMRequest and so on, r=smaug
2017-08-06 20:47:00 +03:00
Andrew McCreight
78807d8776
Bug 1391005 - Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. r=peterv
...
Replace it with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION, because it
has been the same for a while.
MozReview-Commit-ID: 5agRGFyUry1
--HG--
extra : rebase_source : 5388c56b2f6905c6ef969150f0c5b77bf247624d
2017-08-29 16:02:48 -07:00
Bevis Tseng
a29c316c12
Bug 1352401 - Part 2: Count active IDBOpenRequest, IndexedDB databases/transactions. r=janv
...
--HG--
extra : rebase_source : 3f59fe1087678af689384b34db440960966e00af
2017-06-16 19:06:36 +08:00
Bevis Tseng
dda9bab7b2
Backed out changeset 9c62253ad1a3 (Bug 1374675)
2017-06-21 11:01:52 +08:00
Bevis Tseng
d6b1d1a397
Bug 1352401 - Part 2: Count active IDBOpenRequest, IndexedDB databases/transactions. r=janv
...
--HG--
extra : rebase_source : 87263d63be9021fe2493beb4b874c7e2749fd665
2017-06-16 19:06:36 +08:00
Bevis Tseng
e98d22391d
Bug 1366647 - Adopt NS_ASSERT_OWNINGTHREAD for PRThread equality. r=janv
...
MozReview-Commit-ID: 4j1ifEtrsvD
2017-06-07 13:55:00 +08:00
Olli Pettay
0364dbc792
Bug 1326507, remove NS_IMPL_CYCLE_COLLECTION_TRAVERSE_SCRIPT_OBJECTS, r=mccr8
...
--HG--
extra : rebase_source : 3ae1207308de120b7299b13ecaa95dd1612b3459
2017-01-03 21:47:55 +02:00
Stone Shih
1ed10ff082
Bug 1305458 Part1: Rename nsIDOMEventTarget::PreHandleEvent to nsIDOMEventTarget::GetEventTargetParent. r=smaug
...
MozReview-Commit-ID: FM3vDUyLOCb
--HG--
extra : rebase_source : 5a513af84718a6d591f77437a0704984c8fc2b67
2016-10-21 10:11:07 +08:00
Jon Coppeard
556585c65f
Bug 1297558 - Remove explicit calls to Expose*ToActiveJS r=mccr8
2016-10-18 17:58:19 +01:00
Ben Kelly
9d7b33a00b
Bug 1293690 P2 Set explicit status levels to fail at when calling WorkerHolder::HoldWorker. r=baku
2016-08-18 07:11:04 -07:00
Phil Ringnalda
4083fafafc
Backed out 10 changesets (bug 1290116, bug 1293690) for build bustage
...
CLOSED TREE
Backed out changeset bbc14d107fca (bug 1290116)
Backed out changeset a81b6ce5c25f (bug 1290116)
Backed out changeset e0b9c25b6125 (bug 1290116)
Backed out changeset 8e9a9ba04ce5 (bug 1290116)
Backed out changeset 2d5ad5e9ed20 (bug 1290116)
Backed out changeset eb7da0dbfc72 (bug 1290116)
Backed out changeset 6a4e8c92faae (bug 1290116)
Backed out changeset 0342d98afa10 (bug 1293690)
Backed out changeset d84b0768f0ce (bug 1293690)
Backed out changeset f9f62ade9508 (bug 1293690)
2016-08-17 21:16:43 -07:00
Ben Kelly
fa520e1fdd
Bug 1293690 P2 Set explicit status levels to fail at when calling WorkerHolder::HoldWorker. r=baku
2016-08-17 20:01:35 -07:00
Boris Zbarsky
fb2eb08b4d
Bug 1289179. IDBRequest::SetResultCallback should expose its script owner to active JS before entering its compartment. r=baku
2016-07-27 11:05:36 -04:00
Andrea Marchesini
aac2306f2c
Bug 1269154 - Get rid of WorkerFeature: WorkerHolder, r=khuey
...
--HG--
rename : dom/cache/Feature.cpp => dom/cache/CacheWorkerHolder.cpp
rename : dom/cache/Feature.h => dom/cache/CacheWorkerHolder.h
rename : dom/workers/WorkerFeature.h => dom/workers/WorkerHolder.h
2016-06-23 10:53:14 +02:00
Carsten "Tomcat" Book
47aeb86e2c
Backed out changeset 1c5d78c7ba43 (bug 1269154) for bustage on a CLOSED TREE
...
--HG--
rename : dom/cache/CacheWorkerHolder.cpp => dom/cache/Feature.cpp
rename : dom/cache/CacheWorkerHolder.h => dom/cache/Feature.h
rename : dom/workers/WorkerHolder.h => dom/workers/WorkerFeature.h
extra : rebase_source : 49f9e9ce0500ac441fe97878cf9308804926544f
2016-06-23 10:13:54 +02:00
Andrea Marchesini
45087a7970
Bug 1269154 - Get rid of WorkerFeature: WorkerHolder, r=khuey
...
--HG--
rename : dom/cache/Feature.cpp => dom/cache/CacheWorkerHolder.cpp
rename : dom/cache/Feature.h => dom/cache/CacheWorkerHolder.h
rename : dom/workers/WorkerFeature.h => dom/workers/WorkerHolder.h
2016-06-22 17:24:35 +02:00
Alexandre Lissy
09d61ae31a
Bug 1260441 - Never pass a null js context to OpenCursor() r=bz
...
MozReview-Commit-ID: 2Scs80wX411
--HG--
extra : rebase_source : 0d8d74a756a1b059fe0b516de292b0226740def7
2016-03-30 13:03:03 +02:00