The test was failing on ccov machines because it was
timing out. The interesting part is that in the logs
we could see that a huge error was logged, because
we were hitting the IGNORED REDUX ACTION middleware,
which was about a SET_TERMINAL_EAGER_RESULT action
being blocked.
I think that logging this object was taking so much
time that it made the test timeout on slow machines.
So here we're simply waiting for the eager evaluation
result to be displayed, so we know that the action won't
be ignored.
Differential Revision: https://phabricator.services.mozilla.com/D74879
To enable the Open In Sidebar action, we were retrieving the
actor id of the root node of an object inspector.
But in the case of error, we don't use the object inspector
to render them, only the reps.
We still have a reference to the actor id though, so when
there's no object inspector, but that we have an actor id
ref, we enable the action.
A test case is added in a mochitest to ensure this works as
expected for an error object, and that we can observe custom
properties that are not displayed in the error rep.
This also reveiled an issue with React keys in the Error rep,
which we fix in this patch.
Differential Revision: https://phabricator.services.mozilla.com/D73301
In the Browser toolbox destroy function, we now wait for
any pending connection initialization promise.
In the test we close the browser toolbox at the end.
We also need to guard a few method in the connection proxy
to ensure the instances we use are still alive before using
them.
Differential Revision: https://phabricator.services.mozilla.com/D71171
The original site issue (https://trello.com/) seems not obvious on nightly
now. (See Bug 1301305 for more details.) So perhaps we could give this a
trial to disable this pref, for the better performance in other cases.
Differential Revision: https://phabricator.services.mozilla.com/D74278
This moves some symbolication code out of browser.js and into a new module symbolication.jsm.js.
It also threads the pageContext parameter through to getSymbolsFromThisBrowser so that it can
respect the correct objdir pref. This part is probably more complicated than necessary.
Differential Revision: https://phabricator.services.mozilla.com/D63914
The `browser_aboutdebugging_navigate_to_url.js` test times out if we don't wait for the about:devtools-toolbox tab to be removed as a target from about:debugging.
Differential Revision: https://phabricator.services.mozilla.com/D74467
In the Browser toolbox destroy function, we now wait for
any pending connection initialization promise.
In the test we close the browser toolbox at the end.
We also need to guard a few method in the connection proxy
to ensure the instances we use are still alive before using
them.
Differential Revision: https://phabricator.services.mozilla.com/D71171
Fix up the browser_tab_label_during_restore.js test to wait for the right number of tab title changes, since the timing of the tab title updating has now changed.
Differential Revision: https://phabricator.services.mozilla.com/D72562
We add `targetType` and `isTopLevel` properties on the target front, which
are set from the targetList and are used in the EvaluationContextSelector.
As a result we are able to directly call targetFront.targetType in a few
places instead of calling `getTargetType` again.
Differential Revision: https://phabricator.services.mozilla.com/D73890
This patch use the new `exception` and `hasException` field from nsIScriptError
so we can render the actual object in the message error instead of a stringified
version.
Error object are still displayed using the `customFormat` prop, so we display
only the type + message + stacktrace (but we'll have a way to inspect them
in the sidebar soon).
Existing tests were updated to fix failures, and some tests/test cases were
added to make sure we cover all the different kind of errors we can display
in the console.
Differential Revision: https://phabricator.services.mozilla.com/D71288
This patch use the new `exception` and `hasException` field from nsIScriptError
so we can render the actual object in the message error instead of a stringified
version.
Error object are still displayed using the `customFormat` prop, so we display
only the type + message + stacktrace (but we'll have a way to inspect them
in the sidebar soon).
Existing tests were updated to fix failures, and some tests/test cases were
added to make sure we cover all the different kind of errors we can display
in the console.
Differential Revision: https://phabricator.services.mozilla.com/D71288
Depends on D62624
With the previous implementation, an uninitialized document could be returned as a root node.
Here we try to be more explicit and wait for a correct root node. However in some cases a document can remain uninitialized and will never transition to any other state.
If the document is uninitialized but is not currently loading, we should consider it as a valid root node.
Differential Revision: https://phabricator.services.mozilla.com/D62625
Sebastian Zartner
Jason Laster
Alexandre Poirot
David Walsh
Julian Descottes
Christoph Kerschbaumer
Yura Zenevich
Micah Tigley
Nicolas Chevobbe
Florens Verschelde
Bogdan Tara
Tom Schuster
Boris Chiou
Markus Stange
Cosmin Sabou
Mihai Alexandru Michis
Neil Deakin
Razvan Maries
Dorel Luca