It fixes a bunch of websites, and we don't have any known regression.
I think we could try to enable as-is but let me know if you'd prefer me
to look into fixing stuff like bug 1675949 (though I briefly looked into
it and it didn't seem quite trivial, though it should be doable from
DeltaAcummulator::InitLineOrPageDelta).
Your call though.
Differential Revision: https://phabricator.services.mozilla.com/D107195
Until we're ready to advance this all the way to beta/release, we should have
it match so we don't run into late shutdown crashes that we missed on Nightly.
Differential Revision: https://phabricator.services.mozilla.com/D107523
This essentially reverts what we did in bug 1686274, because users are not happy
with just getting Segoe UI Emoji instead. However, the pref is left in place so
that we can easily experiment with disabling the font to continue testing the
impact on startup, rendering, etc.
Differential Revision: https://phabricator.services.mozilla.com/D107056
This is straight-forward and builds on the color animation code. This
implements only the <percentage> syntax, not the whole <color-adjuster>
syntax, which seems fairly more complex.
Of course, this only uses sRGB because that's all the colors we support,
but it should be feasible to extend to lab() / lch() colors once we
support those.
I believe this subset of syntax is useful and worth implementing, so
people can play with it and say if it's useful.
Differential Revision: https://phabricator.services.mozilla.com/D106698
The preference was meant to exist only temporarily when
the "navigator.webdriver" property was added by bug 1169290
in Firefox 60.
Differential Revision: https://phabricator.services.mozilla.com/D106778
Backs out bug 1599173 which landed in Firefox 72. The pref has been enabled since bug 1600855 which landed in Firefox 73
Differential Revision: https://phabricator.services.mozilla.com/D106731
(Almost?) all other scrollbar performed scrolling goes through apz already (this effort was called "desktop_zooming_scrollbars").
This one mode was missed. It uses a repeating timer and setting the curpos attribute to trigger scrolling.
Unfortunately xul trees use this path as well, so we have to keep the old path around for them.
This makes one notable change in behaviour. Both before and after this patch single clicks on scrollbar buttons pass ENABLE_SNAP to the scroll from when they request scrolling (in nsScrollbarButtonFrame::HandleButtonPress). However for repeat scrolling when clicking and holding (which is handled by nsScrollbarFrame::MoveToNewPosition), before this patch the scrolling would not use ENABLE_SNAP. This is not super clear because MoveToNewPosition sets the curpos attributes, and then ScrollFrameHelper::CurPosAttributeChanged( would get called in response to that, and it would call ScrollToWithOrigin to the do scrolling, and it does not specify the snap mode, but the default is DISABLE_SNAP. This patch changes that so that we explicitly pass ENABLE_SNAP in MoveToNewPosition. It seems that this was likely overlooked (not hard to do when it's not clear like this) when adding snapping support. It makes sense to handle snapping the same way for single clicks and clicking and holding. If this turns out to be the wrong idea we can easily change it back.
Needs a test.
Differential Revision: https://phabricator.services.mozilla.com/D105288
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.
Differential Revision: https://phabricator.services.mozilla.com/D105473
If some attributes are only able to be set in certain platform, that increase the difficulty of wrting a test.
Therefore, we make them being able to set in all platforms, but doing the check in the fianl stage, which is reporting the result, to ensure that those error would still only be displayed on the right platform.
But if we're in testing, then we can test all error types in one platform.
Differential Revision: https://phabricator.services.mozilla.com/D104474
If some attributes are only able to be set in certain platform, that increase the difficulty of wrting a test.
Therefore, we make them being able to set in all platforms, but doing the check in the fianl stage, which is reporting the result, to ensure that those error would still only be displayed on the right platform.
But if we're in testing, then we can test all error types in one platform.
Differential Revision: https://phabricator.services.mozilla.com/D104474
Emilio Cobos Álvarez
Henrik Skupin
Doug Thayer
Alexandru Michis
Andrew Osmond
Kagami Sascha Rosylight
Brindusan Cristian
Jonathan Kew
Kershaw Chang
Paul Zuehlcke
Olli Pettay
Matt Woodrow
sotaro
Simon Giesecke
longsonr
Bogdan Tara
Anny Gakhokidze
Timothy Nikkel
Dragana Damjanovic
Randell Jesup
alwu
Cosmin Sabou
Valentin Gosu