Without waiting for the initial navigation to "about:blank" to
complete, there is a risk for a race condition given that the
navigation to the test URL happens immediately.
Differential Revision: https://phabricator.services.mozilla.com/D86967
When the first test URL is "about:blank" the reftest window
needs to refresh its location and not trigger a new navigation,
which would lead to no page load events.
By correctly initializing the lastURL property, "loadTestURL"
will be able to determine the correct loading mechanism to use,
and not always trigger a navigation.
Differential Revision: https://phabricator.services.mozilla.com/D86966
Other engines also do this, but with my previous patch breaks it
(because we only hit print() on the print-content-viewer _after_ doing
the clone).
So move it before triggering all the machinery, and only for
window.print(). Given we didn't check this for print preview etc, I
think it's fine to carry on for user-triggered loads.
Trivial test-case (which I'm not quite sure how to turn into an
automated test...)
<!doctype html>
<h1>I do get printed but...</h1>
<script>
window.print();
</script>
<h2>Do I?</h2>
Note that this is broken with the new print preview UI already, this
fixes it.
Differential Revision: https://phabricator.services.mozilla.com/D87898
Automatic update from web-platform-tests
Make sure Oscillator read index is in valid range.
In ProcessARateVectorKernel we forgot to mask v_read0 to contain the
index in a valid range. v_read1 was handled correctly, and
ProcessKRateVector also masked the indices. Apply the mask.
Manually tested this agains the repro case from the bug and no issues
occur. Previously, I could easily reproduce the issue.
Added simple test case where detune overflows. Output should be zero.
Bug: 1115907
Change-Id: Id7af713b935bd7cc14669630ddb1d04c3b1b2c39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358593
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799646}
--
wpt-commits: 66dd99d39168dd28549af64bb6869bc506d87608
wpt-pr: 25050
Automatic update from web-platform-tests
[FS] Require a leading . in accepted extensions.
Implements the changes from https://github.com/WICG/native-file-system/pull/219.
Change-Id: Ic785f0362b5c73a843145c5384f063cf24770b7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360597
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799617}
--
wpt-commits: 7a3831fa57581bcd6081f9a2d2befbda888c016b
wpt-pr: 25071
Automatic update from web-platform-tests
[wptrunner] Python 3: make sure repo path is str type (#25028)
This CL is to fix a TypeError for edgechromium run with Python 3.6
--
wpt-commits: 0f172703935d6a7df19b42e6a330004707f354d2
wpt-pr: 25028
Automatic update from web-platform-tests
[CORS] Set preflight request mode correctly
CORS preflight request mode was set to kNoCors up until now, and with
cross-origin-embedder-policy: require-corp CORS preflights fail unless
a CORP header is attached. Fix the bug.
Bug: 1116990
Change-Id: Id91c8d92a17c701bacb2289c2f5a23561f3e7538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362065
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799531}
--
wpt-commits: e7b93dec0e72438f6de9fc8f3acb6494f952122c
wpt-pr: 25067
Automatic update from web-platform-tests
Add subtests for case sensitivity of type/entryTypes attributes (#24891)
--
wpt-commits: 17ebc3aea0d6321e69554067c39ab5855e6fb67e
wpt-pr: 24891
Automatic update from web-platform-tests
Update some Screen Enumeration mentions to Window Placement
Use the active window-placement repo url and name instead.
Leaves some mentions that are still abstractly applicable.
Copy Screen TODO from third_party/blink/renderer/core/frame/screen.h
Bug: 897300
Change-Id: I134516e21a74f0cec5f543306efa39fad6d76dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358134
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799460}
--
wpt-commits: 7b54ffa9d93e9fc804f2552a43ad7770bb9d8b5a
wpt-pr: 25085
Automatic update from web-platform-tests
[AspectRatio] Add tests for cross size in flexbox
This exposed a bug where we don't correctly compute the cross
size in a column flexbox with aspect-ratio.
R=ikilpatrick@chromium.org
Bug: 1045668,1117279
Change-Id: Ic823ed349e2caf061834e116d5958832745cd63a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358827
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799377}
--
wpt-commits: 3b0369731004dca0a8d931bafd6859c36c0869b0
wpt-pr: 25060
Automatic update from web-platform-tests
Perpare to fix cancelling when unsetting transition and fix metric
Add logic to distinguish between transitions which should (base
computed style changes) and shouldn't be cancelled when transition is
completely unset (as the default is all 0s). Currently, both are still
cancelled, the same as the old behaviour, but the histogram
kCSSTransitionCancelledByRemovingStyle is now only incremented when
transitions are cancelled incorrectly.
Add WPT for not cancelling transitions then unsetting transition
property, fix web_tests to cancel transitions by setting transition to
none instead of unsetting.
Bug: 934700
Change-Id: Iaf4bf324e6e2bd6ca22a66fd8ae2320620a874dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363173
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799336}
--
wpt-commits: bb69d6b51a09292099d1b04efb774c064a3ff164
wpt-pr: 25069
Automatic update from web-platform-tests
WebCodecs: Evaluate decoder config codec strings
Updates Audio/Video Decoder to reject invalid codecs passed to
configure(). A TypeError should be thrown.
Additionally, if the config is valid but unsupported,
throw a NotSupportedError.
Adds wpt test to verify the behavior for validity. Support behavior
is difficult to wpt test (varies by build/platform) - tested manually.
Bug: 1113824
Change-Id: I647c476fa32e684d57816222e1787aeb8f723c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360312
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799271}
--
wpt-commits: 0299abc230efc4994083cba80b09d836fd2bed64
wpt-pr: 25051
Automatic update from web-platform-tests
Add VideoFrame serialization tests
This CL adds tests which verify that VideoFrames are properly serialized
when posted as messages, and that they can be cloned and destructoyed.
Change-Id: I4aedcde443a8f8f0b1884a106cebd013a4d482d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358349
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799261}
--
wpt-commits: e732d26632aaea04387fe1384b79fa6a457158b0
wpt-pr: 25055
Automatic update from web-platform-tests
[scroll-animations] Support animation-timeline in animation shorthand
This CL adds support for expanding animation-timeline from the
animation shorthand. As of [1], we support multiple shorthand
expansions based on runtime flags, so there is no web-facing change
to the animation shorthand (or anything else) unless the
CSSScrollTimeline runtime flag is turned on.
According to [2], we are supposed to omit the value from the
shorthand serialization if doing so doesn't change the meaning of the
overall value of the shorthand (i.e. if it's 'auto'). Unfortunately
we generally don't adhere this guideline for the existing longhands,
and are therefore not equipped to handle this as gracefully as I would
like. For now I am checking for 'auto' "manually". Long term we might
want to generalize this "skip-if-initial" mechanism somehow, since
it has come up before [3], and will definitely come up again.
Note that:
- Animation::CSSValueFromComputedStyleInternal is the code
responsible for the serialization used when calling
getComputedStyle(elm).animation, and:
- StylePropertySerializer::GetLayeredShorthandValue is the code
responsible for the serialization used when calling (e.g.)
elm.style.animation.
The fact that we have two completely separate code paths for this
is ... suboptimal, but that's a different story.
[1] https://crrev.com/c/2250242
[2] https://drafts.csswg.org/cssom/#serializing-css-values
[3] http://crrev.com/c/2241677
Bug: 1074052
Change-Id: I6f5266ca202276e78536a845835242181b8cd40a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358837
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799248}
--
wpt-commits: 7e5f47c9e13840a0d347d5a7b4c83a63d4e4a130
wpt-pr: 25065
Automatic update from web-platform-tests
Origin isolation: rename the getter (but leave an alias) (#25052)
This renames window.originIsolationRestricted to window.originIsolated
per the latest spec changes. This largely amounts to massive test
updates.
window.originIsolationRestricted is retained as an alias for the
duration of the origin trial so as to avoid breaking deployed code, and
a wpt_internal test ensures this.
Bug: 1103866
Change-Id: I4f570c79d19dc783d40beb3549d677555d1c81af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353013
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799235}
Co-authored-by: Domenic Denicola <domenic@chromium.org>
--
wpt-commits: 44055a7919612fc8c51f273968da9f49b4ad4cab
wpt-pr: 25052