Simon Giesecke
485ec92560
Bug 708901 - Migrate to nsTHashSet in accessible. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D108589
2021-03-23 10:36:32 +00:00
Christian M. Macy
a0adf7ccba
Bug 1633570 - Add setter for AXValue (incrementables only) r=morgan
...
This commit adds an AXValue setter to incremental accessibles, as well
as tests to validate that setter on both a range and number input.
Differential Revision: https://phabricator.services.mozilla.com/D106333
2021-03-16 16:17:53 +00:00
Simon Giesecke
ad01a10a3b
Bug 1634281
- Use nsTHashMap instead of nsDataHashtable. r=xpcom-reviewers,necko-reviewers,jgilbert,nika,valentin
...
Note that this patch only transforms the use of the nsDataHashtable type alias
to a directly equivalent use of nsTHashMap. It does not change the specification
of the hash key type to make use of the key class deduction that nsTHashMap
allows for in some cases. That can be done in a separate step, but requires more
attention.
Differential Revision: https://phabricator.services.mozilla.com/D106008
2021-03-10 10:47:47 +00:00
Eitan Isaacson
d6fb8b1903
Bug 1694566 - P2: Make EWhichChildAtPoint an enum class and put it in Accessible. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D106678
2021-03-03 06:10:01 +00:00
Eitan Isaacson
bafd5e712b
Bug 1694203
- P9: Have RemoteAccessible inherit from Accessible. r=Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D104915
2021-03-02 16:32:24 +00:00
Simon Giesecke
9af107a839
Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
...
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.
Differential Revision: https://phabricator.services.mozilla.com/D105473
2021-02-26 09:11:46 +00:00
Masayuki Nakano
ef2253b4a1
Bug 1691622 - part 9: Make `nsIWidget::SynthesizeNativeMouseEvent` take an XP button ID and abstract message value r=smaug,geckoview-reviewers,agi,m_kato
...
Currently, it takes a raw native message value, but it makes JS content too
complicated. And on Linux, it cannot synthesize non-primary button events
because GDK has only button press and release messages which dont' include
mouse button information.
For solving these problems, this patch creates a new abstract native message
as `nsIWidget::NativeMouseMessage` and makes each widget converts it to
a platform native message.
Additionally, this patch adds an argument to make it possible its callers
to specify pressing or releasing mouse button with a DOM mouse button value.
Note that the following patch adds new argument to
`synthesizeNativeEventMouse*` for mochitests and which will be tested by
new tests.
Differential Revision: https://phabricator.services.mozilla.com/D105763
2021-02-24 01:27:10 +00:00
Masayuki Nakano
b63882dde8
Bug 1691622 - part 4: Make `synthesizeNativeMouseClick*()` aware of modifiers r=smaug,geckoview-reviewers,m_kato
...
Surprisingly, they don't take modifiers, and
`nsIWidget::SynthesizeNativeMouseEvent()` which are implementations of
`nsIDOMWindowUtils::SendNativeMouseEvent()` treat given modifier flags
are native's ones, and handle modifiers only on macOS. Therefore, this
patch makes them handle native modifiers of Gecko.
Unfortunately, I'm not so familiar with Android API, and in the short
term, I don't need the support on Android. Therefore, this patch just
adds a TODO comment on Android widget.
Additionally, we don't have a simple way to set modifier only while
posting a mouse input on Windows too. It requires complicated code.
Therefore, I don't add the support for it on Windows too.
Differential Revision: https://phabricator.services.mozilla.com/D105758
2021-02-24 01:27:07 +00:00
Eitan Isaacson
6e8749d0da
Bug 1693597 - P2: Rename ProxyAccessible to RemoteAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D105671
2021-02-19 23:14:33 +00:00
Eitan Isaacson
6e49732365
Bug 1693597 - P1: Rename Accessible to LocalAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D105670
2021-02-19 23:14:32 +00:00
Markus Stange
355baf5b39
Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik
...
This patch was generated automatically, using the following commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK/NS_OBJC_BEGIN_TRY_IGNORE_BLOCK/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK/NS_OBJC_END_TRY_IGNORE_BLOCK/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104960
2021-02-16 22:55:21 +00:00
Markus Stange
9bc888af4a
Bug 1692391 - Replace NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NIL with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(nil). r=haik
...
This patch was generated automatically, using the following commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NIL/NS_OBJC_END_TRY_BLOCK_RETURN(nil)/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104959
2021-02-16 22:55:21 +00:00
Markus Stange
56051da2d0
Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik
...
This patch was generated with the commands:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE)/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104957
2021-02-16 22:55:20 +00:00
Markus Stange
5257db6695
Bug 1692391 - Remove the word ABORT from the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_RETURN macros, because these macros don't abort. r=haik,necko-reviewers
...
This patch was generated automatically with the commands below:
```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_RETURN' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_RETURN/NS_OBJC_END_TRY_BLOCK_RETURN/g'
```
Differential Revision: https://phabricator.services.mozilla.com/D104955
2021-02-16 22:55:20 +00:00
Sylvestre Ledru
4fe9680965
no bug - Remove a pylint warning - variable 'text' is unused r=mstange DONTBUILD
...
Depends on D105299
Differential Revision: https://phabricator.services.mozilla.com/D105300
2021-02-16 21:10:33 +00:00
Eitan Isaacson
ff59e176e4
Bug 1692523 - P2: Prefix remote heirarchy functions with 'Remote'. r=Jamie
...
Parent -> RemoteParent
ChildAt -> RemoteChildAt
FirstChild -> RemoteFirstChild
LastChild -> RemoteLastChild
NextSibling -> RemoteNextSibling
PrevSibling -> RemotePrevSibling
Differential Revision: https://phabricator.services.mozilla.com/D105035
2021-02-16 20:05:11 +00:00
Eitan Isaacson
8c842a59e3
Bug 1692523 - P1: Prefix local heirarchy functions with 'Local'. r=Jamie
...
Parent -> LocalParent
GetChildAt -> LocalChildAt
FirstChild -> LocalFirstChild
LastChild -> LocalLastChild
NextSibling -> LocalNextSibling
PrevSibling -> LocalPrevSibling
Differential Revision: https://phabricator.services.mozilla.com/D105034
2021-02-16 20:05:10 +00:00
Morgan Reschenberg
1fe81c2358
Bug 1691502: Don't attempt to invalidate table cache on outlines r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D104432
2021-02-10 18:29:36 +00:00
Eitan Isaacson
49dfc2e434
Bug 1691831 - Clamp offsets to character count in HyperTextIterator. r=morgan
...
I tried to come up with a good test for this, that reproduces the issue in a demonstratable way, but couldn't.
Differential Revision: https://phabricator.services.mozilla.com/D104586
2021-02-10 06:58:40 +00:00
Eitan Isaacson
0a92b9e380
Bug 1690342 - P5: Use AXTextArea for multiline aria text boxes. r=morgan DONTBUILD
...
Now that we have attribtued text we don't need to advertise rich text editables as AXTextField.
Differential Revision: https://phabricator.services.mozilla.com/D103803
2021-02-08 23:26:49 +00:00
Eitan Isaacson
cb03a1923c
Bug 1690342 - P4: Implement IPC attributed text getter. r=morgan DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D103802
2021-02-08 23:26:47 +00:00
Eitan Isaacson
e6912635e0
Bug 1690342 - P2: Populate NSAttributedText attributes with attributes. r=morgan DONTBUILD
...
A followup patch will make this work in e10s. This current implementation is non-ipc.
Differential Revision: https://phabricator.services.mozilla.com/D103800
2021-02-08 23:26:31 +00:00
Eitan Isaacson
84896a7a88
Bug 1690342 - P1: Introduce moxAncestorSearch for finding ancestors. r=morgan DONTBUILD
...
It looks like we need to do this often. Adding it to the protocol/base class allows
us to not have to worry each time about typing and traversing past MOX accessibles.
Differential Revision: https://phabricator.services.mozilla.com/D103799
2021-02-08 23:26:24 +00:00
Morgan Reschenberg
b6cdc22e2b
Bug 1680840: Introduce table style changed event to mac platform, update caching r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103698
2021-02-04 20:50:12 +00:00
Morgan Reschenberg
ced0045bea
Bug 1688490: Make GetNativeFromGeckoAccessible null-safe r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103813
2021-02-04 19:41:30 +00:00
Morgan Reschenberg
6b8df6efbe
Bug 1686744: Fire AXMenuItemSelected notification when menu item is pressed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D103954
2021-02-04 19:41:37 +00:00
Morgan Reschenberg
62aed9ef20
Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-02 21:30:58 +00:00
Butkovits Atila
2af3edc6b9
Backed out 2 changesets (bug 1688730) for causing mochitest failures. CLOSED TREE
...
Backed out changeset 677c17ec48ea (bug 1688730)
Backed out changeset a7d0770117c8 (bug 1688730)
2021-02-02 02:04:28 +02:00
Morgan Reschenberg
876affb062
Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-01 20:23:23 +00:00
Butkovits Atila
e13215fdec
Backed out 2 changesets (bug 1688730) for causing build bustage on mozTableAccessible.mm. CLOSED TREE
...
Backed out changeset bd6d78d36cee (bug 1688730)
Backed out changeset dd03939b850e (bug 1688730)
2021-02-01 21:44:02 +02:00
Morgan Reschenberg
3b5f7255b1
Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-01 17:54:13 +00:00
Morgan Reschenberg
897cbb0e6e
Bug 1688490: Gather moxParent directly instead of querying the parent of our gecko accessible r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D102965
2021-01-26 21:12:11 +00:00
Eitan Isaacson
92f8f50dd8
Bug 1688680 - Don't include AXTextStateSync in read-only collapsed text selection events. r=morgan.
...
Differential Revision: https://phabricator.services.mozilla.com/D102948
2021-01-25 17:58:52 +00:00
Eitan Isaacson
81befd069d
Bug 1686832 - Cache MULTI_LINE in mozAccessible. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D101842
2021-01-22 20:42:26 +00:00
Eitan Isaacson
135c36619d
Bug 1686995 - Add AXTextSelectionDirection and AXTextSelectionGranularity to text selection events. r=morgan
...
.. and also add AXTextSelectionChangedFocus and AXTextStateSync when needed.
Differential Revision: https://phabricator.services.mozilla.com/D102509
2021-01-22 21:12:56 +00:00
Morgan Reschenberg
09060aa168
Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-21 19:58:13 +00:00
Brindusan Cristian
ff8e5cb389
Backed out changeset 2860943a09a3 (bug 1686164) for build bustages at mozSelectableElements.mm. CLOSED TREE
2021-01-21 10:58:18 +02:00
Morgan Reschenberg
fdab0ce3d7
Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-21 08:42:02 +00:00
Butkovits Atila
477b1bc69a
Backed out changeset ea36fa2936a2 (bug 1686164) for causing failures on test_controls.html. CLOSED TREE
2021-01-20 08:43:35 +02:00
Morgan Reschenberg
1baf91ec07
Bug 1686164: Implement ignoreWithParent for context menu items and submenus. r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101652
2021-01-19 22:04:52 +00:00
Eitan Isaacson
720902efa2
Bug 1686839 - Apply MustPrune dynamically and not at creation time. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D101853
2021-01-19 17:15:05 +00:00
Marco Zehe
eede5be7ec
Bug 1687480 - Fire NSAccessibility notifications for expanding and collapsing rows, r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D102308
2021-01-19 16:53:38 +00:00
Eitan Isaacson
09c48de881
Bug 1686827 - GeckoTextMarker is lesser than if child's offset is greater or equal. r=morgan
...
Differential Revision: https://phabricator.services.mozilla.com/D101835
2021-01-15 19:18:46 +00:00
Eitan Isaacson
a5ce58cf1a
Bug 1625953 - P2: Introduce support for aria-controls and aria-flowto in mac. r=morgan
...
This is via AXARIAControls and AXLinkedUIElements respectively.
Differential Revision: https://phabricator.services.mozilla.com/D101085
2021-01-15 17:22:56 +00:00
Eitan Isaacson
515ee847be
Bug 1625953 - P1: Introduce getRelationsByType for mozAccessible. r=morgan
...
A small refactor to make all of the relations getting easier.
Differential Revision: https://phabricator.services.mozilla.com/D101084
2021-01-15 17:22:49 +00:00
Dorel Luca
9e9b090ec4
Backed out 2 changesets (bug 1625953) for Eslint failure
...
Backed out changeset 33fa80e826a8 (bug 1625953)
Backed out changeset 36da5d89bc8a (bug 1625953)
2021-01-15 06:37:54 +02:00
Eitan Isaacson
0c9ddcad81
Bug 1625953 - P2: Introduce support for aria-controls and aria-flowto in mac. r=morgan
...
This is via AXARIAControls and AXLinkedUIElements respectively.
Depends on D101084
Differential Revision: https://phabricator.services.mozilla.com/D101085
2021-01-08 00:22:25 +00:00
Eitan Isaacson
1dcdfb0a26
Bug 1625953 - P1: Introduce getRelationsByType for mozAccessible. r=morgan
...
A small refactor to make all of the relations getting easier.
Differential Revision: https://phabricator.services.mozilla.com/D101084
2021-01-08 00:19:04 +00:00
Morgan Reschenberg
c19d6d89b4
Bug 1682865: Map roles::EDITCOMBOBOX to mozTextAccessible r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D101407
2021-01-11 22:04:13 +00:00
Morgan Reschenberg
2bc463ad54
Bug 1681292: Ensure menu items correctly expose AXVisibleChildren and AXChildren r=eeejay
...
Differential Revision: https://phabricator.services.mozilla.com/D99949
2021-01-07 21:33:21 +00:00