The decision not to allocate has been made for the whole block and null
buffers are not filled, so the incremental frame count is irrelevant.
Differential Revision: https://phabricator.services.mozilla.com/D97103
PDMFactory::CreateDecoder is changed to return a MozPromise that will contain the MediaDataDecoder once created.
This will allow to later make RemoteDecoderManager fully asynchronous and no longer require an IPC sync call to start the RDD process.
We also modify the WebrtcMediaDataDecoderCodec to never create a decoder on the main thread, which could cause deadlocks under some circumstances.
Differential Revision: https://phabricator.services.mozilla.com/D96364
PDMFactory::CreateDecoder is changed to return a MozPromise that will contain the MediaDataDecoder once created.
This will allow to later make RemoteDecoderManager fully asynchronous and no longer require an IPC sync call to start the RDD process.
We also modify the WebrtcMediaDataDecoderCodec to never create a decoder on the main thread, which could cause deadlocks under some circumstances.
Differential Revision: https://phabricator.services.mozilla.com/D96364
Currently we didn't consider the engine's output volume when we determine the audible state for the destination node, doing that would help us to more correctly deide the actual audible state for users.
Differential Revision: https://phabricator.services.mozilla.com/D94182
The main purposes of this patch is to
- changes the way the destination node holding the audio channel agent (holding the agent all the time)
That would help us
- earlier mute the destination node in order to prevent sound leaking
- request wakelock based on the actual audible state (considering more factors)
- improve the readability of handling audible state (the old way contains some weird workaround, eg. setting the node as audible in the beginning)
Differential Revision: https://phabricator.services.mozilla.com/D94181
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
This renames the thread and identifiers derived from the thread's name. This is
to avoid ambiguity over if the thread relates to the MediaController class,
which it does not.
Differential Revision: https://phabricator.services.mozilla.com/D93806
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Currently we didn't consider the engine's output volume when we determine the audible state for the destination node, doing that would help us to more correctly deide the actual audible state for users.
Differential Revision: https://phabricator.services.mozilla.com/D94182
The main purposes of this patch is to
- changes the way the destination node holding the audio channel agent (holding the agent all the time)
That would help us
- earlier mute the destination node in order to prevent sound leaking
- request wakelock based on the actual audible state (considering more factors)
- improve the readability of handling audible state (the old way contains some weird workaround, eg. setting the node as audible in the beginning)
Differential Revision: https://phabricator.services.mozilla.com/D94181
Currently we didn't consider the engine's output volume when we determine the audible state for the destination node, doing that would help us to more correctly deide the actual audible state for users.
Differential Revision: https://phabricator.services.mozilla.com/D94182
The main purposes of this patch is to
- changes the way the destination node holding the audio channel agent (holding the agent all the time)
That would help us
- earlier mute the destination node in order to prevent sound leaking
- request wakelock based on the actual audible state (considering more factors)
- improve the readability of handling audible state (the old way contains some weird workaround, eg. setting the node as audible in the beginning)
Differential Revision: https://phabricator.services.mozilla.com/D94181
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Following bug 1566389, an AudioBuffer can be created only to be then truncated if we need to trim it back to a size of 0.
When the resulting AudioBuffer is transferred over IPC it will be rebuilt, and be null then making EnsureAudioBuffer fail.
Depends on D92345
Differential Revision: https://phabricator.services.mozilla.com/D92714
Simon Giesecke
Sylvestre Ledru
Karl Tomlinson
Jean-Yves Avenard
Bogdan Tara
Razvan Maries
Andreas Pehrson
Paul Adenot
Butkovits Atila
Andi-Bogdan Postelnicu
Christian Holler
Corentin Arnould
alwu
Ricky Stewart
Bryce Seager van Dyk
Sebastian Hengst
Csoregi Natalia
Dorel Luca
smolnar
Noemi Erli
Michael Froman