ChromeUtils.import no longer pollute the global scope,
so we can switch to it and remove this ancient helper.
Depends on D26078
Differential Revision: https://phabricator.services.mozilla.com/D26079
--HG--
extra : moz-landing-system : lando
This ensures that any changes to zoom level, when RDM is active,
happen on the content document and not on the RDM interface.
Differential Revision: https://phabricator.services.mozilla.com/D26040
--HG--
extra : moz-landing-system : lando
We do not need to handle onProgressChange64 notifications since the TabChild's
web progress events are filtered through an nsBrowserStatusFilter, which
truncates onProgresChange64 event values to 32-bit integers and then calls
onProgressChange.
Differential Revision: https://phabricator.services.mozilla.com/D25649
--HG--
extra : moz-landing-system : lando
This is part 1 of implementing the redesigned device settings panel. In this patch we are rearranging the existing device settings view to match the new design.
Differential Revision: https://phabricator.services.mozilla.com/D15734
--HG--
extra : moz-landing-system : lando
This test uses a Document with a fixed-width meta viewport. This test
simulates resizing the RDM pane from a wide landscape size to a small
square size, and back again. It does this again with meta viewport
support turned on.
Differential Revision: https://phabricator.services.mozilla.com/D22438
--HG--
extra : source : 2fa518cb0dfc656c6f0c5d5dfbad38348be6f31f
There are two viewports: the layout (or content) viewport, and the visual
viewport. This change ensures that we are both setting and checking the
visual viewport size, which is the size shown in the RDM control bar.
It is still possible to get the layout viewport with getContentSize().
Differential Revision: https://phabricator.services.mozilla.com/D22437
--HG--
extra : source : afaf26d7df4235daef3157d74b3bcd69761c6393
This test uses a Document with a fixed-width meta viewport. This test
simulates resizing the RDM pane from a wide landscape size to a small
square size, and back again. It does this again with meta viewport
support turned on.
Differential Revision: https://phabricator.services.mozilla.com/D22438
--HG--
extra : moz-landing-system : lando
There are two viewports: the layout (or content) viewport, and the visual
viewport. This change ensures that we are both setting and checking the
visual viewport size, which is the size shown in the RDM control bar.
It is still possible to get the layout viewport with getContentSize().
Differential Revision: https://phabricator.services.mozilla.com/D22437
--HG--
extra : moz-landing-system : lando
The position of remote browser was not updated by resizing the window and
changing the align of viewport etc, although will be updated when the window
moves, the frame reflows and so on.
Thus, in this patch, update the position of remote browser before showing
context menu so as to locates at proper position.
I investigated though, when reflow and moving happens, the position is updated
by TabParent::UpdateDimensions()[1]. This patch as well is taking an approach
which update the position explicitly by TabParent::UpdateDimensions() before
showing context menu.
[1] https://searchfox.org/mozilla-central/source/dom/ipc/TabParent.cpp#729
Differential Revision: https://phabricator.services.mozilla.com/D23470
--HG--
extra : moz-landing-system : lando
Just set the RemoteType in the options object argument, instead of
doubling up the information.
Differential Revision: https://phabricator.services.mozilla.com/D23250
--HG--
extra : moz-landing-system : lando
Now that form argument is no longer used by any front to set its actor ID,
we can remove this argument.
Have a particular look at:
* devtools/client/shared/test/test-actor-registry.js
which was the last Front to be manually instantiated and need some tweaks,
* canvas head.js to create canvas front via getFront,
* RDM manager.js, which requires the EmulationFront to be self managed.
Depends on D17615
Differential Revision: https://phabricator.services.mozilla.com/D17616
--HG--
extra : moz-landing-system : lando
Ideally, formAttributeName would be a field on the prototype of each front,
but unfortunately, Firefox doesn't support ES Class's fields yet. So it is
put as an instance attribute instead.
This patch streamline the manually set actorID and the retrieval of actor ID
from root or target front's form into `getFront` helper method.
So that all the specific related to the lazy actor is now inside of this helper.
It also moves the special "this.manage(this)" to this helper.
We might be able to followup on this one and finally have only the root front
being self managed. But the initialize method makes it hard.
Note the special tweak made to devtools/client/responsive.html/manager.js
Hopefully this can be removed once the target classes are merged.
Depends on D15832
Differential Revision: https://phabricator.services.mozilla.com/D17615
--HG--
extra : moz-landing-system : lando
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
- Remane --theme-toolbar-icon-color to just --theme-icon-color
- Rename --theme-toolbar-checked-color to --theme-icon-checked-color
- Introduce a --theme-icon-dimmed-color that is less contrasted (e.g. for Rules icon buttons)
- Remove icon color duplication for twisties, console icons
- Avoid partial opacity variants of Photon Grey as global variables in variables.css
Differential Revision: https://phabricator.services.mozilla.com/D17075
--HG--
extra : moz-landing-system : lando
In order to make the history easier to navigate, this changeset includes the
modifications required to make <xul:browser> actually work as a Custom Element,
and switches the app to use it instead of the XBL browser.
Differential Revision: https://phabricator.services.mozilla.com/D14911
--HG--
extra : moz-landing-system : lando
Micah Tigley
Alexandre Poirot
Brad Werth
Barret Rennie
Jan-Erik Rediger
Botond Ballo
Andreea Pavel
shindli
Daisuke Akatsuka
Kyle Machulis
Mike Conley
Patrick Brosset
Jonathan Kingston
Thomas Nguyen
Cosmin Sabou
Ehsan Akhgari
Kris Maglione
Florens Verschelde
Narcis Beleuzu
Tim Nguyen
Razvan Maries
Brian Grinstead