For all purposes, this is the same as devicePixelRatio. It was meant to
skip the resistFingerprinting check the devicePixelRatio getter does,
but we do that now using CallerType in WebIDL, so if we cared about that
for these tests (which we don't) we could just do
SpecialPowers.wrap(window).devicePixelRatio.
As a follow-up we could move the NoOverride to window for symmetry. But
it's only used by devtools touch simulation so not sure if worth it.
Differential Revision: https://phabricator.services.mozilla.com/D138021
Dashed borders don't paint 100% deterministically, as noted in the previous
patch in this series, so let's switch all of these tests to use a solid border
with a distinguishable color, so that we can avoid fuzzy failures in these
tests.
The HTML changes in this patch were performed automatically by this command:
cd layout/reftests/css-grid
sed -i "s/2px dashed;/2px solid salmon;/" ./grid-fragmentation-*html
And then I edited the reftest.list file by hand to remove all fuzzy annotations
for these tests, since I'm speculating that these annotations are associated
with the dashed borders.
Differential Revision: https://phabricator.services.mozilla.com/D137915
Dashed borders don't paint 100% deterministically, as shown in this bug (where
we've just started seeing intermittent failures with a particular dash
rendering a stray pixel under one set of dynamic conditions -- possibly due to
a subtle antialiasing difference or something like that).
For the sake of test reliability, let's just use a solid border here. I've
chosen salmon as the color, since that still stands out reasonably-well against
the other colors in this test. (I don't want to leave it black, since the test
has other solid black borders already.)
Differential Revision: https://phabricator.services.mozilla.com/D137914
This adds a round trip from double -> float -> double because
CSSRect is float but it should be ok because most users of gfxRect (RectDouble)
should be using Rect instead anyways.
Differential Revision: https://phabricator.services.mozilla.com/D137811
There's no need to create a visual viewport offset here, only if one already exists do we want to clamp it.
I noticed this while reading code for something else, so I'm not sure if it actually fixes anything.
Differential Revision: https://phabricator.services.mozilla.com/D137720
This scaling factor is to account for ComputePagesPerSheetAndPageSizeTransform,
but that is not used when printing headers/footers, which resulted in the
reversed scale clipping the header/footer.
Differential Revision: https://phabricator.services.mozilla.com/D136830
We weren't doing it. I want to see if it helps with some flickering
intermittents with the patch of bug 1718220.
Not sure how to reliably test this.
Differential Revision: https://phabricator.services.mozilla.com/D137794
This scaling factor is to account for ComputePagesPerSheetAndPageSizeTransform,
but that is not used when printing headers/footers, which resulted in the
reversed scale clipping the header/footer.
Differential Revision: https://phabricator.services.mozilla.com/D136830
This prevents opacity from being set on large images sent to WebRender.
Instead, opacity will be handled in the parent layer, which is less efficient,
but correct for these large images.
This can be a temporary fix until WR supports opacity on arbitrarily large
images.
Differential Revision: https://phabricator.services.mozilla.com/D137360
We are fixing mochitests that fail when network.cookie.cookieBehavior = 5, i.e. when we enable Total Cookie Protection.
This is most often due to the test assuming that an origin will always have access to its storage state when embedded as
a third party.
In this case I had to request storage access to allow an embedded iframe to use a BroadcastChannel to communicate with top-level pages of the same origin.
This was only a problem in the XOrigin case where the test html file is loaded in an embedded iframe and then can't communicate with the top-level window it created.
Differential Revision: https://phabricator.services.mozilla.com/D136608
The reason why the global ScrollGeneration::sCounter doesn't work for the APZ
case is the APZ sampler thread is per our top level browser window, so if
there are multiple browser windows at the same time, the sCounter will be muted
from different sampler threads.
Differential Revision: https://phabricator.services.mozilla.com/D133439
We call MaybeApplyAdditionalOffset a few lines up when setting *aOffset, but it
looks like we missed this particular codepath. This was causing content to
render properly during print-preview (which takes the upper codepath) but not
during actual printing (which takes the lower codepath, the one where I'm
adding the new call).
Differential Revision: https://phabricator.services.mozilla.com/D137199
This makes TransformPoint and TransformRect deal with SVG text
correctly. We need TransformPoint support so that GeometryUtils works as
expected, since we need to transform the points individually so that
stuff like transforms report the expected result (a rect doesn't cut it
for those).
Differential Revision: https://phabricator.services.mozilla.com/D135152
This implements the first resolution from https://github.com/w3c/csswg-drafts/issues/5478,
and makes simple cases of quoting a foreign-language snippet work as desired.
Still to do: the match-parent value (second resolution in that issue), required for full
support of nested mixed-language quotes if the author wants the conventions of the
outermost language to propagate down to all nested levels.
Differential Revision: https://phabricator.services.mozilla.com/D137178
This implements the first resolution from https://github.com/w3c/csswg-drafts/issues/5478,
and makes simple cases of quoting a foreign-language snippet work as desired.
Still to do: the match-parent value (second resolution in that issue), required for full
support of nested mixed-language quotes if the author wants the conventions of the
outermost language to propagate down to all nested levels.
Differential Revision: https://phabricator.services.mozilla.com/D137178
There's only one caller of it and it's not sound: The runnable captures a
raw frame pointer etc. Instead, just do a dispatch to the main thread
and call OpenMenu there. This simplifies the following patch.
Differential Revision: https://phabricator.services.mozilla.com/D131082
This was added in bug 1201330 but with WR isn't really needed anymore and the code causes the expiration timer to fire until the scroll frame becomes inactive (the most common scroll frames stay active, ie root scroll frames).
Differential Revision: https://phabricator.services.mozilla.com/D136806
Note that this is only triggered if the application is able to draw to the
canvas while the refresh driver is throttled.
Differential Revision: https://phabricator.services.mozilla.com/D136004
Emilio Cobos Álvarez
smolnar
Daniel Holbert
Jeff Muizelaar
Timothy Nikkel
Emily McDonough
Sylvestre Ledru
Nicolas Silva
Csoregi Natalia
Jonathan Kew
Joel Maher
Brad Werth
Tim Giles
Andi-Bogdan Postelnicu
Benjamin VanderSloot
Hiroyuki Ikezoe
Paul Zuehlcke
Miko Mynttinen
Jonathan Watt
Butkovits Atila
Nicklas Boman
Ting-Yu Lin
Andreas Pehrson