The trait were added in 81 and 82, so we can safely remove them now.
We take this opportunity to bail early in setDefaultpreferencesIfNeeded
when there's no default preferences to set.
Differential Revision: https://phabricator.services.mozilla.com/D98498
Those methods were only kept for backward compatibility in the spec file, so we
can remove them from here.
The methods on the actor can't be removed as they're still called from the StyleSheetsActor
to support servers that don't use the resource watcher for stylesheets.
A test that was using those methods was updated.
Differential Revision: https://phabricator.services.mozilla.com/D98494
The analyzeInputString function tried to handle escape characters in strings,
by having a dedicated ESCAPE state.
Unfortunately, when in ESCAPE state, the code will always re-assign the NORMAL state.
So if at some point the string was terminated, the code would assume we were entering
a string state again.
In the end, this would cause the autocomplete to fail, because the JSPropertyProvider
would think that it was passed an unterminated string literal.
This is fixed by introducing quote-specific escape state, so we know which state to get
back in once the escape character is consumed.
A few test cases are added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D98754
Not doing that, makes the browser_resources_sources.js test to fail because
of pending SW's target which comes with unexpected sources.
Differential Revision: https://phabricator.services.mozilla.com/D98460
This helps cover the workaround put in ResourceWatcher in order to trigger
the SOURCE legacy listener for targets that we don't yet support in the Watcher actor.
Differential Revision: https://phabricator.services.mozilla.com/D98438
This patch adds a script which is similar to the one that was written in the README.md file.
This goes along with a simple package.json that let's us have a simple command
to execute the update script.
The README file is updated as well to reflect this new script.
Differential Revision: https://phabricator.services.mozilla.com/D98912
My editor formats this file automatically when I need to change something here,
and it's annoying to exclude these when I need to change something in this
file. I guess it doesn't hurt to format it so we won't have to do that again.
Differential Revision: https://phabricator.services.mozilla.com/D91266
The changes should be trivial.
The third_party changes are up for review in
https://github.com/servo/rust-cssparser/pull/277 (and of course I'll
land with a bump to 0.28 rather than the override after that gets r+'d).
The basic idea is that with this we have the actual start offset of the
rule, so we wouldn't include html comments or other invalid stuff we
discard during sanitization in bug 1680084. But that's a separate
change.
Differential Revision: https://phabricator.services.mozilla.com/D98677
We weren't handling the error exception object in the Error previewer for
some error classes, and as a result we'd show an undefined grip in the console,
instead of a proper error message.
A test is added to check that we do print wasm errors as expected.
Differential Revision: https://phabricator.services.mozilla.com/D98469
My editor formats this file automatically when I need to change something here,
and it's annoying to exclude these when I need to change something in this
file. I guess it doesn't hurt to format it so we won't have to do that again.
Differential Revision: https://phabricator.services.mozilla.com/D91266
Those traits are going to be removed in Bug 1680280,
and not through the regular backward-compatibility cleanup routine.
Differential Revision: https://phabricator.services.mozilla.com/D98483
The function was taking care of removing old addons.
It landed 2 years ago, so we can assume that we don't
need that anymore.
Differential Revision: https://phabricator.services.mozilla.com/D98465
Prior to Firefox 68, worker target didn't have a unique id,
and we were relying on their actor id in a few places.
Now that we should have the id everywhere, we can remove
the backward compatibility code, and simplify some of
the logic.
Differential Revision: https://phabricator.services.mozilla.com/D98464
This is useful for SOURCE resource, as that's one resource that we expect to
fetch from all targets, but Service Worker and Shared worker targets aren't supported
yet by the watcher. So we should be using legacy listener for these.
Differential Revision: https://phabricator.services.mozilla.com/D97631
Nicolas Chevobbe
Csoregi Natalia
Oriol Brufau
Julian Descottes
Alexandre Poirot
Bogdan Tara
R. Martinho Fernandes
Josue Quilon
Nazım Can Altınova
Emilio Cobos Álvarez
Razvan Maries