* In nsAutoCompleteController, the logic that determines whether the new search is a prefix of the old search is only done in HandleText, i.e., on input, not when the value is set programmatically.
* That logic is a lot more complex in nsAutoCompleteController.
* nsAutoCompleteController autofills in one case where quantumbar doesn't: when completing the "placeholder" string before starting a new search and waiting for the async results (thereby preventing flicker).
* Some nsAutoCompleteController state gets reset each time the awesomebar is focused (see calls to attachController() in the autocomplete binding, which sets the controller's input, which calls ResetInternalState()). That state is important in regard to autofill and the placeholder string. If it's not reset, then the autofill of one search will incorrectly affect the autofill of a later search.
Differential Revision: https://phabricator.services.mozilla.com/D22306
--HG--
rename : browser/components/urlbar/tests/browser/browser_UrlbarInput_autofill.js => browser/components/urlbar/tests/browser/browser_autoFill_caretNotAtEnd.js
extra : moz-landing-system : lando
I like the error message just as well without the class name. In fact, I think
the word "derived" is important to include here, so the message is even a
little better. The stack and line number make it super clear which constructor
we're talking about, so we're not really losing anything.
In Chrome, the error message is "ReferenceError: Must call super constructor in
derived class before accessing 'this' or returning from derived constructor".
Differential Revision: https://phabricator.services.mozilla.com/D23223
--HG--
extra : moz-landing-system : lando
This changes the order of some cleanup operations, harmlessly, to make
initialization and teardown more FIFO.
Differential Revision: https://phabricator.services.mozilla.com/D23222
--HG--
extra : moz-landing-system : lando
Otherwise you see font changes when hovering, which is not really desirable.
Differential Revision: https://phabricator.services.mozilla.com/D24116
--HG--
extra : moz-landing-system : lando
The graph contains some extra things like toolchains, fetches and packaging
tasks that people will almost never want to run on their own. This change gets
them out of the default fuzzy selection interface, and makes it so --full is
needed to schedule them.
Differential Revision: https://phabricator.services.mozilla.com/D24187
--HG--
extra : moz-landing-system : lando
Noticed by Ian Moody [:Kwan] while watching test output. (!)
The test was introduced in bug 515475, 10 years ago. However, the syntax used
in this patch seems to have been removed from SpiderMonkey around that time,
maybe even before the patch landed; that is, this is not among the syntax
removed in bug 517580. As far as I can tell, this test has never functioned
properly.
Differential Revision: https://phabricator.services.mozilla.com/D24236
--HG--
extra : moz-landing-system : lando
The current standard requires this function to have no own `name` property at
all; its `.name` would be inherited from `Function.prototype`. However, V8 and
JSC both already do what we do, so we're working to change the standard instead
of changing our behavior. See <https://github.com/tc39/ecma262/issues/1049>.
Differential Revision: https://phabricator.services.mozilla.com/D23263
--HG--
extra : moz-landing-system : lando
Depends on D23872.
If you want to test the patch, I will post a try link afterwards to pull a valid queue
since my work depends on another bug that is almost ready to land but not yet landed.
Then you can open aboutdebugging-new by going to about:debugging-new
Differential Revision: https://phabricator.services.mozilla.com/D23874
--HG--
extra : moz-landing-system : lando
Depends on D23865
Some localized strings missing in the notftl file. Adding them before moving the strings.
Differential Revision: https://phabricator.services.mozilla.com/D23867
--HG--
extra : moz-landing-system : lando
Depends on D23864. Wifi preference is not used anymore, removing it as well for consistency.
Differential Revision: https://phabricator.services.mozilla.com/D23865
--HG--
extra : moz-landing-system : lando
Depends on D23863. We want to enable network locations by default.
Remove all the logic and l10n strings related to this before moving the l10n strings.
Differential Revision: https://phabricator.services.mozilla.com/D23864
--HG--
extra : moz-landing-system : lando
We add a [MOZ_CAN_RUN_SCRIPT_BOUNDARY] opt-out for now to keep the tree
compiling. The naming purposefully matches the C++ annotation that has a
similar effect, top make it easy to search for.
Differential Revision: https://phabricator.services.mozilla.com/D23520
--HG--
extra : moz-landing-system : lando
This allows calling a C++ MOZ_CAN_RUN_SCRIPT method that takes a callback argument.
The changes to TestCanRunScript.cpp are there to catch an incorrect change I was
going to make to the analysis to make this work, until I figured out that
RootedCallback should be MOZ_IS_SMARTPTR_TO_REFCOUNTED.
Differential Revision: https://phabricator.services.mozilla.com/D23519
--HG--
extra : moz-landing-system : lando
Since bug 1530324 removed the wrapper functions for async functions, it is no
longer true that a Debugger.Frame for an async function call calls its onPop
handler once after evaluating default arguments but before beginning execution
of the body.
Differential Revision: https://phabricator.services.mozilla.com/D23939
--HG--
extra : moz-landing-system : lando
When TalkBack receives a focus event, it redirects the accessibility focus (the green cursor) to the focused element. This is an important driver for the screen reader experience.
Since the focus mode of the GeckoView is "focusable in touch", the focused state of the view is very arbitrary when using TalkBack since the user never directly touches the view. The only way for the view to regain focus is if a control or link in the content is interacted with.
TalkBack user, who is explicitly interacting with the webview/geckoview would expect it to have focus, and to have the accessibility focus redirected in the page in the case of script-driven focus events.
Differential Revision: https://phabricator.services.mozilla.com/D23747
--HG--
extra : moz-landing-system : lando
This is more consistent with how it works in GeckoView. We need to give
up this behavior because it reset the top-level caret position on each
blur. This interferes with find in page which goes to the next search
result past the current caret.
Differential Revision: https://phabricator.services.mozilla.com/D23746
--HG--
extra : moz-landing-system : lando
Drew Willcoxon
dlee
Barret Rennie
Jason Orendorff
Miko Mynttinen
Emilio Cobos Álvarez
Ting-Yu Lin
Andreea Pavel
Christian Frey
Andrew Halberstadt
Felipe Gomes
Cosine
Narcis Beleuzu
Brindusan Cristian
rdalal
championshuttler
Julian Descottes
Eitan Isaacson
Boris Zbarsky
Jim Blandy
Alex Gaynor