Ryan VanderMeulen
71c9853712
Backed out 3 changesets (bug 883358) for Android mochitest-3 failures on a CLOSED TREE.
...
Backed out changeset 84b35dd1879d (bug 883358)
Backed out changeset b5e6522257cb (bug 883358)
Backed out changeset 757a3f2e5de6 (bug 883358)
2013-06-17 19:51:12 -04:00
Boris Zbarsky
4fea0995d3
Bug 883358 part 2. Use the new information in bindings error reporting. r=smaug
2013-06-17 16:31:13 -04:00
Boris Zbarsky
ad494b55cc
Bug 882653 part 4. Improve the WebIDL binding error reporting for the not-sequence, not-callable, not-dictionary, not-date, and invalid-enum-value cases. r=smaug
2013-06-17 13:07:03 -04:00
Boris Zbarsky
f33f6d5496
Bug 882653 part 1. Improve error reporting for bogus this objects in WebIDL bindings. r=smaug
2013-06-17 13:07:03 -04:00
Peter Van der Beken
e246f74b5d
Bug 851465 - Remove slim wrappers - remove various slim wrapper code and checks. r=bholley.
2013-04-19 21:57:18 +02:00
James Kitchener
b71cfc0ec2
Bug 796850 - Implement Code Generation for Bytestring in WebIDL bindings r=bz
2013-06-13 01:18:35 -04:00
Boris Zbarsky
7a3587f2d2
Bug 877281 part 6. Replace ${jsvalPtr} with a MutableHandle ${jsvalHandle}. r=peterv
...
It's a little unfortunate that we need both ${jsvalHandle} and
${jsvalRef}, but the only other option is to consistently have a
MutableHandle in this code. If the thing we have to work with is a
Rooted, that means doing JS::MutableHandle<JS::Value>(&myRooted) as
the thing to substitute for ${jsvalHandle}. Just using "&myRooted"
doesn't work, because things like "&myRooted.set()" or
"&myRooted.address()" fail, even if parenthesized as
"(&myRooted).set()", because &myRooted is actually a Rooted*, not a
MutableHandle.
We could go the JS::MutableHandle<JS::Value>(&myRooted) route if
desired; it would primarily uglify dictionary and sequence to-js
conversions. With the setup in this patch, ideally it looks pretty
idiomatic except for the use of .set() instead of operator= on Rooted.
2013-06-07 22:45:46 -04:00
Ms2ger
94aefffcb2
Bug 876602 - Move JS-implemented webidl construction code into C++; r=bz
2013-06-01 08:56:23 +02:00
Ms2ger
6452f0c3f0
Bug 876604 - Outparamdel UnwrapDOMObjectToISupports; r=bz
2013-06-01 08:56:02 +02:00
Peter Van der Beken
3402cab97c
Bug 874321 - Fix setting of expandos on Xrays for DOM bindings with named properties. r=bz.
...
--HG--
extra : rebase_source : 697545417d27696de05c0f22987e4cb187d226cd
2013-05-29 11:38:57 +02:00
Kyle Huey
0d78767303
Bug 876555: Avoid including xpcprivate.h in most generated dom binding code. r=bz
2013-05-30 11:15:31 +08:00
Boris Zbarsky
3ed0c22089
Bug 875622 part 2. Use handles in ConvertJSValueToString. r=smaug
2013-05-24 09:16:00 -04:00
Boris Zbarsky
cb039702b6
Bug 865951. If the return value of a JS-implemented method or attribute is a JS-implemented interface and the returned object is not a DOM object, automatically wrap it up in an instance of that interface. r=mccr8
...
This does not invoke __init on the chrome object, since there are no
arguments to do it with anyway. It also doesn't invoke init(), so
don't do this in cases in which the chrome-side object will need to
know its window.
2013-05-20 13:47:08 -04:00
Boris Zbarsky
43f774459d
Bug 868312 finale: finish rooting dom/ code. r=smaug
2013-05-17 21:48:25 -04:00
Boris Zbarsky
6b527597e0
Bug 873337. Change the order of the decl and holder in js-to-native conversions to clean up the code some. Now the holder always comes after the decl. r=smaug
2013-05-17 21:48:25 -04:00
Nathan Froyd
0b82017ee5
Bug 873479 - fix BindingUtils.h to compile with GCC 4.4 in non-C++0x mode; r=bz
2013-05-17 10:44:19 -04:00
Boris Zbarsky
90dcaa61d5
Bug 868715 part 8. Add tracing to WebIDL sequence return values. r=peterv
2013-05-16 12:36:56 -04:00
Boris Zbarsky
79374d2426
Bug 868715 part 7. Add tracing to dictionaries. r=peterv
2013-05-16 12:36:55 -04:00
Boris Zbarsky
ac6b11ed0d
Bug 868715 part 6. Add the ability to trace sequence arguments. r=peterv
2013-05-16 12:36:55 -04:00
Boris Zbarsky
68c0f91dfe
Bug 868715 part 4. Use on-stack Rooted<JSObject*> for 'object' arguments in WebIDL bindings. r=peterv
2013-05-16 12:36:55 -04:00
Boris Zbarsky
42f794f96b
Bug 871177. Fix rooting hazard in IsNotDateOrRegexp. r=smaug
2013-05-15 21:46:44 -04:00
Terrence Cole
b6490325af
Bug 777548 - Make non-cc-participant tracing indirect; r=smaug,billm,jst
2013-03-28 13:37:22 -07:00
Boris Zbarsky
3aaf7effea
Bug 867863. Be a little more careful in GlobalObject initialization. r=peterv
2013-05-08 15:50:58 -04:00
Boris Zbarsky
da03e696a5
Bug 869311. More rooting in dom/bindings and content/base. r=smaug
2013-05-07 22:34:56 -04:00
Boris Zbarsky
ec2d2df69a
Bug 865969 part 9. Remaining miscellaneous rooting fixes in WebIDL bindings. r=ms2ger
2013-05-03 19:29:09 -04:00
Boris Zbarsky
7640b170ac
Bug 865969 part 6. Fix rooting hazards in BindingUtils.cpp. r=smaug
2013-05-03 19:29:08 -04:00
Boris Zbarsky
6e1db48b4d
Bug 865969 part 1. Better rooting in bindings for 'object' arguments, as well as for worker interface arguments passed as JSObject*. r=smaug
2013-05-03 19:29:07 -04:00
David Zbarsky
8cdcfa8969
Bug 866450 Part 1: Fix rooting hazards under content/ and dom/ r=bz
2013-05-02 05:12:45 -04:00
Boris Zbarsky
fb71a87689
Bug 860841. Hook up the proto chain of a WebIDL interface object to the interface object of its nearest ancestor interface that has one, as if these were ES6 classes. r=peterv
2013-05-02 14:38:19 -04:00
Ed Morley
cd58a5c447
Backed out changeset ad10907da2d4 (bug 866450) for B2G build failures
2013-05-02 11:58:05 +01:00
David Zbarsky
1527681014
Bug 866450 Part 1: Fix rooting hazards under content/ and dom/ r=bz
2013-05-02 05:12:45 -04:00
Boris Zbarsky
8766287733
Bug 861022 part 2. Root the global object in WebIDL prototype and interface object setup. r=peterv,terrence
2013-05-01 23:44:12 -04:00
Boris Zbarsky
d975beea20
Bug 861022 part 1. Root the non-globals in WebIDL prototype and interface object setup. r=peterv,terrence
2013-05-01 23:44:11 -04:00
Boris Zbarsky
9e0ae56b05
Bug 865961. Root the scope argument of wrap-the-xpconnect-object helpers in WebIDL bindings. r=ms2ger
2013-04-29 17:33:42 -04:00
Boris Zbarsky
3394bf9a4a
Bug 717637. Stop using non-global parent objects for everything that's not an element, since having a mix of parent objects makes us fail shape guards in the JIT. r=peterv
2013-04-29 17:33:41 -04:00
Boris Zbarsky
69e8214aeb
Bug 865964. Remove dead WrapCallbackInterface code. r=smaug
2013-04-26 13:41:21 -04:00
Boris Zbarsky
eb318bbb88
Bug 766583 part 1. Stop declaring dictionaries as const on the stack in bindings code. r=smaug
2013-04-25 19:03:06 -04:00
Boris Zbarsky
1ffcf1ad91
Bug 861493. When passing arguments to an Xray for a WebIDL constructor, make sure to do the argument unwrapping before entering the content compartment. r=bholley,waldo
...
There are several changes here:
1) Adds some MutableThis methods to Optional, Nullable, and dictionaries to
effectively allow doing a const_cast without knowing the actual type being
templated over. I needed this because I do not in fact know that type in
the relevant code. I'm open to suggestions for a better name for this
method.
2) Adds some operator& to RootedJSValue to make it look more like a JS::Value,
and in particular so I can JS_WrapValue the thing in it.
3) Adds a Slot() method to NonNullLazyRootedObject, just like NonNull has.
4) Adds an operator& to LazyRootedObject to make it look more like JSObject* so
I can JS_WrapObject the thing in it.
5) Implements the actual rewrapping of the arguments into the content compartment.
6) Fixes a small preexisting bug in which we didn't look at named constructors
in getTypesFromDescriptor (this was causing my tests to not compile).
7) Changes Xrays to not enter the content compartment when calling a WebIDL
constructor.
8) Adds some friend API to report things as not being functions.
2013-04-25 19:03:05 -04:00
Boris Zbarsky
b834439797
Bug 864727 part 5. Make all the WrapObject methods take a handle for the scope object. r=ms2ger
2013-04-25 12:29:54 -04:00
Boris Zbarsky
47de9d3ebe
Bug 864727 part 4. Pass a handle for the scope object to all the various Wrap*Object stuff in BindingUtils. r=ms2ger
...
Note: The JS::Rooted in CGWrapWithCacheMethod is just there until we start passing a handle to Wrap().
2013-04-25 12:29:53 -04:00
Boris Zbarsky
30064ae263
Bug 864590. Assert that the object is not null when wrapping WebIDL objects. r=peterv
2013-04-24 14:59:15 -04:00
Peter Van der Beken
bfcf81990d
Bug 852094 - Support Unforgeable on proxy-based DOM bindings. r=bz.
2012-12-20 10:56:11 +01:00
David Zbarsky
e583eff928
Bug 857439 Followup: Add null-checks for WrapObject failing and assert that the JSObject took ownership if WrapObject succeeded r=bz
2013-04-19 18:18:31 -04:00
David Zbarsky
fcdb506b78
Bug 857439 Part 3: Make sure to delete owned interfaces if wrapping fails r=bz
2013-04-19 04:49:21 -04:00
Jon Coppeard
7f7df293ae
Bug 861281 - GC: Root the wrap object API r=terrence r=bholley
...
--HG--
extra : rebase_source : 1d3ed88299ad8e9ad6812fb41aa48f03cc7aabae
2013-04-15 18:32:55 +01:00
Jacek Szpot
a38774d086
Bug 854503 - Rename JS unwrapping functions. r=bholley
2013-04-11 11:50:18 -07:00
Boris Zbarsky
0fb62d62f7
Bug 688691. Warn when LenientThis actually causes us to not throw. r=ms2ger
2013-04-08 17:04:21 -04:00
Ryan VanderMeulen
4df26dd5ac
Backed out changeset a85d21e394c0 (bug 854503) for bustage.
2013-04-06 14:37:33 -04:00
Jacek Szpot
ab74228011
Bug 854503 - Rename JS unwrapping functions. r=bholley
2013-04-04 12:14:32 +02:00
Boris Zbarsky
381b988a3b
Bug 855700. Make returning an nsIVariant from a WebIDL interface work. r=smaug
2013-04-03 22:22:16 -04:00