Andreas Pehrson
0ae3dd912f
Bug 1660144 - On disabling VideoFrameConverter, take a path that actually turns the frame black. r=jib
...
Depends on D87790
Differential Revision: https://phabricator.services.mozilla.com/D87791
2020-08-21 12:50:32 +00:00
Andreas Pehrson
c25001fab6
Bug 1652884 - Make disabled tracks, that haven't seen a frame, black. r=jib
...
This affects HTMLMediaElement, MediaRecorder and RTCPeerConnection, which are
the implementors of NotifyEnabledStateChanged.
This use case is going to become more common as users will be able to globally
mute cameras before requesting one. While muted, the camera is off and no frames
will flow. The old logic for showing disabled video tracks as black relied on a
frame appearing that could be turned black.
With this patch in this case we will create a frame if none has been seen yet,
and it will have a hardcoded size.
Depends on D87127
Differential Revision: https://phabricator.services.mozilla.com/D87128
2020-08-19 22:18:30 +00:00
Bogdan Tara
30eb420e4a
Backed out 14 changesets (bug 1652884) for test_peerConnection_trackDisabling.html failures CLOSED TREE
...
Backed out changeset f83951453e94 (bug 1652884)
Backed out changeset fc697986d538 (bug 1652884)
Backed out changeset 20a10128b5e1 (bug 1652884)
Backed out changeset c99c32323c76 (bug 1652884)
Backed out changeset 991e8975f03d (bug 1652884)
Backed out changeset 9e9511e32cdd (bug 1652884)
Backed out changeset 605c1ac3081a (bug 1652884)
Backed out changeset dd6edf636659 (bug 1652884)
Backed out changeset 74a2f5a9eea2 (bug 1652884)
Backed out changeset b9f419aed12d (bug 1652884)
Backed out changeset 84e82e25929f (bug 1652884)
Backed out changeset 876dbad27af5 (bug 1652884)
Backed out changeset 8f60e3af2a19 (bug 1652884)
Backed out changeset de7537bda499 (bug 1652884)
2020-08-20 01:13:29 +03:00
Andreas Pehrson
6c6ea99dac
Bug 1652884 - Make disabled tracks, that haven't seen a frame, black. r=jib
...
This affects HTMLMediaElement, MediaRecorder and RTCPeerConnection, which are
the implementors of NotifyEnabledStateChanged.
This use case is going to become more common as users will be able to globally
mute cameras before requesting one. While muted, the camera is off and no frames
will flow. The old logic for showing disabled video tracks as black relied on a
frame appearing that could be turned black.
With this patch in this case we will create a frame if none has been seen yet,
and it will have a hardcoded size.
Depends on D87127
Differential Revision: https://phabricator.services.mozilla.com/D87128
2020-08-19 20:35:36 +00:00
Bogdan Tara
fd6c09249f
Backed out 14 changesets (bug 1652884) for VideoFrameConverter related failures CLOSED TREE
...
Backed out changeset 28c4e8c373f0 (bug 1652884)
Backed out changeset 658ba8f39abe (bug 1652884)
Backed out changeset 8e67fe040e4a (bug 1652884)
Backed out changeset 6f5833203763 (bug 1652884)
Backed out changeset 569ff85dfc2e (bug 1652884)
Backed out changeset eaa171643447 (bug 1652884)
Backed out changeset 6b37b60b6662 (bug 1652884)
Backed out changeset 438cce7456fb (bug 1652884)
Backed out changeset e6ed13952b67 (bug 1652884)
Backed out changeset e0b1266231bf (bug 1652884)
Backed out changeset 32f4aae2b5fe (bug 1652884)
Backed out changeset 76b4abccd61b (bug 1652884)
Backed out changeset 9010365ffa66 (bug 1652884)
Backed out changeset 763f39eb5c13 (bug 1652884)
2020-08-19 22:21:31 +03:00
Andreas Pehrson
6c5ce9547e
Bug 1652884 - Make disabled tracks, that haven't seen a frame, black. r=jib
...
This affects HTMLMediaElement and MediaRecorder, which are the only implementors
of NotifyEnabledStateChanged.
This use case is going to become more common as users will be able to globally
mute cameras before requesting one. While muted, the camera is off and no frames
will flow. The old logic for showing disabled video tracks as black relied on a
frame appearing that could be turned black.
With this patch in this case we will create a frame if none has been seen yet,
and it will have a hardcoded size.
Differential Revision: https://phabricator.services.mozilla.com/D87128
2020-08-19 12:48:09 +00:00
Simon Giesecke
9350e6b741
Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
...
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.
Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.
Differential Revision: https://phabricator.services.mozilla.com/D62604
--HG--
extra : moz-landing-system : lando
2020-02-20 11:40:14 +00:00
Dorel Luca
d5f9df8ee1
Backed out 2 changesets (bug 1613985) for Build bustage on Windows2012. CLOSED TREE
...
Backed out changeset fd177b40b561 (bug 1613985)
Backed out changeset fb6d62b7f28d (bug 1613985)
2020-02-19 22:22:41 +02:00
Simon Giesecke
59b23375c0
Bug 1613985 - Use MOZ_COUNTED_DEFAULT_CTOR_*/MOZ_COUNTED_DTOR_* macros. r=froydnj
...
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.
Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.
Differential Revision: https://phabricator.services.mozilla.com/D62604
--HG--
extra : moz-landing-system : lando
2020-02-19 18:05:38 +00:00
Paul Adenot
f321d6becd
Bug 1592915 - Fix three warnings in `VideoFrameConverter.h` and `TestVideoTrackEncoder.h`. r=pehrsons
...
This warns because an expression with a side effect is inside a `static_assert` or
`sizeof`.
Differential Revision: https://phabricator.services.mozilla.com/D51243
--HG--
extra : moz-landing-system : lando
2019-10-31 12:12:19 +00:00
Cosmin Sabou
e40bc670f8
Backed out changeset 75ed11ced625 (bug 1592915) for gtest failures on VP8VideoTrackEncoder.
2019-10-31 13:38:56 +02:00
Paul Adenot
2f1622bec4
Bug 1592915 - Fix three warnings in `VideoFrameConverter.h` and `TestVideoTrackEncoder.h`. r=pehrsons
...
This warns because an expression with a side effect is inside a `static_assert` or
`sizeof`.
Differential Revision: https://phabricator.services.mozilla.com/D51243
--HG--
extra : moz-landing-system : lando
2019-10-31 10:50:51 +00:00
Andreas Pehrson
1bdb34c6ec
Bug 1454998 - Rename streams to tracks. r=padenot,karlt,smaug
...
This renames the following (in alphabetical order, non-exhaustive):
AudioCaptureStream -> AudioCaptureTrack
AudioNodeStream -> AudioNodeTrack
AudioNodeExternalInputStream -> AudioNodeExternalInputTrack
DirectMediaStreamTrackListener -> DirectMediaTrackListener
MediaStream -> MediaTrack
- Note that there's also dom::MediaTrack. Namespaces differentiate them.
MediaStreamGraph -> MediaTrackGraph
MediaStreamTrackListener -> MediaTrackListener
MSG -> MTG (in comments)
ProcessedMediaStream -> ProcessedMediaTrack
SharedDummyStream -> SharedDummyTrack
SourceMediaStream -> SourceMediaTrack
StreamTime -> TrackTime
TrackUnionStream -> ForwardedInputTrack
- Because this no longer takes a union of anything, but only a single track
as input.
Other minor classes, members and comments have been updated to reflect these
name changes.
Differential Revision: https://phabricator.services.mozilla.com/D46146
--HG--
rename : dom/media/AudioCaptureStream.cpp => dom/media/AudioCaptureTrack.cpp
rename : dom/media/AudioCaptureStream.h => dom/media/AudioCaptureTrack.h
rename : dom/media/TrackUnionStream.cpp => dom/media/ForwardedInputTrack.cpp
rename : dom/media/TrackUnionStream.h => dom/media/ForwardedInputTrack.h
rename : dom/media/MediaStreamGraph.cpp => dom/media/MediaTrackGraph.cpp
rename : dom/media/MediaStreamGraph.h => dom/media/MediaTrackGraph.h
rename : dom/media/MediaStreamGraphImpl.h => dom/media/MediaTrackGraphImpl.h
rename : dom/media/MediaStreamListener.cpp => dom/media/MediaTrackListener.cpp
rename : dom/media/MediaStreamListener.h => dom/media/MediaTrackListener.h
rename : dom/media/webaudio/AudioNodeExternalInputStream.cpp => dom/media/webaudio/AudioNodeExternalInputTrack.cpp
rename : dom/media/webaudio/AudioNodeExternalInputStream.h => dom/media/webaudio/AudioNodeExternalInputTrack.h
rename : dom/media/webaudio/AudioNodeStream.cpp => dom/media/webaudio/AudioNodeTrack.cpp
rename : dom/media/webaudio/AudioNodeStream.h => dom/media/webaudio/AudioNodeTrack.h
extra : moz-landing-system : lando
2019-10-02 10:23:02 +00:00
Gurzau Raul
40dae37e00
Backed out 7 changesets (bug 1454998) for build bustages at MediaTrackGraph.h on a CLOSED TREE.
...
Backed out changeset 80417bdfa721 (bug 1454998)
Backed out changeset 8ff03f2f4ca2 (bug 1454998)
Backed out changeset ae6056b748d1 (bug 1454998)
Backed out changeset ab721cb2066b (bug 1454998)
Backed out changeset d0e8d413cd1c (bug 1454998)
Backed out changeset 3ce4dc7e9ae2 (bug 1454998)
Backed out changeset 6105a4176729 (bug 1454998)
--HG--
rename : dom/media/AudioCaptureTrack.cpp => dom/media/AudioCaptureStream.cpp
rename : dom/media/AudioCaptureTrack.h => dom/media/AudioCaptureStream.h
rename : dom/media/MediaTrackGraph.cpp => dom/media/MediaStreamGraph.cpp
rename : dom/media/MediaTrackGraph.h => dom/media/MediaStreamGraph.h
rename : dom/media/MediaTrackGraphImpl.h => dom/media/MediaStreamGraphImpl.h
rename : dom/media/MediaTrackListener.cpp => dom/media/MediaStreamListener.cpp
rename : dom/media/MediaTrackListener.h => dom/media/MediaStreamListener.h
rename : dom/media/ForwardedInputTrack.cpp => dom/media/TrackUnionStream.cpp
rename : dom/media/ForwardedInputTrack.h => dom/media/TrackUnionStream.h
rename : dom/media/webaudio/AudioNodeExternalInputTrack.cpp => dom/media/webaudio/AudioNodeExternalInputStream.cpp
rename : dom/media/webaudio/AudioNodeExternalInputTrack.h => dom/media/webaudio/AudioNodeExternalInputStream.h
rename : dom/media/webaudio/AudioNodeTrack.cpp => dom/media/webaudio/AudioNodeStream.cpp
rename : dom/media/webaudio/AudioNodeTrack.h => dom/media/webaudio/AudioNodeStream.h
2019-10-02 11:46:23 +03:00
Andreas Pehrson
36d89d91c8
Bug 1454998 - Rename streams to tracks. r=padenot,karlt,smaug
...
This renames the following (in alphabetical order, non-exhaustive):
AudioCaptureStream -> AudioCaptureTrack
AudioNodeStream -> AudioNodeTrack
AudioNodeExternalInputStream -> AudioNodeExternalInputTrack
DirectMediaStreamTrackListener -> DirectMediaTrackListener
MediaStream -> MediaTrack
- Note that there's also dom::MediaTrack. Namespaces differentiate them.
MediaStreamGraph -> MediaTrackGraph
MediaStreamTrackListener -> MediaTrackListener
MSG -> MTG (in comments)
ProcessedMediaStream -> ProcessedMediaTrack
SharedDummyStream -> SharedDummyTrack
SourceMediaStream -> SourceMediaTrack
StreamTime -> TrackTime
TrackUnionStream -> ForwardedInputTrack
- Because this no longer takes a union of anything, but only a single track
as input.
Other minor classes, members and comments have been updated to reflect these
name changes.
Differential Revision: https://phabricator.services.mozilla.com/D46146
--HG--
rename : dom/media/AudioCaptureStream.cpp => dom/media/AudioCaptureTrack.cpp
rename : dom/media/AudioCaptureStream.h => dom/media/AudioCaptureTrack.h
rename : dom/media/TrackUnionStream.cpp => dom/media/ForwardedInputTrack.cpp
rename : dom/media/TrackUnionStream.h => dom/media/ForwardedInputTrack.h
rename : dom/media/MediaStreamGraph.cpp => dom/media/MediaTrackGraph.cpp
rename : dom/media/MediaStreamGraph.h => dom/media/MediaTrackGraph.h
rename : dom/media/MediaStreamGraphImpl.h => dom/media/MediaTrackGraphImpl.h
rename : dom/media/MediaStreamListener.cpp => dom/media/MediaTrackListener.cpp
rename : dom/media/MediaStreamListener.h => dom/media/MediaTrackListener.h
rename : dom/media/webaudio/AudioNodeExternalInputStream.cpp => dom/media/webaudio/AudioNodeExternalInputTrack.cpp
rename : dom/media/webaudio/AudioNodeExternalInputStream.h => dom/media/webaudio/AudioNodeExternalInputTrack.h
rename : dom/media/webaudio/AudioNodeStream.cpp => dom/media/webaudio/AudioNodeTrack.cpp
rename : dom/media/webaudio/AudioNodeStream.h => dom/media/webaudio/AudioNodeTrack.h
extra : moz-landing-system : lando
2019-10-02 08:18:16 +00:00
Andreas Pehrson
53e4e663a4
Bug 1570673 - Update last frame's time on same-frame-ticks. r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D40599
--HG--
extra : moz-landing-system : lando
2019-08-07 15:11:00 +00:00
Andreas Pehrson
50628ddd24
Bug 1570673 - Add an active state to VideoFrameConverter and propagate it from MediaPipeline. r=bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D40598
--HG--
extra : moz-landing-system : lando
2019-08-05 18:00:48 +00:00
Andreas Pehrson
755d2fbfa4
Bug 1556696
- Only fail the VideoFrameConverter out-of-buffers assert if we dropped 100 frames in a row. r=dminor
...
Five buffers is evidently not enough to ensure we don't run out.
What we really want the assert for is that we are not leaking buffers so that
they never recycle, while also keeping memory usage down. This achieves that
by allowing for 100 frames to drop before failing the out-of-buffers assert.
Differential Revision: https://phabricator.services.mozilla.com/D35324
--HG--
extra : moz-landing-system : lando
2019-06-20 15:19:01 +00:00
Sylvestre Ledru
03c8e8c2dd
Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
...
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D26098
--HG--
extra : moz-landing-system : lando
2019-04-05 21:41:42 +00:00
Csoregi Natalia
ba58e936bd
Backed out changeset 4ad80127f89f (bug 1519636) for bustage on MarkupMap.h and nsAccessibilityService.cpp. CLOSED TREE
2019-04-05 09:48:19 +03:00
Sylvestre Ledru
d1c1878603
Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
...
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D26098
--HG--
extra : moz-landing-system : lando
2019-04-04 21:36:16 +00:00
Narcis Beleuzu
24dbe577a5
Backed out changeset 389b6bbd76db (bug 1519636) for bustages on MarkupMap.h . CLOSED TREE
2019-04-05 00:27:56 +03:00
Sylvestre Ledru
399dbd28fe
Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
...
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D26098
--HG--
extra : moz-landing-system : lando
2019-04-04 20:12:23 +00:00
Sylvestre Ledru
ef0bfc3822
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D24168
--HG--
extra : moz-landing-system : lando
2019-03-31 15:12:55 +00:00
Andreas Pehrson
599d0544bb
Bug 1538113 - Fix static-analysis warning in dom/media/VideoFrameConverter.h. r=dminor
...
Initially indicated by: https://phabricator.services.mozilla.com/D24233#inline-142010
Differential Revision: https://phabricator.services.mozilla.com/D24512
--HG--
extra : moz-landing-system : lando
2019-03-25 14:25:11 +00:00
Andreas Pehrson
ae7831e5ad
Bug 1423253 - Handle MediaDecoder pauses when future frames are already buffered. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D23588
--HG--
extra : moz-landing-system : lando
2019-03-22 11:45:51 +00:00
Andreas Pehrson
49d065b76b
Bug 1423253 - Improve MediaPipeline logging and fix formatting. r=dminor
...
Differential Revision: https://phabricator.services.mozilla.com/D22929
--HG--
extra : moz-landing-system : lando
2019-03-22 11:45:21 +00:00
Andreas Pehrson
021e97c215
Bug 1423253 - Make future frames in MediaPipeline black when a track is disabled. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D22928
--HG--
extra : moz-landing-system : lando
2019-03-22 11:45:15 +00:00
Andreas Pehrson
74e1a2c0aa
Bug 1423253 - Drop old frames before they get processed in VideoFrameConverter. r=padenot
...
To avoid building up a queue of frames when the machine cannot keep up.
Differential Revision: https://phabricator.services.mozilla.com/D23710
--HG--
extra : moz-landing-system : lando
2019-03-22 11:44:40 +00:00
Andreas Pehrson
c459274366
Bug 1423253 - Pace future video frames in MediaPipeline. r=dminor,padenot
...
WebRTC.org doesn't handle receiving multiple future frames.
This will buffer future frames from a direct listener in MediaPipeline
and pass them on when the frame's wall clock timestamp has been reached.
Differential Revision: https://phabricator.services.mozilla.com/D22921
--HG--
extra : moz-landing-system : lando
2019-03-22 11:45:27 +00:00
Andreas Pehrson
a35ff7f46e
Bug 1423253 - Move VideoFrameConverter to its own file. r=dminor
...
This lets us unit test it in a future patch.
Differential Revision: https://phabricator.services.mozilla.com/D24233
--HG--
extra : moz-landing-system : lando
2019-03-22 11:45:23 +00:00